Attention is currently required from: laforge.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43612?usp=email )
Change subject: proxy: queue BURST.req and dispatch per TDMA frame tick
......................................................................
Patch Set 2:
(1 comment)
This change is ready for review.
File proxy/src/burst_fwd.c:
https://gerrit.osmocom.org/c/osmo-trx/+/43612/comment/75a77745_1be6113a?usp… :
PS1, Line 138:
> basically it's a trade-off whether we want more computationally expensive enqueue or dequeue. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43612?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ib147983e97638d2a2e487ccf76184912caf0941d
Gerrit-Change-Number: 43612
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Sun, 13 Sep 2026 19:05:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43112?usp=email )
Change subject: libosmo-trx/ep: flush pending TRXC messages on endpoint teardown
......................................................................
Patch Set 7:
(3 comments)
File libosmo-trx/src/trx_ep.c:
https://gerrit.osmocom.org/c/osmo-trx/+/43112/comment/626c06db_5dca6482?usp… :
PS6, Line 348: flush = talloc(iofd, struct trx_ep_ctrl_flush);
> Because the caller may call `osmo_trx_ep_free()` right after `osmo_trx_ep_close()`. […]
Implemented postponed free()ing the whole `struct osmo_trx_ep`.
https://gerrit.osmocom.org/c/osmo-trx/+/43112/comment/647c3a7c_079eefdf?usp… :
PS6, Line 552: * finish flushing on its own, since it may outlive the endpoint. */
> I don't really see why would you like the ctrl socket to outlive the endpoint. […]
Done
https://gerrit.osmocom.org/c/osmo-trx/+/43112/comment/77ea756a_7d7e4b77?usp… :
PS6, Line 581: return !llist_empty(&ep->closing_flushes);
> The list exists to let `osmo_trx_ep_free()` find outstanding flushes and sever their back-pointer, s […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43112?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I69e6a3bcf49afc3cfca4a72afdf459625cb91e56
Gerrit-Change-Number: 43112
Gerrit-PatchSet: 7
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 13 Sep 2026 18:39:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>