Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43647?usp=email )
Change subject: crypto_utils: log EID instead of the entire EUM certificate
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/onomondo-eim/+/43647/comment/2cc24c2c_23c754b4… :
PS2, Line 13: Let's instead log the EID of the
: eUICC that caused the problem, which is much more helpful then just
: a certificate dump that is barely readable.
Mh, I think such an event is something one definitely wants to investigate further, if it ever happens, right? So I think it definitely is useful to either log some decoded certificate output, or to store the binary blob somewhere so one can later decode it using 'openssl x509 -text' or the like?
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43647?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I33c19fee0bec31b4c6b3c8052976625f3213aac1
Gerrit-Change-Number: 43647
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 17 Sep 2026 12:47:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43648?usp=email )
Change subject: library/Misc_Helpers: Introduce API f_str_oct_split()
......................................................................
library/Misc_Helpers: Introduce API f_str_oct_split()
Similar to existing f_str_split() but operating on octetstrings.
It uses the external f_strstr_oct() function to look up in an efficient
way.
This function will be used by HTTP2 code to split multipart data based
on boundary specified in the HTTP2 Header.
Change-Id: Ie26062bf00133d25be4b41424186484d34b18dce
---
M library/Misc_Helpers.ttcn
1 file changed, 21 insertions(+), 0 deletions(-)
Approvals:
osmith: Looks good to me, but someone else must approve
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/library/Misc_Helpers.ttcn b/library/Misc_Helpers.ttcn
index 967c8d1..24d0590 100644
--- a/library/Misc_Helpers.ttcn
+++ b/library/Misc_Helpers.ttcn
@@ -134,4 +134,25 @@
return parts;
}
+/* Same as f_str_split() but using octetstring */
+type record of octetstring ro_octetstring;
+function f_str_oct_split(octetstring str, octetstring delim := ''O) return ro_octetstring
+{
+ var integer pos := 0;
+ var ro_octetstring parts := {};
+ var integer delim_pos;
+ var integer end := lengthof(str);
+ while (pos < end) {
+ delim_pos := f_strstr_oct(str, delim, pos);
+ if (delim_pos < 0) {
+ delim_pos := end;
+ }
+ if (delim_pos > pos) {
+ parts := parts & { substr(str, pos, delim_pos - pos) };
+ }
+ pos := delim_pos + lengthof(delim);
+ }
+ return parts;
+}
+
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43648?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie26062bf00133d25be4b41424186484d34b18dce
Gerrit-Change-Number: 43648
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43650?usp=email )
Change subject: deps/Makefile: Depend on osmo-ttcn3-openapi-generator.git to support 5G SBI types
......................................................................
deps/Makefile: Depend on osmo-ttcn3-openapi-generator.git to support 5G SBI types
The osmo-ttcn3-openapi-generator.git repository contains a set of .ttcn
files providing TTCN-3 types for 5G SBI interfaces, generated from
OpenAPI yaml descriptions of the related 3GPP specs.
The generated TTCN-3 code makes use of dependency
titan.ProtocolModules.JSON_v07_2006, so also import it.
The upcoming SMF_Tests patches testing 5G interfaces will make use of
these files, so make them already available.
Change-Id: I10753fde79fddcf1c64a2a8b6eb6a2e1af708081
---
M deps/Makefile
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
osmith: Looks good to me, but someone else must approve
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/deps/Makefile b/deps/Makefile
index 10c343c..ad0f260 100644
--- a/deps/Makefile
+++ b/deps/Makefile
@@ -21,6 +21,7 @@
titan.ProtocolModules.ICMPv6 \
titan.ProtocolModules.IP \
titan.ProtocolModules.ISUP_Q.762 \
+ titan.ProtocolModules.JSON_v07_2006 \
titan.ProtocolModules.L2TP \
titan.ProtocolModules.LLC_v7.1.0 \
titan.ProtocolModules.M3UA \
@@ -59,6 +60,7 @@
OSMOGERRIT_REPOS= osmo-uecups
OSMOGITEA_REPOS= nas \
+ osmo-ttcn3-openapi-generator \
titan.ProtocolModules.BSSMAP \
titan.ProtocolModules.MAP \
titan.TestPorts.AF_PACKET \
@@ -73,6 +75,7 @@
# Use tag names from 'git describe --tags' or commit hashes. This way we get
# exact commits of deps when doing regression testing.
nas_commit= 8915a3b55bf21349a116eb8b4395e10e38d72135
+osmo-ttcn3-openapi-generator_commit= 47a66af829eba96dbc4c145bd15270c3a8f9d086
titan.Libraries.TCCUsefulFunctions_commit= R.35.B-6-gb3687da
titan.ProtocolEmulations.M3UA_commit= a70095b9113b23d2ea2405a5775befec18dd0fe0
titan.ProtocolEmulations.SCCP_commit= 744f3eeb58d7b5bc372c9fd01db737a20bae069a
@@ -88,6 +91,7 @@
titan.ProtocolModules.ICMPv6_commit= 46f4d9b6e1e3c794294a92588401a81e4881dd27
titan.ProtocolModules.IP_commit= 1be86705f39ae38f3c04b2109806ee20d25e91d0
titan.ProtocolModules.ISUP_Q.762_commit= R.8.A-5-g42d428b
+titan.ProtocolModules.JSON_v07_2006_commit= R.2.A
titan.ProtocolModules.L2TP_commit= 17e76d3662bd0bb815158e8a9de1ec413f21b530
titan.ProtocolModules.LLC_v7.1.0_commit= 09817f113255d7fb56f1d45d3dd629a093d9248d
titan.ProtocolModules.MAP_commit= R.2.A-1-g79c6a3d
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43650?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I10753fde79fddcf1c64a2a8b6eb6a2e1af708081
Gerrit-Change-Number: 43650
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>