Attention is currently required from: fixeria, laforge.

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/43637?usp=email )

Change subject: pySim-shell: use verify_adm command for commandline ADM auth ......................................................................

Patch Set 4:

(2 comments)

File pySim-shell.py:

https://gerrit.osmocom.org/c/pysim/+/43637/comment/75fa7b7f_554f6653?usp=ema... : PS2, Line 1132: PIN_ADM1

also remove `1` here?

Done

https://gerrit.osmocom.org/c/pysim/+/43637/comment/b6f95712_c1a20548?usp=ema... : PS2, Line 1188: pin_adm_type = "" : if opts.pin_adm_type: : pin_adm_type = "--adm-type %s" % opts.pin_adm_type : if opts.pin_adm: : app.onecmd_plus_hooks("verify_adm %s %s" % : (opts.pin_adm, pin_adm_type), add_to_history = False) : elif opts.pin_adm_hex: : app.onecmd_plus_hooks("verify_adm %s --pin-is-hex %s" % :

Why don't you just call `app. […]

This was my first approach, it even worked, but the linter complained I guess that was why the method is actually in PySimCommands and not in PysimApp.

Then I saw that we use app.onecmd_plus_hooks for running commands and scripts. I think this is the cleaner method since it does a real execution on the CMD2 shell. Its also more uniform with the existing code in the vicinity.