Attention is currently required from: dexter.
Hello Jenkins Builder, jolly, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43439?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: cosmetic: fix static, typos and sourcecode formatting
......................................................................
cosmetic: fix static, typos and sourcecode formatting
This patch fixes a few minor cosmetic issues:
- Ensure that all function that can be declared as static are
declared as static
- Fix typos
- Fix sourcecode formatting
Related: SYS#8101
Change-Id: I3b3fa7dc6e2e541cccff6579b4424157e8233fa8
---
M src/ipa/libipa/es10b_euicc_mem_rst.c
M src/ipa/libipa/es10b_get_eim_cfg_data.c
M src/ipa/libipa/es10b_immediate_enable.c
M src/ipa/libipa/es10b_load_euicc_pkg.c
M src/ipa/libipa/es10b_retr_notif_from_lst.c
M src/ipa/libipa/es10c_get_prfle_info.c
M src/ipa/libipa/esipa_prvde_eim_pkg_rslt.c
M src/ipa/libipa/ipad.c
M src/ipa/libipa/proc_eim_pkg_retr.c
M src/ipa/libipa/proc_euicc_pkg_dwnld_exec.c
10 files changed, 59 insertions(+), 50 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/39/43439/4
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43439?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I3b3fa7dc6e2e541cccff6579b4424157e8233fa8
Gerrit-Change-Number: 43439
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43658?usp=email )
Change subject: mnesia_db_work: use distinct logic when fetching from rest table
......................................................................
Patch Set 1:
(1 comment)
File src/mnesia_db_work.erl:
https://gerrit.osmocom.org/c/onomondo-eim/+/43658/comment/8db87d99_0b2ddde5… :
PS1, Line 51: X#rest.facility =/= euicc
somehow the new indentation is off?
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43658?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I2e42bde0c03155e7b2bcf058b20174b75e8e0d97
Gerrit-Change-Number: 43658
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 17 Sep 2026 12:49:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No