September 2026 - gerrit-log - lists.osmocom.org

[L] Change in libosmo-sigtran[master]: WIP: Cisco like DSCP configuration support
by pespin 17 Sep '26

17 Sep '26

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667?usp=email ) Change subject: WIP: Cisco like DSCP configuration support ...................................................................... Patch Set 1: (14 comments) This change is ready for review. Patchset: PS1: TODO: figure out if it makes sense to provide a default qos, and with with ip-dscp, etc. File include/osmocom/sigtran/osmo_ss7.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/b87f878f_eb6b2… : PS1, Line 155: * QoS Class Better create a new private ss7_qos_class.h + ss7_qos_class.c inside src/, and avoid prefixing it with osmo_ to avoid making them public until there's a real need for them to be public. This way we can extend without breaking the API. https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/afd2067c_a1e1b… : PS1, Line 167: osmo_ss7_qos_class_find(struct osmo_ss7_instance *inst, uint8_t qos_class); This one can go in ss7_instance.h + ss7_instance.c File src/Makefile.am: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/ed222008_955d4… : PS1, Line 92: ss7_qos_class_vty.c \ good, you need to do the same with ss7_qos_class.c and .h. File src/ss7_asp_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/6a792eb9_260a6… : PS1, Line 414: "qos-class " IP_QOS_CLASS_RANGE_STR, SS7_QOS_CLASS_RANGE_STR https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/0e0613f2_81db4… : PS1, Line 423: asp->cfg.ip_dscp = 0; why do you keep asp->cfg.ip_dscp? IMHO it should be removed now that we have the qos-class stuff. https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/a1562528_b2991… : PS1, Line 443: DEFUN_ATTR(asp_ip_dscps, asp_ip_dscp_cmd, This should be deprecated in some way imho. File src/ss7_instance.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/3837f739_7db64… : PS1, Line 363: llist_for_each_entry(xua, &inst->xua_servers, list) { Cisco ITP doesn't have qos-class node for "listen" node, but I think it's actually a good idea to use it here. https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/ae9c485b_bcc2f… : PS1, Line 392: void osmo_ss7_qos_class_update(struct osmo_ss7_qos_class *qos) This can go into ss7_qos_class.c too. btw I don't recall seeing it declared in the header file? File src/ss7_qos_class_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/bf895354_4d8f1… : PS1, Line 112: if (qos->ip_dscp) { I think is "qos" exists it should always print the "qos class" node, even if empty. https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/b1000191_f8c93… : PS1, Line 114: if (qos->ip_dscp) this is always true in this path? File src/ss7_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/baaa5a1e_d2538… : PS1, Line 1409: /* then dump ASPs, as ASs reference them */ I think you can simplify and drop all the connectors "first, then, now, finally" ;) https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/ef4efdbd_1854a… : PS1, Line 1442: return ss7_vty_node_qos_class_go_parent(vty); Are you sure the func is needed? or simply apply it directly here like others? https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667/comment/823a30d6_ac7f5… : PS1, Line 1548: remove this empty line. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic346698fc63771d95e474aec53ffb6c776636b3b Gerrit-Change-Number: 43667 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 17 Sep 2026 17:03:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-ttcn3-hacks[master]: smf: Move HTTP2 hdr block compressor helper to HTTP2_Functions.ttcn
by pespin 17 Sep '26

17 Sep '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43666?usp=email ) Change subject: smf: Move HTTP2 hdr block compressor helper to HTTP2_Functions.ttcn ...................................................................... smf: Move HTTP2 hdr block compressor helper to HTTP2_Functions.ttcn Change-Id: I5a4fffd4c26bde78340612fe024dc54c918885ab --- M library/HTTP2_Functions.ttcn M library/HTTP2_Server_Emulation.ttcn M smf/SMF_Session_CT_5G.ttcn 3 files changed, 19 insertions(+), 36 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/66/43666/1 diff --git a/library/HTTP2_Functions.ttcn b/library/HTTP2_Functions.ttcn index 307938b..2aae55e 100644 --- a/library/HTTP2_Functions.ttcn +++ b/library/HTTP2_Functions.ttcn @@ -7,6 +7,22 @@ import from HTTP2_Types all; import from HTTP2_Templates all; +function f_HTTP2_header_block_encode(HTTP2_header_block hb) return octetstring +{ + var HTTP2_comp_context ctx; + var octetstring data := ''O; + var integer rc; + + ctx := HTTP2_comp_context_init(); + rc := HTTP2_comp_context_encode(ctx, hb, data); + HTTP2_comp_context_free(ctx); + if (rc != 0) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("HTTP2_comp_context_encode returned ", rc)); + } + return data; +} + function f_HTTP2_header_list_find_header(HTTP2_header_list headers, charstring header_name) return template (omit) charstring { for (var integer i := 0; i < lengthof(headers); i := i + 1) { diff --git a/library/HTTP2_Server_Emulation.ttcn b/library/HTTP2_Server_Emulation.ttcn index 779d7f3..f8f60ed 100644 --- a/library/HTTP2_Server_Emulation.ttcn +++ b/library/HTTP2_Server_Emulation.ttcn @@ -20,6 +20,7 @@ import from Socket_API_Definitions all; import from HTTP2_Templates all; +import from HTTP2_Functions all; import from Native_Functions all; import from Misc_Helpers all; @@ -152,25 +153,6 @@ return pl_hblock; } -private function f_HTTP2_Server_Conn_comp_encode(inout HTTP2_Server_Conn conn, HTTP2_header_block hb) -return octetstring -{ - var octetstring pl_frame_data; - var HTTP2_comp_context ctx; - var integer rc; - - ctx := HTTP2_comp_context_init(); - rc := HTTP2_comp_context_encode(ctx, hb, pl_frame_data); - HTTP2_comp_context_free(ctx); - if (rc != 0) { - Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, - log2str(f_HTTP2_Server_Conn_str(conn), - ": HTTP2_comp_context_encode returned ", rc)); - } - - return pl_frame_data; -} - /*********************************************************************** * Main Emulation Component (HTTP2 Server) ***********************************************************************/ @@ -461,7 +443,7 @@ /* Send Header: */ f_HTTP2_Msg_append_hdr_content_length(http2_msg); - var octetstring hdr_enc := f_HTTP2_Server_Conn_comp_encode(conn_table[idx], http2_msg.hb); + var octetstring hdr_enc := f_HTTP2_header_block_encode(http2_msg.hb); http2_frame := ts_HTTP2_Frame_Header(http2_msg.stream_id, end_stream_flag := not ispresent(http2_msg.body), end_header_flag := true, diff --git a/smf/SMF_Session_CT_5G.ttcn b/smf/SMF_Session_CT_5G.ttcn index 22dc5e5..500dac4 100644 --- a/smf/SMF_Session_CT_5G.ttcn +++ b/smf/SMF_Session_CT_5G.ttcn @@ -63,21 +63,6 @@ f_http2_adapter_send(ts_HTTP2_Frame_Window_Update(0, 1073741824)); } -function f_http2_header_block_encode(HTTP2_header_block hb) return octetstring -{ - var HTTP2_comp_context ctx := HTTP2_comp_context_init(); - var integer rc; - var octetstring data := ''O; - - rc := HTTP2_comp_context_encode(ctx, hb, data); - if (rc != 0) { - Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, - log2str("HTTP2_comp_context_encode returned ", rc)); - } - HTTP2_comp_context_free(ctx); - return data; -} - function f_http2_encode_body_multipart_json_5gnas(octetstring json_encoded, octetstring nas_ecnoded, charstring boundary := "=-0EVVjxcWWFYNd1JXh1OQEg==") return octetstring @@ -150,7 +135,7 @@ ts_HTTP2_Hdr_accept_encoding("gzip") }; hb := ts_HTTP2_header_block(pseudo_hdr, hdr_li); - hdr_enc := f_http2_header_block_encode(valueof(hb)); + hdr_enc := f_HTTP2_header_block_encode(valueof(hb)); f_http2_adapter_send(ts_HTTP2_Frame_Header(3, end_stream_flag := false, end_header_flag := true, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43666?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5a4fffd4c26bde78340612fe024dc54c918885ab Gerrit-Change-Number: 43666 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: HTTP2_Functions: Remove trailing \r\n from multipart data payload
by pespin 17 Sep '26

17 Sep '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43665?usp=email ) Change subject: HTTP2_Functions: Remove trailing \r\n from multipart data payload ...................................................................... HTTP2_Functions: Remove trailing \r\n from multipart data payload Change-Id: I7348b8734e23e63e51b5b9c5234075ff073b96e1 --- M library/HTTP2_Functions.ttcn 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/65/43665/1 diff --git a/library/HTTP2_Functions.ttcn b/library/HTTP2_Functions.ttcn index 554b7eb..307938b 100644 --- a/library/HTTP2_Functions.ttcn +++ b/library/HTTP2_Functions.ttcn @@ -72,14 +72,25 @@ return HTTP2_multipart_part { var HTTP2_multipart_part part; var octetstring delim := char2oct("\r\n\r\n"); + var octetstring trail := char2oct("\r\n"); - /* 0..off is headers, off+lengthof(delim)..end is the data. */ + /* 0..off is headers, off+lengthof(delim)..end is the data. + * Furthermore, data contains an extra "\r\n" at the end. */ var integer off := f_strstr_oct(data, delim, 0); var octetstring header := substr(data, 0, off); off := off + lengthof(delim); + + /* Validate data trail: */ + if (lengthof(data) < lengthof(trail) or + substr(data, lengthof(data) - lengthof(trail), lengthof(trail)) != trail) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Rx unexpected part data: ", data)); + + } + part := { headers := f_HTTP2_multipart_msg_parse_part_headers(header), - data := substr(data, off, lengthof(data) - off) + data := substr(data, off, lengthof(data) - lengthof(trail) - off) } return part; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43665?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7348b8734e23e63e51b5b9c5234075ff073b96e1 Gerrit-Change-Number: 43665 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: smd: Decode received NG-NAS PDU Session Establish Accept
by pespin 17 Sep '26

17 Sep '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43664?usp=email ) Change subject: smd: Decode received NG-NAS PDU Session Establish Accept ...................................................................... smd: Decode received NG-NAS PDU Session Establish Accept Change-Id: I41a3625c0cebf3e3631b2dfe8c677783157857b4 --- M library/NG_NAS_Osmo_Templates.ttcn M smf/SMF_Session_CT_5G.ttcn 2 files changed, 66 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/64/43664/1 diff --git a/library/NG_NAS_Osmo_Templates.ttcn b/library/NG_NAS_Osmo_Templates.ttcn index 92e59c7..798fcfb 100644 --- a/library/NG_NAS_Osmo_Templates.ttcn +++ b/library/NG_NAS_Osmo_Templates.ttcn @@ -794,6 +794,62 @@ } } +/* 24.501 cl. 8.3.2 */ +template (present) NG_NAS_DL_SM_Message_Type +cr_NG_PDU_SESSION_ESTABLISHMENT_ACCEPT(template (present) NG_PDU_SessionId p_PDU_SessionId := ?, + template (present) ProcedureTransactionIdentifier p_PTI := ?, + template (present) SSC_Mode p_SSC_Mode := ?, + template (present) PDU_SessionType p_PDU_SessionType := ?, + template (present) QoS_Rules p_QoS_Rules := ?, + template (present) Session_AMBR p_Session_AMBR := ?, + template GMM_GSM_Cause p_Cause := *, + template PDU_Address p_PDU_Address := *, + template GPRS_Timer p_RQTimer := *, + template S_NSSAI_Type p_S_NSSAI := *, + template AlwaysOnPDUSessionInd p_AlwaysOnPDUSessionInd := *, + template MappedEPSBearerContexts p_MappedEPSBearerContexts := *, + template EAP_Message p_EAP := *, + template QoSFlowDescr p_QoSFlowDescr := *, + template ExtdProtocolConfigOptions p_ExtdPCO := *, + template DNN p_DNN := *, + template NGSM_NetworkFeatureSupport p_NGSM_NtwkFeatSupport := *, + template ServingPLMNRateControl p_ServingPLMNRateCtrl := *, + template ATSSSContainer p_ATSSSContainer := *, + template ControlPlaneInd p_ControlPlaneInd := *, + template IPHeaderCompressionConfig p_IPHeaderCompConfig := *, + template EthernetHeaderCompressConfig p_EthernetHeaderCompConfig := *, + template ServiceLvlAAContainer p_ServiceLvlAA := *, + template ReceivedMBSContainer p_ReceivedMBS := *) := { + pdu_Session_Establishment_Accept := { + protocolDiscriminator := tsc_EPD_GSM, /* cl. 9.2 M V 1 */ + pduSessionId := p_PDU_SessionId, /* cl. 9.4 M V 1 */ + procedureTransactionIdentifier := p_PTI, /* cl. 9.6 M V 1 */ + messageType := tsc_MT_NG_PDUSessionEstablishmentAccept, /* cl. 9.7 M V 1 */ + sscMode := p_SSC_Mode, /* cl. 9.11.4.16 M V 1/2 */ + pduSessionType := p_PDU_SessionType, /* cl. 9.11.4.11 M V 1/2 */ + authorizedQoSRules := p_QoS_Rules, /* cl. 9.11.4.13 M LV-E 7-65538 */ + sessionAMBR := p_Session_AMBR, /* cl. 9.11.4.14 M LV ? */ + gsmCause := p_Cause, /* cl. 9.11.4.2 O TV 2 IEI=59 */ + pduAddress := p_PDU_Address, /* cl. 9.11.4.10 O TLV 7-15 IEI=29 */ + rqTimerValue := p_RQTimer, /* cl. 9.11.2.3 O TLV 2 IEI=56 */ + s_NSSAI := p_S_NSSAI, /* cl. 9.11.2.6 O TLV 3-10 IEI=22 */ + alwaysOnPDUSessionInd := p_AlwaysOnPDUSessionInd, /* c. 9.11.4.3 O TV 1 IEI=8 */ + mappedEPSContexts := p_MappedEPSBearerContexts, /* cl. 9.11.4.9 O TLV-E 7-65538 IEI=7F */ + eapMessage := p_EAP, /* cl. 9.11.2.2 O TLV-E 7-1503 IEI=78 */ + authorizedQoSFlowDescr := p_QoSFlowDescr, /* cl. 9.11.4.12 O TLV-E 6-65538 IEI=79 */ + extdProtocolConfigurationOptions := p_ExtdPCO, /* cl. 9.11.4.6 O TLV-E 4-65538 IEI=0x7B */ + dnn := p_DNN, /* cl. 9.11.2.1A O TLV 3-102 IEI=25 */ + ngs_NetworkFeatureSupport := p_NGSM_NtwkFeatSupport, /* cl. 9.11.4.18 O TLV 3-15 IEI=17 Sep20 @sic R5s201387 Baseline Moving sic@ */ + servingPLMNRateControl := p_ServingPLMNRateCtrl, /* cl. 9.11.4.20 O TLV 4 IEI=18 Sep20 @sic R5s201387 Baseline Moving sic@ */ + atsssContainer := p_ATSSSContainer, /* cl. 9.11.4.22 O TLV-E 3-65538 IEI=77 Sep20 @sic R5s201387 Baseline Moving sic@ */ + controlPlaneOnlyIndication := p_ControlPlaneInd, /* cl. 9.11.4.23 O TV 1 IEI=C Sep20 @sic R5s201387 Baseline Moving sic@ */ + ipHeaderCompressionConfig := p_IPHeaderCompConfig, /* cl. 9.11.4.24 O TLV 5-257 IEI=66 Sep20 @sic R5s201387 Baseline Moving sic@ */ + ethernetHeaderCompressConfig := p_EthernetHeaderCompConfig, /* cl. 9.11.4.28 O TLV 3 IEI=1F Sep20 @sic R5s201387 Baseline Moving sic@ */ + serviceLvlAA := p_ServiceLvlAA, /* cl. 9.11.2.10 O TLV-E 6-n IEI=72 Sep22 @sic R5s221179 Baseline Moving sic@ */ + receivedMBS := p_ReceivedMBS /* cl. 9.11.4.30 O TLV-E 8-65538 IEI=71 Sep22 @sic R5s221179 Baseline Moving sic@ */ + } +} + template (value) NG_NAS_UL_Message_Type cs_NG_PDU_SESSION_MODIFICATION_REQUEST(template (value) NG_PDU_SessionId p_PDU_SessionId, template (value) ProcedureTransactionIdentifier p_PTI, diff --git a/smf/SMF_Session_CT_5G.ttcn b/smf/SMF_Session_CT_5G.ttcn index 425675e..22dc5e5 100644 --- a/smf/SMF_Session_CT_5G.ttcn +++ b/smf/SMF_Session_CT_5G.ttcn @@ -240,6 +240,9 @@ var N1N2MessageTransferReqData n1n2msg_req; var NGAP_IEs.PDUSessionResourceSetupRequestTransfer setup_req_transf; var template (value) N1N2MessageTransferRspData n1n2msg_rsp; + var template (present) NG_NAS_DL_SM_Message_Type exp_rx_nas; + var NG_NAS_DL_SM_Message_Type dl_nas; + var NG_NAS_DL_SM_Message_Type rx_nas; var template (value) HTTP2_Msg http2_tx; var octetstring body_enc; @@ -247,14 +250,17 @@ var charstring content_type_val := valueof(f_HTTP2_header_list_find_header(http2_rx.hb.headers, c_HTTP2_HDR_content_type)); var charstring boundary := f_HTTP2_header_content_type_multipart_val_get_boundary(content_type_val) var HTTP2_multipart_part_list parts := f_HTTP2_multipart_msg_parse(http2_rx.body.data, boundary); - log("PESPIN: rx http2 multipart! ", parts); /* Decode 1st part: SBI json: */ f_dec_N1N2MessageTransferReqData(parts[0].data, n1n2msg_req); // TODO: check returned integer. - log("PESPIN: N1N2MessageTransferReqData:", n1n2msg_req); - /* TODO: Decode 2nd part: 5GNAS: */ - log("TODO: Decode 2nd part (5GNAS): ", parts[1].data); + /* Decode 2nd part: NG-NAS: */ + dl_nas := dec_NG_NAS_DL_SM_Message_Type(parts[1].data); + exp_rx_nas := cr_NG_PDU_SESSION_ESTABLISHMENT_ACCEPT(); + if (not match(dl_nas, exp_rx_nas)) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Rx unexpected DL NG-NAS: ", dl_nas, " vs exp ", exp_rx_nas)); + } /* Decode 3rd part: NGAP: */ setup_req_transf := dec_NGAP_PDUSessionResourceSetupRequestTransfer(parts[2].data); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43664?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I41a3625c0cebf3e3631b2dfe8c677783157857b4 Gerrit-Change-Number: 43664 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in pysim[master]: GP: only send a GET STATUS tag list to cards that support it
by dexter 17 Sep '26

17 Sep '26

Attention is currently required from: Hoernchen. dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43552?usp=email ) Change subject: GP: only send a GET STATUS tag list to cards that support it ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Patchset: PS2: I am not entirely through yet, however, my first impression is that this should be ok. File pySim/global_platform/__init__.py: https://gerrit.osmocom.org/c/pysim/+/43552/comment/16a4ddd2_5984ac9c?usp=em… : PS2, Line 805: self._gp_version = decode_gp_version(h2b(data)) maybe logging the gp_version? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43552?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I74cd2bd47617d616bede6453397f544cde5abcb7 Gerrit-Change-Number: 43552 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Sep 2026 14:06:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[L] Change in pysim[master]: transport: stop the T=0 layer from breaking GP 6310
by dexter 17 Sep '26

17 Sep '26

Attention is currently required from: Hoernchen. dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43551?usp=email ) Change subject: transport: stop the T=0 layer from breaking GP 6310 ...................................................................... Patch Set 2: Code-Review+1 (6 comments) Patchset: PS2: From what I can see, the logic is ok, a few spec references and other minor issues might be checked back. Through the unit-tests I only looked through very briefly, but they look comprehensive. Commit Message: https://gerrit.osmocom.org/c/pysim/+/43551/comment/7b4556e9_7f09fd2c?usp=em… : PS2, Line 15: That is not "redundant", as per GP CS v2.3 section 11.4.3.1 the I think we normally refer to the "GlobalPlatform Card Specification" as "GPC" (they haven't given themselves an official abbreviation - at least not that I heard of...) File pySim/global_platform/__init__.py: https://gerrit.osmocom.org/c/pysim/+/43551/comment/aadecb3a_ec057098?usp=em… : PS2, Line 740: p2 = 0x02 # TLV format according to Table 11-36 maybe reference as GPC, section 11.4.3.1, table 11-36. I mention this since at the very beginning of that section they explain the meaning of the 0x02 (bit 2 set in P2) https://gerrit.osmocom.org/c/pysim/+/43551/comment/1328ed5e_82b2533d?usp=em… : PS2, Line 751: raise SwMatchError(sw, '9000/6310') I would recommend to check this back. When I look at the apidoc in exceptions.py:SwMatchError, the sw_expected is defined as a string with 4 hex digits. I have also looked further. When using SwMatchError like this, nothing catastrophic happens. It just prints it out, but its clearly not how the inventors of SwMatchError originally thought. I would recommend to revisit the sw_expected parameter. Maybe we can have a variable parameter here that can be a 4 digit hex-string or a list with multiple 4 digit hex-strings. Then you would call: ``` raise SwMatchError(sw, ['9000', '6310']) ``` I think this would be much cleaner and future-proof. https://gerrit.osmocom.org/c/pysim/+/43551/comment/d5913610_e98cff9f?usp=em… : PS2, Line 760: # GPC CardSpec v2.3, section 11.4.3.1, 6310 == additional matches. As it seems the spec ref is wrong. As far as I understand, the following is correct: GPC, section 11.4.2.2, table 11-34 I wonder if we have to keep the state of bit 2 for the "Get next occurrence(s)"? Section 11.4.2.2 also mentions that bit 2 is deprecated. I would recommend to check this back. I haven't found the spec version 2.3, I used 2.3.1 instead, but that should be close enough. File pySim/transport/__init__.py: https://gerrit.osmocom.org/c/pysim/+/43551/comment/9d1f91d5_bd743594?usp=em… : PS2, Line 344: # makes the card answer 6982 and tears down the whole SCP session and following commands fail with 6985. I always had difficulties to understand what ETSI TS 102 221, section 7.3.1.1.4, step 4b describes, but here is what I understand now: We come from step 3b, and are in 3b. We send the dummy GET RESPONSE as described and we continue with step 5. Never come back, so we never send a dummy GET RESPONSE again. (all the other if statements either break or set le_gr to a length value) So I think that your fix is correct. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43551?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I10f8afa8dd5623a49a6a0e7132607b3a1fad2d8c Gerrit-Change-Number: 43551 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Sep 2026 13:26:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in onomondo-ipa[master]: proc_indirect_prfle_dwnld: refactor module, fix spec references
by jolly 17 Sep '26

17 Sep '26

Attention is currently required from: dexter, laforge. jolly has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43438?usp=email ) Change subject: proc_indirect_prfle_dwnld: refactor module, fix spec references ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43438?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I69571280c7b52f2cb09f733bc0466cb77c0d2590 Gerrit-Change-Number: 43438 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Sep 2026 13:21:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in onomondo-ipa[master]: proc_indirect_prfle_dwnld: refactor module, fix spec references
by dexter 17 Sep '26

17 Sep '26

Attention is currently required from: jolly, laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43438?usp=email ) Change subject: proc_indirect_prfle_dwnld: refactor module, fix spec references ...................................................................... Patch Set 3: (1 comment) File src/ipa/libipa/proc_indirect_prfle_dwnld.c: https://gerrit.osmocom.org/c/onomondo-ipa/+/43438/comment/70b96d61_03e621d8… : PS2, Line 23: #include "esipa_get_bnd_prfle_pkg.h" > redundant include Done -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43438?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I69571280c7b52f2cb09f733bc0466cb77c0d2590 Gerrit-Change-Number: 43438 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 17 Sep 2026 13:20:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>

1 0

[S] Change in onomondo-ipa[master]: libipa: remove non spec compliant user consent callback
by dexter 17 Sep '26

17 Sep '26

dexter has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43437?usp=email ) Change subject: libipa: remove non spec compliant user consent callback ...................................................................... libipa: remove non spec compliant user consent callback libipa allows to pass a callback via its configuration struct. This callback is executed before the profile installation and may be used to prompt the user to consent to the profile download. This is technically a feature that is exclusive to SGP.22. It is not applicable to SGP.32, so let's remove it. Related: OS#8100 Change-Id: I1882890a5c1c74be1243d9649117ba7220c271d6 --- M include/onomondo/ipa/ipad.h M src/ipa/libipa/proc_indirect_prfle_dwnld.c M src/ipa/libipa/proc_prfle_dwnld.c M src/ipa/main.c 4 files changed, 0 insertions(+), 40 deletions(-) Approvals: Jenkins Builder: Verified jolly: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/include/onomondo/ipa/ipad.h b/include/onomondo/ipa/ipad.h index eafcee4..77a66df 100644 --- a/include/onomondo/ipa/ipad.h +++ b/include/onomondo/ipa/ipad.h @@ -16,9 +16,6 @@ struct ipa_context; struct ipa_buf; -/* (deprecated, see github issue #5) */ -typedef bool (*ipa_prfle_inst_consent_cb)(char *sm_dp_plus_address, char *ac_token); - enum ipa_poll_rc { /*! The API user shall call ipa_poll() again immediately. * (there may be still eIM packages waiting to be executed). */ @@ -81,12 +78,6 @@ * consumer eUICC appears as an IoT eUICC on procedure level. */ bool iot_euicc_emu_enabled; - /*! (deprecated, see github issue #5) Consent to profile installation. - * SGP.32 requires to prompt the user to consent to a profile installation. The API user may pass a callback - * function here to handle the consent request. In case no callback function is provided onomondo-eim will - * automatically consent to any profile installation. */ - ipa_prfle_inst_consent_cb prfle_inst_consent_cb; - /*! Set the Device Capabilities. * As IPAd need to set the device capabilities, it overwrites any other capabilities that might have set by * the modem or IoT device. The upper 5 bits can be set according to section 3.4.2 of SGG.22. The lower 3 diff --git a/src/ipa/libipa/proc_indirect_prfle_dwnld.c b/src/ipa/libipa/proc_indirect_prfle_dwnld.c index 016e9a8..9b233d3 100644 --- a/src/ipa/libipa/proc_indirect_prfle_dwnld.c +++ b/src/ipa/libipa/proc_indirect_prfle_dwnld.c @@ -65,7 +65,6 @@ /* TODO: Check if ProfileMetadata contains Profile Policy Rulses (PPRs) and apply the PPRs as configured on the * eUICC. (This is an optional feature, which we currently do not support, see also proc_euicc_data_req.c) */ - /* TODO: remove this part as it is not required (see also github issue #5) */ /* Execute sub procedure: Sub-procedure Profile Download and Installation – Download Confirmation */ prfle_dwnlod_pars.auth_clnt_ok_dpe = auth_clnt_res->auth_clnt_ok_dpe; get_bnd_prfle_pkg_res = ipa_proc_prfle_dwnlod(ctx, &prfle_dwnlod_pars); @@ -77,17 +76,6 @@ goto error; } - /* At this point we must ask the user for consent before we proceed with the profile installation. In case the - * user does not consent, we must abort by calling the common cancel session procedure. */ - if (ctx->cfg->prfle_inst_consent_cb - && !ctx->cfg->prfle_inst_consent_cb(activation_code->sm_dp_plus_address, activation_code->ac_token)) { - IPA_LOGP(SIPA, LERROR, "no end user consent for profile installation -- canceling session!\n"); - cmn_cancel_sess_pars.reason = CancelSessionReason_endUserRejection; - cmn_cancel_sess_pars.transaction_id = *auth_clnt_res->transaction_id; - ipa_proc_cmn_cancel_sess(ctx, &cmn_cancel_sess_pars); - goto error; - } - /* Execute sub procedure: Sub-procedure Profile Installation (See also section 3.1.3.3 of SGP.22) */ prfle_inst_pars.bound_profile_package = &get_bnd_prfle_pkg_res->get_bnd_prfle_pkg_ok->boundProfilePackage; if (ipa_proc_prfle_inst(ctx, &prfle_inst_pars) < 0) { diff --git a/src/ipa/libipa/proc_prfle_dwnld.c b/src/ipa/libipa/proc_prfle_dwnld.c index c30442c..f9c5176 100644 --- a/src/ipa/libipa/proc_prfle_dwnld.c +++ b/src/ipa/libipa/proc_prfle_dwnld.c @@ -8,8 +8,6 @@ * See also: GSMA SGP.22, section 3.1.3.2: Sub-procedure Profile Download and Installation – Download Confirmation */ -/* TODO: fix spec reference, see github issue #5 */ - #include <stdio.h> #include <assert.h> #include <string.h> diff --git a/src/ipa/main.c b/src/ipa/main.c index bf2e386..2b15d9b 100644 --- a/src/ipa/main.c +++ b/src/ipa/main.c @@ -37,19 +37,6 @@ bool running = true; -bool prfle_inst_consent(char *sm_dp_plus_address, char *ac_token) -{ - char user_input; - printf("PLEASE CONSENT TO PROFILE INSTALLATION:\n"); - printf("smdp+: %s\n", sm_dp_plus_address); - printf("ac-token: %s\n", ac_token); - printf("Consent (Y/N)? "); - user_input = getchar(); - if (user_input == 'Y' || user_input == 'y') - return true; - return false; -} - static void print_help(const char *prog_name) { printf("Usage: %s [OPTIONS] [OPERATION]\n", prog_name); @@ -63,7 +50,6 @@ printf(" -n PATH ..................... path to nvstate file (default: %s)\n", DEFAULT_NVSTATE_PATH); printf(" -y NUM ...................... number of retries for ESipa requests (default: %u)\n", DEFAULT_ESIPA_REQ_RETRIES); - printf(" -a .......................... ask end user for consent\n"); printf(" -C .......................... CA (Certificate Authority) Bundle file\n"); printf(" -S .......................... disable HTTPS\n"); printf(" -I .......................... disable SSL certificate verification (insecure)\n"); @@ -222,9 +208,6 @@ case 'y': cfg.esipa_req_retries = atoi(optarg); break; - case 'a': - cfg.prfle_inst_consent_cb = prfle_inst_consent; - break; case '1': getopt_one_euicc_pkg_only = true; break; -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43437?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I1882890a5c1c74be1243d9649117ba7220c271d6 Gerrit-Change-Number: 43437 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[M] Change in onomondo-ipa[master]: proc_indirect_prfle_dwnld: refactor module, fix spec references
by dexter 17 Sep '26

17 Sep '26

Attention is currently required from: dexter, laforge. Hello Jenkins Builder, jolly, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43438?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: proc_indirect_prfle_dwnld: refactor module, fix spec references ...................................................................... proc_indirect_prfle_dwnld: refactor module, fix spec references The Indirect Profile Download Procedure uses incorrect spec references. As it seems it was a bit mixed up with the Direct Profile Download Procedure, which is very similar, but not identical. With this patch we: - Move the steps from proc_prfle_dwnld.c into proc_indirect_prfle_dwnld.c - restructure the code - Fix the incorrect spec references - Refactor the error handling (session cancellation) - Add TODOs for parts that are still missing Related: SYS#8101 Change-Id: I69571280c7b52f2cb09f733bc0466cb77c0d2590 --- M src/ipa/libipa/CMakeLists.txt M src/ipa/libipa/proc_cmn_mtl_auth.c M src/ipa/libipa/proc_indirect_prfle_dwnld.c D src/ipa/libipa/proc_prfle_dwnld.c D src/ipa/libipa/proc_prfle_dwnld.h 5 files changed, 64 insertions(+), 122 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/38/43438/3 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43438?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I69571280c7b52f2cb09f733bc0466cb77c0d2590 Gerrit-Change-Number: 43438 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log September 2026