September 2026 - gerrit-log - lists.osmocom.org

[L] Change in pysim[master]: transport: stop the T=0 layer from breaking GP 6310
by dexter 18 Sep '26

18 Sep '26

Attention is currently required from: Hoernchen. dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43551?usp=email ) Change subject: transport: stop the T=0 layer from breaking GP 6310 ...................................................................... Patch Set 2: (1 comment) File pySim/global_platform/__init__.py: https://gerrit.osmocom.org/c/pysim/+/43551/comment/1f30b9a9_c7b592eb?usp=em… : PS2, Line 751: raise SwMatchError(sw, '9000/6310') > I would recommend to check this back. When I look at the apidoc in exceptions. […] I gave this a practical test: When I select the ISD and do a "get_status applications" for example, I end up in this code path. I am not sure if this is expected or not, at least with current master no such error is displayed. I just wanted to inform you about this. If this is the expected behavior, everything should be fine. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43551?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I10f8afa8dd5623a49a6a0e7132607b3a1fad2d8c Gerrit-Change-Number: 43551 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Sep 2026 08:31:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: bts: testenv: fake_trx.py -> osmo-trx-proxy
by osmith 18 Sep '26

18 Sep '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43668?usp=email ) Change subject: bts: testenv: fake_trx.py -> osmo-trx-proxy ...................................................................... bts: testenv: fake_trx.py -> osmo-trx-proxy Use the new osmo-trx-proxy instead of fake_trx.py. Related: OS#6672 Depends: osmo-trx I995b44bf9a884cf5ba6db8333e6f08c9604a58a5 Change-Id: I8eadd99f3263fde08b31dc228dddfc87a38dba52 --- M _testenv/data/osmo-dev/testenv.opts M _testenv/data/podman/Dockerfile A bts/osmo-trx-proxy.cfg M bts/testenv_generic.cfg M bts/testenv_hopping.cfg M bts/testenv_oml.cfg 6 files changed, 63 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/68/43668/1 diff --git a/_testenv/data/osmo-dev/testenv.opts b/_testenv/data/osmo-dev/testenv.opts index 4ee524b..f6456df 100644 --- a/_testenv/data/osmo-dev/testenv.opts +++ b/_testenv/data/osmo-dev/testenv.opts @@ -1,3 +1,4 @@ osmo-bts --enable-trx osmo-remsim --disable-remsim-client-ifdhandler onomondo-ipa -DMEM_EMIT_DEBUG=ON +osmo-trx --with-proxy diff --git a/_testenv/data/podman/Dockerfile b/_testenv/data/podman/Dockerfile index 6a1a42a..cc9816b 100644 --- a/_testenv/data/podman/Dockerfile +++ b/_testenv/data/podman/Dockerfile @@ -43,6 +43,7 @@ libdbd-sqlite3 \ libdbi-dev \ libelf-dev \ + libfftw3-dev \ libgcc-*-dev \ libgcrypt-dev \ libgnutls28-dev \ diff --git a/bts/osmo-trx-proxy.cfg b/bts/osmo-trx-proxy.cfg new file mode 100644 index 0000000..a48ad9c --- /dev/null +++ b/bts/osmo-trx-proxy.cfg @@ -0,0 +1,34 @@ +log stderr + logging filter all 1 + logging color 1 + logging print category-hex 0 + logging print category 1 + logging print thread-id 0 + logging print extended-timestamp 1 + logging print level 1 + logging print file basename last + logging level set-all notice + logging level proxy info + logging level trxc info + logging level trxd notice + logging level lglobal notice +! +proxy + bind-addr 127.0.0.1 + clck-gen start-fn random + clck-gen ind-period 102 + pm-rssi-noise -110 + path-loss 110 + nominal-toa256 0 + nominal-ci 90 + ep bts + remote-addr 127.0.0.1 + base-port 5700 + num-chans 3 + tx-power 50 + ep ms + remote-addr 127.0.0.1 + base-port 6700 + num-chans 3 + tx-power 50 + no clock-socket diff --git a/bts/testenv_generic.cfg b/bts/testenv_generic.cfg index 5094177..62d679b 100644 --- a/bts/testenv_generic.cfg +++ b/bts/testenv_generic.cfg @@ -8,10 +8,15 @@ package=osmo-bsc copy=osmo-bsc.cfg -[fake-trx] -program=run_fake_trx.sh -make=.make.osmocom-bb.clone -package=osmocom-bb-trx-toolkit +[trx-proxy] +program=osmo-trx-proxy +make=osmo-trx +package=osmo-trx-proxy +copy=osmo-trx-proxy.cfg +# Remove *_latest after osmo-trx >= 1.9.0 was released +program_latest=run_fake_trx.sh +make_latest=.make.osmocom-bb.clone +package_latest=osmocom-bb-trx-toolkit [trxcon] program=trxcon diff --git a/bts/testenv_hopping.cfg b/bts/testenv_hopping.cfg index 99943f1..e90f638 100644 --- a/bts/testenv_hopping.cfg +++ b/bts/testenv_hopping.cfg @@ -11,10 +11,15 @@ package=osmo-bsc libosmocore-utils copy=osmo-bsc.cfg osmo-bsc-fh.confmerge -[fake-trx] -program=run_fake_trx.sh -make=.make.osmocom-bb.clone -package=osmocom-bb-trx-toolkit +[trx-proxy] +program=osmo-trx-proxy +make=osmo-trx +package=osmo-trx-proxy +copy=osmo-trx-proxy.cfg +# Remove *_latest after osmo-trx >= 1.9.0 was released +program_latest=run_fake_trx.sh +make_latest=.make.osmocom-bb.clone +package_latest=osmocom-bb-trx-toolkit [trxcon] program=trxcon diff --git a/bts/testenv_oml.cfg b/bts/testenv_oml.cfg index 7b7651e..c1cce63 100644 --- a/bts/testenv_oml.cfg +++ b/bts/testenv_oml.cfg @@ -2,10 +2,15 @@ program=BTS_Tests config=BTS_Tests_OML.cfg -[fake-trx] -program=run_fake_trx.sh -make=.make.osmocom-bb.clone -package=osmocom-bb-trx-toolkit +[trx-proxy] +program=osmo-trx-proxy +make=osmo-trx +package=osmo-trx-proxy +copy=osmo-trx-proxy.cfg +# Remove *_latest after osmo-trx >= 1.9.0 was released +program_latest=run_fake_trx.sh +make_latest=.make.osmocom-bb.clone +package_latest=osmocom-bb-trx-toolkit [trxcon] program=trxcon -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43668?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8eadd99f3263fde08b31dc228dddfc87a38dba52 Gerrit-Change-Number: 43668 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in onomondo-eim[master]: esipa_asn1_handler: fix typos
by dexter 18 Sep '26

18 Sep '26

dexter has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43654?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: esipa_asn1_handler: fix typos ...................................................................... esipa_asn1_handler: fix typos Related: SYS#8100 Change-Id: I14416250cdb523f5c1a20d3a3e3dbe5cc6c53bcd --- M src/esipa_asn1_handler.erl 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/esipa_asn1_handler.erl b/src/esipa_asn1_handler.erl index 2fe7603..9cb264a 100644 --- a/src/esipa_asn1_handler.erl +++ b/src/esipa_asn1_handler.erl @@ -21,7 +21,7 @@ % initiateAuthenticationRequest. However the field is only missing in case the IPA capability minimizeEsipaBytes is % used. This is an optional feature that this eIM does not support, so we can expect euiccInfo1 to be always present. - % TODO: Popluate smdpAddress from Activation Code if missing: smdpAddress is declared as anan optional field in + % TODO: Popluate smdpAddress from Activation Code if missing: smdpAddress is declared as an optional field in % InitiateAuthenticationRequestEsipa. If the field is missing, we can retrieve it from the Activation Code that is % stored in the download Order (see also SGP.32, section 3.2.3.2, step 8). @@ -229,8 +229,8 @@ % Sub-procedure Profile Installation (see also GSMA SGP.22, section 3.1.3.3). The eIM uses the % result data contained in this message to conclude the download and to make the download results % available to the REST API user. However, in rare cases it is possible that a - % ProfileInstallationResult is received way too late as part of the Notification Delivery to - % Notification Receivers (see also GSMA SGP.32, section 3.7) procedure. By then the context in the + % ProfileInstallationResult is received way too late as part of the notification delivery to + % notification receivers (see also GSMA SGP.32, section 3.7) procedure. By then the context in the % eIM may be long gone. The eIM will be unable to match the ProfileInstallationResult to any % context but it will foward it to the SMDP+ anyway. case mnesia_db_work:bind(Pid, TransactionId) of -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43654?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I14416250cdb523f5c1a20d3a3e3dbe5cc6c53bcd Gerrit-Change-Number: 43654 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in onomondo-eim[master]: crypto_utils: log EID and encoded EUM cert instead of decoded cert
by dexter 18 Sep '26

18 Sep '26

Attention is currently required from: laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43647?usp=email ) Change subject: crypto_utils: log EID and encoded EUM cert instead of decoded cert ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/onomondo-eim/+/43647/comment/fd30f2b2_c96eab1f… : PS2, Line 13: Let's instead log the EID of the : eUICC that caused the problem, which is much more helpful then just : a certificate dump that is barely readable. > Mh, I think such an event is something one definitely wants to investigate further, if it ever happe […] We could just log the binary blob of the EUM Certificate in addition the EID. I think this is a good compromise. -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43647?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I33c19fee0bec31b4c6b3c8052976625f3213aac1 Gerrit-Change-Number: 43647 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 18 Sep 2026 07:41:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in onomondo-eim[master]: esipa_asn1_handler: fix typos
by dexter 18 Sep '26

18 Sep '26

Attention is currently required from: dexter. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-eim/+/43654?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: esipa_asn1_handler: fix typos ...................................................................... esipa_asn1_handler: fix typos Related: SYS#8100 Change-Id: I14416250cdb523f5c1a20d3a3e3dbe5cc6c53bcd --- M src/esipa_asn1_handler.erl 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/54/43654/3 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43654?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I14416250cdb523f5c1a20d3a3e3dbe5cc6c53bcd Gerrit-Change-Number: 43654 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in onomondo-eim[master]: crypto_utils: log EID and encoded EUM cert instead of decoded cert
by dexter 18 Sep '26

18 Sep '26

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-eim/+/43647?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: crypto_utils: log EID and encoded EUM cert instead of decoded cert ...................................................................... crypto_utils: log EID and encoded EUM cert instead of decoded cert When a profile download happens, the eIM automatically tries to check the EUM (and the eUICC certificate). This is done in order to cache the public key of the eUICC certificate. For the check, a the root certificate of the EUM certificate is required. If none is found, an error is logged with the decoded EUM certificate as context. This produces a lot of log lines and the decoded certificate contents are barely readable. Let's instead log the EID of the eUICC and the EUM certificate in its encoded form (hexdump). This is much more compact and still gives eIM operators enough context to track down the problem. Related: SYS#8100 Change-Id: I33c19fee0bec31b4c6b3c8052976625f3213aac1 --- M src/crypto_utils.erl 1 file changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/47/43647/3 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43647?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I33c19fee0bec31b4c6b3c8052976625f3213aac1 Gerrit-Change-Number: 43647 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in onomondo-eim[master]: mnesia_db_work: use distinct logic when fetching from rest table
by dexter 18 Sep '26

18 Sep '26

Attention is currently required from: laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43658?usp=email ) Change subject: mnesia_db_work: use distinct logic when fetching from rest table ...................................................................... Patch Set 2: (1 comment) File src/mnesia_db_work.erl: https://gerrit.osmocom.org/c/onomondo-eim/+/43658/comment/377d272c_b367b3a7… : PS1, Line 51: X#rest.facility =/= euicc > somehow the new indentation is off? I also think they look off, but that is what rebar3 fmt -w generates/enforces. -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43658?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I2e42bde0c03155e7b2bcf058b20174b75e8e0d97 Gerrit-Change-Number: 43658 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 18 Sep 2026 07:41:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[M] Change in onomondo-ipa[master]: cosmetic: fix static, typos and sourcecode formatting
by dexter 18 Sep '26

18 Sep '26

dexter has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43439?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: cosmetic: fix static, typos and sourcecode formatting ...................................................................... cosmetic: fix static, typos and sourcecode formatting This patch fixes a few minor cosmetic issues: - Ensure that all function that can be declared as static are declared as static - Fix typos - Fix sourcecode formatting Related: SYS#8101 Change-Id: I3b3fa7dc6e2e541cccff6579b4424157e8233fa8 --- M src/ipa/libipa/es10b_euicc_mem_rst.c M src/ipa/libipa/es10b_get_eim_cfg_data.c M src/ipa/libipa/es10b_immediate_enable.c M src/ipa/libipa/es10b_load_euicc_pkg.c M src/ipa/libipa/es10b_retr_notif_from_lst.c M src/ipa/libipa/es10c_get_prfle_info.c M src/ipa/libipa/esipa_prvde_eim_pkg_rslt.c M src/ipa/libipa/ipad.c M src/ipa/libipa/proc_eim_pkg_retr.c M src/ipa/libipa/proc_euicc_pkg_dwnld_exec.c 10 files changed, 59 insertions(+), 50 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified jolly: Looks good to me, but someone else must approve diff --git a/src/ipa/libipa/es10b_euicc_mem_rst.c b/src/ipa/libipa/es10b_euicc_mem_rst.c index 1e90adb..179f89a 100644 --- a/src/ipa/libipa/es10b_euicc_mem_rst.c +++ b/src/ipa/libipa/es10b_euicc_mem_rst.c @@ -131,7 +131,7 @@ return rc; } -int euicc_mem_rst(struct ipa_context *ctx, const struct ipa_es10b_euicc_mem_rst *req) +static int euicc_mem_rst(struct ipa_context *ctx, const struct ipa_es10b_euicc_mem_rst *req) { struct ipa_buf *es10b_req = NULL; struct ipa_buf *es10b_res = NULL; @@ -180,7 +180,7 @@ return rc; } -int euicc_mem_rst_emu(struct ipa_context *ctx, const struct ipa_es10b_euicc_mem_rst *req) +static int euicc_mem_rst_emu(struct ipa_context *ctx, const struct ipa_es10b_euicc_mem_rst *req) { struct ipa_buf *es10b_req = NULL; struct ipa_buf *es10b_res = NULL; diff --git a/src/ipa/libipa/es10b_get_eim_cfg_data.c b/src/ipa/libipa/es10b_get_eim_cfg_data.c index 6e2f32b..9a34392 100644 --- a/src/ipa/libipa/es10b_get_eim_cfg_data.c +++ b/src/ipa/libipa/es10b_get_eim_cfg_data.c @@ -23,7 +23,7 @@ #include "es10x.h" #include "es10b_get_eim_cfg_data.h" -void convert_get_eim_cfg_data(struct ipa_es10b_eim_cfg_data *res) +static void convert_get_eim_cfg_data(struct ipa_es10b_eim_cfg_data *res) { unsigned int i; asn_enc_rval_t rc; diff --git a/src/ipa/libipa/es10b_immediate_enable.c b/src/ipa/libipa/es10b_immediate_enable.c index 922e015..9847fc0 100644 --- a/src/ipa/libipa/es10b_immediate_enable.c +++ b/src/ipa/libipa/es10b_immediate_enable.c @@ -57,7 +57,7 @@ return rc; } -int immediate_enable(struct ipa_context *ctx, bool refresh_flag) +static int immediate_enable(struct ipa_context *ctx, bool refresh_flag) { struct ipa_buf *es10b_req = NULL; struct ipa_buf *es10b_res = NULL; @@ -87,7 +87,7 @@ return rc; } -int immediate_enable_emu(struct ipa_context *ctx, bool refresh_flag) +static int immediate_enable_emu(struct ipa_context *ctx, bool refresh_flag) { struct ipa_es10c_enable_prfle_req enable_prfle_req = { 0 }; struct ipa_es10c_enable_prfle_res *enable_prfle_res = NULL; diff --git a/src/ipa/libipa/es10b_load_euicc_pkg.c b/src/ipa/libipa/es10b_load_euicc_pkg.c index 3bc0747..1989a59 100644 --- a/src/ipa/libipa/es10b_load_euicc_pkg.c +++ b/src/ipa/libipa/es10b_load_euicc_pkg.c @@ -71,7 +71,7 @@ return 0; } -struct ipa_es10b_load_euicc_pkg_res *load_euicc_pkg(struct ipa_context *ctx, +static struct ipa_es10b_load_euicc_pkg_res *load_euicc_pkg(struct ipa_context *ctx, const struct ipa_es10b_load_euicc_pkg_req *req) { struct ipa_buf *es10b_req = NULL; @@ -105,7 +105,7 @@ return NULL; } -struct EuiccResultData *iot_emo_do_enable_psmo(struct ipa_context *ctx, const struct Psmo__enable *enable_psmo) +static struct EuiccResultData *iot_emu_do_enable_psmo(struct ipa_context *ctx, const struct Psmo__enable *enable_psmo) { struct EuiccResultData *euicc_result_data = IPA_ALLOC_ZERO(struct EuiccResultData); struct ipa_es10c_enable_prfle_req enable_prfle_req = { 0 }; @@ -129,7 +129,8 @@ return euicc_result_data; } -struct EuiccResultData *iot_emo_do_disable_psmo(struct ipa_context *ctx, const struct Psmo__disable *disable_psmo) +static struct EuiccResultData *iot_emu_do_disable_psmo(struct ipa_context *ctx, + const struct Psmo__disable *disable_psmo) { struct EuiccResultData *euicc_result_data = IPA_ALLOC_ZERO(struct EuiccResultData); struct ipa_es10c_disable_prfle_req disable_prfle_req = { 0 }; @@ -153,7 +154,7 @@ return euicc_result_data; } -struct EuiccResultData *iot_emo_do_delete_psmo(struct ipa_context *ctx, const struct Psmo__delete *delete_psmo) +static struct EuiccResultData *iot_emu_do_delete_psmo(struct ipa_context *ctx, const struct Psmo__delete *delete_psmo) { struct EuiccResultData *euicc_result_data = IPA_ALLOC_ZERO(struct EuiccResultData); struct ipa_es10c_delete_prfle_req delete_prfle_req = { 0 }; @@ -175,8 +176,9 @@ return euicc_result_data; } -struct EuiccResultData *iot_emo_do_listProfileInfo_psmo(struct ipa_context *ctx, - const struct ProfileInfoListRequest *listProfileInfo_psmo) +static struct EuiccResultData *iot_emu_do_listProfileInfo_psmo(struct ipa_context *ctx, + const struct ProfileInfoListRequest + *listProfileInfo_psmo) { struct EuiccResultData *euicc_result_data = IPA_ALLOC_ZERO(struct EuiccResultData); struct ipa_es10c_get_prfle_info_req get_prfle_info_req = { 0 }; @@ -207,7 +209,7 @@ return euicc_result_data; } -struct EuiccResultData *iot_emo_do_getRAT_psmo(struct ipa_context *ctx, const struct Psmo__getRAT *getRAT_psmo) +static struct EuiccResultData *iot_emu_do_getRAT_psmo(struct ipa_context *ctx, const struct Psmo__getRAT *getRAT_psmo) { struct EuiccResultData *euicc_result_data = IPA_ALLOC_ZERO(struct EuiccResultData); struct ipa_es10b_get_rat_res *get_rat_res = NULL; @@ -234,8 +236,9 @@ return euicc_result_data; } -struct EuiccResultData *iot_emo_do_configureImmediateEnable_psmo(struct ipa_context *ctx, const struct Psmo__configureImmediateEnable - *configureImmediateEnable_psmo) +static struct EuiccResultData *iot_emu_do_configureImmediateEnable_psmo(struct ipa_context *ctx, + const struct Psmo__configureImmediateEnable + *configureImmediateEnable_psmo) { struct EuiccResultData *euicc_result_data = IPA_ALLOC_ZERO(struct EuiccResultData); @@ -266,8 +269,9 @@ return euicc_result_data; } -struct EuiccResultData *iot_emo_do_setFallbackAttribute_psmo(struct ipa_context *ctx, - const struct Psmo__setFallbackAttribute *setFallbackAttribute_psmo) +static struct EuiccResultData *iot_emu_do_setFallbackAttribute_psmo(struct ipa_context *ctx, + const struct Psmo__setFallbackAttribute + *setFallbackAttribute_psmo) { struct EuiccResultData *euicc_result_data = IPA_ALLOC_ZERO(struct EuiccResultData); @@ -280,8 +284,9 @@ return euicc_result_data; } -struct EuiccResultData *iot_emo_do_unsetFallbackAttribute_psmo(struct ipa_context *ctx, - const struct Psmo__unsetFallbackAttribute *unsetFallbackAttribute_psmo) +static struct EuiccResultData *iot_emu_do_unsetFallbackAttribute_psmo(struct ipa_context *ctx, + const struct Psmo__unsetFallbackAttribute + *unsetFallbackAttribute_psmo) { struct EuiccResultData *euicc_result_data = IPA_ALLOC_ZERO(struct EuiccResultData); @@ -294,8 +299,9 @@ return euicc_result_data; } -struct EuiccResultData *iot_emo_do_setDefaultDpAddress_psmo(struct ipa_context *ctx, - const SGP32_SetDefaultDpAddressRequest_t *setDefaultDpAddress_psmo) +static struct EuiccResultData *iot_emu_do_setDefaultDpAddress_psmo(struct ipa_context *ctx, + const SGP32_SetDefaultDpAddressRequest_t + *setDefaultDpAddress_psmo) { struct EuiccResultData *euicc_result_data = IPA_ALLOC_ZERO(struct EuiccResultData); int rc; @@ -313,7 +319,8 @@ return euicc_result_data; } -struct EuiccResultData *iot_emo_do_addEim_eco(struct ipa_context *ctx, const struct EimConfigurationData *addEim_eco) +static struct EuiccResultData *iot_emu_do_addEim_eco(struct ipa_context *ctx, + const struct EimConfigurationData *addEim_eco) { struct EuiccResultData *euicc_result_data = IPA_ALLOC_ZERO(struct EuiccResultData); struct ipa_es10b_eim_cfg_data *eim_cfg_data = NULL; @@ -389,7 +396,8 @@ return euicc_result_data; } -struct EuiccResultData *iot_emo_do_deleteEim_eco(struct ipa_context *ctx, const struct Eco__deleteEim *deleteEim_eco) +static struct EuiccResultData *iot_emu_do_deleteEim_eco(struct ipa_context *ctx, + const struct Eco__deleteEim *deleteEim_eco) { struct EuiccResultData *euicc_result_data = IPA_ALLOC_ZERO(struct EuiccResultData); struct ipa_es10b_eim_cfg_data *eim_cfg_data = NULL; @@ -448,8 +456,8 @@ return euicc_result_data; } -struct EuiccResultData *iot_emo_do_updateEim_eco(struct ipa_context *ctx, - const struct EimConfigurationData *updateEim_eco) +static struct EuiccResultData *iot_emu_do_updateEim_eco(struct ipa_context *ctx, + const struct EimConfigurationData *updateEim_eco) { struct EuiccResultData *euicc_result_data = IPA_ALLOC_ZERO(struct EuiccResultData); struct ipa_es10b_eim_cfg_data *eim_cfg_data = NULL; @@ -538,7 +546,7 @@ return euicc_result_data; } -struct EuiccResultData *iot_emo_do_listEim_eco(struct ipa_context *ctx, const struct Eco__listEim *listEim_eco) +static struct EuiccResultData *iot_emu_do_listEim_eco(struct ipa_context *ctx, const struct Eco__listEim *listEim_eco) { struct EuiccResultData *euicc_result_data = IPA_ALLOC_ZERO(struct EuiccResultData); struct ipa_es10b_eim_cfg_data *eim_cfg_data = NULL; @@ -584,8 +592,8 @@ return euicc_result_data; } -struct ipa_es10b_load_euicc_pkg_res *load_euicc_pkg_iot_emu(struct ipa_context *ctx, - const struct ipa_es10b_load_euicc_pkg_req *req) +static struct ipa_es10b_load_euicc_pkg_res *load_euicc_pkg_iot_emu(struct ipa_context *ctx, + const struct ipa_es10b_load_euicc_pkg_req *req) { struct ipa_es10b_load_euicc_pkg_res *res = NULL; struct EuiccPackageResult *asn = NULL; @@ -621,7 +629,7 @@ ipa_buf_assign(&euicc_sign_epr, euiccSignEPR_dummy, sizeof(euiccSignEPR_dummy)); IPA_COPY_IPA_BUF_TO_ASN(&asn->choice.euiccPackageResultSigned.euiccSignEPR, &euicc_sign_epr); - /* Go through the list of PSMOs and ECOs and execute the corresponding iot_emo_do... functions */ + /* Go through the list of PSMOs and ECOs and execute the corresponding iot_emu_do... functions */ switch (req->req.euiccPackageSigned.euiccPackage.present) { case EuiccPackage_PR_psmoList: for (i = 0; i < req->req.euiccPackageSigned.euiccPackage.choice.psmoList.list.count; i++) { @@ -629,32 +637,32 @@ psmo_result = NULL; switch (psmo->present) { case Psmo_PR_enable: - psmo_result = iot_emo_do_enable_psmo(ctx, &psmo->choice.enable); + psmo_result = iot_emu_do_enable_psmo(ctx, &psmo->choice.enable); break; case Psmo_PR_disable: - psmo_result = iot_emo_do_disable_psmo(ctx, &psmo->choice.disable); + psmo_result = iot_emu_do_disable_psmo(ctx, &psmo->choice.disable); break; case Psmo_PR_delete: - psmo_result = iot_emo_do_delete_psmo(ctx, &psmo->choice.Delete); + psmo_result = iot_emu_do_delete_psmo(ctx, &psmo->choice.Delete); break; case Psmo_PR_listProfileInfo: - psmo_result = iot_emo_do_listProfileInfo_psmo(ctx, &psmo->choice.listProfileInfo); + psmo_result = iot_emu_do_listProfileInfo_psmo(ctx, &psmo->choice.listProfileInfo); break; case Psmo_PR_getRAT: - psmo_result = iot_emo_do_getRAT_psmo(ctx, &psmo->choice.getRAT); + psmo_result = iot_emu_do_getRAT_psmo(ctx, &psmo->choice.getRAT); break; case Psmo_PR_configureImmediateEnable: psmo_result = - iot_emo_do_configureImmediateEnable_psmo(ctx, &psmo->choice.configureImmediateEnable); + iot_emu_do_configureImmediateEnable_psmo(ctx, &psmo->choice.configureImmediateEnable); break; case Psmo_PR_setFallbackAttribute: - psmo_result = iot_emo_do_setFallbackAttribute_psmo(ctx, &psmo->choice.setFallbackAttribute); + psmo_result = iot_emu_do_setFallbackAttribute_psmo(ctx, &psmo->choice.setFallbackAttribute); break; case Psmo_PR_unsetFallbackAttribute: - psmo_result = iot_emo_do_unsetFallbackAttribute_psmo(ctx, &psmo->choice.unsetFallbackAttribute); + psmo_result = iot_emu_do_unsetFallbackAttribute_psmo(ctx, &psmo->choice.unsetFallbackAttribute); break; case Psmo_PR_setDefaultDpAddress: - psmo_result = iot_emo_do_setDefaultDpAddress_psmo(ctx, &psmo->choice.setDefaultDpAddress); + psmo_result = iot_emu_do_setDefaultDpAddress_psmo(ctx, &psmo->choice.setDefaultDpAddress); break; default: IPA_LOGP_ES10X("LoadEuiccPackage", LERROR, "ignoring invalid or unsupported PSMO!\n"); @@ -671,16 +679,16 @@ eco_result = NULL; switch (eco->present) { case Eco_PR_addEim: - eco_result = iot_emo_do_addEim_eco(ctx, &eco->choice.addEim); + eco_result = iot_emu_do_addEim_eco(ctx, &eco->choice.addEim); break; case Eco_PR_deleteEim: - eco_result = iot_emo_do_deleteEim_eco(ctx, &eco->choice.deleteEim); + eco_result = iot_emu_do_deleteEim_eco(ctx, &eco->choice.deleteEim); break; case Eco_PR_updateEim: - eco_result = iot_emo_do_updateEim_eco(ctx, &eco->choice.updateEim); + eco_result = iot_emu_do_updateEim_eco(ctx, &eco->choice.updateEim); break; case Eco_PR_listEim: - eco_result = iot_emo_do_listEim_eco(ctx, &eco->choice.listEim); + eco_result = iot_emu_do_listEim_eco(ctx, &eco->choice.listEim); break; default: IPA_LOGP_ES10X("LoadEuiccPackage", LERROR, "ignoring invalid or unsupported eCO!\n"); diff --git a/src/ipa/libipa/es10b_retr_notif_from_lst.c b/src/ipa/libipa/es10b_retr_notif_from_lst.c index 608a8db..52773ca 100644 --- a/src/ipa/libipa/es10b_retr_notif_from_lst.c +++ b/src/ipa/libipa/es10b_retr_notif_from_lst.c @@ -24,8 +24,8 @@ #include "es10b_retr_notif_from_lst.h" /* Convert a notificationList (RetrieveNotificationsListResponse) from RSP to SGP32 format. */ -void convert_notification_list(PendingNotificationList_t *lst_out, - const struct RetrieveNotificationsListResponse__notificationList *lst_in) +static void convert_notification_list(PendingNotificationList_t *lst_out, + const struct RetrieveNotificationsListResponse__notificationList *lst_in) { unsigned int i; struct PendingNotification *pending_notif_item; @@ -73,7 +73,7 @@ } /*! Free a converted notificationList (RetrieveNotificationsListResponse). */ -void free_converted_notification_list(PendingNotificationList_t *lst) +static void free_converted_notification_list(PendingNotificationList_t *lst) { int i; if (!lst) diff --git a/src/ipa/libipa/es10c_get_prfle_info.c b/src/ipa/libipa/es10c_get_prfle_info.c index 9c82505..6005101 100644 --- a/src/ipa/libipa/es10c_get_prfle_info.c +++ b/src/ipa/libipa/es10c_get_prfle_info.c @@ -105,7 +105,7 @@ return sgp32_res; } -struct ipa_es10c_get_prfle_info_req *conv_get_prfle_info_req(const struct ipa_es10c_get_prfle_info_req *req) +static struct ipa_es10c_get_prfle_info_req *conv_get_prfle_info_req(const struct ipa_es10c_get_prfle_info_req *req) { uint8_t default_tags[] = { 0x5A, 0x4F, 0x9F, 0x70, 0x91, 0x92, 0x95, 0x9F, 0x7B, 0x9F, 0x26, 0x9F, 0x67 }; struct ipa_es10c_get_prfle_info_req *conv_req = IPA_ALLOC_ZERO(struct ipa_es10c_get_prfle_info_req); @@ -157,7 +157,7 @@ return conv_req; } -void conv_get_prfle_info_req_free(struct ipa_es10c_get_prfle_info_req *req) +static void conv_get_prfle_info_req_free(struct ipa_es10c_get_prfle_info_req *req) { if (!req) return; diff --git a/src/ipa/libipa/esipa_prvde_eim_pkg_rslt.c b/src/ipa/libipa/esipa_prvde_eim_pkg_rslt.c index 96af767..d0914b2 100644 --- a/src/ipa/libipa/esipa_prvde_eim_pkg_rslt.c +++ b/src/ipa/libipa/esipa_prvde_eim_pkg_rslt.c @@ -67,7 +67,7 @@ return enc; } -struct ipa_esipa_prvde_eim_pkg_rslt_res *dec_prvde_eim_pkg_rslt_res(const struct ipa_buf *msg_to_ipa_encoded) +static struct ipa_esipa_prvde_eim_pkg_rslt_res *dec_prvde_eim_pkg_rslt_res(const struct ipa_buf *msg_to_ipa_encoded) { struct EsipaMessageFromEimToIpa *msg_to_ipa = NULL; struct ipa_esipa_prvde_eim_pkg_rslt_res *res = NULL; diff --git a/src/ipa/libipa/ipad.c b/src/ipa/libipa/ipad.c index 0a590ec..1b15e56 100644 --- a/src/ipa/libipa/ipad.c +++ b/src/ipa/libipa/ipad.c @@ -88,7 +88,7 @@ return nvstate_bin; } -struct ipa_buf *nvstate_deserialize_ipa_buf(uint8_t ** nvstate_data, size_t *nvstate_data_len) +static struct ipa_buf *nvstate_deserialize_ipa_buf(uint8_t **nvstate_data, size_t *nvstate_data_len) { struct ipa_buf *buf; diff --git a/src/ipa/libipa/proc_eim_pkg_retr.c b/src/ipa/libipa/proc_eim_pkg_retr.c index ebe8e91..e5b3422 100644 --- a/src/ipa/libipa/proc_eim_pkg_retr.c +++ b/src/ipa/libipa/proc_eim_pkg_retr.c @@ -62,7 +62,7 @@ } /* Relay package contents to suitable handler procedure */ -int eim_pkg_exec(struct ipa_context *ctx, const struct ipa_esipa_get_eim_pkg_res *get_eim_pkg_res) +static int eim_pkg_exec(struct ipa_context *ctx, const struct ipa_esipa_get_eim_pkg_res *get_eim_pkg_res) { struct ipa_buf *allowed_ca_pkid = NULL; bool indirect_profile_download = false; diff --git a/src/ipa/libipa/proc_euicc_pkg_dwnld_exec.c b/src/ipa/libipa/proc_euicc_pkg_dwnld_exec.c index f8f072b..d942bc7 100644 --- a/src/ipa/libipa/proc_euicc_pkg_dwnld_exec.c +++ b/src/ipa/libipa/proc_euicc_pkg_dwnld_exec.c @@ -159,7 +159,8 @@ * \param[inout] ctx pointer to ipa_context. * \param[in] euicc_package_request pointer to struct that holds the EuiccPackageRequest. * \returns struct with intermediate result on success, NULL on failure. */ -struct ipa_proc_eucc_pkg_dwnld_exec_res *ipa_proc_eucc_pkg_dwnld_exec(struct ipa_context *ctx, const struct EuiccPackageRequest +struct ipa_proc_eucc_pkg_dwnld_exec_res *ipa_proc_eucc_pkg_dwnld_exec(struct ipa_context *ctx, + const struct EuiccPackageRequest *euicc_package_request) { struct ipa_es10b_load_euicc_pkg_req load_euicc_pkg_req = { 0 }; -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43439?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I3b3fa7dc6e2e541cccff6579b4424157e8233fa8 Gerrit-Change-Number: 43439 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[M] Change in onomondo-ipa[master]: cosmetic: fix static, typos and sourcecode formatting
by dexter 18 Sep '26

18 Sep '26

Attention is currently required from: dexter. Hello Jenkins Builder, jolly, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43439?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: cosmetic: fix static, typos and sourcecode formatting ...................................................................... cosmetic: fix static, typos and sourcecode formatting This patch fixes a few minor cosmetic issues: - Ensure that all function that can be declared as static are declared as static - Fix typos - Fix sourcecode formatting Related: SYS#8101 Change-Id: I3b3fa7dc6e2e541cccff6579b4424157e8233fa8 --- M src/ipa/libipa/es10b_euicc_mem_rst.c M src/ipa/libipa/es10b_get_eim_cfg_data.c M src/ipa/libipa/es10b_immediate_enable.c M src/ipa/libipa/es10b_load_euicc_pkg.c M src/ipa/libipa/es10b_retr_notif_from_lst.c M src/ipa/libipa/es10c_get_prfle_info.c M src/ipa/libipa/esipa_prvde_eim_pkg_rslt.c M src/ipa/libipa/ipad.c M src/ipa/libipa/proc_eim_pkg_retr.c M src/ipa/libipa/proc_euicc_pkg_dwnld_exec.c 10 files changed, 59 insertions(+), 50 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/39/43439/5 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43439?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I3b3fa7dc6e2e541cccff6579b4424157e8233fa8 Gerrit-Change-Number: 43439 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-trx[master]: Transceiver52M: use lround() for TRXD toa/ci rounding
by fixeria 17 Sep '26

17 Sep '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/43161?usp=email ) ( 4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: Transceiver52M: use lround() for TRXD toa/ci rounding ...................................................................... Transceiver52M: use lround() for TRXD toa/ci rounding trxd_fill_v0_specific() and trxd_fill_v1_specific() rounded bi->toa and bi->ci to the nearest integer using the "+ 0.5, then truncate" idiom. That only rounds correctly for non-negative inputs: for negative values (toa can be negative for an early burst, ci can be negative under poor C/I conditions) it biases towards zero instead of rounding to nearest, e.g. -1.3 + 0.5 = -0.8, truncated to 0 instead of the correct -1. Use lround() instead, which rounds-half-away-from-zero correctly for both signs. Change-Id: I0c52f1b91070e4750a8a0ffbccb222454e694c3b Related: OS#5283 --- M Transceiver52M/proto_trxd.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/Transceiver52M/proto_trxd.c b/Transceiver52M/proto_trxd.c index e5a889d..638f7f3 100644 --- a/Transceiver52M/proto_trxd.c +++ b/Transceiver52M/proto_trxd.c @@ -38,7 +38,7 @@ int toa_int; /* in 1/256 symbols, round to closest integer */ - toa_int = (int) (bi->toa * 256.0 + 0.5); + toa_int = (int) lround(bi->toa * 256.0); v0->rssi = bi->rssi; osmo_store16be(toa_int, &v0->toa); } @@ -48,7 +48,7 @@ int16_t ci_int_cB; /* deciBels->centiBels, round to closest integer */ - ci_int_cB = (int16_t)((bi->ci * 10) + 0.5); + ci_int_cB = (int16_t) lround(bi->ci * 10.0); v1->idle = !!bi->idle; v1->modulation = (bi->modulation == MODULATION_GMSK) ? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43161?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I0c52f1b91070e4750a8a0ffbccb222454e694c3b Gerrit-Change-Number: 43161 Gerrit-PatchSet: 9 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com>

1 0

2026

2025

2024

2023

2022

gerrit-log September 2026