Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43670?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: HTTP2: Introduce {tr,ts}_HTTP2_pseudo_headers_{Req,Resp}
......................................................................
HTTP2: Introduce {tr,ts}_HTTP2_pseudo_headers_{Req,Resp}
The subset of pseudo headers to use are totally different in requests
and responses. Provide templates for each to ease passing params and
easily identifying requests and responses.
Change-Id: Ida525296d998e85ea630ea24910ded1439c977f4
---
M library/HTTP2_Server_Emulation.ttcn
M library/HTTP2_Templates.ttcn
M smf/SMF_Session_CT_5G.ttcn
3 files changed, 36 insertions(+), 11 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/70/43670/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43670?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ida525296d998e85ea630ea24910ded1439c977f4
Gerrit-Change-Number: 43670
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: laforge, pespin.
Hello Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43666?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Verified+1 by Jenkins Builder
Change subject: smf: Move HTTP2 hdr block compressor helpers to HTTP2_Functions.ttcn
......................................................................
smf: Move HTTP2 hdr block compressor helpers to HTTP2_Functions.ttcn
Change-Id: I5a4fffd4c26bde78340612fe024dc54c918885ab
---
M library/HTTP2_Functions.ttcn
M library/HTTP2_Server_Emulation.ttcn
M smf/SMF_Session_CT_5G.ttcn
3 files changed, 38 insertions(+), 56 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/66/43666/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43666?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5a4fffd4c26bde78340612fe024dc54c918885ab
Gerrit-Change-Number: 43666
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: Hoernchen.
dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43558?usp=email )
Change subject: bip: answer proactive commands the relay does not implement
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Patchset:
PS2:
To me this looks like a reasonable quick-fix. I would have nothing against solving the problem this way. It logs the proactive commands attempts, so it is also clear to the user that something is missing...
File pySim/bip.py:
https://gerrit.osmocom.org/c/pysim/+/43558/comment/bdb62244_88c18215?usp=em… :
PS2, Line 215: because we claim to support every feature flag there is.
I wonder if we could send a more accurate set of feature flags? - Just an idea, probably thought of it already...
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/43558?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I1e55d6f88c872a04b89a3946dd840d30b329621e
Gerrit-Change-Number: 43558
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 18 Sep 2026 10:53:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Hoernchen.
dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43557?usp=email )
Change subject: cat: add sms_pp_download_envelope()
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File pySim/cat.py:
https://gerrit.osmocom.org/c/pysim/+/43557/comment/d34c3977_791f5fd0?usp=em… :
PS2, Line 773: if its missing, so for remote management its presence should suffice (?).
I think it is ok when the address is present. The UICC should have no problems with that and it also can't verify it. A missing address should also not hurt. When I remove the Adress instance altogether it still works.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/43557?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Id23227eac53d697f4f13a84e087c32bf1d60f474
Gerrit-Change-Number: 43557
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 18 Sep 2026 10:45:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/43669?usp=email )
Change subject: Add new VTY node for QoS class configuration in libosmo-sigtran
......................................................................
Add new VTY node for QoS class configuration in libosmo-sigtran
Related: OS#6753
Change-Id: I06927855a173c5b6dbf5c93aa08ea75e1d9d5f37
---
M TODO-RELEASE
M include/osmocom/vty/command.h
2 files changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/69/43669/1
diff --git a/TODO-RELEASE b/TODO-RELEASE
index 0ed7189..94320ff 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -7,3 +7,4 @@
# If any interfaces have been added since the last public release: c:r:a + 1.
# If any interfaces have been removed or changed since the last public release: c:r:0.
#library what description / commit summary line
+vty added VTY node for libsosmo-sigtran L_CS7_QOS_CLASS_NODE
diff --git a/include/osmocom/vty/command.h b/include/osmocom/vty/command.h
index 667e9ab..7e2d9c2 100644
--- a/include/osmocom/vty/command.h
+++ b/include/osmocom/vty/command.h
@@ -102,11 +102,13 @@
L_CPU_SCHED_NODE, /*!< CPU Sched related options node */
L_NS_BIND_NODE, /*!< NS bind node */
L_NS_NSE_NODE, /*!< NS NSE node */
+
+ L_CS7_QOS_CLASS_NODE, /*!< SS7 QoS Class */
+
/*
* When adding new nodes to the libosmocore project, these nodes can be
* used to avoid ABI changes for unrelated projects.
*/
- RESERVED1_NODE, /*!< Reserved for later extensions */
RESERVED2_NODE, /*!< Reserved for later extensions */
RESERVED3_NODE, /*!< Reserved for later extensions */
RESERVED4_NODE, /*!< Reserved for later extensions */
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43669?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I06927855a173c5b6dbf5c93aa08ea75e1d9d5f37
Gerrit-Change-Number: 43669
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Attention is currently required from: Hoernchen.
dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43555?usp=email )
Change subject: tools: print tracebacks to the same stream as delimiters
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/43555?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I2ed37dfe241d014e4a26894cddbc9b21be1fd0c2
Gerrit-Change-Number: 43555
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 18 Sep 2026 09:59:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Hoernchen.
dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43554?usp=email )
Change subject: transport: trace APDUs when they are sent
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
Interesting, apparently the StdoutApduTracer and the Cmd2ApduTracer implementation was oversimplified...
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/43554?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I828ea36b06da36b6bb0aa073d235d4f49cbb3161
Gerrit-Change-Number: 43554
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 18 Sep 2026 09:55:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Hoernchen.
dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43553?usp=email )
Change subject: pySim-shell: let --apdu-trace cover the session
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
Looks good to me, I also have tested it and it works.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/43553?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I83469e15f4cdd67418cd11df3869f2536105dbc8
Gerrit-Change-Number: 43553
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 18 Sep 2026 09:49:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes