Attention is currently required from: Hoernchen.
dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43560?usp=email )
Change subject: cat: fix TS 102 223 8.61 Access technology coding
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
I have looked it up and compared to the spec, looks good to me.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/43560?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I74f361cd5b818079636f399cb8c1b1c609b9e1f2
Gerrit-Change-Number: 43560
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 18 Sep 2026 11:47:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Hoernchen.
dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43559?usp=email )
Change subject: cat: fix Supported Radio Access Technologies state flag
......................................................................
Patch Set 2: Code-Review+2
(6 comments)
Patchset:
PS2:
The patch looks ok to me, but I think the comments are a bit short. At least this time it was hard to follow, even though the patch is actually very simple.
File tests/unittests/test_cat.py:
https://gerrit.osmocom.org/c/pysim/+/43559/comment/93a90179_42629fa6?usp=em… :
PS2, Line 34: def test_enabled_is_encodable(self):
maybe call this "test_encode_technology_enabled"
https://gerrit.osmocom.org/c/pysim/+/43559/comment/e01dc8c8_047e15df?usp=em… :
PS2, Line 35: """The flag used to have a bm of 0 so enabled -> 00 (that is disabled..)"""
I don't understand what a 'bm' (bit mask?) is, but I guess you refer to the state?
https://gerrit.osmocom.org/c/pysim/+/43559/comment/f127d637_36d53a53?usp=em… :
PS2, Line 40: def test_disabled_differs_from_enabled(self):
maybe call this "test_encode_technology_disabled"
https://gerrit.osmocom.org/c/pysim/+/43559/comment/e8550b52_3f6c2150?usp=em… :
PS2, Line 45: def test_state_byte_is_read_back_faithfully(self):
maybe call this "test_decode_technology", maybe then also assert on the technology ('eutran')?
https://gerrit.osmocom.org/c/pysim/+/43559/comment/df0c4932_27e3a0ee?usp=em… :
PS2, Line 53: def test_multiple_technologies(self):
... then you could call this "test_decode_technology_multiple"
those are only suggestions, I don't want to block here.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/43559?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I4dd16182eb06c99265aabab5d889967b890f6bf2
Gerrit-Change-Number: 43559
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 18 Sep 2026 11:30:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43670?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: HTTP2: Introduce {tr,ts}_HTTP2_pseudo_headers_{Req,Resp}
......................................................................
HTTP2: Introduce {tr,ts}_HTTP2_pseudo_headers_{Req,Resp}
The subset of pseudo headers to use are totally different in requests
and responses. Provide templates for each to ease passing params and
easily identifying requests and responses.
Change-Id: Ida525296d998e85ea630ea24910ded1439c977f4
---
M library/HTTP2_Server_Emulation.ttcn
M library/HTTP2_Templates.ttcn
M smf/SMF_Session_CT_5G.ttcn
3 files changed, 37 insertions(+), 14 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/70/43670/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43670?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ida525296d998e85ea630ea24910ded1439c977f4
Gerrit-Change-Number: 43670
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: jolly.
pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/43669?usp=email )
Change subject: Add new VTY node for QoS class configuration in libosmo-sigtran
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43669?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I06927855a173c5b6dbf5c93aa08ea75e1d9d5f37
Gerrit-Change-Number: 43669
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Fri, 18 Sep 2026 11:22:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43670?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: HTTP2: Introduce {tr,ts}_HTTP2_pseudo_headers_{Req,Resp}
......................................................................
HTTP2: Introduce {tr,ts}_HTTP2_pseudo_headers_{Req,Resp}
The subset of pseudo headers to use are totally different in requests
and responses. Provide templates for each to ease passing params and
easily identifying requests and responses.
Change-Id: Ida525296d998e85ea630ea24910ded1439c977f4
---
M library/HTTP2_Server_Emulation.ttcn
M library/HTTP2_Templates.ttcn
M smf/SMF_Session_CT_5G.ttcn
3 files changed, 38 insertions(+), 13 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/70/43670/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43670?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ida525296d998e85ea630ea24910ded1439c977f4
Gerrit-Change-Number: 43670
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43670?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: HTTP2: Introduce {tr,ts}_HTTP2_pseudo_headers_{Req,Resp}
......................................................................
HTTP2: Introduce {tr,ts}_HTTP2_pseudo_headers_{Req,Resp}
The subset of pseudo headers to use are totally different in requests
and responses. Provide templates for each to ease passing params and
easily identifying requests and responses.
Change-Id: Ida525296d998e85ea630ea24910ded1439c977f4
---
M library/HTTP2_Server_Emulation.ttcn
M library/HTTP2_Templates.ttcn
M smf/SMF_Session_CT_5G.ttcn
3 files changed, 36 insertions(+), 11 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/70/43670/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43670?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ida525296d998e85ea630ea24910ded1439c977f4
Gerrit-Change-Number: 43670
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>