Attention is currently required from: Hoernchen.
dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43564?usp=email )
Change subject: bip/smpp2sim: TERMINAL PROFILE that matches what we do
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File pySim-smpp2sim.py:
https://gerrit.osmocom.org/c/pysim/+/43564/comment/8ff29c4b_2f87f29a?usp=em… :
PS2, Line 129: self.scc.terminal_profile(b2h(terminal_profile()))
I see, now we have a more distinct terminal profile - Nice!
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/43564?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I91a60760fc3ad816b7385da8b26ec7330b462abd
Gerrit-Change-Number: 43564
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 18 Sep 2026 14:07:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Hoernchen.
dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43563?usp=email )
Change subject: bip: refuse OPEN CHANNEL with a TERMINAL RESPONSE
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Patchset:
PS2:
From what I can see, the logic looks reasonable and there are also comprehensive unit-tests. I think this patch should be ok.
File tests/unittests/test_bip_relay.py:
https://gerrit.osmocom.org/c/pysim/+/43563/comment/c3fc41c4_b46fa9f6?usp=em… :
PS2, Line 304: 'requested_uicc_if_transp_level_not_available')
I am not sure if this is needed or not, but you currently only test with udp_uicc_client_remote, what about testing with the other variants (tcp_uicc_server, udp_uicc_client_local, tcp_uicc_client_local)? Its clear that those will yield the same result (I have read the code), but maybe it makes sense to test those as well?
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/43563?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: If8f01e6acb9cb3f7af952a0760fc093db81be53a
Gerrit-Change-Number: 43563
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 18 Sep 2026 13:44:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Hoernchen.
dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43561?usp=email )
Change subject: cat: properly decode IMEI/IMEISV IE
......................................................................
Patch Set 2: Code-Review+2
(3 comments)
Patchset:
PS2:
I have looked through the encoding and decoding implementation, to me this appears to be correct.
Commit Message:
https://gerrit.osmocom.org/c/pysim/+/43561/comment/2ac9add0_77b01094?usp=em… :
PS2, Line 9: Currently BcdAdapter(GreedyBytes), a plain
missing word: ..., is a plain sapped..." ?
File pySim/cat.py:
https://gerrit.osmocom.org/c/pysim/+/43561/comment/311660b2_b638c53b?usp=em… :
PS2, Line 350: digits = digits[:-1] # drop the 1111 end mark
This is so weird becaus the first digit is in the higher nibble of octet 3 - maybe worth a comment. I don't know...
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/43561?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iad7aea77513d413c338edc18ef1bcc37488ae849
Gerrit-Change-Number: 43561
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 18 Sep 2026 12:31:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: jolly, pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: Add Cisco like DSCP configuration support
......................................................................
Add Cisco like DSCP configuration support
Add Cisco like VTY configuration support for DSCP. QoS classes can be
defined and configured per SS7 instance and the classes can be assigned
to listener and connections like this:
cs7 instance 0
qos class 3
qos-ip-dscp 36
...
asp myasp 2905 2905 m3ua
qos-class 3
...
asp asp-srv-m3ua 2906 2905 m3ua
qos-class 3
...
asp asp-clnt-m3ua 2905 2906 m3ua
qos-class 3
...
Ensure that the ongoing listener or connection socket is updated
whenever the QoS class is changed or deleted or its DSCP value is
changed.
Deprecated "ip-dscp" and "init-ip-dscp" configuration is still
supported. When QoS class is assigned, the deprecated configuration is
removed and vice versa.
Related: OS#6753
Depends-on: I06927855a173c5b6dbf5c93aa08ea75e1d9d5f37 (libosmocore)
Change-Id: Ic346698fc63771d95e474aec53ffb6c776636b3b
---
M TODO-RELEASE
M doc/examples/osmo-stp.cfg
M src/Makefile.am
M src/ss7_asp.c
M src/ss7_asp.h
M src/ss7_asp_vty.c
M src/ss7_instance.c
M src/ss7_instance.h
A src/ss7_qos_class.c
A src/ss7_qos_class.h
A src/ss7_qos_class_vty.c
M src/ss7_vty.c
M src/ss7_vty.h
M src/ss7_xua_srv.c
M src/ss7_xua_srv.h
M src/ss7_xua_srv_vty.c
16 files changed, 402 insertions(+), 23 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/67/43667/3
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ic346698fc63771d95e474aec53ffb6c776636b3b
Gerrit-Change-Number: 43667
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: jolly.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: Add Cisco like DSCP configuration support
......................................................................
Add Cisco like DSCP configuration support
Add Cisco like VTY configuration support for DSCP. QoS classes can be
defined and configured per SS7 instance and the classes can be assigned
to listener and connections like this:
cs7 instance 0
qos class 3
qos-ip-dscp 36
...
asp myasp 2905 2905 m3ua
qos-class 3
...
asp asp-srv-m3ua 2906 2905 m3ua
qos-class 3
...
asp asp-clnt-m3ua 2905 2906 m3ua
qos-class 3
...
Ensure that the ongoing listener or connection socket is updated
whenever the QoS class is changed or deleted or its DSCP value is
changed.
Deprecated "ip-dscp" and "init-ip-dscp" configuration is still
supported. When QoS class is assigned, the deprecated configuration is
removed and vice versa.
Related: OS#6753
Depends-on: I06927855a173c5b6dbf5c93aa08ea75e1d9d5f37 (libosmocore)
Change-Id: Ic346698fc63771d95e474aec53ffb6c776636b3b
---
M TODO-RELEASE
M doc/examples/osmo-stp.cfg
M src/Makefile.am
M src/ss7_asp.c
M src/ss7_asp.h
M src/ss7_asp_vty.c
M src/ss7_instance.c
M src/ss7_instance.h
A src/ss7_qos_class.c
A src/ss7_qos_class.h
A src/ss7_qos_class_vty.c
M src/ss7_vty.c
M src/ss7_vty.h
M src/ss7_xua_srv.c
M src/ss7_xua_srv.h
M src/ss7_xua_srv_vty.c
16 files changed, 402 insertions(+), 23 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/67/43667/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43667?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ic346698fc63771d95e474aec53ffb6c776636b3b
Gerrit-Change-Number: 43667
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>