August 2026 - gerrit-log - lists.osmocom.org

[M] Change in libosmocore[master]: iuup: test receival of IuUP Data with way too big payload
by pespin 14 Aug '26

14 Aug '26

Attention is currently required from: osmith, pespin. Hello osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/43248?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by osmith Change subject: iuup: test receival of IuUP Data with way too big payload ...................................................................... iuup: test receival of IuUP Data with way too big payload Take the chance to improve logging in that case, otherwise it is confusing when stating CRC check against 0xffffffff fails. Related: OS#7052 Change-Id: Id7059e08aa78af4c18c2be1493fb780a31e3e862 --- M src/gsm/iuup.c M tests/iuup/iuup_test.c M tests/iuup/iuup_test.err M tests/iuup/iuup_test.ok 4 files changed, 55 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/48/43248/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43248?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id7059e08aa78af4c18c2be1493fb780a31e3e862 Gerrit-Change-Number: 43248 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in libosmocore[master]: iuup: Validate msgb input length in rx Initialization path
by pespin 14 Aug '26

14 Aug '26

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/43247?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by osmith Change subject: iuup: Validate msgb input length in rx Initialization path ...................................................................... iuup: Validate msgb input length in rx Initialization path Input length validation of msgb was left as a TODO in iuup_rx_initialization(), which could end up in OOB reads. Related: OS#7063 Reported-By: Adam Bedard <adam.bedard(a)gmail.com> Change-Id: Id0f7b0f63efc37376024359a3bf7fabbc40bc387 --- M src/gsm/iuup.c M tests/iuup/iuup_test.c M tests/iuup/iuup_test.err M tests/iuup/iuup_test.ok 4 files changed, 327 insertions(+), 59 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/47/43247/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43247?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id0f7b0f63efc37376024359a3bf7fabbc40bc387 Gerrit-Change-Number: 43247 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: contrib/jenkins: add script for running pytest
by osmith 14 Aug '26

14 Aug '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/43242?usp=email ) Change subject: contrib/jenkins: add script for running pytest ...................................................................... contrib/jenkins: add script for running pytest Run pytest on this repository when sending new patches to gerrit. Change-Id: Iaec67a252fca8f1978d1465f3ce3e1d4c9415a9b --- A contrib/jenkins.sh M jobs/gerrit-verifications.yml 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh new file mode 100755 index 0000000..80bacc9 --- /dev/null +++ b/contrib/jenkins.sh @@ -0,0 +1,4 @@ +#!/bin/sh -ex +# CI script that runs on patches sent to gerrit. + +pytest -xvv diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 45ffc38..ed01050 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -311,7 +311,6 @@ pipeline_binpkgs: "" - osmo-ci: - pipeline_build: false pipeline_binpkgs: "" - osmo-dev: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43242?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaec67a252fca8f1978d1465f3ce3e1d4c9415a9b Gerrit-Change-Number: 43242 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ci[master]: tests: add test_gerrit_verifications
by osmith 14 Aug '26

14 Aug '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/43241?usp=email ) Change subject: tests: add test_gerrit_verifications ...................................................................... tests: add test_gerrit_verifications Change-Id: I6139e0385470e4c0c48d8a698f67645ac1605cbc --- A .pytest.ini A tests/test_gerrit_verifications.py 2 files changed, 32 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/.pytest.ini b/.pytest.ini new file mode 100644 index 0000000..1992657 --- /dev/null +++ b/.pytest.ini @@ -0,0 +1,3 @@ +[pytest] +addopts = --tb=no +testpaths = tests diff --git a/tests/test_gerrit_verifications.py b/tests/test_gerrit_verifications.py new file mode 100644 index 0000000..05b665c --- /dev/null +++ b/tests/test_gerrit_verifications.py @@ -0,0 +1,29 @@ +import re +from pathlib import Path + + +def test_gerrit_verifications_binpkgs(): + """Ensure we don't use more parameters for pipeline_binpkgs than the + pipeline can handle.""" + yml = Path(Path(__file__) / "../../jobs/gerrit-verifications.yml").resolve() + regex = re.compile(r'.*pipeline_binpkgs:.*"(.*)"') + + with open(yml) as f: + num = 0 + for line in f: + num += 1 + + if "pipeline_binpkgs:" not in line: + continue + + prefix = f"\n\njobs/gerrit_verifications.yml:{num}: {line}\nERROR" + + match = regex.match(line) + assert match, f"{prefix}: failed to read pipeline_binpkgs" + + count = len(match.group(1).split(" ")) + count_max = 5 + assert count < count_max, ( + f"{prefix}: found {count} parameters, but max is currently {count_max}!" + " Adjust the 'dsl' section in the yml file and count_max in this test." + ) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43241?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6139e0385470e4c0c48d8a698f67645ac1605cbc Gerrit-Change-Number: 43241 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: scripts/update-osmo-ci: rename from contrib/jenkins.sh
by osmith 14 Aug '26

14 Aug '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/43240?usp=email ) Change subject: scripts/update-osmo-ci: rename from contrib/jenkins.sh ...................................................................... scripts/update-osmo-ci: rename from contrib/jenkins.sh In all other Osmocom repositories, the contrib/jenkins.sh is the script we run in gerrit-verifications. Here we had such a script as well, but it was for a different purpose, to update osmo-ci, osmo-gsm-manuals repos on jenkins nodes and rebuild docker images, triggered by the update-osmo-ci job. Rename the script to avoid confusion and to prepare to add a script for running in gerrit-verifications. Change-Id: Ie9793663aa9b60683fc78c738b550913e8f01fbb --- M jobs/update-osmo-ci-on-slaves.yml R scripts/update-osmo-ci/update-osmo-ci.sh 2 files changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/jobs/update-osmo-ci-on-slaves.yml b/jobs/update-osmo-ci-on-slaves.yml index 9abefa9..f05c21c 100644 --- a/jobs/update-osmo-ci-on-slaves.yml +++ b/jobs/update-osmo-ci-on-slaves.yml @@ -47,7 +47,7 @@ - timed: "H H * * *" builders: - - shell: './contrib/jenkins.sh' + - shell: './scripts/update-osmo-ci/update-osmo-ci.sh' wrappers: - ansicolor: diff --git a/contrib/jenkins.sh b/scripts/update-osmo-ci/update-osmo-ci.sh similarity index 100% rename from contrib/jenkins.sh rename to scripts/update-osmo-ci/update-osmo-ci.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43240?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie9793663aa9b60683fc78c738b550913e8f01fbb Gerrit-Change-Number: 43240 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ci[master]: jobs/gerrit-verifications: support up to 5 distros
by osmith 14 Aug '26

14 Aug '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/43239?usp=email ) Change subject: jobs/gerrit-verifications: support up to 5 distros ...................................................................... jobs/gerrit-verifications: support up to 5 distros I noticed that libosmocore wasn't building for debian:13 anymore in CI even though it has: pipeline_binpkgs: "almalinux:8 centos:7 debian:10 debian:13" This is because only 3 parameters for pipeline_binpkgs were supported. Increase the count to 5. When I wrote this initially I had also looked into making it so that new stages get added automatically depending on the amount of parameters, but didn't find a way to do it with the "groovy" language used for jenkins pipelines. Therefore just increase the count to 5 and add a test in a follow-up patch to ensure we can't go beyond that number without noticing in the future. Change-Id: I9fd3c90cee659706a53e81244f3324d0e9940069 --- M jobs/gerrit-verifications.yml 1 file changed, 24 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 28ca308..45ffc38 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -759,6 +759,30 @@ }} }} + stage("binpkgs-3") {{ + when {{ + expression {{ params.PIPELINE_BINPKGS.split().size() > 3 }} + }} + steps {{ + script {{ + distro = params.PIPELINE_BINPKGS.split()[3] + run_job(distro, "gerrit-binpkgs", null, distro) + }} + }} + }} + + stage("binpkgs-4") {{ + when {{ + expression {{ params.PIPELINE_BINPKGS.split().size() > 4 }} + }} + steps {{ + script {{ + distro = params.PIPELINE_BINPKGS.split()[4] + run_job(distro, "gerrit-binpkgs", null, distro) + }} + }} + }} + }} // end of parallel }} // end of Verification stage -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43239?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9fd3c90cee659706a53e81244f3324d0e9940069 Gerrit-Change-Number: 43239 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: contrib/jenkins: add script for running pytest
by pespin 14 Aug '26

14 Aug '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/43242?usp=email ) Change subject: contrib/jenkins: add script for running pytest ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43242?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaec67a252fca8f1978d1465f3ce3e1d4c9415a9b Gerrit-Change-Number: 43242 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Aug 2026 10:51:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmocore[master]: iuup: test receival of IuUP Data with way too big payload
by osmith 14 Aug '26

14 Aug '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/43248?usp=email ) Change subject: iuup: test receival of IuUP Data with way too big payload ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File tests/iuup/iuup_test.c: https://gerrit.osmocom.org/c/libosmocore/+/43248/comment/58eb54a0_55dac7b8?… : PS1, Line 930: //osmo_iuup_instance_set_transport_prim_cb(iui, _decode_passive_init_exp_nack_transport_prim_cb, NULL); leftover? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43248?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id7059e08aa78af4c18c2be1493fb780a31e3e862 Gerrit-Change-Number: 43248 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Aug 2026 10:51:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ci[master]: tests: add test_gerrit_verifications
by pespin 14 Aug '26

14 Aug '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/43241?usp=email ) Change subject: tests: add test_gerrit_verifications ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43241?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6139e0385470e4c0c48d8a698f67645ac1605cbc Gerrit-Change-Number: 43241 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Aug 2026 10:49:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: scripts/update-osmo-ci: rename from contrib/jenkins.sh
by pespin 14 Aug '26

14 Aug '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/43240?usp=email ) Change subject: scripts/update-osmo-ci: rename from contrib/jenkins.sh ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43240?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie9793663aa9b60683fc78c738b550913e8f01fbb Gerrit-Change-Number: 43240 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Aug 2026 10:48:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log August 2026