August 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: jobs/gerrit-verifications: support up to 5 distros
by pespin 14 Aug '26

14 Aug '26

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/43239?usp=email ) Change subject: jobs/gerrit-verifications: support up to 5 distros ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43239?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9fd3c90cee659706a53e81244f3324d0e9940069 Gerrit-Change-Number: 43239 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Aug 2026 10:48:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmocore[master]: iuup: Validate msgb input length in rx Initialization path
by osmith 14 Aug '26

14 Aug '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/43247?usp=email ) Change subject: iuup: Validate msgb input length in rx Initialization path ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/43247/comment/e46cf7e7_6dd324b2?… : PS1, Line 12: Related: SYS#7063 ```suggestion Related: OS#7063 ``` -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43247?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id0f7b0f63efc37376024359a3bf7fabbc40bc387 Gerrit-Change-Number: 43247 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Aug 2026 10:47:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: iuup: Fix formatting of log line printing payload checksum error
by osmith 14 Aug '26

14 Aug '26

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/43246?usp=email ) Change subject: iuup: Fix formatting of log line printing payload checksum error ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43246?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ife1de59a8257d6c857f724460b546f511db59ebd Gerrit-Change-Number: 43246 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Aug 2026 10:41:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: deps/Makefile: eclipse gitlab -> osmocom mirror
by osmith 14 Aug '26

14 Aug '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43245?usp=email ) Change subject: deps/Makefile: eclipse gitlab -> osmocom mirror ...................................................................... deps/Makefile: eclipse gitlab -> osmocom mirror Even with recent changes to the deps logic, we occasionally still run into the rate limits of the eclipse gitlab. Change it to clone from our forgejo instance instead, where we now have mirrors of these repositories that get updated every 8 hours. Change-Id: Ica33853154438a81a42196e9bfefac98764cbf18 --- M deps/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/deps/Makefile b/deps/Makefile index 7df5746..acdadcd 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -2,7 +2,7 @@ # Copyright 2018 sysmocom - s.f.m.c. GmbH # SPDX-License-Identifier: Apache-2.0 -ECLIPSEGITLAB:=https://gitlab.eclipse.org/eclipse/titan +ECLIPSEGITLAB:=https://gitea.osmocom.org/mirrors OSMOGITHUB:=https://github.com/osmocom OSMOGERRIT:=https://gerrit.osmocom.org OSMOGITEA:=https://gitea.osmocom.org/ttcn3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43245?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ica33853154438a81a42196e9bfefac98764cbf18 Gerrit-Change-Number: 43245 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: deps/Makefile: eclipse gitlab -> osmocom mirror
by pespin 14 Aug '26

14 Aug '26

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43245?usp=email ) Change subject: deps/Makefile: eclipse gitlab -> osmocom mirror ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43245?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ica33853154438a81a42196e9bfefac98764cbf18 Gerrit-Change-Number: 43245 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Aug 2026 10:37:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmocore[master]: iuup: Validate msgb input length in rx Initialization path
by pespin 14 Aug '26

14 Aug '26

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/43247?usp=email ) Change subject: iuup: Validate msgb input length in rx Initialization path ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: FYI, see "Figure 24" in 3GPP TS 25.415 if you want to see the related structure while reviewing. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43247?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id0f7b0f63efc37376024359a3bf7fabbc40bc387 Gerrit-Change-Number: 43247 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 14 Aug 2026 10:26:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ci[master]: jenkins-gerrit/comment_generate: fix 0 jobs msg
by pespin 14 Aug '26

14 Aug '26

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/43243?usp=email ) Change subject: jenkins-gerrit/comment_generate: fix 0 jobs msg ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43243?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7289ce30492a84dedeac12bfc967d7c578f13790 Gerrit-Change-Number: 43243 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Aug 2026 10:24:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmocore[master]: iuup: test receival of IuUP Data with way too big payload
by pespin 14 Aug '26

14 Aug '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/43248?usp=email ) Change subject: iuup: test receival of IuUP Data with way too big payload ...................................................................... iuup: test receival of IuUP Data with way too big payload Take the chance to improve logging in that case, otherwise it is confusing when stating CRC check against 0xffffffff fails. Related: OS#7052 Change-Id: Id7059e08aa78af4c18c2be1493fb780a31e3e862 --- M src/gsm/iuup.c M tests/iuup/iuup_test.c M tests/iuup/iuup_test.err M tests/iuup/iuup_test.ok 4 files changed, 56 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/48/43248/1 diff --git a/src/gsm/iuup.c b/src/gsm/iuup.c index a233fb9..fb4734d 100644 --- a/src/gsm/iuup.c +++ b/src/gsm/iuup.c @@ -966,8 +966,13 @@ return 0; payload_crc_err: - LOGP(DLIUUP, LOGL_NOTICE, "Payload Checksum error (pdu type %u): rx 0x%04x vs exp 0x%04x\n", - pdu_type, payload_crc, payload_crc_computed); + if (payload_crc_computed < 0) { + LOGP(DLIUUP, LOGL_NOTICE, "Payload Checksum failed (pdu type %u): Packet too big? length %u\n", + pdu_type, len); + } else { + LOGP(DLIUUP, LOGL_NOTICE, "Payload Checksum error (pdu type %u): rx 0x%04x vs exp 0x%04x\n", + pdu_type, payload_crc, payload_crc_computed); + } return -EIO; } diff --git a/tests/iuup/iuup_test.c b/tests/iuup/iuup_test.c index 353c76a..43079b8 100644 --- a/tests/iuup/iuup_test.c +++ b/tests/iuup/iuup_test.c @@ -912,6 +912,48 @@ _test_submit_iuup_initialization_trimmed(sizeof(iuup_initialization_no_iptis) - 1, __func__); } +/* Test IUT when a way too big IuUP data packet is received. It should be dropped. */ +void test_data_too_big(void) +{ + /* Here we check the passive INIT code path, aka receiving INIT and returning INIT_ACK/NACK */ + struct osmo_iuup_instance *iui; + struct osmo_iuup_rnl_prim *rnp; + struct osmo_iuup_tnl_prim *tnp; + struct iuup_pdutype0_hdr *hdr0; + uint16_t payload_crc; + int rc; + unsigned int pkt_len = sizeof(struct iuup_pdutype0_hdr) + 1600; + OSMO_ASSERT(pkt_len <= IUUP_MSGB_SIZE); + + iui = osmo_iuup_instance_alloc(iuup_test_ctx, __func__); + OSMO_ASSERT(iui); + //osmo_iuup_instance_set_transport_prim_cb(iui, _decode_passive_init_exp_nack_transport_prim_cb, NULL); + + clock_override_set(0, 0); + + /* Tx CONFIG.req */ + rnp = osmo_iuup_rnl_prim_alloc(iuup_test_ctx, OSMO_IUUP_RNL_CONFIG, PRIM_OP_REQUEST, IUUP_MSGB_SIZE); + rnp->u.config = def_configure_req; + rnp->u.config.active = false; + + rc = osmo_iuup_rnl_prim_down(iui, rnp); + OSMO_ASSERT(rc == 0); + + /* Send IuUP incoming data to the implementation: */ + tnp = osmo_iuup_tnl_prim_alloc(iuup_test_ctx, OSMO_IUUP_TNL_UNITDATA, PRIM_OP_INDICATION, IUUP_MSGB_SIZE); + tnp->oph.msg->l2h = msgb_put(tnp->oph.msg, pkt_len); + hdr0 = (struct iuup_pdutype0_hdr *)msgb_l2(tnp->oph.msg); + memcpy(hdr0, iuup_data, sizeof(iuup_data)); + + payload_crc = osmo_iuup_compute_payload_crc(msgb_l2(tnp->oph.msg), msgb_l2len(tnp->oph.msg)); + hdr0->payload_crc_hi = (payload_crc >> 8) & 0x03; + hdr0->payload_crc_lo = payload_crc & 0xff; + + OSMO_ASSERT((rc = osmo_iuup_tnl_prim_up(iui, tnp)) == 0); + + osmo_iuup_instance_free(iui); +} + int main(int argc, char **argv) { iuup_test_ctx = talloc_named_const(NULL, 0, "iuup_test"); @@ -937,6 +979,7 @@ test_decode_passive_init_malformed_no_rfci(); test_decode_passive_init_malformed_rfci_too_short(); test_decode_passive_init_malformed_missing_last_byte(); + test_data_too_big(); printf("OK.\n"); } diff --git a/tests/iuup/iuup_test.err b/tests/iuup/iuup_test.err index 0298420..5a573b4 100644 --- a/tests/iuup/iuup_test.err +++ b/tests/iuup/iuup_test.err @@ -88,3 +88,8 @@ DLIUUP IuUP(test_decode_passive_init_malformed_missing_last_byte){Initialisation}: Initialization: Malformed packet, length 15 too short DLIUUP IuUP(test_decode_passive_init_malformed_missing_last_byte){Initialisation}: Tx Initialization NACK cause=8 orig_message=e0 00 df f7 06 01 51 67 3c 86 27 00 00 00 01 DLIUUP IuUP(test_decode_passive_init_malformed_missing_last_byte){Initialisation}: Deallocated +DLIUUP IuUP(test_data_too_big){NULL}: Allocated +DLIUUP IuUP(test_data_too_big){NULL}: Received Event IuUP-CONFIG-req +DLIUUP IuUP(test_data_too_big){NULL}: state_chg to Initialisation +DLIUUP Payload Checksum failed (pdu type 0): Packet too big? length 1604 +DLIUUP IuUP(test_data_too_big){Initialisation}: Discarding invalid IuUP PDU: 01 00 e3 ff 08 55 6d 94 4c 71 a1 a0 81 e7 ea d2 04 24 44 80 00 0e cd 82 b8 11 18 00 00 97 c4 79 4e 77 40 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0DLIUUP IuUP(test_data_too_big){Initialisation}: Deallocated diff --git a/tests/iuup/iuup_test.ok b/tests/iuup/iuup_test.ok index 204c290..08b011f 100644 --- a/tests/iuup/iuup_test.ok +++ b/tests/iuup/iuup_test.ok @@ -73,4 +73,5 @@ sys={0.000000}, clock_override_set _decode_passive_init_exp_nack_transport_prim_cb() Transport: DL len=5: e8 00 90 00 20 +sys={0.000000}, clock_override_set OK. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43248?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id7059e08aa78af4c18c2be1493fb780a31e3e862 Gerrit-Change-Number: 43248 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[NoOp] Change in osmo-ttcn3-hacks[master]: smdpp: update SGP.26 DPtls certificate
by dexter 14 Aug '26

14 Aug '26

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43203?usp=email ) Change subject: smdpp: update SGP.26 DPtls certificate ...................................................................... smdpp: update SGP.26 DPtls certificate The SGP.26 DPtls certificate (CERT_S_SM_DP_TLS_BRP/NIST) has expired This patch replaces the expired certificate with a recent versipn (CERT_S_SM_DP_VARO_TLS_BRP/NIST) Change-Id: I09c70797e2ba897a41d46c378dfd0ca12b645a79 --- D smdpp/sgp26/DPtls/CERT_S_SM_DP_TLS_BRP.der D smdpp/sgp26/DPtls/CERT_S_SM_DP_TLS_NIST.der A smdpp/sgp26/DPtls/CERT_S_SM_DP_VARO_TLS_BRP.der A smdpp/sgp26/DPtls/CERT_S_SM_DP_VARO_TLS_NIST.der 4 files changed, 0 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/smdpp/sgp26/DPtls/CERT_S_SM_DP_TLS_NIST.der b/smdpp/sgp26/DPtls/CERT_S_SM_DP_TLS_NIST.der deleted file mode 100644 index b819e77..0000000 --- a/smdpp/sgp26/DPtls/CERT_S_SM_DP_TLS_NIST.der +++ /dev/null Binary files differ diff --git a/smdpp/sgp26/DPtls/CERT_S_SM_DP_TLS_BRP.der b/smdpp/sgp26/DPtls/CERT_S_SM_DP_VARO_TLS_BRP.der similarity index 61% rename from smdpp/sgp26/DPtls/CERT_S_SM_DP_TLS_BRP.der rename to smdpp/sgp26/DPtls/CERT_S_SM_DP_VARO_TLS_BRP.der index 48f8422..2900a74 100644 --- a/smdpp/sgp26/DPtls/CERT_S_SM_DP_TLS_BRP.der +++ b/smdpp/sgp26/DPtls/CERT_S_SM_DP_VARO_TLS_BRP.der Binary files differ diff --git a/smdpp/sgp26/DPtls/CERT_S_SM_DP_VARO_TLS_NIST.der b/smdpp/sgp26/DPtls/CERT_S_SM_DP_VARO_TLS_NIST.der new file mode 100644 index 0000000..5ea86bb --- /dev/null +++ b/smdpp/sgp26/DPtls/CERT_S_SM_DP_VARO_TLS_NIST.der Binary files differ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43203?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I09c70797e2ba897a41d46c378dfd0ca12b645a79 Gerrit-Change-Number: 43203 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: iuup: Fix formatting of log line printing payload checksum error
by pespin 14 Aug '26

14 Aug '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/43246?usp=email ) Change subject: iuup: Fix formatting of log line printing payload checksum error ...................................................................... iuup: Fix formatting of log line printing payload checksum error The payload CRC is 10bits long, hence 2 bytes are used. Printing 3 digits would be enough, but keep it as 4 digits since anyway we are storing it in uint16_t. Change-Id: Ife1de59a8257d6c857f724460b546f511db59ebd --- M src/gsm/iuup.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/46/43246/1 diff --git a/src/gsm/iuup.c b/src/gsm/iuup.c index 622302a..b7aa5f9 100644 --- a/src/gsm/iuup.c +++ b/src/gsm/iuup.c @@ -923,7 +923,7 @@ return 0; payload_crc_err: - LOGP(DLIUUP, LOGL_NOTICE, "Payload Checksum error (pdu type %u): rx 0x%02x vs exp 0x%02x\n", + LOGP(DLIUUP, LOGL_NOTICE, "Payload Checksum error (pdu type %u): rx 0x%04x vs exp 0x%04x\n", pdu_type, payload_crc, payload_crc_computed); return -EIO; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43246?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ife1de59a8257d6c857f724460b546f511db59ebd Gerrit-Change-Number: 43246 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log August 2026