August 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: stp: Use SI in valid range when transmitting data
by pespin 25 Aug '26

25 Aug '26

Attention is currently required from: fixeria, laforge, osmith, pespin. Hello Jenkins Builder, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43383?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: stp: Use SI in valid range when transmitting data ...................................................................... stp: Use SI in valid range when transmitting data ITU Q.704 14.2.1 defines Service Indicator as being 4 bits, hence valid range of the field is 0..0x0F. M3UA encodes it inside a full octet "justified to the least significant bit. Unused bits are coded `0'." Make sure we send a value inside range, since newer libosmo-sigtran will validate the received m3ua field. Use SI=0010 "spare" since we are not really sending any meaningful data. Change-Id: I1d0553b0ed57b9283dd988e0f686dea8a4f17ebb --- M stp/STP_Tests_M3UA.ttcn 1 file changed, 10 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/83/43383/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43383?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1d0553b0ed57b9283dd988e0f686dea8a4f17ebb Gerrit-Change-Number: 43383 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in pysim[master]: Decode GSM 7-bit packed EF.PNN data
by fixeria 25 Aug '26

25 Aug '26

Attention is currently required from: biocape, laforge. fixeria has posted comments on this change by biocape. ( https://gerrit.osmocom.org/c/pysim/+/41913?usp=email ) Change subject: Decode GSM 7-bit packed EF.PNN data ...................................................................... Patch Set 3: Code-Review+2 (1 comment) File pySim/utils.py: https://gerrit.osmocom.org/c/pysim/+/41913/comment/22f6be3a_8d75c061?usp=em… : PS1, Line 81: de > I would think those are useful/relevant beyond pySim and should go into pyosmocom instead? Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41913?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4558fd011592aeeae2389fe8a1f62f3d7e21d219 Gerrit-Change-Number: 41913 Gerrit-PatchSet: 3 Gerrit-Owner: biocape <biofel(a)cape.co> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: biocape <biofel(a)cape.co> Gerrit-Comment-Date: Tue, 25 Aug 2026 10:06:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: stp: Use SI in valid range when transmitting data
by osmith 25 Aug '26

25 Aug '26

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43383?usp=email ) Change subject: stp: Use SI in valid range when transmitting data ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43383?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1d0553b0ed57b9283dd988e0f686dea8a4f17ebb Gerrit-Change-Number: 43383 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Aug 2026 10:05:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: stp: Use SI in valid range when transmitting data
by pespin 25 Aug '26

25 Aug '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43383?usp=email ) Change subject: stp: Use SI in valid range when transmitting data ...................................................................... stp: Use SI in valid range when transmitting data ITU Q.704 14.2.1 defines Service Indicator as being 4 bits, hence valid range of the field is 0..0x0F. M3UA encodes it inside a full octet "justified to the least significant bit. Unused bits are coded `0'." Make sure we send a value inside range, since newer libosmo-sigtran will validate the received m3ua field. Use SI=0010 "spare" since we are not really sending any meaningful data. Change-Id: I1d0553b0ed57b9283dd988e0f686dea8a4f17ebb --- M stp/STP_Tests_M3UA.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/83/43383/1 diff --git a/stp/STP_Tests_M3UA.ttcn b/stp/STP_Tests_M3UA.ttcn index f1ce309..f740f15 100644 --- a/stp/STP_Tests_M3UA.ttcn +++ b/stp/STP_Tests_M3UA.ttcn @@ -776,7 +776,7 @@ /* Test if traffic is routed from idx_tx/pc_tx to idx_rx/pc_rx */ friend function f_test_traffic(integer idx_tx, template (omit) OCT4 rctx_sender, OCT4 pc_tx, integer idx_rx, template (omit) OCT4 rctx_receiver, OCT4 pc_rx, - OCT1 si := '23'O, OCT1 ni := mp_ni, OCT1 mp := '00'O, OCT1 sls := '00'O) + OCT1 si := '02'O, OCT1 ni := mp_ni, OCT1 mp := '00'O, OCT1 sls := '00'O) runs on RAW_M3UA_CT { var octetstring data := f_rnd_octstring_rnd_len(100); f_M3UA_send(idx_tx, ts_M3UA_DATA(rctx_sender, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43383?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1d0553b0ed57b9283dd988e0f686dea8a4f17ebb Gerrit-Change-Number: 43383 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in ...pyosmocom[master]: Add GSM 7-bit packing and Network Name IE support
by fixeria 25 Aug '26

25 Aug '26

Attention is currently required from: biocape, dexter. fixeria has posted comments on this change by biocape. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/43371?usp=email ) Change subject: Add GSM 7-bit packing and Network Name IE support ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmocom/utils.py: https://gerrit.osmocom.org/c/python/pyosmocom/+/43371/comment/cbd43c9e_754f… : PS1, Line 121: int.from_bytes(packed, byteorder='little') I like the approach, but there is a problem here: `int.from_bytes()` with `byteorder='little'` will drop any trailing 0x00 bytes in the stream. It's probably safe for the Network Name IE, but this function may also be used for general GSM 7-bit unpacking where data can end in zeros (like SMS text). You can append a dummy byte before converting to prevent bit-shifting into empty padding: ```suggestion packed_int = int.from_bytes(packed + b'\x01', byteorder='little') ``` -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/43371?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I4661352e39031dc0041fc7851f675d6083a1035f Gerrit-Change-Number: 43371 Gerrit-PatchSet: 1 Gerrit-Owner: biocape <biofel(a)cape.co> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: biocape <biofel(a)cape.co> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Aug 2026 10:02:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: library/pfcp: Support passing CP/UP Function Features to Assoc Setup ...
by pespin 25 Aug '26

25 Aug '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43379?usp=email ) Change subject: library/pfcp: Support passing CP/UP Function Features to Assoc Setup helpers ...................................................................... library/pfcp: Support passing CP/UP Function Features to Assoc Setup helpers For instance open5gs-smfd expects the UPF to support FTUP (F-TEID allocation at the UPF), and otherwise logs a warning. Change-Id: I8d74d56e3a602890f2559abbc671bfa3ee3c6e0d --- M library/PFCP_Emulation.ttcn M library/PFCP_Templates.ttcn 2 files changed, 129 insertions(+), 10 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/library/PFCP_Emulation.ttcn b/library/PFCP_Emulation.ttcn index 86c5879..ad00561 100644 --- a/library/PFCP_Emulation.ttcn +++ b/library/PFCP_Emulation.ttcn @@ -420,7 +420,9 @@ function f_pfcp_wait_assoc_setup_req(template (value) Node_ID local_node_id, boolean fail_timeout := true, boolean fail_rx_others := true, - float wait_timeout := 16.0) runs on PFCP_ConnHdlr { + float wait_timeout := 16.0, + template (omit) UP_Function_Features up_function_features := omit, + template (omit) CP_Function_Features cp_function_features := omit) runs on PFCP_ConnHdlr { var PDU_PFCP m; timer T := wait_timeout; var integer rts := f_PFCPEM_get_recovery_timestamp(); @@ -433,7 +435,9 @@ PFCP.send(ts_PFCP_Assoc_Setup_Resp(m.sequence_number, local_node_id, ts_PFCP_Cause(REQUEST_ACCEPTED), - rts)); + rts, + up_function_features := up_function_features, + cp_function_features := cp_function_features)); setverdict(pass); } [fail_rx_others] PFCP.receive(PDU_PFCP:?) -> value m { @@ -457,7 +461,9 @@ function f_pfcp_force_assoc_setup_req(template (value) Node_ID local_node_id, boolean fail_timeout := true, boolean fail_rx_others := true, - float wait_timeout := 16.0) + float wait_timeout := 16.0, + template (omit) UP_Function_Features up_function_features := omit, + template (omit) CP_Function_Features cp_function_features := omit) runs on PFCP_ConnHdlr { var boolean rx_hb_resp := false; var boolean rx_assoc_setup_req := false; @@ -482,7 +488,9 @@ PFCP.send(ts_PFCP_Assoc_Setup_Resp(m.sequence_number, local_node_id, ts_PFCP_Cause(REQUEST_ACCEPTED), - rts)); + rts, + up_function_features := up_function_features, + cp_function_features := cp_function_features)); if (not rx_hb_resp) { repeat; } diff --git a/library/PFCP_Templates.ttcn b/library/PFCP_Templates.ttcn index 142ed74..eba36da 100644 --- a/library/PFCP_Templates.ttcn +++ b/library/PFCP_Templates.ttcn @@ -1,4 +1,4 @@ -/* PFCP Templates in TTCN-3 +/* PFCP Templates in TTCN-3, (3GPP TS 29.244) * (C) 2022 sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> * All rights reserved. * @@ -72,7 +72,8 @@ node_id_value := id_value }; -/* t_PFCP_Node_ID_IPv4(f_inet_addr("127.0.0.1")) */ +/* 8.2.38 Node ID + * t_PFCP_Node_ID_IPv4(f_inet_addr("127.0.0.1")) */ template (value) Node_ID ts_PFCP_Node_ID_ipv4(template (value) OCT4 ip_value) := ts_PFCP_Node_ID(PFCP_Node_ID_IPv4, ip_value); template (present) Node_ID @@ -83,6 +84,113 @@ template (present) Node_ID tr_PFCP_Node_ID_fqdn(template (present) octetstring fqdn) := tr_PFCP_Node_ID(PFCP_Node_ID_FQDN, fqdn); +/* 8.2.25 UP Function Features */ +template (value) UP_Function_Features +ts_PFCP_UP_Function_Features(template (value) BIT1 ftup := '0'B) := { + elementIdentifier := 43, + lengthIndicator := 0, + /* octet 5: */ + bucp := '0'B, + ddnd := '0'B, + dlbd := '0'B, + trst := '0'B, + ftup := ftup, + pfdm := '0'B, + heeu := '0'B, + treu := '0'B, + /* octet 6: */ + empu := '0'B, + pdiu := '0'B, + udbc := '0'B, + quoac := '0'B, + trace := '0'B, + frrt := '0'B, + pfde := '0'B, + epfar := '0'B, + /* octet 7: */ + dpdra := '0'B, + adpdp := '0'B, + ueip := '0'B, + sset := '0'B, + mnop := '0'B, + mte := '0'B, + bundl := '0'B, + gcom := '0'B, + /* octet 8: */ + mpas := '0'B, + rttl := '0'B, + vtime := '0'B, + norp := '0'B, + iptv := '0'B, + ip6pl := '0'B, + tsn := '0'B, + mptcp := '0'B, + /* octet 9: */ + atsss_ll := '0'B, + qfqm := '0'B, + gpqm := '0'B, + mt_edt := '0'B, + ciot := '0'B, + ethar := '0'B, + ddds := '0'B, + rds := '0'B, + /* octet 10: */ + rttwp := '0'B, + quasf := '0'B, + nspoc := '0'B, + l2tp := '0'B, + upber := '0'B, + resps := '0'B, + iprep := '0'B, + dnsts := '0'B, + /* octet 11: */ + drqos := '0'B, + mbsn4 := '0'B, + psuprm := '0'B, + epppi := '0'B, + ratp := '0'B, + upidp := '0'B, + afsfc := '0'B, + mquic_udp := '0'B, + /* octet 12: */ + redsm := '0'B, + dbdm := '0'B, + tscts := '0'B, + drtsc := '0'B, + n6jedb := '0'B, + qmcon := '0'B, + detnet := '0'B, + eml4s := '0'B, + /* octet 13: */ + pdusm := '0'B, + cn_tl := '0'B, + qmdrm := '0'B, + edbnc := '0'B, + mt_sdt := '0'B, + upsbies := '0'B, + umn6ip := '0'B, + un6tu := '0'B, + /* octet 14: */ + mbsch := '0'B, + un6dm := '0'B, + natpub := '0'B, + ushph := '0'B, + mpquic_ip := '0'B, + mpquic_e := '0'B, + dyntr := '0'B, + muxmf := '0'B, + /* octet 15: */ + conudp := '0'B, + moq := '0'B, + ulm := '0'B, + psitlm := '0'B, + udpopt := '0'B, + qmabr := '0'B, + papfd := '0'B, + spare:= '0'B +} + +/* 8.2.65 Recovery Time Stamp */ template (value) Recovery_Time_Stamp ts_PFCP_Recovery_Timestamp(template (value) LIN4_BO_LAST time_value) := { elementIdentifier := 96, @@ -198,7 +306,10 @@ ts_PFCP_Assoc_Setup_Resp(LIN3_BO_LAST sequence_number, template (value) Node_ID node_id, template (value) Cause cause, - LIN4_BO_LAST recovery_timestamp) + LIN4_BO_LAST recovery_timestamp, + template (omit) UP_Function_Features up_function_features := omit, + template (omit) CP_Function_Features cp_function_features := omit, + template (omit) UP_IP_Resource_Information_list UP_IP_resource_list := omit) modifies ts_PDU_PFCP_ := { sequence_number := sequence_number, message_body := { @@ -206,9 +317,9 @@ node_id := node_id, cause := cause, time_stamp := ts_PFCP_Recovery_Timestamp(recovery_timestamp), - up_function_features := omit, - cp_function_features := omit, - UP_IP_resource_list := omit + up_function_features := up_function_features, + cp_function_features := cp_function_features, + UP_IP_resource_list := UP_IP_resource_list } } }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43379?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d74d56e3a602890f2559abbc671bfa3ee3c6e0d Gerrit-Change-Number: 43379 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: Introduce library/NTP_Functions.ttcn
by pespin 25 Aug '26

25 Aug '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43377?usp=email ) Change subject: Introduce library/NTP_Functions.ttcn ...................................................................... Introduce library/NTP_Functions.ttcn This is useful to encdec timestamps in NTP format, which are used by other protocols, eg. PFCP. Change-Id: I1551c3424679da8cb71aadb6f34a545c698eb329 --- A library/NTP_Functions.ttcn 1 file changed, 36 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/library/NTP_Functions.ttcn b/library/NTP_Functions.ttcn new file mode 100644 index 0000000..4072153 --- /dev/null +++ b/library/NTP_Functions.ttcn @@ -0,0 +1,36 @@ +/* NTP Functions in TTCN-3, (RFC 5905) + * (C) 2026 sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> + * All rights reserved. + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +module NTP_Functions { + +import from TCCDateTime_Functions all; + +const integer TIME_NTP32_1970_1900_SEC_DIFF := 2208988800; /* 1970 - 1900 in seconds */ + +function f_time_to_ntp32(integer time) return integer +{ + return (time + TIME_NTP32_1970_1900_SEC_DIFF) mod 4294967296; +} + +function f_time_from_ntp32(integer ntp_timestamp) return integer +{ + if (ntp_timestamp < TIME_NTP32_1970_1900_SEC_DIFF) { + return 0; + } + return ntp_timestamp - TIME_NTP32_1970_1900_SEC_DIFF; +} + +function f_time_ntp32_now() return integer +{ + var integer now := f_time(); + return f_time_to_ntp32(now); +} + +} -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43377?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1551c3424679da8cb71aadb6f34a545c698eb329 Gerrit-Change-Number: 43377 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: PFCP_Emulation: Use recovery timestamp to send proper time
by pespin 25 Aug '26

25 Aug '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43381?usp=email ) Change subject: PFCP_Emulation: Use recovery timestamp to send proper time ...................................................................... PFCP_Emulation: Use recovery timestamp to send proper time As per FPCP spec: "This IE shall contain the time stamp when the PFCP entity was started". Change-Id: Iecbf76c9e7cb17d47edbe879ceeefc54d028f50b --- M hnbgw/gen_links.sh M hnbgw/regen_makefile.sh M library/PFCP_Emulation.ttcn M s1gw/gen_links.sh M s1gw/regen_makefile.sh M upf/gen_links.sh M upf/regen_makefile.sh 7 files changed, 12 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve diff --git a/hnbgw/gen_links.sh b/hnbgw/gen_links.sh index c8ed46d..cbbc6f9 100755 --- a/hnbgw/gen_links.sh +++ b/hnbgw/gen_links.sh @@ -11,6 +11,7 @@ DIR=$BASEDIR/titan.Libraries.TCCUsefulFunctions/src FILES="TCCInterface_Functions.ttcn TCCConversion_Functions.ttcn TCCConversion.cc TCCInterface.cc TCCInterface_ip.h" FILES+=" TCCEncoding_Functions.ttcn TCCEncoding.cc " # GSM 7-bit coding +FILES+="TCCDateTime.cc TCCDateTime_Functions.ttcn " # NTP_Functions (NTP timestamp) gen_links $DIR $FILES DIR=$BASEDIR/titan.TestPorts.Common_Components.Socket-API/src @@ -100,7 +101,7 @@ FILES="Iuh_Types.ttcn Iuh_CodecPort.ttcn Iuh_CodecPort_CtrlFunctDef.cc Iuh_CodecPort_CtrlFunct.ttcn Iuh_Emulation.ttcn DNS_Helpers.ttcn " FILES+="SDP_Templates.ttcn MGCP_Emulation.ttcn MGCP_Types.ttcn MGCP_Templates.ttcn MGCP_CodecPort.ttcn MGCP_CodecPort_CtrlFunct.ttcn MGCP_CodecPort_CtrlFunctDef.cc " FILES+="SCCP_Adapter.ttcnpp RAN_Adapter.ttcnpp RAN_Emulation.ttcnpp BSSAP_CodecPort.ttcn SCCP_Templates.ttcn " -FILES+="PFCP_CodecPort.ttcn PFCP_CodecPort_CtrlFunct.ttcn PFCP_CodecPort_CtrlFunctDef.cc PFCP_Emulation.ttcn PFCP_Templates.ttcn " +FILES+="NTP_Functions.ttcn PFCP_Templates.ttcn PFCP_CodecPort.ttcn PFCP_CodecPort_CtrlFunct.ttcn PFCP_CodecPort_CtrlFunctDef.cc PFCP_Emulation.ttcn " FILES+="Misc_Helpers.ttcn General_Types.ttcn Osmocom_Types.ttcn GSM_Types.ttcn Osmocom_VTY_Functions.ttcn Native_Functions.ttcn Native_FunctionDefs.cc IPA_Types.ttcn IPA_CodecPort.ttcn IPA_CodecPort_CtrlFunct.ttcn IPA_CodecPort_CtrlFunctDef.cc IPA_Emulation.ttcnpp Osmocom_CTRL_Types.ttcn Osmocom_CTRL_Functions.ttcn Osmocom_CTRL_Adapter.ttcn RTP_CodecPort.ttcn RTP_CodecPort_CtrlFunct.ttcn RTP_CodecPort_CtrlFunctDef.cc RTP_Emulation.ttcn IuUP_Types.ttcn IuUP_EncDec.cc IuUP_Emulation.ttcn " FILES+="StatsD_Types.ttcn StatsD_CodecPort.ttcn StatsD_CodecPort_CtrlFunct.ttcn StatsD_CodecPort_CtrlFunctdef.cc StatsD_Checker.ttcnpp " FILES+="L3_Templates.ttcn L3_Common.ttcn " diff --git a/hnbgw/regen_makefile.sh b/hnbgw/regen_makefile.sh index d75ec1c..45a3f1f 100755 --- a/hnbgw/regen_makefile.sh +++ b/hnbgw/regen_makefile.sh @@ -19,6 +19,7 @@ SDP_EncDec.cc StatsD_CodecPort_CtrlFunctdef.cc TCCConversion.cc + TCCDateTime.cc TCCEncoding.cc TCCInterface.cc TELNETasp_PT.cc diff --git a/library/PFCP_Emulation.ttcn b/library/PFCP_Emulation.ttcn index 2471faf..86c5879 100644 --- a/library/PFCP_Emulation.ttcn +++ b/library/PFCP_Emulation.ttcn @@ -21,6 +21,8 @@ import from PFCP_CodecPort all; import from PFCP_CodecPort_CtrlFunct all; +import from NTP_Functions all; + /*********************************************************************** * Main Emulation Component ***********************************************************************/ @@ -220,7 +222,7 @@ res := PFCP_CodecPort_CtrlFunct.f_IPL4_listen(PFCP, cfg.pfcp_bind_ip, cfg.pfcp_bind_port, {udp:={}}); g_pfcp_conn_id := res.connId; - g_recovery_timestamp := f_rnd_int(4294967296); + g_recovery_timestamp := f_time_ntp32_now(); g_pfcp_cfg := cfg; g_conns_bcast := { }; diff --git a/s1gw/gen_links.sh b/s1gw/gen_links.sh index 58a3e57..ac58c3b 100755 --- a/s1gw/gen_links.sh +++ b/s1gw/gen_links.sh @@ -7,6 +7,7 @@ DIR=$BASEDIR/titan.Libraries.TCCUsefulFunctions/src FILES="TCCInterface_Functions.ttcn TCCConversion_Functions.ttcn TCCConversion.cc TCCInterface.cc TCCInterface_ip.h" FILES+=" TCCEncoding_Functions.ttcn TCCEncoding.cc " +FILES+="TCCDateTime.cc TCCDateTime_Functions.ttcn " # NTP_Functions (NTP timestamp) gen_links $DIR $FILES DIR=$BASEDIR/titan.TestPorts.Common_Components.Socket-API/src @@ -45,7 +46,7 @@ DIR=../library FILES="Misc_Helpers.ttcn Mutex.ttcn General_Types.ttcn Osmocom_Types.ttcn Native_Functions.ttcn Native_FunctionDefs.cc " -FILES+="PFCP_CodecPort.ttcn PFCP_CodecPort_CtrlFunct.ttcn PFCP_CodecPort_CtrlFunctDef.cc PFCP_Emulation.ttcn PFCP_Templates.ttcn " +FILES+="NTP_Functions.ttcn PFCP_Templates.ttcn PFCP_CodecPort.ttcn PFCP_CodecPort_CtrlFunct.ttcn PFCP_CodecPort_CtrlFunctDef.cc PFCP_Emulation.ttcn " FILES+="S1AP_CodecPort.ttcn S1AP_CodecPort_CtrlFunctDef.cc S1AP_CodecPort_CtrlFunct.ttcn S1AP_Functions.ttcn " FILES+="SCTP_Templates.ttcn " FILES+="StatsD_Types.ttcn StatsD_CodecPort.ttcn StatsD_CodecPort_CtrlFunct.ttcn StatsD_CodecPort_CtrlFunctdef.cc StatsD_Checker.ttcnpp " diff --git a/s1gw/regen_makefile.sh b/s1gw/regen_makefile.sh index aa575e7..8b46384 100755 --- a/s1gw/regen_makefile.sh +++ b/s1gw/regen_makefile.sh @@ -18,6 +18,7 @@ S1AP_EncDec.cc StatsD_CodecPort_CtrlFunctdef.cc TCCConversion.cc + TCCDateTime.cc TCCEncoding.cc TCCInterface.cc " diff --git a/upf/gen_links.sh b/upf/gen_links.sh index 2a65368..230c82b 100755 --- a/upf/gen_links.sh +++ b/upf/gen_links.sh @@ -7,6 +7,7 @@ DIR=$BASEDIR/titan.Libraries.TCCUsefulFunctions/src FILES="TCCInterface_Functions.ttcn TCCConversion_Functions.ttcn TCCConversion.cc TCCInterface.cc TCCInterface_ip.h" FILES+=" TCCEncoding_Functions.ttcn TCCEncoding.cc " # GSM 7-bit coding +FILES+="TCCDateTime.cc TCCDateTime_Functions.ttcn " # NTP_Functions (NTP timestamp) gen_links $DIR $FILES DIR=$BASEDIR/titan.TestPorts.Common_Components.Socket-API/src @@ -30,7 +31,7 @@ DIR=../library FILES="Misc_Helpers.ttcn General_Types.ttcn Osmocom_Types.ttcn Osmocom_VTY_Functions.ttcn Native_Functions.ttcn Native_FunctionDefs.cc IPA_Types.ttcn IPA_CodecPort.ttcn IPA_CodecPort_CtrlFunct.ttcn IPA_CodecPort_CtrlFunctDef.cc IPA_Emulation.ttcnpp Osmocom_CTRL_Types.ttcn Osmocom_CTRL_Functions.ttcn Osmocom_CTRL_Adapter.ttcn " FILES+="StatsD_Types.ttcn StatsD_CodecPort.ttcn StatsD_CodecPort_CtrlFunct.ttcn StatsD_CodecPort_CtrlFunctdef.cc StatsD_Checker.ttcnpp " -FILES+="PFCP_CodecPort.ttcn PFCP_CodecPort_CtrlFunct.ttcn PFCP_CodecPort_CtrlFunctDef.cc PFCP_Emulation.ttcn PFCP_Templates.ttcn" +FILES+="NTP_Functions.ttcn PFCP_Templates.ttcn PFCP_CodecPort.ttcn PFCP_CodecPort_CtrlFunct.ttcn PFCP_CodecPort_CtrlFunctDef.cc PFCP_Emulation.ttcn " gen_links $DIR $FILES gen_links_finish diff --git a/upf/regen_makefile.sh b/upf/regen_makefile.sh index d835449..99ff387 100755 --- a/upf/regen_makefile.sh +++ b/upf/regen_makefile.sh @@ -12,6 +12,7 @@ Native_FunctionDefs.cc StatsD_CodecPort_CtrlFunctdef.cc TCCConversion.cc + TCCDateTime.cc TCCEncoding.cc TCCInterface.cc TELNETasp_PT.cc -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43381?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iecbf76c9e7cb17d47edbe879ceeefc54d028f50b Gerrit-Change-Number: 43381 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: deps: Switch to osmocom fork of titan.ProtocolModules.PFCP_v15.1.0
by pespin 25 Aug '26

25 Aug '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43382?usp=email ) Change subject: deps: Switch to osmocom fork of titan.ProtocolModules.PFCP_v15.1.0 ...................................................................... deps: Switch to osmocom fork of titan.ProtocolModules.PFCP_v15.1.0 Our fork contains lots of improvements (currently submitted in several PRs upstream) which are required to talk against newer releases of PFCP, ie. what open5gs-smfd is using. The commit hash in deps/Makefile points to our osmocom/master branch. PFCP_Templates.ttcn is updated to initialized the new optional fields appearing in deps/ PFCP_Types.ttcn. Change-Id: I954c9972124edd349354a4cc76805a4f9a2346c4 --- M deps/Makefile M library/PFCP_Templates.ttcn 2 files changed, 52 insertions(+), 24 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/deps/Makefile b/deps/Makefile index 7d3198e..abab58a 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -38,7 +38,6 @@ titan.ProtocolModules.NS_v7.3.0 \ titan.ProtocolModules.SGsAP_13.2.0 \ titan.ProtocolModules.SNDCP_v7.0.0 \ - titan.ProtocolModules.PFCP_v15.1.0 \ titan.TestPorts.Common_Components.Socket-API \ titan.TestPorts.Common_Components.Abstract_Socket \ titan.TestPorts.HTTPmsg \ @@ -61,6 +60,7 @@ OSMOGITEA_REPOS= nas \ titan.ProtocolModules.BSSMAP \ titan.ProtocolModules.MAP \ + titan.ProtocolModules.PFCP_v15.1.0 \ titan.TestPorts.AF_PACKET \ titan.TestPorts.USB @@ -107,7 +107,7 @@ titan.ProtocolModules.SUA_commit= R.5.A-5-gcf1137a titan.ProtocolModules.TCP_commit= R.3.A-5-g39e5f45 titan.ProtocolModules.UDP_commit= R.4.A-5-geea8aa3 -titan.ProtocolModules.PFCP_v15.1.0_commit= d550ad9ddb6f9c823c9a555254cd76cf0e738d18 +titan.ProtocolModules.PFCP_v15.1.0_commit= f2fbaf3662519b045077c26e256f32deae4fbf33 titan.TestPorts.AF_PACKET_commit= 0.1-5-g89ebea6 titan.TestPorts.Common_Components.Socket-API_commit= R.6.A-6-gf4380d0 titan.TestPorts.Common_Components.Abstract_Socket_commit= R.9.B-4-gbd41994 diff --git a/library/PFCP_Templates.ttcn b/library/PFCP_Templates.ttcn index 0726fd2..142ed74 100644 --- a/library/PFCP_Templates.ttcn +++ b/library/PFCP_Templates.ttcn @@ -392,7 +392,8 @@ sdf_filter_list := omit, application_id := omit, ethernet_packet_filter_list := omit, - qfi_list := omit + qfi_list := omit, + source_interface_type := omit } } template (present) PDI_IE @@ -411,7 +412,8 @@ sdf_filter_list := *, application_id := *, ethernet_packet_filter_list := *, - qfi_list := * + qfi_list := *, + source_interface_type := * } } @@ -419,27 +421,47 @@ ts_PFCP_Apply_Action(BIT1 forw := '0'B, BIT1 drop := '0'B, BIT1 buff := '0'B) := { - elementIdentifier := 44, - lengthIndicator := 0, - drop := drop, - forw := forw, - buff := buff, - nocp := '0'B, - dupl := '0'B, - spare := '000'B + elementIdentifier := 44, + lengthIndicator := 0, + /* octet 5: */ + drop := drop, + forw := forw, + buff := buff, + nocp := '0'B, + dupl := '0'B, + ipma := '0'B, + ipmd := '0'B, + dfrt := '0'B, + /* octet 6: */ + edrt := omit, + bdpn := omit, + ddpn := omit, + fssm := omit, + mbsu := omit, + spare := omit } template (present) Apply_Action tr_PFCP_Apply_Action(template (present) BIT1 forw := '0'B, template (present) BIT1 drop := '0'B, template (present) BIT1 buff := '0'B) := { - elementIdentifier := 44, - lengthIndicator := ?, - drop := drop, - forw := forw, - buff := buff, - nocp := ?, - dupl := ?, - spare := ? + elementIdentifier := 44, + lengthIndicator := ?, + /* octet 5: */ + drop := drop, + forw := forw, + buff := buff, + nocp := ?, + dupl := ?, + ipma := ?, + ipmd := ?, + dfrt := ?, + /* octet 6: */ + edrt := *, + bdpn := *, + ddpn := *, + fssm := *, + mbsu := *, + spare := * } template (value) Apply_Action ts_PFCP_Apply_Action_FORW := ts_PFCP_Apply_Action(forw := '1'B); @@ -539,7 +561,8 @@ transport_level_marking := omit, forwarding_policy := omit, header_enrichment := omit, - traffic_endpoint_ID := omit + traffic_endpoint_ID := omit, + destination_interface_type := omit } } template (present) Forwarding_Parameters @@ -556,7 +579,8 @@ transport_level_marking := *, forwarding_policy := *, header_enrichment := *, - traffic_endpoint_ID := * + traffic_endpoint_ID := *, + destination_interface_type := * } } @@ -751,7 +775,9 @@ create_traffic_endpoint_list := omit, pdn_type := omit, node_list := omit, - up_inactivity_timer := omit + up_inactivity_timer := omit, + user_id := omit, + apn_dnn := omit } } } @@ -774,7 +800,9 @@ create_traffic_endpoint_list := *, pdn_type := *, node_list := *, - up_inactivity_timer := * + up_inactivity_timer := *, + user_id := *, + apn_dnn := * } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43382?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I954c9972124edd349354a4cc76805a4f9a2346c4 Gerrit-Change-Number: 43382 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: library/pfcp: Support passing CP/UP Function Features to Assoc Setup ...
by laforge 25 Aug '26

25 Aug '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43379?usp=email ) Change subject: library/pfcp: Support passing CP/UP Function Features to Assoc Setup helpers ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43379?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d74d56e3a602890f2559abbc671bfa3ee3c6e0d Gerrit-Change-Number: 43379 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Aug 2026 09:23:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log August 2026