August 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: IPAd: Add 2nd test for function ES10b.GetConnectivityParameters
by jolly 25 Aug '26

25 Aug '26

Attention is currently required from: jolly, laforge, osmith. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43274?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: IPAd: Add 2nd test for function ES10b.GetConnectivityParameters ...................................................................... IPAd: Add 2nd test for function ES10b.GetConnectivityParameters Simply test the failure case and expect the error result. Related: SYS#8101 Change-Id: Ic6f9547cbb1fa5e3138c178e39c448933885ffc9 --- M ipad/IPAd_Tests.ttcn M library/euicc/SGP32Definitions_Templates.ttcn 2 files changed, 37 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/74/43274/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43274?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic6f9547cbb1fa5e3138c178e39c448933885ffc9 Gerrit-Change-Number: 43274 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-ttcn3-hacks[master]: IPAd: Add eimTransactionId to TC_proc_indirect_prfle_dwnld
by jolly 25 Aug '26

25 Aug '26

Attention is currently required from: jolly. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43279?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: IPAd: Add eimTransactionId to TC_proc_indirect_prfle_dwnld ...................................................................... IPAd: Add eimTransactionId to TC_proc_indirect_prfle_dwnld As we now have an optional transaction ID within profileDownloadTriggerRequest, check if the same transaction ID is received with the initiateAuthenticationRequestEsipa. Related: SYS#8101 Change-Id: I1b6370188a909dd2315215b6eff23c80d2b26c30 --- M ipad/IPAd_Tests.ttcn M library/euicc/SGP32Definitions_Templates.ttcn 2 files changed, 16 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/79/43279/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43279?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1b6370188a909dd2315215b6eff23c80d2b26c30 Gerrit-Change-Number: 43279 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu>

1 0

[S] Change in osmo-ttcn3-hacks[master]: IPAd: Add eimTransactionId to TC_proc_euicc_pkg_dwnld_exec
by jolly 25 Aug '26

25 Aug '26

Attention is currently required from: jolly, laforge, osmith. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43280?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: IPAd: Add eimTransactionId to TC_proc_euicc_pkg_dwnld_exec ...................................................................... IPAd: Add eimTransactionId to TC_proc_euicc_pkg_dwnld_exec As we now have an optional transaction ID within euiccPackageSigned, check if the same transaction ID is received with the euiccPackageResultDataSigned. Also check if the euiccPackageRequest towards the eUICC also contains the same transaction ID. Related: SYS#8101 Change-Id: I04b456edbb1cbae4f1ec0e3a2e9c2e28b787af6b --- M ipad/IPAd_Tests.ttcn M library/euicc/SGP32Definitions_Templates.ttcn 2 files changed, 24 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/80/43280/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43280?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I04b456edbb1cbae4f1ec0e3a2e9c2e28b787af6b Gerrit-Change-Number: 43280 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[M] Change in osmo-ttcn3-hacks[master]: IPAd: A test to verify proper session cancellation by eIM
by jolly 25 Aug '26

25 Aug '26

Attention is currently required from: jolly, osmith. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43373?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: IPAd: A test to verify proper session cancellation by eIM ...................................................................... IPAd: A test to verify proper session cancellation by eIM When an error occurs (GetBoundProfilePackageRequestEsipa is rejected in this case), expect the IPAd to cancel the session towards the eUICC and also towards the eIM. Related: SYS#8101 Change-Id: I6b2360b043e11c8a20eda7cda426b822c6876b45 --- M ipad/IPAd_Tests.ttcn M library/euicc/SGP32Definitions_Templates.ttcn 2 files changed, 76 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/73/43373/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43373?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6b2360b043e11c8a20eda7cda426b822c6876b45 Gerrit-Change-Number: 43373 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu>

1 0

[M] Change in osmo-ttcn3-hacks[master]: IPAd: A test to verify proper session cancellation by eUICC
by jolly 25 Aug '26

25 Aug '26

Attention is currently required from: jolly, osmith. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43372?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: IPAd: A test to verify proper session cancellation by eUICC ...................................................................... IPAd: A test to verify proper session cancellation by eUICC When an error occurs (PepareDownloadRequest is rejected in this case), expect the IPAd to cancel the session towards the eUICC and also towards the eIM. Related: SYS#8101 Change-Id: I9776cd88d332b74c1f627cc284d214e0be251b0a --- M ipad/IPAd_Tests.ttcn M library/euicc/RSPDefinitions_Templates.ttcn M library/euicc/RSPDefinitions_Types.ttcn 3 files changed, 90 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/72/43372/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43372?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9776cd88d332b74c1f627cc284d214e0be251b0a Gerrit-Change-Number: 43372 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu>

1 0

[M] Change in libosmo-sigtran[master]: m3ua: Validate Protocol Data IE of incoming messages
by laforge 25 Aug '26

25 Aug '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43385?usp=email ) Change subject: m3ua: Validate Protocol Data IE of incoming messages ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43385?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I28ac1cb0039d1be99dd200de9f93003289c48055 Gerrit-Change-Number: 43385 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Aug 2026 10:54:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: ss7_instance: Only call osmo_ss7_pc_width() when needed
by laforge 25 Aug '26

25 Aug '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43384?usp=email ) Change subject: ss7_instance: Only call osmo_ss7_pc_width() when needed ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43384?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ie0728cef36c1cbeb755baef105f3ab88d025db01 Gerrit-Change-Number: 43384 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Aug 2026 10:53:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: stp: Use SI in valid range when transmitting data
by osmith 25 Aug '26

25 Aug '26

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43383?usp=email ) Change subject: stp: Use SI in valid range when transmitting data ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43383?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1d0553b0ed57b9283dd988e0f686dea8a4f17ebb Gerrit-Change-Number: 43383 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Aug 2026 10:24:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: ss7_instance: Only call osmo_ss7_pc_width() when needed
by pespin 25 Aug '26

25 Aug '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43384?usp=email ) Change subject: ss7_instance: Only call osmo_ss7_pc_width() when needed ...................................................................... ss7_instance: Only call osmo_ss7_pc_width() when needed Change-Id: Ie0728cef36c1cbeb755baef105f3ab88d025db01 --- M src/ss7_instance.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/84/43384/1 diff --git a/src/ss7_instance.c b/src/ss7_instance.c index 05f6be8..b349974 100644 --- a/src/ss7_instance.c +++ b/src/ss7_instance.c @@ -671,15 +671,15 @@ int osmo_ss7_pointcode_parse_mask_or_len(const struct osmo_ss7_instance *inst, const char *in) { - unsigned int width = osmo_ss7_pc_width(inst ? &inst->cfg.pc_fmt : &default_pc_fmt); - if (in[0] == '/') { /* parse mask by length */ + unsigned int width; int masklen = atoi(in+1); if (masklen < 0 || masklen > 32) return -EINVAL; if (masklen == 0) return 0; + width = osmo_ss7_pc_width(inst ? &inst->cfg.pc_fmt : &default_pc_fmt); return (0xFFFFFFFF << (width - masklen)) & ((1 << width)-1); } /* parse mask as point code */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43384?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ie0728cef36c1cbeb755baef105f3ab88d025db01 Gerrit-Change-Number: 43384 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: m3ua: Validate Protocol Data IE of incoming messages
by pespin 25 Aug '26

25 Aug '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43385?usp=email ) Change subject: m3ua: Validate Protocol Data IE of incoming messages ...................................................................... m3ua: Validate Protocol Data IE of incoming messages This fixes a potential assert hit by peer sending SLS > 0x0f over M3UA to us. Related: OS#7073 Reported-By: Tristan Madani <tristan(a)talencesecurity.com> Change-Id: I28ac1cb0039d1be99dd200de9f93003289c48055 --- M src/m3ua.c 1 file changed, 73 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/85/43385/1 diff --git a/src/m3ua.c b/src/m3ua.c index f2455eb..b29cfcf 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -24,6 +24,7 @@ #include <errno.h> #include <unistd.h> #include <string.h> +#include <inttypes.h> #include <osmocom/core/utils.h> #include <osmocom/core/linuxlist.h> @@ -606,6 +607,74 @@ return data_hdr; } +static int m3ua_rx_xfer_validate_data_ie(struct osmo_ss7_asp *asp, const struct xua_msg_part *data_ie) +{ + struct m3ua_data_hdr *dh; + uint32_t pc; + + /* As already checked by xua_dialect_check_all_mand_ies(): */ + OSMO_ASSERT(data_ie); + + if (data_ie->len < sizeof(struct m3ua_data_hdr)) { + LOGPASP(asp, DLM3UA, LOGL_NOTICE, + "Discarding received M3UA XFER:DATA: Wrong Protocol Data parameter IE len=%" PRIu16 "\n", + data_ie->len); + return M3UA_ERR_INVAL_PARAM_VAL; + } + + dh = (struct m3ua_data_hdr *) data_ie->dat; + OSMO_ASSERT(dh); + + pc = ntohl(dh->opc); + if (!osmo_ss7_pc_is_valid(pc)) { + LOGPASP(asp, DLM3UA, LOGL_NOTICE, + "Discarding received M3UA XFER:DATA: Invalid OPC=%" PRIu32 "\n", + pc); + return M3UA_ERR_INVAL_PARAM_VAL; + } + + pc = ntohl(dh->dpc); + if (!osmo_ss7_pc_is_valid(pc)) { + LOGPASP(asp, DLM3UA, LOGL_NOTICE, + "Discarding received M3UA XFER:DATA: Invalid DPC=%" PRIu32 "\n", + pc); + return M3UA_ERR_INVAL_PARAM_VAL; + } + + if (dh->si & ~0x0F) { + LOGPASP(asp, DLM3UA, LOGL_NOTICE, + "Discarding received M3UA XFER:DATA: Invalid SI=%" PRIu8 "\n", + dh->si); + return M3UA_ERR_INVAL_PARAM_VAL; + } + + /* Drop packets not matching our configured Network Indicator: */ + if (dh->ni != asp->inst->cfg.network_indicator) { + LOGPASP(asp, DLM3UA, LOGL_NOTICE, + "Discarding received M3UA XFER:DATA: NI=%u not matching ss7 instance configured NI=%u\n", + dh->ni, asp->inst->cfg.network_indicator); + rate_ctr_inc2(asp->inst->ctrg, SS7_INST_CTR_PKT_RX_NI_MISMATCH); + rate_ctr_inc2(asp->ctrg, SS7_ASP_CTR_PKT_RX_NI_MISMATCH); + return M3UA_ERR_UNEXPECTED_MSG; + } + + if (dh->mp & ~0x03) { + LOGPASP(asp, DLM3UA, LOGL_NOTICE, + "Discarding received M3UA XFER:DATA: Invalid MP=%" PRIu8 "\n", + dh->mp); + return M3UA_ERR_INVAL_PARAM_VAL; + } + + if (dh->sls & ~0x0F) { + LOGPASP(asp, DLM3UA, LOGL_NOTICE, + "Discarding received M3UA XFER:DATA: Invalid SLS=%" PRIu8 "\n", + dh->sls); + return M3UA_ERR_INVAL_PARAM_VAL; + } + + return 0; +} + /* This function takes ownership of xua msg passed to it. */ static int m3ua_rx_xfer(struct osmo_ss7_asp *asp, struct xua_msg *xua) { @@ -641,11 +710,13 @@ goto ret_free; } + rc = m3ua_rx_xfer_validate_data_ie(asp, data_ie); + if (rc) + goto ret_free; + /* store the MTP-level information in the xua_msg for use by * higher layer protocols */ - OSMO_ASSERT(data_ie); dh = (struct m3ua_data_hdr *) data_ie->dat; - OSMO_ASSERT(dh); m3ua_dh_to_xfer_param(&xua->mtp, dh); LOGPASP(asp, DLM3UA, LOGL_DEBUG, "%s(): M3UA data header: opc=%u=%s dpc=%u=%s sls=%u\n", @@ -653,17 +724,6 @@ xua->mtp.dpc, osmo_ss7_pointcode_print2(asp->inst, xua->mtp.dpc), xua->mtp.sls); - /* Drop packets not matching our configured Network Indicator: */ - if (dh->ni != asp->inst->cfg.network_indicator) { - LOGPASP(asp, DLM3UA, LOGL_NOTICE, - "Discarding received XUA Message %s: NI=%u not matching ss7 instance configured NI=%u\n", - xua_hdr_dump(xua, &xua_dialect_sua), dh->ni, asp->inst->cfg.network_indicator); - rate_ctr_inc2(asp->inst->ctrg, SS7_INST_CTR_PKT_RX_NI_MISMATCH); - rate_ctr_inc2(asp->ctrg, SS7_ASP_CTR_PKT_RX_NI_MISMATCH); - rc = M3UA_ERR_UNEXPECTED_MSG; - goto ret_free; - } - rc = xua_find_as_for_asp(&as, asp, rctx_ie); if (rc) goto ret_free; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43385?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I28ac1cb0039d1be99dd200de9f93003289c48055 Gerrit-Change-Number: 43385 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log August 2026