Attention is currently required from: daniel, fixeria, jolly, laforge, osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/42354?usp=email )
Change subject: osmo_io: Rewrite iofd_handle_send_completion() to fix multiple issues
......................................................................
Patch Set 1:
(1 comment)
File src/core/osmo_io.c:
https://gerrit.osmocom.org/c/libosmocore/+/42354/comment/09dea661_8d51b220?… :
PS1, Line 556: break;
> how do following msghdr->msg[idx] get freed after the break? would it maybe make more sense to only […]
I still need to look more closely into this, but I think indeed msgbs were being leaked here in this early return (and one in line 608) also in the previous version of the code prior to this patch. Maybe @andreas@eversberg.eu can confirm the problem.
I'll probably do a follow-up commit fixing that.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42354?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia016e4df7be5e534a8212f7271caff9779e08eb1
Gerrit-Change-Number: 42354
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 16 Mar 2026 08:49:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Attention is currently required from: fixeria, laforge.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/42406?usp=email )
Change subject: netdev: netdev_mnl_set_mtu(): drop unneeded variables
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Patchset:
PS1:
> maybe the point was to zero-initialize some part of the truct? AFter all, it doesn't look like we'r […]
The man documentation states the struct is passed, so imho looks like a good thing to set flags field to 0.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42406?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I8f9d39733a80a0ec4e8c462f4ae32b4ac52b5849
Gerrit-Change-Number: 42406
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 16 Mar 2026 08:45:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>