March 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: library/GSM_RR_Types: add send/receive variants for t_RrL3Header
by fixeria 16 Mar '26

16 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42392?usp=email ) Change subject: library/GSM_RR_Types: add send/receive variants for t_RrL3Header ...................................................................... library/GSM_RR_Types: add send/receive variants for t_RrL3Header Change-Id: I35e5897470154f0a868fead4800a46849585a201 --- M bsc/BSC_Tests.ttcn M library/GSM_RR_Types.ttcn 2 files changed, 11 insertions(+), 4 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index ef02faf..17f2326 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -10154,7 +10154,7 @@ /* Decode the L3 message and make sure it is (RR) Assignment Command */ var GsmRrL3Message l3_msg := dec_GsmRrL3Message(ie.l3_info.payload); - if (not match(l3_msg.header, t_RrL3Header(ASSIGNMENT_COMMAND))) { + if (not match(l3_msg.header, tr_RrL3Header(ASSIGNMENT_COMMAND))) { setverdict(fail, "Failed to match Assignment Command: ", l3_msg); continue; } @@ -10224,7 +10224,7 @@ /* Decode the L3 message and make sure it is (RR) Handover Command */ var GsmRrL3Message l3_msg := dec_GsmRrL3Message(ie.l3_info.payload); - if (not match(l3_msg.header, t_RrL3Header(HANDOVER_COMMAND))) { + if (not match(l3_msg.header, tr_RrL3Header(HANDOVER_COMMAND))) { setverdict(fail, "Failed to match Handover Command: ", l3_msg); return; } diff --git a/library/GSM_RR_Types.ttcn b/library/GSM_RR_Types.ttcn index 963ad0c..3dc1cd5 100644 --- a/library/GSM_RR_Types.ttcn +++ b/library/GSM_RR_Types.ttcn @@ -205,7 +205,14 @@ RrMessageType message_type } with { variant "" }; - template RrL3Header t_RrL3Header(RrMessageType msg_type) := { + template (value) RrL3Header + ts_RrL3Header(template (value) RrMessageType msg_type) := { + skip_indicator := 0, + rr_protocol_discriminator := 6, + message_type := msg_type + } + template (present) RrL3Header + tr_RrL3Header(template (present) RrMessageType msg_type := ?) := { skip_indicator := 0, rr_protocol_discriminator := 6, message_type := msg_type @@ -897,7 +904,7 @@ template (value) GsmRrL3Message ts_MEAS_REP(template (value) MeasurementResults meas_res := ts_MeasurementResults) := { - header := t_RrL3Header(MEASUREMENT_REPORT), + header := ts_RrL3Header(MEASUREMENT_REPORT), payload := { meas_rep := { meas_res := meas_res -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42392?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I35e5897470154f0a868fead4800a46849585a201 Gerrit-Change-Number: 42392 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: netdev: netdev_mnl_set_mtu(): drop unneeded variables
by fixeria 16 Mar '26

16 Mar '26

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/42406?usp=email ) Change subject: netdev: netdev_mnl_set_mtu(): drop unneeded variables ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > The man-page for `mnl_nlmsg_put_extra_header()`: […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42406?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8f9d39733a80a0ec4e8c462f4ae32b4ac52b5849 Gerrit-Change-Number: 42406 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 09:06:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: gsmtap_util: gsmtap_gsm_channel_names[]: fix PTCCH string
by fixeria 16 Mar '26

16 Mar '26

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/42409?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: gsmtap_util: gsmtap_gsm_channel_names[]: fix PTCCH string ...................................................................... gsmtap_util: gsmtap_gsm_channel_names[]: fix PTCCH string Change-Id: Ic65668ae0363b991966bcf8ba4fb913940639964 --- M src/core/gsmtap_util.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/09/42409/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42409?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic65668ae0363b991966bcf8ba4fb913940639964 Gerrit-Change-Number: 42409 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: gsm48: remove duplicate GSM48_MT_RR_HANDO_INFO
by fixeria 16 Mar '26

16 Mar '26

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/42408?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: gsm48: remove duplicate GSM48_MT_RR_HANDO_INFO ...................................................................... gsm48: remove duplicate GSM48_MT_RR_HANDO_INFO Change-Id: Ic1cbba2b2a746667b9920ed2ed19b3848185977d --- M include/osmocom/gsm/protocol/gsm_04_08.h M src/gsm/gsm48.c 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/08/42408/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42408?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic1cbba2b2a746667b9920ed2ed19b3848185977d Gerrit-Change-Number: 42408 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: gsm48: fix missing/misspelled value-strings
by fixeria 16 Mar '26

16 Mar '26

Attention is currently required from: fixeria, jolly. Hello Jenkins Builder, jolly, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/42407?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: gsm48: fix missing/misspelled value-strings ...................................................................... gsm48: fix missing/misspelled value-strings Change-Id: I8d2333290c7715fd75ce7e7c759cb564a26b7461 --- M src/gsm/gsm48.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/07/42407/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42407?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8d2333290c7715fd75ce7e7c759cb564a26b7461 Gerrit-Change-Number: 42407 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: netdev: netdev_mnl_set_mtu(): drop unneeded variables
by fixeria 16 Mar '26

16 Mar '26

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/42406?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review-1 by pespin, Verified+1 by Jenkins Builder Change subject: netdev: netdev_mnl_set_mtu(): drop unneeded variables ...................................................................... netdev: netdev_mnl_set_mtu(): drop unneeded variables Change-Id: I8f9d39733a80a0ec4e8c462f4ae32b4ac52b5849 --- M src/core/netdev.c 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/06/42406/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42406?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8f9d39733a80a0ec4e8c462f4ae32b4ac52b5849 Gerrit-Change-Number: 42406 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: netdev: netdev_mnl_set_mtu(): drop unneeded variables
by fixeria 16 Mar '26

16 Mar '26

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/42406?usp=email ) Change subject: netdev: netdev_mnl_set_mtu(): drop unneeded variables ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > The man documentation states the struct is passed, so imho looks like a good thing to set flags fiel […] The man-page for `mnl_nlmsg_put_extra_header()`: https://manpages.debian.org/experimental/libmnl-doc/mnl_nlmsg_put_extra_hea… states that "this function sets to zero the room that is required to put the extra header", so it does zero-initialize the extra header internally. I confirmed that by looking at the source code. However, I am fine with setting both fields to 0 explicitly. I'll update the patch. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42406?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8f9d39733a80a0ec4e8c462f4ae32b4ac52b5849 Gerrit-Change-Number: 42406 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 09:03:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmocom-bb[master]: mobile: gsm48_cc_tx_release_compl(): actually send the message
by fixeria 16 Mar '26

16 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42401?usp=email ) Change subject: mobile: gsm48_cc_tx_release_compl(): actually send the message ...................................................................... mobile: gsm48_cc_tx_release_compl(): actually send the message The message buffer is allocated, filled in, and then leaked when `trans_free(trans)` is called. The RELEASE COMPLETE message is never transmitted to the network. Change-Id: Ic754fe1ddd7e2908627374590f01e6fc81a73c77 --- M src/host/layer23/src/mobile/gsm48_cc.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve jolly: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/host/layer23/src/mobile/gsm48_cc.c b/src/host/layer23/src/mobile/gsm48_cc.c index 2a8823f..869f57a 100644 --- a/src/host/layer23/src/mobile/gsm48_cc.c +++ b/src/host/layer23/src/mobile/gsm48_cc.c @@ -1710,6 +1710,8 @@ if (rel->fields & MNCC_F_SSVERSION) gsm48_encode_ssversion(nmsg, &rel->ssversion); + gsm48_cc_to_mm(nmsg, trans, GSM48_MMCC_DATA_REQ); + /* release without sending MMCC_REL_REQ */ new_cc_state(trans, GSM_CSTATE_NULL); trans->callref = 0; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42401?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic754fe1ddd7e2908627374590f01e6fc81a73c77 Gerrit-Change-Number: 42401 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmocom-bb[master]: mobile: gsm48_mmxx_msg_names[]: fix some strings
by fixeria 16 Mar '26

16 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42402?usp=email ) Change subject: mobile: gsm48_mmxx_msg_names[]: fix some strings ...................................................................... mobile: gsm48_mmxx_msg_names[]: fix some strings Change-Id: Iab3e249acc18057416a5c1fc00322b597df403d4 --- M src/host/layer23/src/mobile/gsm48_mm.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/host/layer23/src/mobile/gsm48_mm.c b/src/host/layer23/src/mobile/gsm48_mm.c index fad475e..14a68b0 100644 --- a/src/host/layer23/src/mobile/gsm48_mm.c +++ b/src/host/layer23/src/mobile/gsm48_mm.c @@ -749,8 +749,8 @@ { GSM48_MMGCC_DATA_IND, "MMGCC_DATA_IND" }, { GSM48_MMGCC_UNIT_DATA_REQ, "MMGCC_UNIT_DATA_REQ" }, { GSM48_MMGCC_UNIT_DATA_IND, "MMGCC_UNIT_DATA_IND" }, - { GSM48_MMGCC_REEST_REQ, "MMBCC_REEST_REQ" }, - { GSM48_MMGCC_REEST_CNF, "MMBCC_REEST_CNF" }, + { GSM48_MMGCC_REEST_REQ, "MMGCC_REEST_REQ" }, + { GSM48_MMGCC_REEST_CNF, "MMGCC_REEST_CNF" }, { GSM48_MMGCC_ERR_IND, "MMGCC_ERR_IND" }, { GSM48_MMGCC_NOTIF_IND, "MMGCC_NOTIF_IND" }, { GSM48_MMGCC_GROUP_REQ, "MMGCC_GROUP_REQ" }, @@ -758,7 +758,7 @@ { GSM48_MMGCC_UPLINK_REQ, "MMGCC_UPLINK_REQ" }, { GSM48_MMGCC_UPLINK_CNF, "MMGCC_UPLINK_CNF" }, { GSM48_MMGCC_UPLINK_REL_REQ, "MMGCC_UPLINK_REL_REQ" }, - { GSM48_MMGCC_UPLINK_REL_IND, "MMGCC_UPLINK_REL_CNF" }, + { GSM48_MMGCC_UPLINK_REL_IND, "MMGCC_UPLINK_REL_IND" }, { GSM48_MMGCC_UPLINK_FREE_IND, "MMGCC_UPLINK_FREE_IND" }, { GSM48_MMGCC_UPLINK_BUSY_IND, "MMGCC_UPLINK_BUSY_IND" }, { GSM48_MMBCC_EST_REQ, "MMBCC_EST_REQ" }, -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42402?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iab3e249acc18057416a5c1fc00322b597df403d4 Gerrit-Change-Number: 42402 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmocom-bb[master]: mobile: gsm48_cc_tx_release_compl(): actually send the message
by fixeria 16 Mar '26

16 Mar '26

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42401?usp=email ) Change subject: mobile: gsm48_cc_tx_release_compl(): actually send the message ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/42401?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic754fe1ddd7e2908627374590f01e6fc81a73c77 Gerrit-Change-Number: 42401 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 08:53:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log March 2026