March 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: tch: fix RTP clock not ticking for unhandled payload types
by Thorkell Thorkelsson 02 Mar '26

02 Mar '26

Attention is currently required from: Thorkell Thorkelsson, falconia, fixeria, pespin. Hello Jenkins Builder, falconia, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email to look at the new patch set (#4). Change subject: tch: fix RTP clock not ticking for unhandled payload types ...................................................................... tch: fix RTP clock not ticking for unhandled payload types When the payload type from the DSP is not handled by the switch in l1if_tch_rx(), rmsg stays NULL and we return 0 without calling add_l1sap_header(), silently dropping a 20ms RTP tick. Always allocate an empty RTP frame when rmsg is NULL so the RTP clock keeps ticking. Related: OS#5974 Change-Id: I202522ea6f83d77872a2f84d9a2622b87e829a0c Signed-off-by: Thorkell Thorkelsson <thorkellmanithorkelsson(a)gmail.com> --- M src/osmo-bts-sysmo/tch.c 1 file changed, 14 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/44/42244/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I202522ea6f83d77872a2f84d9a2622b87e829a0c Gerrit-Change-Number: 42244 Gerrit-PatchSet: 4 Gerrit-Owner: Thorkell Thorkelsson <thorkellmanithorkelsson(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: Thorkell Thorkelsson <thorkellmanithorkelsson(a)gmail.com> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: tch: fix RTP clock not ticking for unhandled payload types
by Jenkins Builder 02 Mar '26

02 Mar '26

Attention is currently required from: Thorkell Thorkelsson, falconia, fixeria, pespin. Jenkins Builder has posted comments on this change by Thorkell Thorkelsson. ( https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email ) Change subject: tch: fix RTP clock not ticking for unhandled payload types ...................................................................... Patch Set 3: (1 comment) File src/osmo-bts-sysmo/tch.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bts/+/42244/comment/3a633eb7_a1349033?usp… : PS3, Line 601: /* FIXME: what about GsmL1_TchPlType_Amr_SidBad? not well documented. */ code indent should use tabs where possible -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I202522ea6f83d77872a2f84d9a2622b87e829a0c Gerrit-Change-Number: 42244 Gerrit-PatchSet: 3 Gerrit-Owner: Thorkell Thorkelsson <thorkellmanithorkelsson(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: Thorkell Thorkelsson <thorkellmanithorkelsson(a)gmail.com> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 01 Mar 2026 21:16:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-bts[master]: tch: fix RTP clock not ticking for unhandled payload types
by Thorkell Thorkelsson 02 Mar '26

02 Mar '26

Attention is currently required from: Thorkell Thorkelsson, falconia, fixeria, pespin. Hello Jenkins Builder, falconia, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review-1 by falconia, Verified+1 by Jenkins Builder Change subject: tch: fix RTP clock not ticking for unhandled payload types ...................................................................... tch: fix RTP clock not ticking for unhandled payload types When the payload type from the DSP is not handled by the switch in l1if_tch_rx(), rmsg stays NULL and we return 0 without calling add_l1sap_header(), silently dropping a 20ms RTP tick. Always allocate an empty RTP frame when rmsg is NULL so the RTP clock keeps ticking. Related: OS#5974 Change-Id: I202522ea6f83d77872a2f84d9a2622b87e829a0c Signed-off-by: Thorkell Thorkelsson <thorkellmanithorkelsson(a)gmail.com> --- M src/osmo-bts-sysmo/tch.c 1 file changed, 15 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/44/42244/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I202522ea6f83d77872a2f84d9a2622b87e829a0c Gerrit-Change-Number: 42244 Gerrit-PatchSet: 3 Gerrit-Owner: Thorkell Thorkelsson <thorkellmanithorkelsson(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: Thorkell Thorkelsson <thorkellmanithorkelsson(a)gmail.com> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: tch: fix RTP clock not ticking for unhandled payload types
by falconia 02 Mar '26

02 Mar '26

Attention is currently required from: Thorkell Thorkelsson, fixeria, pespin. falconia has posted comments on this change by Thorkell Thorkelsson. ( https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email ) Change subject: tch: fix RTP clock not ticking for unhandled payload types ...................................................................... Patch Set 2: Code-Review-1 (1 comment) File src/osmo-bts-sysmo/tch.c: https://gerrit.osmocom.org/c/osmo-bts/+/42244/comment/aec6ad15_7b86e380?usp… : PS2, Line 601: FIXME: what about GsmL1_TchPlType_Amr_SidBad? not well documented > The patch catches Amr_SidBad in the generic fallback case. […] First of all, when a BTS receives a corrupted SID update (one that fails CRC) on TCH/AFS or TCH/AHS in the middle of a DTX pause, an empty RTP tick is **not** the optimal handling. It is certainly better than getting RTP time scale out of sync, but it is not ideal. Instead the correct handling is to emit RFC 4867 representation of a SID_BAD frame: FT=8, Q=0, STI=1. But because we have the additional complication of sysmoBTS PHY being a black box (with insufficient documentation, according to the comment which you shouldn't be deleting), what we really need to do is experiment with different TCH UL conditions for AMR (including a special GSM MS that can transmit intentionally corrupted SID update blocks) and observe what sysmoBTS PHY puts out in each condition. It won't be easy - hence I currently avoid AMR and run my sysmoBTS with EFR instead... But back to your proposed patch, there are two separate issues going on: 1. In cases when, for whatever reason, we are not able to handle the Rx frame from the sysmoBTS PHY in a truly proper manner, we should emit an empty RTP tick instead of just dropping that 20 ms quantum of time. In this regard your patch is fully proper and welcome. 2. Applying truly correct handling to AMR corner cases is a separate problem that will remain unsolved for now, until someone who cares about the combination of sysmoBTS hw with AMR invests the time and effort needed for a proper investigation. However, I agree very strongly with Vadim that the FIXME comment should **not** be removed. Therefore, I have to CR-1 your patch for now. If you restore that FIXME comment in the next patch iteration, I will give CR+1 as the rest of your patch is fine. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I202522ea6f83d77872a2f84d9a2622b87e829a0c Gerrit-Change-Number: 42244 Gerrit-PatchSet: 2 Gerrit-Owner: Thorkell Thorkelsson <thorkellmanithorkelsson(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Thorkell Thorkelsson <thorkellmanithorkelsson(a)gmail.com> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 01 Mar 2026 21:08:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Thorkell Thorkelsson <thorkellmanithorkelsson(a)gmail.com> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: tch: fix RTP clock not ticking for unhandled payload types
by Thorkell Thorkelsson 02 Mar '26

02 Mar '26

Attention is currently required from: falconia, fixeria, pespin. Thorkell Thorkelsson has posted comments on this change by Thorkell Thorkelsson. ( https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email ) Change subject: tch: fix RTP clock not ticking for unhandled payload types ...................................................................... Patch Set 2: (1 comment) File src/osmo-bts-sysmo/tch.c: https://gerrit.osmocom.org/c/osmo-bts/+/42244/comment/f9cfe304_73e1abba?usp… : PS2, Line 601: FIXME: what about GsmL1_TchPlType_Amr_SidBad? not well documented > I believe this comment is still valid: `GsmL1_TchPlType_Amr_SidBad` is not handled in the switch sta […] The patch catches Amr_SidBad in the generic fallback case. As SidBad indicates a corrupted SID with no valid AMR data, generating an empty RTP tick would be the appropriate response. Adding a specific case for it would result in the same response. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I202522ea6f83d77872a2f84d9a2622b87e829a0c Gerrit-Change-Number: 42244 Gerrit-PatchSet: 2 Gerrit-Owner: Thorkell Thorkelsson <thorkellmanithorkelsson(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 01 Mar 2026 16:27:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: tch: fix RTP clock not ticking for unhandled payload types
by fixeria 02 Mar '26

02 Mar '26

Attention is currently required from: Thorkell Thorkelsson, falconia, pespin. fixeria has posted comments on this change by Thorkell Thorkelsson. ( https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email ) Change subject: tch: fix RTP clock not ticking for unhandled payload types ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/osmo-bts-sysmo/tch.c: https://gerrit.osmocom.org/c/osmo-bts/+/42244/comment/eb5c5f1e_5a3fda38?usp… : PS2, Line 601: FIXME: what about GsmL1_TchPlType_Amr_SidBad? not well documented I believe this comment is still valid: `GsmL1_TchPlType_Amr_SidBad` is not handled in the switch statement. Could you please explain why are you removing it? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I202522ea6f83d77872a2f84d9a2622b87e829a0c Gerrit-Change-Number: 42244 Gerrit-PatchSet: 2 Gerrit-Owner: Thorkell Thorkelsson <thorkellmanithorkelsson(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: Thorkell Thorkelsson <thorkellmanithorkelsson(a)gmail.com> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 01 Mar 2026 15:28:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bts[master]: tch: fix RTP clock not ticking for unhandled payload types
by Thorkell Thorkelsson 01 Mar '26

01 Mar '26

Thorkell Thorkelsson has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email ) Change subject: tch: fix RTP clock not ticking for unhandled payload types ...................................................................... tch: fix RTP clock not ticking for unhandled payload types When the payload type from the DSP is not handled by the switch in l1if_tch_rx(), rmsg stays NULL and we return 0 without calling add_l1sap_header(), silently dropping a 20ms RTP tick. Always allocate an empty RTP frame when rmsg is NULL so the RTP clock keeps ticking. Related: OS#5974 Change-Id: I202522ea6f83d77872a2f84d9a2622b87e829a0c --- M src/osmo-bts-sysmo/tch.c 1 file changed, 14 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/44/42244/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I202522ea6f83d77872a2f84d9a2622b87e829a0c Gerrit-Change-Number: 42244 Gerrit-PatchSet: 2 Gerrit-Owner: Thorkell Thorkelsson <thorkellmanithorkelsson(a)gmail.com> Gerrit-CC: Jenkins Builder

1 0

[S] Change in osmo-bts[master]: tch: fix RTP clock not ticking for unhandled payload types
by Thorkell Thorkelsson 01 Mar '26

01 Mar '26

Thorkell Thorkelsson has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email ) Change subject: tch: fix RTP clock not ticking for unhandled payload types ...................................................................... tch: fix RTP clock not ticking for unhandled payload types When the payload type from the DSP is not handled by the switch in l1if_tch_rx(), rmsg stays NULL and we return 0 without calling add_l1sap_header(), silently dropping a 20ms RTP tick. Always allocate an empty RTP frame when rmsg is NULL so the RTP clock keeps ticking. Related: OS#5974 Change-Id: I202522ea6f83d77872a2f84d9a2622b87e829a0c Signed-off-by: Thorkell Thorkelsson <thorkellmanithorkelsson(a)gmail.com> --- M src/osmo-bts-sysmo/tch.c 1 file changed, 14 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/44/42244/1 diff --git a/src/osmo-bts-sysmo/tch.c b/src/osmo-bts-sysmo/tch.c index b5bf04b..bbf05c1 100644 --- a/src/osmo-bts-sysmo/tch.c +++ b/src/osmo-bts-sysmo/tch.c @@ -598,18 +598,23 @@ case GsmL1_TchPlType_Amr_SidFirstP1: rmsg = l1_to_rtppayload_amr(payload, payload_len, lchan); break; - /* FIXME: what about GsmL1_TchPlType_Amr_SidBad? not well documented. */ } - if (rmsg) - return add_l1sap_header(trx, rmsg, lchan, chan_nr, data_ind->u32Fn, - data_ind->measParam.fBer * 10000, - data_ind->measParam.fLinkQuality * 10, - data_ind->measParam.fRssi, - data_ind->measParam.i16BurstTiming * 64, - 0); + if (!rmsg) { + LOGPLCFN(lchan, data_ind->u32Fn, DL1P, LOGL_NOTICE, + "Unhandled payload type %s, generating empty RTP tick\n", + get_value_string(femtobts_tch_pl_names, payload_type)); + rmsg = msgb_alloc_headroom(256, 128, "L1P-to-RTP"); + if (!rmsg) + return -ENOMEM; + } - return 0; + return add_l1sap_header(trx, rmsg, lchan, chan_nr, data_ind->u32Fn, + data_ind->measParam.fBer * 10000, + data_ind->measParam.fLinkQuality * 10, + data_ind->measParam.fRssi, + data_ind->measParam.i16BurstTiming * 64, + 0); err_payload_match: LOGPLCFN(lchan, data_ind->u32Fn, DL1P, LOGL_ERROR, "%s Rx Payload Type %s incompatible with lchan\n", -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I202522ea6f83d77872a2f84d9a2622b87e829a0c Gerrit-Change-Number: 42244 Gerrit-PatchSet: 1 Gerrit-Owner: Thorkell Thorkelsson <thorkellmanithorkelsson(a)gmail.com>

1 0

2026

2025

2024

2023

2022

gerrit-log March 2026