March 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-trx[master]: debian/*.install: make paths consistent
by osmith 03 Mar '26

03 Mar '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/42245?usp=email ) Change subject: debian/*.install: make paths consistent ...................................................................... debian/*.install: make paths consistent Some of the paths start with a leading slash and some don't. Both variants work, but this is confusing. Let's go without the leading slash, because the paths are releative (in this case to debian/tmp where "make install" puts the files during debian packaging). Related: https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/ae98245f_98e51337/ Related: https://www.debian.org/doc/manuals/maint-guide/dother.en.html#install Related: https://manpages.debian.org/testing/debhelper/dh_install.1.en.html#debian/ Change-Id: I4b9de40e1fc6d3935ae8ff82804d94cb863663e9 --- M debian/osmo-trx-ipc.install M debian/osmo-trx-lms.install M debian/osmo-trx-ms-blade.install M debian/osmo-trx-uhd.install M debian/osmo-trx-usrp1.install 5 files changed, 12 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/45/42245/1 diff --git a/debian/osmo-trx-ipc.install b/debian/osmo-trx-ipc.install index db64623..6b71116 100644 --- a/debian/osmo-trx-ipc.install +++ b/debian/osmo-trx-ipc.install @@ -1,4 +1,4 @@ etc/osmocom/osmo-trx-ipc.cfg lib/systemd/system/osmo-trx-ipc.service -/usr/bin/osmo-trx-ipc -/usr/share/doc/osmo-trx/examples/osmo-trx-ipc/osmo-trx-ipc.cfg /usr/share/doc/osmo-trx/examples/osmo-trx-ipc/ +usr/bin/osmo-trx-ipc +usr/share/doc/osmo-trx/examples/osmo-trx-ipc/osmo-trx-ipc.cfg /usr/share/doc/osmo-trx/examples/osmo-trx-ipc/ diff --git a/debian/osmo-trx-lms.install b/debian/osmo-trx-lms.install index b89506a..022778f 100644 --- a/debian/osmo-trx-lms.install +++ b/debian/osmo-trx-lms.install @@ -1,4 +1,4 @@ etc/osmocom/osmo-trx-lms.cfg lib/systemd/system/osmo-trx-lms.service -/usr/bin/osmo-trx-lms -/usr/share/doc/osmo-trx/examples/osmo-trx-lms/osmo-trx-limesdr.cfg /usr/share/doc/osmo-trx/examples/osmo-trx-lms/ +usr/bin/osmo-trx-lms +usr/share/doc/osmo-trx/examples/osmo-trx-lms/osmo-trx-limesdr.cfg /usr/share/doc/osmo-trx/examples/osmo-trx-lms/ diff --git a/debian/osmo-trx-ms-blade.install b/debian/osmo-trx-ms-blade.install index 0a3f163..00aea2e 100644 --- a/debian/osmo-trx-ms-blade.install +++ b/debian/osmo-trx-ms-blade.install @@ -1 +1 @@ -/usr/bin/osmo-trx-ms-blade +usr/bin/osmo-trx-ms-blade diff --git a/debian/osmo-trx-uhd.install b/debian/osmo-trx-uhd.install index 77236ca..14c3c9c 100644 --- a/debian/osmo-trx-uhd.install +++ b/debian/osmo-trx-uhd.install @@ -1,6 +1,6 @@ etc/osmocom/osmo-trx-uhd.cfg lib/systemd/system/osmo-trx-uhd.service -/usr/bin/osmo-trx-uhd -/usr/share/doc/osmo-trx/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg /usr/share/doc/osmo-trx/examples/osmo-trx-uhd/ -/usr/share/doc/osmo-trx/examples/osmo-trx-uhd/osmo-trx-limesdr.cfg /usr/share/doc/osmo-trx/examples/osmo-trx-uhd/ -/usr/share/doc/osmo-trx/examples/osmo-trx-uhd/osmo-trx-umtrx.cfg /usr/share/doc/osmo-trx/examples/osmo-trx-uhd/ +usr/bin/osmo-trx-uhd +usr/share/doc/osmo-trx/examples/osmo-trx-uhd/osmo-trx-usrp_b200.cfg /usr/share/doc/osmo-trx/examples/osmo-trx-uhd/ +usr/share/doc/osmo-trx/examples/osmo-trx-uhd/osmo-trx-limesdr.cfg /usr/share/doc/osmo-trx/examples/osmo-trx-uhd/ +usr/share/doc/osmo-trx/examples/osmo-trx-uhd/osmo-trx-umtrx.cfg /usr/share/doc/osmo-trx/examples/osmo-trx-uhd/ diff --git a/debian/osmo-trx-usrp1.install b/debian/osmo-trx-usrp1.install index 112a149..51055f4 100644 --- a/debian/osmo-trx-usrp1.install +++ b/debian/osmo-trx-usrp1.install @@ -1,4 +1,4 @@ lib/systemd/system/osmo-trx-usrp1.service -/usr/bin/osmo-trx-usrp1 -/usr/share/usrp/rev2/std_inband.rbf -/usr/share/usrp/rev4/std_inband.rbf +usr/bin/osmo-trx-usrp1 +usr/share/usrp/rev2/std_inband.rbf +usr/share/usrp/rev4/std_inband.rbf -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42245?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I4b9de40e1fc6d3935ae8ff82804d94cb863663e9 Gerrit-Change-Number: 42245 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in pysim[master]: docs/smpp-ota-tool: Add documentation/tutorial
by dexter 02 Mar '26

02 Mar '26

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/42237?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: docs/smpp-ota-tool: Add documentation/tutorial ...................................................................... docs/smpp-ota-tool: Add documentation/tutorial We already have documentation that explains how to run pySim-smpp2sim. With smpp-ota-tool we now have a counterpart for pySim-smpp2sim, so let's add documentation for this tool as well. Related: SYS#7881 Change-Id: If0d18a263f5a6dc035b90f5c5c6a942d46bbba49 --- M docs/index.rst A docs/smpp-ota-tool.rst M docs/smpp2sim.rst 3 files changed, 182 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/37/42237/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42237?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If0d18a263f5a6dc035b90f5c5c6a942d46bbba49 Gerrit-Change-Number: 42237 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[M] Change in pysim[master]: docs/smpp-ota-tool: Add documentation/tutorial
by dexter 02 Mar '26

02 Mar '26

Attention is currently required from: laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42237?usp=email ) Change subject: docs/smpp-ota-tool: Add documentation/tutorial ...................................................................... Patch Set 2: (10 comments) File docs/smpp-ota-tool.rst: https://gerrit.osmocom.org/c/pysim/+/42237/comment/79856fe5_73b4eaf0?usp=em… : PS1, Line 5: cards > an eUICC must not be a card, in fact most often it is not. […] I think SIM/UICC/eUICC should cover all variations. (As far as I know classic SIMs were already able to receive OTA-SMS messages) https://gerrit.osmocom.org/c/pysim/+/42237/comment/495d3de6_6fa25324?usp=em… : PS1, Line 6: SMPP : server > "... SMPP server (such as a production SMSC of a live cellular network) as well." […] Done https://gerrit.osmocom.org/c/pysim/+/42237/comment/ede38d0a_0f4b8232?usp=em… : PS1, Line 17: a se > it's not "a set" but "sets of keys".. […] Done https://gerrit.osmocom.org/c/pysim/+/42237/comment/54ddfa34_75b7b3f8?usp=em… : PS1, Line 17: card > we have many more instances of "card" in the document, it seems. […] Done https://gerrit.osmocom.org/c/pysim/+/42237/comment/c44f2edd_826ab9f7?usp=em… : PS1, Line 26: The KIK is not used in the scope of SCP80. > oh, are you sure? That means you cannot deploy new SCP80 (or other) keys via SCP80? I would have as […] I have asked myself the same question but I could not find any reference to KIK in ETSI TS 102 225 This lead me to the assumption that KIK is not available in SCP80. When I look at Table 1. There is only "KIc" and "KID", not "KIK" or anything. We also only have the sections "Coding of KIc" and "Coding of KID". But I have had closer look at this again now: ETSI TS 102 226, section 8.2.1.5 hints towards that the KIK (DEK) is implicitly selected. KIc and KID must be the same numbers anyway (mixing keys from different keysets is forbidden, but SCP80 would technically allow it). The spec says: "The transport security keys (i.e. KIc/KID) used to secure the Response Packet shall be the same as the ones of the Command Packet containing the PUT KEY command.", so when KIc/KID is 1, then KIK is also 1. and so on. So, I think we should write this paragraph a bit differently... (I still have problems to understand to which layer the KIK actually belongs to. To me it seems that it is more or less something that is specific to put_key. If this is true it should not be mentioned in any of those specs and only be discussed in the global platform spec where put_key is specified.) https://gerrit.osmocom.org/c/pysim/+/42237/comment/e8a9027a_153c6f3a?usp=em… : PS1, Line 28: programmed into the issuer security domain (ISD) > the keyset doesn't have to be in the ISD. […] Done https://gerrit.osmocom.org/c/pysim/+/42237/comment/e63b30fb_1f32f751?usp=em… : PS1, Line 84: A0A40000027F20 > might be worth using formatting instructions to use monospaced font for all APDUs or other hex-strin […] Done https://gerrit.osmocom.org/c/pysim/+/42237/comment/c4c34553_7cc37059?usp=em… : PS1, Line 86: is received by the SIM RFM application and then executed. This method poses some limitations that have to be taken into > might be worth stating that he SIM RFM application is "on the card" Done https://gerrit.osmocom.org/c/pysim/+/42237/comment/5be08627_e556b4b9?usp=em… : PS1, Line 115: : To prevent this, we may include a replay protection counter within the message. In this case, the MSL indicates that a : replay protection counter is not required. However, to extended the security of our messages, we may chose to use a : counter anyway. In the following example, we will encode a counter value of 100. We will instruct the card to make sure : that the value we send is higher than the counter value that is currently stored in the card. > it might be worth mentioning at some earlier point that the MSL of the card may be different for dif […] Done https://gerrit.osmocom.org/c/pysim/+/42237/comment/f516e49f_69754f5e?usp=em… : PS1, Line 162: overlap > "... it will not wrap on overflow ... Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42237?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If0d18a263f5a6dc035b90f5c5c6a942d46bbba49 Gerrit-Change-Number: 42237 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 02 Mar 2026 12:49:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XL] Change in osmo-trx[master]: feat(usdr): add USDR backend support (osmo-trx-usdr)
by Timur Davydov 02 Mar '26

02 Mar '26

Attention is currently required from: Hoernchen, fixeria, laforge, osmith, pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42198?usp=email ) Change subject: feat(usdr): add USDR backend support (osmo-trx-usdr) ...................................................................... Patch Set 6: (4 comments) File Transceiver52M/device/usdr/USDRDevice.h: https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/fec3eb12_ab445422?usp… : PS4, Line 12: This program is distributed in the hope that it will be useful, > and the indentation still differs from the the lines above. Fixed indentation. File Transceiver52M/device/usdr/USDRDevice.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/8a485113_237ed47f?usp… : PS4, Line 475: std::string USDRDevice::getTxAntenna(size_t chan ) > Not removed ;) Now removed :) File doc/manuals/chapters/trx-backends.adoc: https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/940f6378_bb71d198?usp… : PS3, Line 86: where multiple small SDRs are combined to present one or more TRX instances > SO IIUC that means you didn't actually yet try/succeed to run multi-trx BTS with these devices, corr […] Correct. So far, I've only tested one `osmo-trx-usdr` instance with one `osmo-bts-trx`. Initially, I assumed that one `osmo-bts-trx` could connect to multiple `osmo-trx-usdr` instances (one for each SDR), based on the structure of the `trx` configuration in `osmo-bts-trx`, where `trx` has an index, so it's possible to create multiple `trx` instance configurations. File doc/manuals/chapters/trx-devices.adoc: https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/9a0f3ddd_631f53df?usp… : PS3, Line 102: scale the number of TRX instances. > As mentioned in the other comment, multi-trx for a given BTS running multiple osmo-trx processes is […] I’ve adjusted the documentation in this file. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5d1d25921514954c4929ae6e7352168b3ceb05df Gerrit-Change-Number: 42198 Gerrit-PatchSet: 6 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Mar 2026 12:02:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[XL] Change in osmo-trx[master]: feat(usdr): add USDR backend support (osmo-trx-usdr)
by Timur Davydov 02 Mar '26

02 Mar '26

Attention is currently required from: Hoernchen, Timur Davydov, fixeria, laforge, osmith. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/42198?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: feat(usdr): add USDR backend support (osmo-trx-usdr) ...................................................................... feat(usdr): add USDR backend support (osmo-trx-usdr) - Implement USDRDevice backend for Transceiver52M - Add --with-usdr configure option and build integration - Add systemd service unit (osmo-trx-usdr.service) - Add Debian packaging files for osmo-trx-usdr - Provide example configuration file - Extend manuals and device documentation with USDR backend section Change-Id: I5d1d25921514954c4929ae6e7352168b3ceb05df --- M .gitignore M Transceiver52M/Makefile.am M Transceiver52M/device/Makefile.am A Transceiver52M/device/usdr/Makefile.am A Transceiver52M/device/usdr/USDRDevice.cpp A Transceiver52M/device/usdr/USDRDevice.h M configure.ac M contrib/systemd/Makefile.am A contrib/systemd/osmo-trx-usdr.service A debian/osmo-trx-usdr.install A debian/osmo-trx-usdr.postinst M doc/examples/Makefile.am A doc/examples/osmo-trx-usdr/osmo-trx-usdr.cfg M doc/manuals/Makefile.am M doc/manuals/chapters/trx-backends.adoc M doc/manuals/chapters/trx-devices.adoc 16 files changed, 1,022 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/98/42198/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5d1d25921514954c4929ae6e7352168b3ceb05df Gerrit-Change-Number: 42198 Gerrit-PatchSet: 6 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[M] Change in osmo-trx[master]: build: install common/GSM/transceiver libraries for emscripten and ad...
by fixeria 02 Mar '26

02 Mar '26

Attention is currently required from: Hoernchen, osmith, pespin. fixeria has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email ) Change subject: build: install common/GSM/transceiver libraries for emscripten and add pkg-config files ...................................................................... Patch Set 1: (1 comment) File Transceiver52M/arch/common/Makefile.am: https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/fed757d5_931117b9?usp… : PS1, Line 16: NOT_HAVE_EMSCRIPTEN I believe you can re-use `HAVE_EMSCRIPTEN` here: ```suggestion if !HAVE_EMSCRIPTEN ``` According to https://www.gnu.org/software/automake/manual/html_node/Usage-of-Conditional…, this seems to be a valid syntax. You can then remove `NOT_HAVE_EMSCRIPTEN`. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I2495c5b5c79f2fe74bef83902058e1d2207c1f3c Gerrit-Change-Number: 42243 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Mar 2026 11:39:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-trx[master]: build: install common/GSM/transceiver libraries for emscripten and ad...
by Timur Davydov 02 Mar '26

02 Mar '26

Attention is currently required from: Hoernchen, fixeria, osmith, pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email ) Change subject: build: install common/GSM/transceiver libraries for emscripten and add pkg-config files ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > why would you need to make those as shared libraries? Are you saying emscripten supports shared libr […] For Emscripten I’m actually building them as static libraries. Shared libraries are not supported in the usual sense there, so everything is linked statically into the final module. The shared library build is only used for native targets. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I2495c5b5c79f2fe74bef83902058e1d2207c1f3c Gerrit-Change-Number: 42243 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Mar 2026 11:34:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-trx[master]: fix(threads): centralize portable strerror handling
by fixeria 02 Mar '26

02 Mar '26

Attention is currently required from: Timur Davydov, osmith. fixeria has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email ) Change subject: fix(threads): centralize portable strerror handling ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I642aff8a9f98823e117c4debd19384ddf5975039 Gerrit-Change-Number: 42199 Gerrit-PatchSet: 5 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Mon, 02 Mar 2026 11:22:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-remsim[master]: remsim-bankd: Don't pass on illegal TPDUs of illegal length
by laforge 02 Mar '26

02 Mar '26

Attention is currently required from: Hoernchen, lynxis lazus. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42231?usp=email ) Change subject: remsim-bankd: Don't pass on illegal TPDUs of illegal length ...................................................................... Patch Set 3: (1 comment) File src/bankd/bankd_main.c: https://gerrit.osmocom.org/c/osmo-remsim/+/42231/comment/64496dbc_3fe793be?… : PS3, Line 826: return -107; > (unresolv it) The most likely explanation for a short TPDU is that the cardem/tracer somehow failed to correctly receive/decode the command from the modem, possibly due to timing, EMI or a firmware bug or the like. Well, it's hard to know what is desirable here. If any one APDU in a sequence of APDUs fails, there is no way to know if the state is still consistent. Imagine a SELECT before an UPDATE - you end up writing to the wrong file. So I think failing fast and fully is a safe approach, rather than simply ignoring errors. But I'm happy to be convinced otherwise... -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42231?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I5c9f1143b85470234acd2e2ffe3e0cf72bd2ae43 Gerrit-Change-Number: 42231 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 02 Mar 2026 11:17:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-remsim[master]: remsim-client: Don't attempt to pass on illegal TPDU length
by laforge 02 Mar '26

02 Mar '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42230?usp=email ) Change subject: remsim-client: Don't attempt to pass on illegal TPDU length ...................................................................... remsim-client: Don't attempt to pass on illegal TPDU length TPDUs with length < 5 or > 260 bytes are illegal in T=0. It doesn't make sense to send them to bankd, triggering bugs in either bankd, pcsc-lite or the CCID firmware down the road. Let's filter them right where they might originate. Change-Id: I175eb4622d0e69dbc6aca2cddfe091a78f225da5 --- M src/client/main_fsm.c 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified lynxis lazus: Looks good to me, approved diff --git a/src/client/main_fsm.c b/src/client/main_fsm.c index 18798d3..5a35567 100644 --- a/src/client/main_fsm.c +++ b/src/client/main_fsm.c @@ -331,6 +331,11 @@ case MF_E_MDM_TPDU: tpdu = data; OSMO_ASSERT(tpdu); + if (tpdu->len < 5 || tpdu->len > 260) { + LOGPFSML(fi, LOGL_ERROR, "Modem submitted illegal TPDU length %zu (%s), dropping\n", tpdu->len, + osmo_hexdump_nospc(tpdu->buf, tpdu->len)); + break; + } LOGPFSML(fi, LOGL_INFO, "Tx tpduModemToCard (%s)\n", osmo_hexdump_nospc(tpdu->buf, tpdu->len)); /* forward to bankd */ bank_slot2rspro(&bslot, &bc->bankd_slot); -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42230?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I175eb4622d0e69dbc6aca2cddfe091a78f225da5 Gerrit-Change-Number: 42230 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log March 2026