March 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: tch: fix RTP clock not ticking for unhandled payload types
by laforge 02 Mar '26

02 Mar '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email ) Change subject: tch: fix RTP clock not ticking for unhandled payload types ...................................................................... tch: fix RTP clock not ticking for unhandled payload types When the payload type from the DSP is not handled by the switch in l1if_tch_rx(), rmsg stays NULL and we return 0 without calling add_l1sap_header(), silently dropping a 20ms RTP tick. Always allocate an empty RTP frame when rmsg is NULL so the RTP clock keeps ticking. Related: OS#5974 Change-Id: I202522ea6f83d77872a2f84d9a2622b87e829a0c --- M src/osmo-bts-sysmo/tch.c 1 file changed, 14 insertions(+), 8 deletions(-) Approvals: pespin: Looks good to me, approved falconia: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bts-sysmo/tch.c b/src/osmo-bts-sysmo/tch.c index b5bf04b..6a431d0 100644 --- a/src/osmo-bts-sysmo/tch.c +++ b/src/osmo-bts-sysmo/tch.c @@ -601,15 +601,21 @@ /* FIXME: what about GsmL1_TchPlType_Amr_SidBad? not well documented. */ } - if (rmsg) - return add_l1sap_header(trx, rmsg, lchan, chan_nr, data_ind->u32Fn, - data_ind->measParam.fBer * 10000, - data_ind->measParam.fLinkQuality * 10, - data_ind->measParam.fRssi, - data_ind->measParam.i16BurstTiming * 64, - 0); + if (!rmsg) { + LOGPLCFN(lchan, data_ind->u32Fn, DL1P, LOGL_NOTICE, + "Unhandled payload type %s, generating empty RTP tick\n", + get_value_string(femtobts_tch_pl_names, payload_type)); + rmsg = msgb_alloc_headroom(256, 128, "L1P-to-RTP"); + if (!rmsg) + return -ENOMEM; + } - return 0; + return add_l1sap_header(trx, rmsg, lchan, chan_nr, data_ind->u32Fn, + data_ind->measParam.fBer * 10000, + data_ind->measParam.fLinkQuality * 10, + data_ind->measParam.fRssi, + data_ind->measParam.i16BurstTiming * 64, + 0); err_payload_match: LOGPLCFN(lchan, data_ind->u32Fn, DL1P, LOGL_ERROR, "%s Rx Payload Type %s incompatible with lchan\n", -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I202522ea6f83d77872a2f84d9a2622b87e829a0c Gerrit-Change-Number: 42244 Gerrit-PatchSet: 5 Gerrit-Owner: Thorkell Thorkelsson <thorkellmanithorkelsson(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: tch: fix RTP clock not ticking for unhandled payload types
by laforge 02 Mar '26

02 Mar '26

Attention is currently required from: Thorkell Thorkelsson, fixeria. laforge has posted comments on this change by Thorkell Thorkelsson. ( https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email ) Change subject: tch: fix RTP clock not ticking for unhandled payload types ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I202522ea6f83d77872a2f84d9a2622b87e829a0c Gerrit-Change-Number: 42244 Gerrit-PatchSet: 5 Gerrit-Owner: Thorkell Thorkelsson <thorkellmanithorkelsson(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Thorkell Thorkelsson <thorkellmanithorkelsson(a)gmail.com> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Mar 2026 11:12:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-trx[master]: build: install common/GSM/transceiver libraries for emscripten and ad...
by pespin 02 Mar '26

02 Mar '26

Attention is currently required from: Timur Davydov. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email ) Change subject: build: install common/GSM/transceiver libraries for emscripten and add pkg-config files ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: why would you need to make those as shared libraries? Are you saying emscripten supports shared libraries but not static libraries? This smells wrong to me. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I2495c5b5c79f2fe74bef83902058e1d2207c1f3c Gerrit-Change-Number: 42243 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Mon, 02 Mar 2026 11:03:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XL] Change in osmo-trx[master]: feat(usdr): add USDR backend support (osmo-trx-usdr)
by pespin 02 Mar '26

02 Mar '26

Attention is currently required from: Hoernchen, Timur Davydov, fixeria, laforge, osmith. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42198?usp=email ) Change subject: feat(usdr): add USDR backend support (osmo-trx-usdr) ...................................................................... Patch Set 5: (40 comments) File Transceiver52M/device/usdr/USDRDevice.h: https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/471c550a_e5761512?usp… : PS4, Line 12: This program is distributed in the hope that it will be useful, > Added the `*` prefix. and the indentation still differs from the the lines above. https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/f2a82332_9a4aa5a4?usp… : PS4, Line 46: struct DeviceParameters { > Yes, replaced with `struct dev_desc` for consistency with the other devices. Done https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/4f8422fd_5ab50155?usp… : PS4, Line 48: * time correction for TX timestamp, in seconds, to align it with RX timestamp, which is needed to achieve correct > Fixed, wrapped to stay under 120 chars. Done https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/a1ead6bb_441d4300?usp… : PS4, Line 54: using DeviceParametersMap = std::map<std::string, DeviceParameters>; > Yes, replaced with `dev_map_t` for consistency with the other devices. Done https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/de9c7bca_dcdef9eb?usp… : PS4, Line 86: public: > Reordered the class members to match the structure used in the other device classes (public section […] Done https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/644d6824_42434013?usp… : PS4, Line 115: /** > Removed trailing whitespace. Done https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/f70ef8e2_893ba916?usp… : PS4, Line 116: * @brief Read samples from the USDR. > Ack. […] Done https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/096ba097_1347a43d?usp… : PS4, Line 126: bool *underrun = nullptr); > Aligned as suggested. Done File Transceiver52M/device/usdr/USDRDevice.h: https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/4f484909_a53aac39?usp… : PS3, Line 54: int txsps; ///< samples count per GSM symbol for Tx > Replaced with `tx_sps` and `rx_sps` from `RadioDevice` Done https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/b7f10edb_6afd13dc?usp… : PS3, Line 60: int timeTxCorr = 0; ///< time correction for TX timestamp, in samples, to align it with RX timestamp, which is needed to achieve correct timing of the transmitted signal. This is a device-specific parameter that can be configured via dev_args and defaults to 0 if not specified. > Done Done https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/3cc3340a_949321a6?usp… : PS3, Line 63: TIMESTAMP ts_last_recv = 0; > Fixed indentation throughout the file Done https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/62a9520e_10e54542?usp… : PS3, Line 90: Read samples from the USDR. > Fixed comments throughout the file Done https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/311fa05a_4ce46b10?usp… : PS3, Line 100: TIMESTAMP timestamp = 0xffffffff, bool *underrun = NULL); > Fixed indentation throughout the file Done https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/0b5e83b1_0deddbd0?usp… : PS3, Line 121: > Fixed whitespaces throughout the file Done https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/a876a8be_93671360?usp… : PS3, Line 132: TIMESTAMP initialReadTimestamp(void) { return ts_initial;} > Fixed indentation throughout the file Done File Transceiver52M/device/usdr/USDRDevice.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/bac9759b_0fd0ecd1?usp… : PS3, Line 49: {"limemini", {tx_offset: 86.769us}}, /* 94 samples at 1083333.33333 sps corresponds to 86.769 us */ > Thanks, good catch — I indeed lost xSDR in that section. […] Done https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/f653d980_0f9b118c?usp… : PS3, Line 52: enum { > Replaced the enum with #define constants as suggested Done https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/7d6b5694_b0e53434?usp… : PS3, Line 85: std::string msg = std::string("Error creating USDR device with connection string '") + connection_string + "' res: " + std::to_string(res) + "(" + strerror(res) + ")"; > Reformatted the file to ensure all lines are within the 120-character limit Done https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/02b41a8a_c8939e46?usp… : PS3, Line 180: dev = NULL; > Fixed indentation throughout the file Done File Transceiver52M/device/usdr/USDRDevice.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/7ea8e927_577d51c6?usp… : PS4, Line 191: const int loglevel = parse_config(args, "loglevel", 3); > I’ve added a logging callback similar to the other backends. […] Ack, fine. https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/28da068b_0e6c779f?usp… : PS4, Line 199: const double rate = 0.27083333333e6 * tx_sps; > It comes from 1083333.33333 sps / 4. […] Done https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/e716211c_775c711d?usp… : PS4, Line 203: uint64_t val; > I've moved the variable declarations to the top of the function, except for const ones in some funct […] Done https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/f643e89a_41df4ba3?usp… : PS4, Line 221: usdr_dme_set_uint_exception(dev, "/dm/sdr/0/tx/gain", 0); > Added the suggested macros and replaced the hardcoded paths accordingly. Done https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/a85b9b60_4c86ab55?usp… : PS4, Line 228: const char* fmt = "ci16"; > Moved it to a #define at the top of the file. Done https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/d95d074a_b34067c2?usp… : PS4, Line 246: usdr_dms_sync_exception(dev, "rx", ped.size(), ped.data()); > Replaced the remaining hardcoded strings with defines. Done https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/c909c799_7310ba57?usp… : PS4, Line 260: if (dev) { > Implemented as suggested. Done https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/357dcc50_1169f130?usp… : PS4, Line 269: return false; > Added an error message. Done https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/1866d804_334efc44?usp… : PS4, Line 296: return !started; > Implemented as suggested. Done https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/0290b35e_e83b0182?usp… : PS4, Line 327: double USDRDevice::setTxGain(double dB, size_t chan) > Removed all unused functions. Done https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/f8dcbd92_80861407?usp… : PS4, Line 382: try { > Reworked it to follow the other backends: values are now cached per channel in arrays (rx_gains, tx_ […] Done https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/dca9c323_be9e8e78?usp… : PS4, Line 392: TIMESTAMP timestamp, bool *underrun) > Fixed the indentation. Done https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/86153742_bcaf52f6?usp… : PS4, Line 394: if (!started) > Replaced the check with the same bufs. […] Done https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/69188723_e0f9b0ed?usp… : PS4, Line 421: bool *underrun, TIMESTAMP timestamp) > Fixed Done https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/fcecb741_2a71b9bc?usp… : PS4, Line 475: std::string USDRDevice::getTxAntenna(size_t chan ) > Removed Not removed ;) https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/2b5e005a_9307955e?usp… : PS4, Line 492: return GSM::Time(6,7); > Added space Done https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/3268480a_2f30223f?usp… : PS4, Line 610: return new USDRDevice(iface, cfg); > I don’t think additional device-specific checks are needed here. […] Done File debian/osmo-trx-usdr.install: https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/f38b6ad5_542ad2da?usp… : PS4, Line 3: /usr/bin/osmo-trx-usdr > It surprised me as well. […] @osmith@sysmocom.de CC File doc/manuals/chapters/trx-backends.adoc: https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/81873d67_72d8b6ae?usp… : PS3, Line 86: where multiple small SDRs are combined to present one or more TRX instances > Updated the documentation according to your remarks. SO IIUC that means you didn't actually yet try/succeed to run multi-trx BTS with these devices, correct? File doc/manuals/chapters/trx-devices.adoc: https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/b71db28d_36b06576?usp… : PS3, Line 102: scale the number of TRX instances. > Good point, thanks. […] As mentioned in the other comment, multi-trx for a given BTS running multiple osmo-trx processes is not supported nowadays. Can you actually provide information on how did you test such a setup? Otherwise please update the documentation in this file. File doc/manuals/chapters/trx-devices.adoc: https://gerrit.osmocom.org/c/osmo-trx/+/42198/comment/da8c8ccb_8fdf65ed?usp… : PS4, Line 127: instances. The current _osmo-trx-usdr_ backend operates in single-channel mode. > Added the missing newline at the end of the file. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5d1d25921514954c4929ae6e7352168b3ceb05df Gerrit-Change-Number: 42198 Gerrit-PatchSet: 5 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Mon, 02 Mar 2026 10:59:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[M] Change in osmo-trx[master]: radio: improve API documentation in RadioDevice
by pespin 02 Mar '26

02 Mar '26

Attention is currently required from: Timur Davydov. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42242?usp=email ) Change subject: radio: improve API documentation in RadioDevice ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42242?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I7b41c549d743ad180a1ddcd8c0313e1003860070 Gerrit-Change-Number: 42242 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Mon, 02 Mar 2026 10:47:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-asf4-dfu[master]: Improve comments on errata 2.6.10
by mschramm 02 Mar '26

02 Mar '26

Attention is currently required from: lynxis lazus. mschramm has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42168?usp=email ) Change subject: Improve comments on errata 2.6.10 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: The point here is: there is no such facility nor even a concept of a 'low-priority' WDT in this Cortex-M4F, therefore it can not be started, and hence your comment is simply wrong. This rather reads like a typo/thinko from the errata workaround where they want to have the WDT initialized w/ "low(est) period" . -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42168?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I3c35f590a4e43d778e70f2f377e0d470c3a652b2 Gerrit-Change-Number: 42168 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: mschramm <mschramm(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 02 Mar 2026 10:47:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-bts[master]: tch: fix RTP clock not ticking for unhandled payload types
by pespin 02 Mar '26

02 Mar '26

Attention is currently required from: Thorkell Thorkelsson, fixeria. pespin has posted comments on this change by Thorkell Thorkelsson. ( https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email ) Change subject: tch: fix RTP clock not ticking for unhandled payload types ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I202522ea6f83d77872a2f84d9a2622b87e829a0c Gerrit-Change-Number: 42244 Gerrit-PatchSet: 5 Gerrit-Owner: Thorkell Thorkelsson <thorkellmanithorkelsson(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Thorkell Thorkelsson <thorkellmanithorkelsson(a)gmail.com> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Mar 2026 10:46:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-asn1-tcap[master]: Introduce API osmo_asn1_tcap_TCMessage_decode()
by pespin 02 Mar '26

02 Mar '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42238?usp=email ) Change subject: Introduce API osmo_asn1_tcap_TCMessage_decode() ...................................................................... Introduce API osmo_asn1_tcap_TCMessage_decode() This new API allows passing a talloc context where all memory is allocated by asn1c code is allocated. Related: SYS#5423 Related: OS#6965 Change-Id: I02923afb3936a1acf6643def27528e35e4b03e86 --- A TODO-RELEASE M include/osmocom/tcap/asn_internal.h M include/osmocom/tcap/tcap.h M src/Makefile.am M src/tcap.c 5 files changed, 25 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/TODO-RELEASE b/TODO-RELEASE new file mode 100644 index 0000000..9312dbd --- /dev/null +++ b/TODO-RELEASE @@ -0,0 +1,10 @@ +# When cleaning up this file: bump API version in corresponding Makefile.am and rename corresponding debian/lib*.install +# according to https://osmocom.org/projects/cellular-infrastructure/wiki/Make_a_new_release +# In short: https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info… +# LIBVERSION=c:r:a +# If the library source code has changed at all since the last update, then increment revision: c:r + 1:a. +# If any interfaces have been added, removed, or changed since the last update: c + 1:0:a. +# If any interfaces have been added since the last public release: c:r:a + 1. +# If any interfaces have been removed or changed since the last public release: c:r:0. +#library what description / commit summary line +libosmo-asn1-tcap add osmo_asn1_tcap_TCMessage_decode() diff --git a/include/osmocom/tcap/asn_internal.h b/include/osmocom/tcap/asn_internal.h index f4337d3..18e493f 100644 --- a/include/osmocom/tcap/asn_internal.h +++ b/include/osmocom/tcap/asn_internal.h @@ -35,7 +35,7 @@ #define ASN1C_ENVIRONMENT_VERSION 923 /* Compile-time version */ int get_asn1c_environment_version(void); /* Run-time version */ -extern void *tcap_talloc_asn1_ctx; +extern __thread void *tcap_talloc_asn1_ctx; #define CALLOC(nmemb, size) talloc_zero_size(tcap_talloc_asn1_ctx, (nmemb) * (size)) #define MALLOC(size) talloc_size(tcap_talloc_asn1_ctx, size) #define REALLOC(oldptr, size) talloc_realloc_size(tcap_talloc_asn1_ctx, oldptr, size) diff --git a/include/osmocom/tcap/tcap.h b/include/osmocom/tcap/tcap.h index 309f283..c7db4ab 100644 --- a/include/osmocom/tcap/tcap.h +++ b/include/osmocom/tcap/tcap.h @@ -6,6 +6,8 @@ #include <osmocom/tcap/TCAP_TCMessage.h> -int osmo_asn1_tcap_decode(struct TCAP_TCMessage *tcapmsg, const uint8_t *data, size_t data_len); +int osmo_asn1_tcap_decode(struct TCAP_TCMessage *tcapmsg, const uint8_t *data, size_t data_len) OSMO_DEPRECATED("Use osmo_asn1_tcap_TCMessage_decode() instead"); + +int osmo_asn1_tcap_TCMessage_decode(struct TCAP_TCMessage *tcapmsg, const uint8_t *data, size_t data_len, void *talloc_ctx); void osmo_asn1_tcap_TCMessage_free_contents(struct TCAP_TCMessage *tcapmsg); diff --git a/src/Makefile.am b/src/Makefile.am index 42089af..78d8d0d 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -243,7 +243,7 @@ ../../move-asn1-header-files.sh osmocom/tcap $(ASN_MODULE_INC) #Patch mem alloc defines to use talloc: sed -i "s/#define\tASN_INTERNAL_H/#define\tASN_INTERNAL_H\n#include <talloc.h>/g" $(top_srcdir)/include/osmocom/tcap/asn_internal.h - sed -i "s/#define\tCALLOC/extern void *tcap_talloc_asn1_ctx;\n#define\tCALLOC/g" $(top_srcdir)/include/osmocom/tcap/asn_internal.h + sed -i "s/#define\tCALLOC/extern __thread void *tcap_talloc_asn1_ctx;\n#define\tCALLOC/g" $(top_srcdir)/include/osmocom/tcap/asn_internal.h sed -i "s/calloc(nmemb, size)/talloc_zero_size(tcap_talloc_asn1_ctx, (nmemb) * (size))/g" $(top_srcdir)/include/osmocom/tcap/asn_internal.h sed -i "s/malloc(size)/talloc_size(tcap_talloc_asn1_ctx, size)/g" $(top_srcdir)/include/osmocom/tcap/asn_internal.h sed -i "s/realloc(oldptr, size)/talloc_realloc_size(tcap_talloc_asn1_ctx, oldptr, size)/g" $(top_srcdir)/include/osmocom/tcap/asn_internal.h diff --git a/src/tcap.c b/src/tcap.c index f5303ac..0957faa 100644 --- a/src/tcap.c +++ b/src/tcap.c @@ -26,7 +26,7 @@ #include <osmocom/tcap/asn_codecs.h> #include <osmocom/tcap/TCAP_TCMessage.h> -void *tcap_talloc_asn1_ctx; +__thread void *tcap_talloc_asn1_ctx; int osmo_asn1_tcap_decode(struct TCAP_TCMessage *tcapmsg, const uint8_t *data, size_t data_len) { @@ -41,6 +41,15 @@ return 0; } +int osmo_asn1_tcap_TCMessage_decode(struct TCAP_TCMessage *tcapmsg, const uint8_t *data, size_t data_len, void *talloc_ctx) +{ + int rc; + tcap_talloc_asn1_ctx = talloc_ctx; + rc = osmo_asn1_tcap_decode(tcapmsg, data, data_len); + tcap_talloc_asn1_ctx = NULL; + return rc; +} + void osmo_asn1_tcap_TCMessage_free_contents(struct TCAP_TCMessage *tcapmsg) { ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_TCAP_TCMessage, tcapmsg); -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42238?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I02923afb3936a1acf6643def27528e35e4b03e86 Gerrit-Change-Number: 42238 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-asn1-tcap[master]: Add README.md
by pespin 02 Mar '26

02 Mar '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42216?usp=email ) Change subject: Add README.md ...................................................................... Add README.md Change-Id: Ie3fa506cb9b40992cebe6942ea833a2e49ba2680 --- A README.md 1 file changed, 68 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/README.md b/README.md new file mode 100644 index 0000000..b73eefe --- /dev/null +++ b/README.md @@ -0,0 +1,68 @@ +libosmo-asn1-tcap +================= + +This repository contains C-language routing to encode and decode TCAP (ITU Q.771-Q.775). + +Homepage +-------- + +The official homepage of the project is +https://gitea.osmocom.org/ss7-in-c/libosmo-asn1-tcap/ + +GIT Repository +-------------- + +You can clone from the official libosmo-asn1-tcap.git repository using + + git clone https://gitea.osmocom.org/ss7-in-c/libosmo-asn1-tcap/ + +There is a web interface at <https://gitea.osmocom.org/ss7-in-c/libosmo-asn1-tcap/> + +Mailing List +------------ + +Discussions related to libosmo-asn1-tcap are happening on the +openbsc(a)lists.osmocom.org mailing list, please see +https://lists.osmocom.org/mailman/listinfo/openbsc for subscription +options and the list archive. + +Please observe the [Osmocom Mailing List +Rules](https://osmocom.org/projects/cellular-infrastructure/wiki/Mailing_List_Rules) +when posting. + +Contributing +------------ + +Our coding standards are described at +https://osmocom.org/projects/cellular-infrastructure/wiki/Coding_standards + +We use a Gerrit based patch submission/review process for managing +contributions. Please see +https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit for +more details + +The current patch queue for libosmo-asn1-tcap can be seen at +https://gerrit.osmocom.org/#/q/project:libosmo-asn1-tcap+status:open + + +Generating asn1c code +--------------------- + +The upstream fork maintained by a big contributor +[mouse07410](https://github.com/mouse07410/asn1c) of asn1c is used to generate +TCAP code from from ASN.1 files present in the asn/ directory. + +In order to regenerate the code, one shall adjust the ASN1C_SKELETON_PATH and +ASN1C_BIN_PATH in configure.ac to point to the built & installed asn1c from +mouse07410 (usually `vlm_master` branch). Last generated code was built using +commit hash 2c065550a5a0d08636cad64f4b067c1dcba2f339. + +Then, do the usual `autoreconf -fi && ./configure`, using a buildir != srcdir +(important, in order to avoid ending up with temporary files in srcdir and +making it difficult to stash the relevant changes). + +Finally, run `make -C src/ regen`, which will regenerate the files and copy over +the skeletons, with git possibly showing changes in the following paths: +- include/osmocom/tcap/ +- src/gen/ +- src/skel/ -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42216?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: Ie3fa506cb9b40992cebe6942ea833a2e49ba2680 Gerrit-Change-Number: 42216 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-asn1-tcap[master]: Makefile.am: Avoid removing tcap.h during make -C src/ regen
by pespin 02 Mar '26

02 Mar '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42217?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: Makefile.am: Avoid removing tcap.h during make -C src/ regen ...................................................................... Makefile.am: Avoid removing tcap.h during make -C src/ regen That header is ours and is the public entry towards the library. Change-Id: I89a34ef61e6f74ba7482a5abcf55404c157a14fb --- M src/Makefile.am 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/src/Makefile.am b/src/Makefile.am index ef91d4b..6c2f830 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -210,7 +210,9 @@ regen: regenerate-from-asn1-source regenerate-from-asn1-source: - rm -f $(top_srcdir)/src/gen/*.c $(top_srcdir)/include/osmocom/tcap/*.h + rm -f $(top_srcdir)/src/gen/*.c +# Remove all .h files except our tcap.h: + find $(top_srcdir)/include/osmocom/tcap/ -type f -name '*.h' -type f -not -name 'tcap.h' -delete ASN1C_PREFIX="TCAP_" ${ASN1C_BIN_PATH} \ -S $(ASN1C_SKELETON_PATH) \ -D $(top_srcdir)/src/gen \ -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42217?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I89a34ef61e6f74ba7482a5abcf55404c157a14fb Gerrit-Change-Number: 42217 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log March 2026