Attention is currently required from: fixeria, pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42232?usp=email )
Change subject: NGAP_Emulation: Use specific record types for AMF/RAN IDs
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42232?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibd85be865a3a61c97d312df76ab3d1ae7ae32a6a
Gerrit-Change-Number: 42232
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 03 Mar 2026 11:57:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42239?usp=email )
Change subject: Use new libosmo-asn1-tcap API osmo_asn1_tcap_TCMessage_decode()
......................................................................
Use new libosmo-asn1-tcap API osmo_asn1_tcap_TCMessage_decode()
This allows passing a talloc context used to allocate memory when
decoding the message.
Related: SYS#5423
Related: OS#6965
Change-Id: Iebeb2808c54c5b82026a1b31d985aa73f602b42a
---
M TODO-RELEASE
M src/tcap_as_loadshare.c
2 files changed, 2 insertions(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, but someone else must approve
Jenkins Builder: Verified
daniel: Looks good to me, but someone else must approve
osmith: Looks good to me, approved
diff --git a/TODO-RELEASE b/TODO-RELEASE
index 0ed7189..ef38361 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -7,3 +7,4 @@
# If any interfaces have been added since the last public release: c:r:a + 1.
# If any interfaces have been removed or changed since the last public release: c:r:0.
#library what description / commit summary line
+libosmo-asn1-tcap >0.2.1 osmo_asn1_tcap_TCMessage_decode()
diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c
index 5a52f83..f7ae3b8 100644
--- a/src/tcap_as_loadshare.c
+++ b/src/tcap_as_loadshare.c
@@ -96,7 +96,7 @@
OSMO_ASSERT(ids);
- rc = osmo_asn1_tcap_decode(tcapmsg, data, len);
+ rc = osmo_asn1_tcap_TCMessage_decode(tcapmsg, data, len, as);
if (rc < 0) {
LOGPAS(as, DLTCAP, LOGL_NOTICE, "Error decoding TCAP message rc: %d, message: %s\n",
rc, osmo_hexdump(data, len));
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42239?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Iebeb2808c54c5b82026a1b31d985aa73f602b42a
Gerrit-Change-Number: 42239
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: falconia, lynxis lazus.
csaba.sipos has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42246?usp=email )
Change subject: nokia_site: Add new BTS types to the list
......................................................................
Patch Set 1:
(2 comments)
File src/osmo-bsc/bts_nokia_site.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/42246/comment/7cd7e60e_c2000e6a?usp… :
PS1, Line 578: 800
> This line was already present before your current patch, but I say it should also be changed to say […]
I am using the exact product names Nokia used. The consistency here is to keep it as the vendor refers to their own products.
https://gerrit.osmocom.org/c/osmo-bsc/+/42246/comment/743abb6e_5af3b212?usp… :
PS1, Line 584: 800
> I say we should refer to the band in question as 850 rather than 800. […]
Same here as at #578.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42246?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia0dbbf148394d8205dc9219b41cfba3cf62bdeaa
Gerrit-Change-Number: 42246
Gerrit-PatchSet: 1
Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-CC: falconia <falcon(a)freecalypso.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Tue, 03 Mar 2026 08:31:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Attention is currently required from: csaba.sipos, lynxis lazus.
falconia has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42246?usp=email )
Change subject: nokia_site: Add new BTS types to the list
......................................................................
Patch Set 1:
(3 comments)
Patchset:
PS1:
Full disclosure: American 2G Cooperative is in the process of buying a Nokia Flexi BTS (ESMB+FXCB modules, can't tell if it is supposed to be called "Flexi EDGE" or "Flexi Multiradio"), and we seek to get it working with OsmoBSC. Csaba is helping us as Osmocom community's resident expert on Nokia BTS. To our knowledge, ours will be the first attempt to get this BTS model (newer than UltraSite) to work with Osmocom.
File src/osmo-bsc/bts_nokia_site.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/42246/comment/09a086b2_78290a14?usp… :
PS1, Line 578: 800
This line was already present before your current patch, but I say it should also be changed to say "850", and also replace "/" with " & " for consistency with "900 & 1800" and with newly added Flexi EDGE GSM cases.
https://gerrit.osmocom.org/c/osmo-bsc/+/42246/comment/0f4df668_46ec7f1c?usp… :
PS1, Line 584: 800
I say we should refer to the band in question as 850 rather than 800. While it is true that USA FCC (the agency that originally invented this band) sometimes refers to it as "800 MHz cellular", and that is how this band is usually called in AMPS (analog) world, in GSM land it has always been called GSM850, and the description strings for single-band Nokia BTS models do already say "850". If the "800" here came from some doc, it is possible that whoever wrote that doc wasn't very careful..
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42246?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia0dbbf148394d8205dc9219b41cfba3cf62bdeaa
Gerrit-Change-Number: 42246
Gerrit-PatchSet: 1
Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-CC: falconia <falcon(a)freecalypso.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Tue, 03 Mar 2026 05:25:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-trx/+/42248?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: transceiver: add optional Laurent burst LUT modulation (int16)
......................................................................
transceiver: add optional Laurent burst LUT modulation (int16)
Introduce an optional Burst LUT optimization for Laurent-based burst
modulation, enabled via --with-burst-lut.
- Add precomputed Laurent LUT tables (float and int16 I/Q variants)
- Generate LUT at initialization (prepareBurstLUT)
- Use LUT-based modulation for sps=4 when enabled
- Keep original modulateBurstLaurent() as fallback
- Add configure.ac option and USE_BURST_LUT define
This reduces runtime computation by replacing per-burst Laurent
processing with memcpy-based LUT lookups.
Change-Id: I1715c2d33dc55fe1c7be5c6e7259d378ea5e80b2
---
M Transceiver52M/sigProcLib.cpp
M configure.ac
2 files changed, 186 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/48/42248/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42248?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I1715c2d33dc55fe1c7be5c6e7259d378ea5e80b2
Gerrit-Change-Number: 42248
Gerrit-PatchSet: 2
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder