laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42434?usp=email )
Change subject: eIM_Tests: align RSP version number in HTTP header
......................................................................
eIM_Tests: align RSP version number in HTTP header
The RSP version number in the x-admin-protocol header string should
be set to v.2.1.0 (gsma/rsp/v2.1.0), even though the ASN.1 spec we
currently use is at version 2.5.
This is to maintain compatibility with older IPAd versions and also
stated explicitly in GSMA SGP.32 V2.1, section 6.1.
Change-Id: I125c3b13697c71d35788e54b7d88a9f943bb7a71
Related: SYS#7945
---
M eim/eIM_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
osmith: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
diff --git a/eim/eIM_Tests.ttcn b/eim/eIM_Tests.ttcn
index 5dcbdab..b3a3519 100644
--- a/eim/eIM_Tests.ttcn
+++ b/eim/eIM_Tests.ttcn
@@ -378,7 +378,7 @@
template (value) HeaderLines ts_esipa_HTTP_Header := {
{ header_name := "User-Agent", header_value := "TTCN3 eIM testsuite" },
- { header_name := "X-Admin-Protocol", header_value := "gsma/rsp/v2.5.0" },
+ { header_name := "X-Admin-Protocol", header_value := "gsma/rsp/v2.1.0" },
{ header_name := "Content-Type", header_value := "application/x-gsma-rsp-asn1" }
};
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42434?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I125c3b13697c71d35788e54b7d88a9f943bb7a71
Gerrit-Change-Number: 42434
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: daniel, dexter, neels.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42441?usp=email )
Change subject: transport: change APDU format paradigm
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
don't you think it would make sense to have the strict APDU enabled by default?
Or at least print a warning in case a user runs an old script, stating that this legacy mode will not be supported by default in the future?
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42441?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9a531a825def318b28bf58291d811cf119003fab
Gerrit-Change-Number: 42441
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 20 Mar 2026 21:08:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42437?usp=email )
Change subject: library/HTTP_Adapter: bail out early on failure
......................................................................
library/HTTP_Adapter: bail out early on failure
Replace `self.stop` with `Misc_Helpers.f_shutdown()`, and add it after
existing `setverdict(fail, ...)` calls that previously fell through.
In all these cases there is no meaningful way to continue: the caller
of these functions usually expects a valid value to be returned, and
continuing (not stopping) oftentimes results in confusing DTEs.
Change-Id: I229028d551d5cf9651e6e65314cd40f414bfe235
---
M library/HTTP_Adapter.ttcn
1 file changed, 9 insertions(+), 4 deletions(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/library/HTTP_Adapter.ttcn b/library/HTTP_Adapter.ttcn
index 161ca23..bd34a5f 100644
--- a/library/HTTP_Adapter.ttcn
+++ b/library/HTTP_Adapter.ttcn
@@ -16,6 +16,7 @@
import from HTTPmsg_Types all;
import from HTTPmsg_PortType all;
import from Native_Functions all;
+import from Misc_Helpers all;
type component http_CT {
port HTTPmsg_PT HTTP;
@@ -82,6 +83,7 @@
/* Make sure we never use body or binary_body at the same time */
if (not istemplatekind(body, "omit") and not istemplatekind(binary_body, "omit")) {
setverdict(fail, "use wither (ascii) body or binary_body");
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
}
/* Build default header */
@@ -198,7 +200,7 @@
/* The user is expected to either pass global http_pars with on initialization (f_http_init) or
* to pass individual http_pars with each request. */
setverdict(fail, "no HTTP parameters set");
- self.stop;
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
}
/* Use globally set HTTP parameters */
use_http_pars := valueof(g_http_pars);
@@ -215,11 +217,11 @@
[] HTTP.receive(Connect_result:?) -> value rc;
[] HTTP.receive {
setverdict(fail, "HTTP connection to client failed");
- self.stop;
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
}
[] T.timeout {
setverdict(fail, "Timeout waiting for completion of HTTP connection");
- self.stop;
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
}
}
use_client_id := rc.client_id;
@@ -243,6 +245,7 @@
custom_hdr := custom_hdr, client_id := use_client_id));
} else {
setverdict(fail, "either binary_body or body must be used (a request can contain either ASCII data or binary data, not both!");
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
}
}
@@ -260,13 +263,15 @@
}
[] HTTP.receive(tr_HTTP_Resp) -> value resp {
setverdict(fail, "Unexpected HTTP response ", resp);
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
}
[] HTTP.receive(tr_HTTP_Resp_Bin) -> value resp {
setverdict(fail, "Unexpected (binary) HTTP response ", resp);
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
}
[] T.timeout {
setverdict(fail, "Timeout waiting for HTTP response");
- self.stop;
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
}
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42437?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I229028d551d5cf9651e6e65314cd40f414bfe235
Gerrit-Change-Number: 42437
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: Hoernchen, lynxis lazus.
laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224?usp=email )
Change subject: irq: make default IRQ handler Dummy_Handler weak
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> I would like to keep the changes to the atmel start code as minimal as possible. […]
I agree that we should keep changes to ASF code minimal.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I544e9c84dd538bb744fb799904adc58f9d850465
Gerrit-Change-Number: 42224
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Fri, 20 Mar 2026 20:34:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: Hoernchen, lynxis lazus.
laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42163?usp=email )
Change subject: main: rework panic handler
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
Patchset:
PS6:
> The WDT reset reason would require to set up the WDT before, right? […]
I agree it is nice to be able to distinguish a power-on reset from a WDT reset. In theory the RCAUSE register should differentiate between a POR (power on reset) and a SYST(em reset). Or is that again broken by some errata? I couldn't find any reference to that. @ewild@sysmocom.de please clarify.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42163?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I91c732001e848ec5509bf81af8aac1a2a80eb718
Gerrit-Change-Number: 42163
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: mschramm <mschramm(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Fri, 20 Mar 2026 20:34:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-uecups/+/42457?usp=email )
Change subject: cups_client: Add commands to perform IPv6 SLAAC and obtain GTP tunnel IPv6 global info
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/42457?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-uecups
Gerrit-Branch: master
Gerrit-Change-Id: I917b5c70f143d48b55b4e270e24594d1a36f71aa
Gerrit-Change-Number: 42457
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 20 Mar 2026 20:26:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes