fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42538?usp=email )
Change subject: docs/card-key-provider: fix heading levels and typo
......................................................................
docs/card-key-provider: fix heading levels and typo
The "ADM PIN" and "SCP02 / SCP03" sub-sections of "Field naming" used
the '~' heading character, which Sphinx resolved to level 4 - skipping
level 3 and throwing build ERRORs. As a result, both sub-sections
had no heading at all. Change both to '^' (level 3) to match the
other sub-sections in this file.
While at it, fix a typo: "consisting if" -> "consisting of".
Change-Id: Ia56efc7fadcc0fd62e87e63850b929d2f80851ba
---
M docs/card-key-provider.rst
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/38/42538/1
diff --git a/docs/card-key-provider.rst b/docs/card-key-provider.rst
index 16ac105..702e363 100644
--- a/docs/card-key-provider.rst
+++ b/docs/card-key-provider.rst
@@ -305,16 +305,16 @@
ADM PIN
-~~~~~~~
+^^^^^^^
The `verify_adm` command will attempt to look up the `ADM1` column
indexed by the ICCID of the SIM/UICC.
SCP02 / SCP03
-~~~~~~~~~~~~~
+^^^^^^^^^^^^^
-SCP02 and SCP03 each use key triplets consisting if ENC, MAC and DEK
+SCP02 and SCP03 each use key triplets consisting of ENC, MAC and DEK
keys. For more details, see the applicable GlobalPlatform
specifications.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42538?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ia56efc7fadcc0fd62e87e63850b929d2f80851ba
Gerrit-Change-Number: 42538
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42539?usp=email )
Change subject: docs/shell: fix copy-paste typos in editor command descriptions
......................................................................
docs/shell: fix copy-paste typos in editor command descriptions
Two adjacent commands (`edit_record_decoded`, `edit_binary_decoded`)
had identical copy-pasted error messages with three typos each:
"modificatiosn" -> "modifications"
"us the" -> "use the"
"comamdn" -> "command"
Change-Id: Ie23baba4634e2cc40f81439fb11b102778aed1f6
---
M docs/shell.rst
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/39/42539/1
diff --git a/docs/shell.rst b/docs/shell.rst
index 7cef71f..0dc00ba 100644
--- a/docs/shell.rst
+++ b/docs/shell.rst
@@ -602,8 +602,8 @@
If this command fails before the editor is spawned, it means that the current record contents is not decodable,
and you should use the :ref:`update_record_decoded` or :ref:`update_record` command.
-If this command fails after making your modificatiosn in the editor, it means that the new file contents is not
-encodable; please check your input and/or us the raw :ref:`update_record` comamdn.
+If this command fails after making your modifications in the editor, it means that the new file contents is not
+encodable; please check your input and/or use the raw :ref:`update_record` command.
decode_hex
@@ -708,8 +708,8 @@
If this command fails before the editor is spawned, it means that the current file contents is not decodable,
and you should use the :ref:`update_binary_decoded` or :ref:`update_binary` command.
-If this command fails after making your modificatiosn in the editor, it means that the new file contents is not
-encodable; please check your input and/or us the raw :ref:`update_binary` comamdn.
+If this command fails after making your modifications in the editor, it means that the new file contents is not
+encodable; please check your input and/or use the raw :ref:`update_binary` command.
decode_hex
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42539?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie23baba4634e2cc40f81439fb11b102778aed1f6
Gerrit-Change-Number: 42539
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42540?usp=email )
Change subject: docs/saip-tool: fix typo "insertaion" -> "insertion"
......................................................................
docs/saip-tool: fix typo "insertaion" -> "insertion"
Change-Id: Ie9c9235ec964a15fab19d6ca5a83b2b1ddf07e7b
---
M docs/saip-tool.rst
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/40/42540/1
diff --git a/docs/saip-tool.rst b/docs/saip-tool.rst
index 347d430..32707bf 100644
--- a/docs/saip-tool.rst
+++ b/docs/saip-tool.rst
@@ -67,7 +67,7 @@
To inspect the application PE contents of an existing profile package, sub-command `info` with parameter '--apps' can
be used. This command lists out all application and their parameters in detail. This allows an application developer
-to check if the applet insertaion was carried out as expected.
+to check if the applet insertion was carried out as expected.
Example: Listing applications and their parameters
::
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42540?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie9c9235ec964a15fab19d6ca5a83b2b1ddf07e7b
Gerrit-Change-Number: 42540
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42542?usp=email )
Change subject: docs/put_key-tutorial: fix three typos
......................................................................
docs/put_key-tutorial: fix three typos
"verifiation" -> "verification"
"this is identifies" -> "this identifies" (extra word)
"and and" -> "and" (doubled word)
Change-Id: I1ae6b01638cc2c3dd8355ba801f85cc179ca8bd3
---
M docs/put_key-tutorial.rst
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/42/42542/1
diff --git a/docs/put_key-tutorial.rst b/docs/put_key-tutorial.rst
index 400a094..fe49729 100644
--- a/docs/put_key-tutorial.rst
+++ b/docs/put_key-tutorial.rst
@@ -404,7 +404,7 @@
+-----------+-------------------------------------------------------+
| 113 | Receipt key (DES) |
+-----------+-------------------------------------------------------+
-| 115 | DAP verifiation key (RS public or DES) |
+| 115 | DAP verification key (RS public or DES) |
+-----------+-------------------------------------------------------+
| 116 | reserved for CASD |
+-----------+-------------------------------------------------------+
@@ -493,7 +493,7 @@
argument that sets the algorithm correctly (`des` in this case).
Finally we have to target the keyset we want to rotate by its KVN. The `--old-key-version-nr` argument is set to 112
-as this is identifies the keyset we want to rotate. The `--key-version-nr` is also set to 112 as we do not want to the
+as this identifies the keyset we want to rotate. The `--key-version-nr` is also set to 112 as we do not want
KVN to be changed in this example. Changing the KVN while rotating a keyset is possible. In case the KVN has to change
for some reason, the new KVN must be selected carefully to keep the key usable with the associated Secure Channel
Protocol.
@@ -538,7 +538,7 @@
In the following we will discuss how to add an entirely new keyset. The procedure is almost identical with the key
rotation procedure we have already discussed and it is assumed that all details about the key rotation are understood.
-In this section we will go into more detail and and illustrate how to provision new 3DES, `AES128` and `AES256` keysets.
+In this section we will go into more detail and illustrate how to provision new 3DES, `AES128` and `AES256` keysets.
It is important to keep in mind that storage space on smartcard is a precious resource. In many cases the amount of
keysets that a Security Domain can store is limited. In some situations you may be forced to sacrifice one of your
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42542?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I1ae6b01638cc2c3dd8355ba801f85cc179ca8bd3
Gerrit-Change-Number: 42542
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42543?usp=email )
Change subject: docs/conf.py: silence autosectionlabel duplicate-label warnings
......................................................................
docs/conf.py: silence autosectionlabel duplicate-label warnings
sphinxarg.ext generates generic sub-headings ("Named arguments",
"Positional arguments", "Sub-commands", "General options", ...) for
every argparse command and tool. These repeat across many files and
trigger large numbers of autosectionlabel duplicate-label warnings.
Two-pronged fix:
* `autosectionlabel_maxdepth = 3` eliminates the depth-4+ warnings
(sub-headings inside each individual command block).
* `suppress_warnings` per file silences the residual depth-3 collisions
("serial reader", "decode_hex", "sub-commands", ...) that still
appear across tool documentation files.
Cross-references into these generic argparse-generated sections are not
a supported use-case, so suppressing the warnings is appropriate.
Change-Id: I9cdf2a4f6cbd435b16b90ab668205600ffd7c3b0
---
M docs/conf.py
1 file changed, 20 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/43/42543/1
diff --git a/docs/conf.py b/docs/conf.py
index ef40070..13a66e5 100644
--- a/docs/conf.py
+++ b/docs/conf.py
@@ -64,3 +64,23 @@
html_static_path = ['_static']
autoclass_content = 'both'
+
+# sphinxarg.ext generates generic sub-headings ("Named arguments",
+# "Positional arguments", "Sub-commands", "General options", …) for every
+# argparse command/tool. These repeat across many files and trigger masses
+# of autosectionlabel duplicate-label warnings.
+#
+# autosectionlabel_maxdepth = 3 eliminates most of them (depth-4+ sub-headings
+# inside each command block), but cross-file collisions at depth 3 ("serial
+# reader", "decode_hex", etc.) still slip through. Suppress the residual
+# warnings per-file; cross-references into these sections are not a supported
+# use-case.
+autosectionlabel_maxdepth = 3
+suppress_warnings = [
+ 'autosectionlabel.saip-tool',
+ 'autosectionlabel.shell',
+ 'autosectionlabel.smpp2sim',
+ 'autosectionlabel.smpp-ota-tool',
+ 'autosectionlabel.suci-keytool',
+ 'autosectionlabel.trace',
+]
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42543?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9cdf2a4f6cbd435b16b90ab668205600ffd7c3b0
Gerrit-Change-Number: 42543
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42536?usp=email )
Change subject: m3ua: m3ua_gen_error_msg(): include Routing Context IE in cause Invalid Routing Context
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42536?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: If821109701e315d17f5334c680670ea6c7bce3bd
Gerrit-Change-Number: 42536
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 30 Mar 2026 13:06:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42534?usp=email )
Change subject: osmo_ss7_find_free_{rctx,l_rk_id}(): Make more robust to wrap-around
......................................................................
Patch Set 1:
(1 comment)
File src/ss7_instance.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42534/comment/72796318_d9d93… :
PS1, Line 261: } while (rctx != next_rctx);
looks like if all rctx are used, this would loop forever. maybe worth checking for this and aborting? same below.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42534?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ie10f4048d0af384dc84c79e6fc441c8537649d55
Gerrit-Change-Number: 42534
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 30 Mar 2026 13:03:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No