March 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ccid-firmware[master]: firmware: fix timers, add missing return
by Hoernchen 30 Mar '26

30 Mar '26

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42544?usp=email ) Change subject: firmware: fix timers, add missing return ...................................................................... firmware: fix timers, add missing return Change-Id: I5b12284c88d8fe6e4fe55cc4cd2aad550d276af4 --- M sysmoOCTSIM/libosmo_emb.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/44/42544/1 diff --git a/sysmoOCTSIM/libosmo_emb.c b/sysmoOCTSIM/libosmo_emb.c index 37f6126..e96f88e 100644 --- a/sysmoOCTSIM/libosmo_emb.c +++ b/sysmoOCTSIM/libosmo_emb.c @@ -21,7 +21,7 @@ uint64_t get_jiffies(void) { - ldrd_u64(&jiffies); + return ldrd_u64(&jiffies); } void store_jiffies(uint64_t j) -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42544?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I5b12284c88d8fe6e4fe55cc4cd2aad550d276af4 Gerrit-Change-Number: 42544 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>

1 0

[S] Change in pysim[master]: docs/conf.py: silence autosectionlabel duplicate-label warnings
by fixeria 30 Mar '26

30 Mar '26

fixeria has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/pysim/+/42543?usp=email ) Change subject: docs/conf.py: silence autosectionlabel duplicate-label warnings ...................................................................... docs/conf.py: silence autosectionlabel duplicate-label warnings sphinxarg.ext generates generic sub-headings ("Named arguments", "Positional arguments", "Sub-commands", "General options", ...) for every argparse command and tool. These repeat across many files and trigger large numbers of autosectionlabel duplicate-label warnings. Two-pronged fix: * `autosectionlabel_maxdepth = 3` eliminates the depth-4+ warnings (sub-headings inside each individual command block). * `suppress_warnings` per file silences the residual depth-3 collisions ("serial reader", "decode_hex", "sub-commands", ...) that still appear across tool documentation files. Cross-references into these generic argparse-generated sections are not a supported use-case, so suppressing the warnings is appropriate. Change-Id: I9cdf2a4f6cbd435b16b90ab668205600ffd7c3b0 --- M docs/conf.py 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/43/42543/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42543?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9cdf2a4f6cbd435b16b90ab668205600ffd7c3b0 Gerrit-Change-Number: 42543 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder

1 0

[M] Change in libosmo-sigtran[master]: asp: Configure block and shutdown adm state independently
by osmith 30 Mar '26

30 Mar '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42528?usp=email ) Change subject: asp: Configure block and shutdown adm state independently ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42528/comment/c8bf8f02_80a17… : PS1, Line 14: > It will be soon, so easily findable around same git history 😊 Acknowledged -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42528?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3ab81a4f6f6b72015c5068d5a27128642622cf99 Gerrit-Change-Number: 42528 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 30 Mar 2026 13:43:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: osmo_ss7_find_free_{rctx,l_rk_id}(): Make more robust to wrap-around
by osmith 30 Mar '26

30 Mar '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42534?usp=email ) Change subject: osmo_ss7_find_free_{rctx,l_rk_id}(): Make more robust to wrap-around ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/ss7_instance.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42534/comment/156f1598_adfb3… : PS1, Line 261: } while (rctx != next_rctx); > Not sure what you mean. […] uh yes, I didn't read it properly... looking at it again: LGTM -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42534?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ie10f4048d0af384dc84c79e6fc441c8537649d55 Gerrit-Change-Number: 42534 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 30 Mar 2026 13:42:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bts[master]: struct trx_power_params: fix inaccurate comment
by fixeria 30 Mar '26

30 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/42525?usp=email ) Change subject: struct trx_power_params: fix inaccurate comment ...................................................................... struct trx_power_params: fix inaccurate comment Change-Id: I1bdb7fab24fee28dbeac0ed05e13f650e08c98e9 Fixes: 4c632421 ("bts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSED") --- M include/osmo-bts/tx_power.h 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/include/osmo-bts/tx_power.h b/include/osmo-bts/tx_power.h index 52c02f5..6327c62 100644 --- a/include/osmo-bts/tx_power.h +++ b/include/osmo-bts/tx_power.h @@ -60,7 +60,7 @@ struct osmo_timer_list step_timer; /* call-back called when target is reached */ ramp_compl_cb_t compl_cb; - /* set to true after compl_cb has been called (ramp target confirmed by hardware) */ + /* set to true just before compl_cb is called (ramp target confirmed by hardware) */ bool complete; } ramp; }; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42525?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1bdb7fab24fee28dbeac0ed05e13f650e08c98e9 Gerrit-Change-Number: 42525 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bts[master]: struct trx_power_params: fix inaccurate comment
by pespin 30 Mar '26

30 Mar '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42525?usp=email ) Change subject: struct trx_power_params: fix inaccurate comment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42525?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1bdb7fab24fee28dbeac0ed05e13f650e08c98e9 Gerrit-Change-Number: 42525 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 30 Mar 2026 13:41:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: osmo_ss7_find_free_{rctx,l_rk_id}(): Make more robust to wrap-around
by pespin 30 Mar '26

30 Mar '26

Attention is currently required from: osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42534?usp=email ) Change subject: osmo_ss7_find_free_{rctx,l_rk_id}(): Make more robust to wrap-around ...................................................................... Patch Set 1: (1 comment) File src/ss7_instance.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42534/comment/3e90f105_c9104… : PS1, Line 261: } while (rctx != next_rctx); > looks like if all rctx are used, this would loop forever. […] Not sure what you mean. After uint32 iterations (supposing all are in use), the while loop will exit here. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42534?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ie10f4048d0af384dc84c79e6fc441c8537649d55 Gerrit-Change-Number: 42534 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 30 Mar 2026 13:40:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: OBS: nightly: add ".0" after versions on git tags
by osmith 30 Mar '26

30 Mar '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/42535?usp=email ) Change subject: OBS: nightly: add ".0" after versions on git tags ...................................................................... OBS: nightly: add ".0" after versions on git tags Fix that with the current logic of generating version numbers for nightly, a version done on a tag can be higher than the following version: on tag: 1.14.0.202603231800 on tag (with this patch): 1.14.0.0.202603231800 next commit after the tag: 1.14.0.1.abcd.202603241800 Fixes: OS#6981 Change-Id: Id140d8ea76bf98357711587a9909d54097250fd6 --- M scripts/obs/lib/srcpkg.py 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/scripts/obs/lib/srcpkg.py b/scripts/obs/lib/srcpkg.py index b3e0422..8ed50df 100644 --- a/scripts/obs/lib/srcpkg.py +++ b/scripts/obs/lib/srcpkg.py @@ -106,6 +106,12 @@ if ":" in ret: ret = ret.split(":")[1] + # Nightly: add a ".0" after the version if the current commit is on a + # version tag, so the next version is higher (OS#6981) + if lib.args.feed == "nightly": + while ret.count(".") < 3: + ret += ".0" + # Append the conflict_version to increase the version even if the commit # did not change (OS#5135) conflict_version = lib.args.conflict_version -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42535?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id140d8ea76bf98357711587a9909d54097250fd6 Gerrit-Change-Number: 42535 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: OBS: nightly: add ".0" after versions on git tags
by pespin 30 Mar '26

30 Mar '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42535?usp=email ) Change subject: OBS: nightly: add ".0" after versions on git tags ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42535?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id140d8ea76bf98357711587a9909d54097250fd6 Gerrit-Change-Number: 42535 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 30 Mar 2026 13:40:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: asp: Configure block and shutdown adm state independently
by pespin 30 Mar '26

30 Mar '26

Attention is currently required from: osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42528?usp=email ) Change subject: asp: Configure block and shutdown adm state independently ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42528/comment/0cf15dd6_990d2… : PS1, Line 14: > Maybe note here again that blocking is not implemented yet? It will be soon, so easily findable around same git history 😊 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42528?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3ab81a4f6f6b72015c5068d5a27128642622cf99 Gerrit-Change-Number: 42528 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 30 Mar 2026 13:39:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log March 2026