Attention is currently required from: Hoernchen, fixeria, laforge, osmith, pespin.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email )
Change subject: build: install common/GSM/transceiver libraries for emscripten and add pkg-config files
......................................................................
Patch Set 3:
(1 comment)
File configure.ac:
https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/84a05183_f042cc8e?usp… :
PS3, Line 307: PKG_CHECK_MODULES(FFTWF, fftw3f)
> fftw3.h is being included in Transceiver52M/arch/common/fft.c , and then fft. […]
For the Emscripten build, fft.c is explicitly disabled and not compiled at all.
As a result, fftw3 is not required in that configuration. The WebAssembly target does not rely on the FFTW3-based implementation.
So while those headers are present in the native build, they are not part of the compilation unit when targeting Emscripten.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I2495c5b5c79f2fe74bef83902058e1d2207c1f3c
Gerrit-Change-Number: 42243
Gerrit-PatchSet: 3
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 03 Mar 2026 18:37:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: Hoernchen, fixeria, laforge, osmith, pespin.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email )
Change subject: build: install common/GSM/transceiver libraries for emscripten and add pkg-config files
......................................................................
Patch Set 3:
(1 comment)
File CommonLibs/Makefile.am:
https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/094b974d_673ab709?usp… :
PS3, Line 56: lib_LTLIBRARIES = libcommon.la
> This is not intended for the regular native build. […]
As another option, I could introduce a device driver called `osmo-trx-web`, but implement it as a library rather than a standalone binary.
This library would include all the required parts from `osmo-trx` and provide the necessary integration for the WebAssembly build.
The only caveat is that it would no longer be a traditional `RadioDevice` subclass, since in this model it wouldn’t represent a hardware-backed radio device but rather a web-integrated transport/runtime component.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I2495c5b5c79f2fe74bef83902058e1d2207c1f3c
Gerrit-Change-Number: 42243
Gerrit-PatchSet: 3
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 03 Mar 2026 18:09:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>
Attention is currently required from: Hoernchen, fixeria, laforge, osmith, pespin.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email )
Change subject: build: install common/GSM/transceiver libraries for emscripten and add pkg-config files
......................................................................
Patch Set 3:
(1 comment)
File CommonLibs/Makefile.am:
https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/096fab28_b81b36a5?usp… :
PS3, Line 56: lib_LTLIBRARIES = libcommon.la
> By doing this, you are installing the libraries, which is something we don't wanna do.
This is not intended for the regular native build.
The idea is to enable this only for the Emscripten/WebAssembly build, where we intentionally combine parts of `osmo-bts-trx` and `osmo-trx` into a single target. In that scenario, we are not installing system-wide libraries in the traditional sense — we just need proper linkage metadata to consume those components during the unified build.
For normal native builds, nothing would change and no additional libraries would be installed.
If installing the libraries is not acceptable even conditionally, perhaps you could suggest a preferred way to make the internal components linkable when building `osmo-bts-trx` and `osmo-trx` together as a single target? I'm open to structuring it in a way that fits the project’s expectations.
As an alternative, I could create a separate library specifically for the Emscripten build that would include only the source files required from osmo-trx.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I2495c5b5c79f2fe74bef83902058e1d2207c1f3c
Gerrit-Change-Number: 42243
Gerrit-PatchSet: 3
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 03 Mar 2026 17:52:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
pespin has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42221?usp=email )
Change subject: tcap: Use osmo_asn1_tcap_set_talloc_ctx() to set app talloc ctx
......................................................................
Abandoned
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42221?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I9c1abc040fdeb58cb97e9b99a2382f336146bc40
Gerrit-Change-Number: 42221
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Attention is currently required from: Hoernchen, Timur Davydov, fixeria, laforge, osmith.
pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email )
Change subject: build: install common/GSM/transceiver libraries for emscripten and add pkg-config files
......................................................................
Patch Set 3:
(5 comments)
File CommonLibs/Makefile.am:
https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/32d0c1e0_84eec133?usp… :
PS3, Line 56: lib_LTLIBRARIES = libcommon.la
By doing this, you are installing the libraries, which is something we don't wanna do.
File GSM/Makefile.am:
https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/c6e2181f_a4fd25ed?usp… :
PS3, Line 29: gsm_headers = \
You are now also installing headers which shouldn't be installed afaiu.
File configure.ac:
https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/cffc163a_9ac32661?usp… :
PS3, Line 82: AC_DISABLE_SHARED dnl don't build shared libraries (emscripten)
I changed this, see my patchset in https://gerrit.osmocom.org/c/osmo-trx/+/42252/https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/e94559b7_a07b4618?usp… :
PS3, Line 306: PKG_CHECK_MODULES(LIBUSB, libusb-1.0)
See "https://gerrit.osmocom.org/c/osmo-trx/+/42255 Drop libusb dependency"
https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/1382e3c6_37796f00?usp… :
PS3, Line 307: PKG_CHECK_MODULES(FFTWF, fftw3f)
fftw3.h is being included in Transceiver52M/arch/common/fft.c , and then fft.h is being included by:
Transceiver52M/Channelizer.cpp
33:#include "fft.h"
Transceiver52M/ChannelizerBase.cpp
34:#include "fft.h"
Transceiver52M/ChannelizerBase.h
22: struct fft_hdl *fftHandle;
Transceiver52M/Synthesis.cpp
34:#include "fft.h"
How are you supposed to be building without all that?
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I2495c5b5c79f2fe74bef83902058e1d2207c1f3c
Gerrit-Change-Number: 42243
Gerrit-PatchSet: 3
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Comment-Date: Tue, 03 Mar 2026 16:42:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: lynxis lazus.
csaba.sipos has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42246?usp=email )
Change subject: nokia_site: Add new BTS types to the list
......................................................................
Patch Set 1:
(1 comment)
File src/osmo-bsc/bts_nokia_site.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/42246/comment/46f81cbb_1d3dc675?usp… :
PS1, Line 584: 800
> Maybe add an additional comment describing that these are the product names and it is 850 MHz.
I am not inventing (nor fixing) Nokia product names.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42246?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia0dbbf148394d8205dc9219b41cfba3cf62bdeaa
Gerrit-Change-Number: 42246
Gerrit-PatchSet: 1
Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Tue, 03 Mar 2026 16:42:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Comment-In-Reply-To: csaba.sipos <metro4(a)freemail.hu>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>