March 2026 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: transitional name mapping
by neels 04 Mar '26

04 Mar '26

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41919?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: transitional name mapping ...................................................................... transitional name mapping To help existing applications transition to a common naming scheme for the SdKey classes, offer this intermediate result, where the SdKey classes' .name are still unchanged as before generating them. Change-Id: I974cb6c393a2ed2248a6240c2722d157e9235c33 --- M pySim/esim/saip/personalization.py 1 file changed, 26 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/19/41919/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41919?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I974cb6c393a2ed2248a6240c2722d157e9235c33 Gerrit-Change-Number: 41919 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>

1 0

[S] Change in pysim[master]: remove transitional name mapping
by neels 04 Mar '26

04 Mar '26

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42258?usp=email ) Change subject: remove transitional name mapping ...................................................................... remove transitional name mapping This reverts commit I974cb6c393a2ed2248a6240c2722d157e9235c33 Now, finally, all SdKey classes have a unified logical naming scheme. Change-Id: Ic185af4a903c2211a5361d023af9e7c6fc57ae78 --- M pySim/esim/saip/personalization.py 1 file changed, 0 insertions(+), 26 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/58/42258/1 diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py index 400a9c4..b28d88e 100644 --- a/pySim/esim/saip/personalization.py +++ b/pySim/esim/saip/personalization.py @@ -760,30 +760,6 @@ SdKey.all_implementations = [] - transitional_name_mapping = { - 'SCP02-KVN20-AES-DEK': 'SCP02-20-AES-DEK', - 'SCP02-KVN20-AES-ENC': 'SCP02-20-AES-ENC', - 'SCP02-KVN20-AES-MAC': 'SCP02-20-AES-MAC', - 'SCP02-KVN21-AES-DEK': 'SCP02-21-AES-DEK', - 'SCP02-KVN21-AES-ENC': 'SCP02-21-AES-ENC', - 'SCP02-KVN21-AES-MAC': 'SCP02-21-AES-MAC', - 'SCP02-KVN22-AES-DEK': 'SCP02-22-AES-DEK', - 'SCP02-KVN22-AES-ENC': 'SCP02-22-AES-ENC', - 'SCP02-KVN22-AES-MAC': 'SCP02-22-AES-MAC', - 'SCP02-KVNff-AES-DEK': 'SCP02-ff-AES-DEK', - 'SCP02-KVNff-AES-ENC': 'SCP02-ff-AES-ENC', - 'SCP02-KVNff-AES-MAC': 'SCP02-ff-AES-MAC', - 'SCP03-KVN30-AES-DEK': 'SCP03-30-AES-DEK', - 'SCP03-KVN30-AES-ENC': 'SCP03-30-AES-ENC', - 'SCP03-KVN30-AES-MAC': 'SCP03-30-AES-MAC', - 'SCP03-KVN31-AES-DEK': 'SCP03-31-AES-DEK', - 'SCP03-KVN31-AES-ENC': 'SCP03-31-AES-ENC', - 'SCP03-KVN31-AES-MAC': 'SCP03-31-AES-MAC', - 'SCP03-KVN32-AES-DEK': 'SCP03-32-AES-DEK', - 'SCP03-KVN32-AES-ENC': 'SCP03-32-AES-ENC', - 'SCP03-KVN32-AES-MAC': 'SCP03-32-AES-MAC', - } - def camel(s): return s[:1].upper() + s[1:].lower() @@ -815,8 +791,6 @@ max_key_len = attrs.get('allow_len')[-1] - cls_label = transitional_name_mapping.get(cls_label, cls_label) - attrs.update({ 'name' : cls_label, 'kvn': kvn, -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42258?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic185af4a903c2211a5361d023af9e7c6fc57ae78 Gerrit-Change-Number: 42258 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: UppAudit: better indicate exception cause
by neels 04 Mar '26

04 Mar '26

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42259?usp=email ) Change subject: UppAudit: better indicate exception cause ...................................................................... UppAudit: better indicate exception cause Change-Id: I4d986b89a473a5b12ed56b4710263b034876a33e --- M pySim/esim/saip/batch.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/59/42259/1 diff --git a/pySim/esim/saip/batch.py b/pySim/esim/saip/batch.py index 48e2d05..5b17e59 100644 --- a/pySim/esim/saip/batch.py +++ b/pySim/esim/saip/batch.py @@ -164,7 +164,7 @@ try: for valdict in param.get_values_from_pes(pes): upp_audit.add_values(valdict) - except (TypeError, ValueError) as e: + except Exception as e: raise ValueError(f'Error during audit for parameter {param}: {e}') from e if not additional_sd_keys: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42259?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4d986b89a473a5b12ed56b4710263b034876a33e Gerrit-Change-Number: 42259 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

1 0

[S] Change in pysim[master]: ConfigurableParameter: safer val length check
by neels 04 Mar '26

04 Mar '26

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42260?usp=email ) Change subject: ConfigurableParameter: safer val length check ...................................................................... ConfigurableParameter: safer val length check Change-Id: Ibe91722ed1477b00d20ef5e4e7abd9068ff2f3e4 --- M pySim/esim/saip/personalization.py 1 file changed, 12 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/60/42260/1 diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py index b28d88e..7d24453 100644 --- a/pySim/esim/saip/personalization.py +++ b/pySim/esim/saip/personalization.py @@ -191,19 +191,25 @@ elif isinstance(val, io.BytesIO): val = val.getvalue() + if hasattr(val, '__len__'): + val_len = len(val) + else: + # e.g. int length + val_len = len(str(val)) + if cls.allow_len is not None: l = cls.allow_len # cls.allow_len could be one int, or a tuple of ints. Wrap a single int also in a tuple. if not isinstance(l, (tuple, list)): l = (l,) - if len(val) not in l: - raise ValueError(f'length must be one of {cls.allow_len}, not {len(val)}: {val!r}') + if val_len not in l: + raise ValueError(f'length must be one of {cls.allow_len}, not {val_len}: {val!r}') if cls.min_len is not None: - if len(val) < cls.min_len: - raise ValueError(f'length must be at least {cls.min_len}, not {len(val)}: {val!r}') + if val_len < cls.min_len: + raise ValueError(f'length must be at least {cls.min_len}, not {val_len}: {val!r}') if cls.max_len is not None: - if len(val) > cls.max_len: - raise ValueError(f'length must be at most {cls.max_len}, not {len(val)}: {val!r}') + if val_len > cls.max_len: + raise ValueError(f'length must be at most {cls.max_len}, not {val_len}: {val!r}') return val @classmethod -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42260?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibe91722ed1477b00d20ef5e4e7abd9068ff2f3e4 Gerrit-Change-Number: 42260 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

1 0

[S] Change in pysim[master]: saip: SmspTpScAddr: fix get_values_from_pes
by neels 04 Mar '26

04 Mar '26

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42261?usp=email ) Change subject: saip: SmspTpScAddr: fix get_values_from_pes ...................................................................... saip: SmspTpScAddr: fix get_values_from_pes Change-Id: I2010305340499c907bb7618c04c61e194db34814 --- M pySim/esim/saip/personalization.py 1 file changed, 24 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/61/42261/1 diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py index 7d24453..de6e6ce 100644 --- a/pySim/esim/saip/personalization.py +++ b/pySim/esim/saip/personalization.py @@ -554,21 +554,39 @@ example_input = '+49301234567' default_source = param_source.ConstantSource - @classmethod - def validate_val(cls, val): - val = super().validate_val(val) - addr_str = str(val) + @staticmethod + def str_to_tuple(addr_str): if addr_str[0] == '+': digits = addr_str[1:] international = True else: digits = addr_str international = False + return (international, digits) + + @staticmethod + def tuple_to_str(addr_tuple): + international, digits = addr_tuple + if international: + ret = '+' + else: + ret = '' + ret += digits + return ret + + @classmethod + def validate_val(cls, val): + val = super().validate_val(val) + + addr_tuple = cls.str_to_tuple(str(val)) + + international, digits = addr_tuple if len(digits) > 20: raise ValueError(f'TP-SC-ADDR must not exceed 20 digits: {digits!r}') if not digits.isdecimal(): raise ValueError(f'TP-SC-ADDR must only contain decimal digits: {digits!r}') - return (international, digits) + + return addr_tuple @classmethod def apply_val(cls, pes: ProfileElementSequence, val): @@ -627,7 +645,7 @@ continue international = (international == 'international') - yield (international, digits) + yield { cls.name: cls.tuple_to_str((international, digits)) } class SdKey(BinaryParam): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42261?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2010305340499c907bb7618c04c61e194db34814 Gerrit-Change-Number: 42261 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: esim.saip.personalization: fix TLSPSK keys
by neels 04 Mar '26

04 Mar '26

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42264?usp=email ) Change subject: esim.saip.personalization: fix TLSPSK keys ...................................................................... esim.saip.personalization: fix TLSPSK keys Add AES variant of TLSPSK DEK (SCP81 KVN40 key_id=0x02). Change-Id: I713a008fd26bbfcf437e0f29717b753f058ce76a --- M pySim/esim/saip/personalization.py 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/64/42264/1 diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py index 617e936..761f0ee 100644 --- a/pySim/esim/saip/personalization.py +++ b/pySim/esim/saip/personalization.py @@ -714,7 +714,7 @@ DEK = ('DEK', dict(key_id=0x03, key_usage_qual=0x48) ) TLSPSK_PSK = ('TLSPSK', dict(key_type=KeyType.tls_psk, key_id=0x01, key_usage_qual=0x3c, allow_len=LEN_128_192_256) ) - TLSPSK_DEK = ('DEK', dict(key_type=KeyType.des, key_id=0x02, key_usage_qual=0x48, allow_len=LEN_128) ) + TLSPSK_DEK = ('DEK', dict(key_id=0x02, key_usage_qual=0xc4) ) # THIS IS THE LIST that controls which SdKeyXxx subclasses exist: SD_KEY_DEFS = ( @@ -722,7 +722,11 @@ ('SCP02', (0x20, 0x21, 0x22, 0xff), (AES, ), (ENC, MAC, DEK) ), ('SCP03', (0x30, 0x31, 0x32), (AES, ), (ENC, MAC, DEK) ), ('SCP80', (0x01, 0x02, 0x03), (DES, AES), (ENC, MAC, DEK) ), - ('SCP81', (0x40, 0x41, 0x42), (TLSPSK_PSK, TLSPSK_DEK, ), ), + + # key_id=1 + ('SCP81', (0x40, 0x41, 0x42), (TLSPSK_PSK, ), ), + # key_id=2 + ('SCP81', (0x40, 0x41, 0x42), (DES, AES), (TLSPSK_DEK, ) ), ) all_implementations = None -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42264?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I713a008fd26bbfcf437e0f29717b753f058ce76a Gerrit-Change-Number: 42264 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

1 0

[M] Change in pysim[master]: test_configurable_parameters.py: add tests for new parameters
by neels 04 Mar '26

04 Mar '26

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42262?usp=email ) Change subject: test_configurable_parameters.py: add tests for new parameters ...................................................................... test_configurable_parameters.py: add tests for new parameters For: SmspTpScAddr MilenageRotation MilenageXoringConstants TuakNrOfKeccak Change-Id: Iecbea14fe31a9ee08d871dcde7f295d26d7bd001 --- M tests/unittests/test_configurable_parameters.py 1 file changed, 65 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/62/42262/1 diff --git a/tests/unittests/test_configurable_parameters.py b/tests/unittests/test_configurable_parameters.py index fa6437f..8d31f8a 100755 --- a/tests/unittests/test_configurable_parameters.py +++ b/tests/unittests/test_configurable_parameters.py @@ -202,6 +202,71 @@ val=io.BytesIO(b'\x01\x02\x03\x04\x05\x06\x07\x08\x09\x10\x11\x12\x13\x14\x15\x16'), expect_clean_val=b'\x01\x02\x03\x04\x05\x06\x07\x08\x09\x10\x11\x12\x13\x14\x15\x16', expect_val='01020304050607080910111213141516'), + + Paramtest(param_cls=p13n.SmspTpScAddr, + val='+1234567', + expect_clean_val=(True, '1234567'), + expect_val='+1234567'), + Paramtest(param_cls=p13n.SmspTpScAddr, + val=1234567, + expect_clean_val=(False, '1234567'), + expect_val='1234567'), + + Paramtest(param_cls=p13n.TuakNumberOfKeccak, + val='123', + expect_clean_val=123, + expect_val='123'), + Paramtest(param_cls=p13n.TuakNumberOfKeccak, + val=123, + expect_clean_val=123, + expect_val='123'), + + Paramtest(param_cls=p13n.MilenageRotationConstants, + val='0a 0b 0c 01 02', + expect_clean_val=b'\x0a\x0b\x0c\x01\x02', + expect_val='0a0b0c0102'), + Paramtest(param_cls=p13n.MilenageRotationConstants, + val=b'\x0a\x0b\x0c\x01\x02', + expect_clean_val=b'\x0a\x0b\x0c\x01\x02', + expect_val='0a0b0c0102'), + Paramtest(param_cls=p13n.MilenageRotationConstants, + val=bytearray(b'\x0a\x0b\x0c\x01\x02'), + expect_clean_val=b'\x0a\x0b\x0c\x01\x02', + expect_val='0a0b0c0102'), + + Paramtest(param_cls=p13n.MilenageXoringConstants, + val='aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa' + ' bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb' + ' cccccccccccccccccccccccccccccccc' + ' 11111111111111111111111111111111' + ' 22222222222222222222222222222222', + expect_clean_val=b'\xaa' * 16 + + b'\xbb' * 16 + + b'\xcc' * 16 + + b'\x11' * 16 + + b'\x22' * 16, + expect_val='aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa' + 'bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb' + 'cccccccccccccccccccccccccccccccc' + '11111111111111111111111111111111' + '22222222222222222222222222222222'), + Paramtest(param_cls=p13n.MilenageXoringConstants, + val=b'\xaa' * 16 + + b'\xbb' * 16 + + b'\xcc' * 16 + + b'\x11' * 16 + + b'\x22' * 16, + expect_clean_val=b'\xaa' * 16 + + b'\xbb' * 16 + + b'\xcc' * 16 + + b'\x11' * 16 + + b'\x22' * 16, + expect_val='aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa' + 'bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb' + 'cccccccccccccccccccccccccccccccc' + '11111111111111111111111111111111' + '22222222222222222222222222222222'), + ] for sdkey_cls in ( -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42262?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iecbea14fe31a9ee08d871dcde7f295d26d7bd001 Gerrit-Change-Number: 42262 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: add comment about not updating existing key_usage_qualifier
by neels 04 Mar '26

04 Mar '26

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42263?usp=email ) Change subject: add comment about not updating existing key_usage_qualifier ...................................................................... add comment about not updating existing key_usage_qualifier Change-Id: Ie23ae5fde17be6b37746784bf1601b4d0874397a --- M pySim/esim/saip/personalization.py 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/63/42263/1 diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py index de6e6ce..617e936 100644 --- a/pySim/esim/saip/personalization.py +++ b/pySim/esim/saip/personalization.py @@ -678,6 +678,11 @@ ) pe.add_key(key) else: + # A key of this KVN and ID already exists in the profile. + + # Keep the key_usage_qualifier as it was in the profile, so skip this here: + # key.key_usage_qualifier = cls.key_usage_qual + key.key_components = set_components @classmethod -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42263?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie23ae5fde17be6b37746784bf1601b4d0874397a Gerrit-Change-Number: 42263 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

1 0

[L] Change in pysim[master]: personalization: add param_source.py, implement batch personalization
by neels 04 Mar '26

04 Mar '26

neels has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/40096?usp=email ) Change subject: personalization: add param_source.py, implement batch personalization ...................................................................... Abandoned I've made a mistake when squashing two commits, as a result this patch became I01ae40a06605eb205bfb409189fcd2b3a128855a now -- sorry about that -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40096?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I497c60c101ea0eea980e8b1a4b1f36c0eda39002 Gerrit-Change-Number: 40096 Gerrit-PatchSet: 10 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org>

1 0

[L] Change in pysim[master]: personalization: add param_source.py, add batch.py
by neels 04 Mar '26

04 Mar '26

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41845?usp=email to look at the new patch set (#6). Change subject: personalization: add param_source.py, add batch.py ...................................................................... personalization: add param_source.py, add batch.py Implement pySim.esim.saip.batch.BatchPersonalization, generating N eSIM profiles from a preset configuration. Batch parameters can be fed by a constant, incrementing, random or from CSV rows: add pySim.esim.saip.param_source.* classes to feed such input to each of the BatchPersonalization's ConfigurableParameter instances. Related: SYS#6768 Change-Id: I01ae40a06605eb205bfb409189fcd2b3a128855a --- A pySim/esim/saip/batch.py A pySim/esim/saip/param_source.py 2 files changed, 291 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/45/41845/6 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41845?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I01ae40a06605eb205bfb409189fcd2b3a128855a Gerrit-Change-Number: 41845 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log March 2026