Attention is currently required from: neels.
dexter has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40199?usp=email )
Change subject: personalization: allow reading back multiple values from PES
......................................................................
Patch Set 10:
(2 comments)
Patchset:
PS10:
As far as I understand, this patch only extends the patch from before so that we can read back multiple values. (I also see that this patch fixes some unrelated things from the patch before) Maybe it makes sense to squash both patches into one?
File pySim/esim/saip/personalization.py:
https://gerrit.osmocom.org/c/pysim/+/40199/comment/2be3fe1e_9d30e01f?usp=em… :
PS10, Line 209: def get_values_from_pes(cls, pes: ProfileElementSequence) -> Generator:
Ah, ok here you fix the comment chars. Should be ok then.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/40199?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iecb68af7c216c6b9dc3add469564416b6f37f7b2
Gerrit-Change-Number: 40199
Gerrit-PatchSet: 10
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 06 Mar 2026 12:07:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: neels.
dexter has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40198?usp=email )
Change subject: personalization: implement reading back values from a PES
......................................................................
Patch Set 11: Code-Review+1
(5 comments)
Patchset:
PS11:
I think this patch looks ok. I would recommend to look at decimal_hex_to_str() a bit more closely to make sure it actually does the right thing.
File pySim/esim/saip/personalization.py:
https://gerrit.osmocom.org/c/pysim/+/40198/comment/37303680_0841eeb4?usp=em… :
PS11, Line 209: def get_values_from_pes(cls, pes: ProfileElementSequence) -> Generator:
As far as I understand ''' just marks a multiline comment, but shouldn't this be a doctstring?
https://gerrit.osmocom.org/c/pysim/+/40198/comment/df8adf24_6dd87150?usp=em… :
PS11, Line 290: def decimal_hex_to_str(cls, val):
also have not seen single quotes as comment chars before...
https://gerrit.osmocom.org/c/pysim/+/40198/comment/7ddc4bfe_68a1a8c5?usp=em… :
PS11, Line 292: if isinstance(val, bytes):
Is it always ensured that we won't get sometimes bytes and sometimes bytearrays?
https://gerrit.osmocom.org/c/pysim/+/40198/comment/501ac867_7f438d57?usp=em… :
PS11, Line 297: val = unrpad(val, c)
You are sure that you want to turn val to ascii, like "4141" => "AA"? (am a bit confused since the method name suggests more that the input should be a hexstring or a bytearray with decimal digits and the output should be a string with the same digits.)
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/40198?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I234fc4317f0bdc1a486f0cee4fa432c1dce9b463
Gerrit-Change-Number: 40198
Gerrit-PatchSet: 11
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 06 Mar 2026 11:54:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/42283?usp=email )
Change subject: repo-install-test: ignore pyhss
......................................................................
repo-install-test: ignore pyhss
PyHSS listens on the same port as OsmoHLR, which causes the test to fail
with debian 13 because OsmoHLR can't start up properly. PyHSS wasn't
built for earlier debian versions in the Osmocom binary repositories.
Change-Id: I796e85a212dff94fbf9b8ef563eba47418c221cc
---
M scripts/repo-install-test/run-inside.sh
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/83/42283/1
diff --git a/scripts/repo-install-test/run-inside.sh b/scripts/repo-install-test/run-inside.sh
index 88dcdda..493c29f 100755
--- a/scripts/repo-install-test/run-inside.sh
+++ b/scripts/repo-install-test/run-inside.sh
@@ -364,6 +364,9 @@
# Breaks the ssh connection to QEMU
charon-systemd*) ;;
+ # Conflicts with OsmoHLR (127.0.0.1:4222: Address already in use)
+ pyhss*) ;;
+
# All other packages are not filtered
*) echo "$i" ;;
esac
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42283?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I796e85a212dff94fbf9b8ef563eba47418c221cc
Gerrit-Change-Number: 42283
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/42280?usp=email )
Change subject: repo-install-test: fix test_conflict for debian 13
......................................................................
repo-install-test: fix test_conflict for debian 13
Two changes are necessary to make this test work with debian 13:
* Installing libosmocore from osmocom-latest, then switching to
osmocom-nightly and attempting to install another package is not
enough anymore to trigger a conflict. apt is now able to resolve this
by uninstalling the osmocom-latest package and upgrading libosmocore
to the nightly version. Force the conflict by explicitly marking
osmocom-latest (osmocom-$FEED) as installed and for hold.
* The apt conflict message has been reworked, so the string to look for
needs to be adjusted.
Change-Id: Ibdcd583e48b97ced11ad4939974dccea3e139480
---
M scripts/repo-install-test/run-inside.sh
1 file changed, 14 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/80/42280/1
diff --git a/scripts/repo-install-test/run-inside.sh b/scripts/repo-install-test/run-inside.sh
index 6937dac..836d59d 100755
--- a/scripts/repo-install-test/run-inside.sh
+++ b/scripts/repo-install-test/run-inside.sh
@@ -242,7 +242,8 @@
return
fi
- apt-get -y install libosmocore
+ apt-get -y install libosmocore osmocom-"$FEED"
+ apt-mark hold osmocom-"$FEED"
configure_osmocom_repo_debian_remove "$PROJ"
configure_osmocom_repo_debian "$PROJ_CONFLICT"
@@ -259,9 +260,18 @@
"requested an impossible situation" \
"^The following packages have unmet dependencies:"
- find_patterns_or_exit \
- /tmp/out \
- "Conflicts: osmocom-"
+ case "$DISTRO" in
+ debian11|debian12)
+ find_patterns_or_exit \
+ /tmp/out \
+ "Conflicts: osmocom-"
+ ;;
+ *)
+ find_patterns_or_exit \
+ /tmp/out \
+ "Conflicts osmocom-"
+ ;;
+ esac
configure_osmocom_repo_debian_remove "$PROJ_CONFLICT"
configure_osmocom_repo_debian "$PROJ"
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42280?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ibdcd583e48b97ced11ad4939974dccea3e139480
Gerrit-Change-Number: 42280
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/42281?usp=email )
Change subject: repo-install-test: ignore sdcc-dbgsym
......................................................................
repo-install-test: ignore sdcc-dbgsym
Fix for this error with debian 13:
The following packages have unmet dependencies:
sdcc-dbgsym : Depends: sdcc (= 4.2.0~osmocom3.113.9edd) but 4.5.0+dfsg-1 is to be installed
E: Unable to correct problems, you have held broken packages.
E: The following information from --solver 3.0 may provide additional context:
Unable to satisfy dependencies. Reached two conflicting decisions:
1. sdcc:amd64=4.2.0~osmocom3.113.9edd is not selected for install
2. sdcc:amd64=4.2.0~osmocom3.113.9edd is selected for install because:
1. sdcc-dbgsym:amd64=4.2.0~osmocom3.113.9edd is selected for install
2. sdcc-dbgsym:amd64 Depends sdcc (= 4.2.0~osmocom3.113.9edd)
Change-Id: Ibb12118853f354d177cb94df63b60dd3bd9dfcb7
---
M scripts/repo-install-test/run-inside.sh
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/81/42281/1
diff --git a/scripts/repo-install-test/run-inside.sh b/scripts/repo-install-test/run-inside.sh
index 836d59d..94bfa0e 100755
--- a/scripts/repo-install-test/run-inside.sh
+++ b/scripts/repo-install-test/run-inside.sh
@@ -340,6 +340,12 @@
librtlsdr0-dbgsym) ;;
rtl-sdr-dbgsym) ;;
+ # sdcc 4.2.0 is needed to build libusrp (OS#6748), so we build
+ # it for distros that ship a newer version. Ignore the debug
+ # package as apt tries to install it together with the newer
+ # sdcc version from debian repositories.
+ sdcc-dbgsym) ;;
+
# Depends on mongodb, which was droppend from debian 10 onwards
open5gs*) ;;
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42281?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ibb12118853f354d177cb94df63b60dd3bd9dfcb7
Gerrit-Change-Number: 42281
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/42282?usp=email )
Change subject: repo-install-test: ignore charon-systemd
......................................................................
repo-install-test: ignore charon-systemd
This package from strongswan-epdg causes the SSH connection to QEMU to
break when installed in debian 13. Don't install it. Use the wildcard,
because there is also a debug symbols package that pulls in
charon-systemd.
Change-Id: Ic641d5361c51df147a8cef5d49eb1e0f07b72e87
---
M scripts/repo-install-test/run-inside.sh
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/82/42282/1
diff --git a/scripts/repo-install-test/run-inside.sh b/scripts/repo-install-test/run-inside.sh
index 94bfa0e..88dcdda 100755
--- a/scripts/repo-install-test/run-inside.sh
+++ b/scripts/repo-install-test/run-inside.sh
@@ -361,6 +361,9 @@
# this test as downloading FPGA bitstream fails.
*bladerf*) ;;
+ # Breaks the ssh connection to QEMU
+ charon-systemd*) ;;
+
# All other packages are not filtered
*) echo "$i" ;;
esac
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42282?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ic641d5361c51df147a8cef5d49eb1e0f07b72e87
Gerrit-Change-Number: 42282
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>