March 2026 - gerrit-log - lists.osmocom.org

[XS] Change in ...pyosmocom[master]: Fix lint errors: test for membership should be `not in`
by osmith 07 Mar '26

07 Mar '26

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41386?usp=email ) Change subject: Fix lint errors: test for membership should be `not in` ...................................................................... Patch Set 3: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41386?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I2ca3135f1ce38dcc06dc95c38f4b6258a60121cd Gerrit-Change-Number: 41386 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 Mar 2026 13:19:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...pyosmocom[master]: Fix lint errors: avoid equality comparisons to `False`
by osmith 07 Mar '26

07 Mar '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41385?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: Fix lint errors: avoid equality comparisons to `False` ...................................................................... Fix lint errors: avoid equality comparisons to `False` src/osmocom/utils.py:150:8: E712 Avoid equality comparisons to `False`; use `if not signed:` for false checks | 148 | """ 149 | 150 | if signed == False and number < 0: | ^^^^^^^^^^^^^^^ E712 151 | raise ValueError("expecting a positive number") | = help: Replace with `not signed` Change-Id: I2ebb33c498b4a7e6229980462aa51b579fa4f782 --- M src/osmocom/utils.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved osmith: Verified laforge: Looks good to me, approved diff --git a/src/osmocom/utils.py b/src/osmocom/utils.py index 3991da2..7963c05 100644 --- a/src/osmocom/utils.py +++ b/src/osmocom/utils.py @@ -147,7 +147,7 @@ Integer 'nbytes', which is the number of bytes required to encode 'number' """ - if signed == False and number < 0: + if not signed and number < 0: raise ValueError("expecting a positive number") # Compute how many bytes we need for the absolute (positive) value of the given number -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41385?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I2ebb33c498b4a7e6229980462aa51b579fa4f782 Gerrit-Change-Number: 41385 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in ...pyosmocom[master]: Fix lint errors: avoid equality comparisons to `False`
by osmith 07 Mar '26

07 Mar '26

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41385?usp=email ) Change subject: Fix lint errors: avoid equality comparisons to `False` ...................................................................... Patch Set 3: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41385?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I2ebb33c498b4a7e6229980462aa51b579fa4f782 Gerrit-Change-Number: 41385 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 Mar 2026 13:19:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: {hlr,hss}/pyhss/config: remove unused options
by osmith 06 Mar '26

06 Mar '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42286?usp=email ) Change subject: {hlr,hss}/pyhss/config: remove unused options ...................................................................... {hlr,hss}/pyhss/config: remove unused options PyHSS had several unused config options. They have been removed upstream, remove them from the osmo-ttcn3-hacks configs as well. Related: https://github.com/nickvsnetworking/pyhss/pull/284 Change-Id: I87cf01e00fe0a3b32be9eaa4cf4c1ddf02cddc0b --- M hlr/pyhss/config.yaml M hss/pyhss/config.yaml 2 files changed, 0 insertions(+), 52 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/86/42286/1 diff --git a/hlr/pyhss/config.yaml b/hlr/pyhss/config.yaml index 87e6c53..61b819e 100644 --- a/hlr/pyhss/config.yaml +++ b/hlr/pyhss/config.yaml @@ -8,12 +8,6 @@ site_name: "TTCN3" MCC: "001" MNC: "01" - SLh_enabled: False - #IMSI of Test Subscriber for Unit Checks (Optional) - test_sub_imsi: '001021234567890' - - #The maximum time to wait, in seconds, before disconnecting a client when no data is received. - client_socket_timeout: 120 #The maximum time to wait, in seconds, before disconnecting a client when no data is received. client_socket_timeout: 300 @@ -39,13 +33,6 @@ #If enabled sends CLRs to old MME when new MME attaches active sub CancelLocationRequest_Enabled: False - #Workaround for some MMEs to force an Insert Subscriber Data request to be sent immediately after ULA - Insert_Subscriber_Data_Force: False - - #Default Initial Filter Criteria for IMS Subscribers - #Jinja Formatted Template, see the example for variables passed to it. - Default_iFC: 'default_ifc.xml' - #Default Sh User Data Default_Sh_UserData: 'default_sh_user_data.xml' @@ -124,11 +111,7 @@ database: db_type: sqlite server: 127.0.0.1 - username: dbeaver - password: password database: pyhss.db - readCacheEnabled: True - readCacheInterval: 60 ## External Webhook Notifications webhooks: @@ -160,18 +143,6 @@ unixSocketPath: '/var/run/redis/redis-server.sock' host: localhost port: 6379 - sentinel: - masterName: exampleMaster - hosts: - - exampleSentinel.mnc001.mcc001.3gppnetwork.org: - port: 6379 - password: '' - - -prometheus: - enabled: False - port: 8081 #If the API is run the API runs on the next port number up from this - async_subscriber_count: False #If enabled the subscriber count will be updated asynchronously for Prometheus influxdb: enabled: False diff --git a/hss/pyhss/config.yaml b/hss/pyhss/config.yaml index 3114820..c951beb 100644 --- a/hss/pyhss/config.yaml +++ b/hss/pyhss/config.yaml @@ -8,12 +8,6 @@ site_name: "TTCN3" MCC: "001" MNC: "01" - SLh_enabled: False - #IMSI of Test Subscriber for Unit Checks (Optional) - test_sub_imsi: '001021234567890' - - #The maximum time to wait, in seconds, before disconnecting a client when no data is received. - client_socket_timeout: 120 #The maximum time to wait, in seconds, before disconnecting a client when no data is received. client_socket_timeout: 300 @@ -39,13 +33,6 @@ #If enabled sends CLRs to old MME when new MME attaches active sub CancelLocationRequest_Enabled: False - #Workaround for some MMEs to force an Insert Subscriber Data request to be sent immediately after ULA - Insert_Subscriber_Data_Force: False - - #Default Initial Filter Criteria for IMS Subscribers - #Jinja Formatted Template, see the example for variables passed to it. - Default_iFC: 'default_ifc.xml' - #Default Sh User Data Default_Sh_UserData: 'default_sh_user_data.xml' @@ -121,11 +108,7 @@ database: db_type: sqlite server: 127.0.0.1 - username: dbeaver - password: password database: pyhss.db - readCacheEnabled: True - readCacheInterval: 60 ## External Webhook Notifications webhooks: @@ -157,12 +140,6 @@ unixSocketPath: '/var/run/redis/redis-server.sock' host: localhost port: 6379 - sentinel: - masterName: exampleMaster - hosts: - - exampleSentinel.mnc001.mcc001.3gppnetwork.org: - port: 6379 - password: '' influxdb: enabled: False -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42286?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I87cf01e00fe0a3b32be9eaa4cf4c1ddf02cddc0b Gerrit-Change-Number: 42286 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: hlr: pyhss: run the pyhss_hss service
by osmith 06 Mar '26

06 Mar '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42285?usp=email ) Change subject: hlr: pyhss: run the pyhss_hss service ...................................................................... hlr: pyhss: run the pyhss_hss service Database preparations used to be done in PyHSS by all services if they noticed that this was needed. The time between checking and creating the tables caused a race condition where two services attempting to create tables at the same time will result at one of them failing, we have seen this in our ttcn3-hlr-test-pyhss jobs sometimes: [Database] [DEBUG] Table apn already exists [Database] [DEBUG] Table auc already exists [Database] [DEBUG] Table subscriber already exists … [testenv][pyhss] pyhss_gsup: setup script failed I have fixed this upstream by letting only the main service (pyhss_hss) prepare the database: https://github.com/nickvsnetworking/pyhss/commit/8b8a2202c345fbb7262c9d07d0… This means that we now need to run the pyhss_hss service in the HLR tests, so pyhss_gsup doesn't fail with: [Database] [INFO] Waiting for the main service to prepare the database ERROR: 127.0.0.1:4222 did not become available within 5s! [testenv][pyhss] pyhss_gsup: setup script failed Change-Id: I4fe689c8d8617432175ba403b45021c0f646970b --- M hlr/testenv_pyhss.cfg 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/85/42285/1 diff --git a/hlr/testenv_pyhss.cfg b/hlr/testenv_pyhss.cfg index 7a70872..2e81987 100644 --- a/hlr/testenv_pyhss.cfg +++ b/hlr/testenv_pyhss.cfg @@ -10,6 +10,11 @@ package=no copy=pyhss/redis.conf +[pyhss_hss] +program=cd ../pyhss_gsup && ./run_in_venv.sh pyhss_hss +make=pyhss +package=pyhss + [pyhss_gsup] program=./run_in_venv.sh pyhss_gsup setup=wait_for_port.py -p 4222 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42285?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4fe689c8d8617432175ba403b45021c0f646970b Gerrit-Change-Number: 42285 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in pysim[master]: personalization: indicate default ParamSource per ConfigurableParameter
by dexter 06 Mar '26

06 Mar '26

Attention is currently required from: neels. dexter has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40200?usp=email ) Change subject: personalization: indicate default ParamSource per ConfigurableParameter ...................................................................... Patch Set 9: Code-Review+1 (2 comments) Patchset: PS9: I think this patch looks ok. I would recommend to double check the code paths so that we can be sure that the luhn checksum of the ICCID is always correct. File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/40200/comment/96a9a801_96a414a3?usp=em… : PS9, Line 362: default_source = param_source.IncDigitSource The ICCID has a luhn checksum at the end. A wrong checksum may cause the eUICC to just refuse the profile installation. As far as I know, the IncDigitSource just increments, it does not add a checksum or anything. As far as I can see you are using enc_iccid to encode the value in apply_val. This function only does the nibble swap. sanitize_iccid would calculate the luhn if it is not yet present, but its only called in validate_val... Maybe you calculate the luhn somewehere and everything is fine. I am just writing this to make sure you are aware of this. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40200?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie58d13bce3fa1aa2547cf3cee918c2f5b30a8b32 Gerrit-Change-Number: 40200 Gerrit-PatchSet: 9 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 Mar 2026 12:32:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ci[master]: repo-install-test: run for debian 13 too
by pespin 06 Mar '26

06 Mar '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42284?usp=email ) Change subject: repo-install-test: run for debian 13 too ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42284?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1db9de8c740d5167e4813ece36f422b27aed5111 Gerrit-Change-Number: 42284 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 Mar 2026 12:22:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: repo-install-test: ignore pyhss
by pespin 06 Mar '26

06 Mar '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42283?usp=email ) Change subject: repo-install-test: ignore pyhss ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42283?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I796e85a212dff94fbf9b8ef563eba47418c221cc Gerrit-Change-Number: 42283 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 Mar 2026 12:21:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: repo-install-test: ignore charon-systemd
by pespin 06 Mar '26

06 Mar '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42282?usp=email ) Change subject: repo-install-test: ignore charon-systemd ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42282?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic641d5361c51df147a8cef5d49eb1e0f07b72e87 Gerrit-Change-Number: 42282 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 Mar 2026 12:21:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: repo-install-test: ignore sdcc-dbgsym
by pespin 06 Mar '26

06 Mar '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42281?usp=email ) Change subject: repo-install-test: ignore sdcc-dbgsym ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ibb12118853f354d177cb94df63b60dd3bd9dfcb7 Gerrit-Change-Number: 42281 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 Mar 2026 12:21:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log March 2026