February 2026 - gerrit-log - lists.osmocom.org

[XS] Change in pysim[master]: compile_asn1_subdir: filter compiled files by .asn suffix
by laforge 10 Feb '26

10 Feb '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42009?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: compile_asn1_subdir: filter compiled files by .asn suffix ...................................................................... compile_asn1_subdir: filter compiled files by .asn suffix When I open the .asn file in vim, pySim should not attempt to read the vim .swp file as asn.1. File "/home/moi/osmo-dev/src/pysim/pySim/esim/saip/__init__.py", line 45, in <module> asn1 = compile_asn1_subdir('saip') [...] File "<frozen codecs>", line 325, in decode UnicodeDecodeError: 'utf-8' codec can't decode byte 0xad in position 21: invalid start byte Related: OS#6937 Change-Id: I37df3fc081e51e2ed2198876c63f6e68ecc8fcd8 --- M pySim/esim/__init__.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/pySim/esim/__init__.py b/pySim/esim/__init__.py index 35b733e..9bbaf17 100644 --- a/pySim/esim/__init__.py +++ b/pySim/esim/__init__.py @@ -54,6 +54,8 @@ __ver = sys.version_info if (__ver.major, __ver.minor) >= (3, 9): for i in resources.files('pySim.esim').joinpath('asn1').joinpath(subdir_name).iterdir(): + if not i.name.endswith('.asn'): + continue asn_txt += i.read_text() asn_txt += "\n" #else: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42009?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I37df3fc081e51e2ed2198876c63f6e68ecc8fcd8 Gerrit-Change-Number: 42009 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-sgsn[master]: Some older modules, such as the Air20X module, may crash during PDP a...
by Jenkins Builder 10 Feb '26

10 Feb '26

Attention is currently required from: canghaiwuhen. Jenkins Builder has posted comments on this change by canghaiwuhen. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/42050?usp=email ) Change subject: Some older modules, such as the Air20X module, may crash during PDP attachment due to excessively long QoS response packets. If the PDP is not released after successful attachment, the module will restart, and subsequent TCP connections will fail. ...................................................................... Patch Set 4: (6 comments) File src/sgsn/gprs_gmm.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/c55ee09f_d7da6f88?us… : PS4, Line 1340: /* [FIX] Known IMSI context. If the module initiates an Attach, it means it has restarted and lost its PDP state. trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/4154947e_40a46358?us… : PS4, Line 1341: * We must clean up the old PDP context on the SGSN side; otherwise, the SGSN will not recreate them, leading to communication failure. */ code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/7d7e51b4_649bd5f0?us… : PS4, Line 1341: * We must clean up the old PDP context on the SGSN side; otherwise, the SGSN will not recreate them, leading to communication failure. */ please, no space before tabs Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/ee3726d4_736165b3?us… : PS4, Line 1368: llist_for_each_entry_safe(pdp, pdp2, &ctx->pdp_list, list) { suspect code indent for conditional statements (24, 24) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/1cb547cf_b4b79eb3?us… : PS4, Line 1372: } code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/1e516135_bbd620dc?us… : PS4, Line 1372: } please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/42050?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I11c24b64f0e49cf80c825969dbf018b2948d855c Gerrit-Change-Number: 42050 Gerrit-PatchSet: 4 Gerrit-Owner: canghaiwuhen <canghaiwuhen(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: canghaiwuhen <canghaiwuhen(a)gmail.com> Gerrit-Comment-Date: Tue, 10 Feb 2026 15:41:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in libosmo-sigtran[master]: m3ua: Allow rx SCON in IPSP role
by daniel 10 Feb '26

10 Feb '26

Attention is currently required from: fixeria, laforge, pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42029?usp=email ) Change subject: m3ua: Allow rx SCON in IPSP role ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42029?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I49838219aab912243a761ab9b5167095e363c72b Gerrit-Change-Number: 42029 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Feb 2026 15:39:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: cosmetic: ss7_asp.h: Drop comment no longer valid
by pespin 10 Feb '26

10 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42104?usp=email ) Change subject: cosmetic: ss7_asp.h: Drop comment no longer valid ...................................................................... cosmetic: ss7_asp.h: Drop comment no longer valid Since a while ago, remote asp ID is stored in asp->remote_asp_id. Fixes: b8fe5e4a1adfb54f265efc81432eab6252e9b04f Change-Id: I2253b1cb9e24270b9d6b3400d3fa20827c66ad23 --- M src/ss7_asp.h 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/04/42104/1 diff --git a/src/ss7_asp.h b/src/ss7_asp.h index 459163f..80a0a8a 100644 --- a/src/ss7_asp.h +++ b/src/ss7_asp.h @@ -71,7 +71,6 @@ char *sock_name; /* ASP Identifier for ASP-UP + NTFY, as received by the peer. - * (In IPA ASPs it's used internally to hold 4-bit SLS). * FIXME: This should actually be stored in a AS-ASP relation, since it * can be different per AS, see RFC4666 3.5.1 * "The optional ASP Identifier parameter contains a unique value that -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42104?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2253b1cb9e24270b9d6b3400d3fa20827c66ad23 Gerrit-Change-Number: 42104 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ci[master]: scripts/kernel/linux-shallow-clone: new script
by osmith 10 Feb '26

10 Feb '26

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42095?usp=email ) Change subject: scripts/kernel/linux-shallow-clone: new script ...................................................................... Patch Set 1: (1 comment) File scripts/kernel/linux-shallow-clone.sh: https://gerrit.osmocom.org/c/osmo-ci/+/42095/comment/aef896e8_5d913086?usp=… : PS1, Line 78: mv "$DEST_OLD" "$DEST"-old > iirc it's possible to configure a jenkins job to avoid running another specific jenkins job is runni […] Interesting idea. There is a build blocker plugin, but we don't have it installed right now: https://jenkins-job-builder.readthedocs.io/en/latest/properties.html#proper… If this becomes a problem, I'd probably just tweak the timers instead so we can avoid installing another plugin. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42095?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id3aadb46813047ecac3b80868192809b272dba0e Gerrit-Change-Number: 42095 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Feb 2026 13:51:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: pySim/euicc: fix encoding/decoding of Iccid
by dexter 10 Feb '26

10 Feb '26

dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42086?usp=email ) Change subject: pySim/euicc: fix encoding/decoding of Iccid ...................................................................... pySim/euicc: fix encoding/decoding of Iccid The class Iccid uses a BcdAdapter to encoded/decode the ICCID. This works fine for ICCIDs that have an even (20) number of digits. In case the digit count is odd (19), the ICCID the last digit requires padding. Let's switch to PaddedBcdAdapter for encoding/decoding, to ensure that odd-length ICCIDs are padded automatically. Change-Id: I527a44ba454656a0d682ceb590eec6d9d0ac883a Related: OS#6868 --- M pySim/euicc.py M tests/pySim-shell_test/euicc/get_profiles_info.ok M tests/pySim-shell_test/euicc/test.py M tests/pySim-shell_test/euicc/test_gen_notif.script 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve lynxis lazus: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/euicc.py b/pySim/euicc.py index ccb65be..36e2d2a 100644 --- a/pySim/euicc.py +++ b/pySim/euicc.py @@ -181,7 +181,7 @@ class NotificationAddress(BER_TLV_IE, tag=0x0c): _construct = Utf8Adapter(GreedyBytes) class Iccid(BER_TLV_IE, tag=0x5a): - _construct = BcdAdapter(GreedyBytes) + _construct = PaddedBcdAdapter(GreedyBytes) class NotificationMetadata(BER_TLV_IE, tag=0xbf2f, nested=[SeqNumber, ProfileMgmtOperation, NotificationAddress, Iccid]): pass diff --git a/tests/pySim-shell_test/euicc/get_profiles_info.ok b/tests/pySim-shell_test/euicc/get_profiles_info.ok index 8450cb2..28eeff4 100644 --- a/tests/pySim-shell_test/euicc/get_profiles_info.ok +++ b/tests/pySim-shell_test/euicc/get_profiles_info.ok @@ -15,7 +15,7 @@ }, { "profile_info": { - "iccid": "8949449999999990031f", + "iccid": "8949449999999990031", "isdp_aid": "a0000005591010ffffffff8900001200", "profile_state": "disabled", "service_provider_name": "OsmocomSPN", diff --git a/tests/pySim-shell_test/euicc/test.py b/tests/pySim-shell_test/euicc/test.py index 3cad859..654d575 100644 --- a/tests/pySim-shell_test/euicc/test.py +++ b/tests/pySim-shell_test/euicc/test.py @@ -23,7 +23,7 @@ import json from utils import * -# This testcase requires a sysmoEUICC1-C2T with the test prfile TS48V1-B-UNIQUE (ICCID 8949449999999990031f) +# This testcase requires a sysmoEUICC1-C2T with the test prfile TS48V1-B-UNIQUE (ICCID 8949449999999990031) # installed, and in disabled state. Also the profile must be installed in such a way that notifications are # generated when the profile is disabled or enabled (ProfileMetadata) diff --git a/tests/pySim-shell_test/euicc/test_gen_notif.script b/tests/pySim-shell_test/euicc/test_gen_notif.script index d97dc2b..feb7ef2 100644 --- a/tests/pySim-shell_test/euicc/test_gen_notif.script +++ b/tests/pySim-shell_test/euicc/test_gen_notif.script @@ -4,5 +4,5 @@ select ADF.ISD-R # Generate two (additional) notifications by quickly enabeling the test profile -enable_profile --iccid 8949449999999990031f +enable_profile --iccid 8949449999999990031 enable_profile --iccid 89000123456789012341 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42086?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I527a44ba454656a0d682ceb590eec6d9d0ac883a Gerrit-Change-Number: 42086 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in pysim[master]: euicc: get_profiles_info: add additional tags
by dexter 10 Feb '26

10 Feb '26

Attention is currently required from: lynxis lazus. dexter has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/pysim/+/42058?usp=email ) Change subject: euicc: get_profiles_info: add additional tags ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File pySim/euicc.py: https://gerrit.osmocom.org/c/pysim/+/42058/comment/7703cf08_2844a799?usp=em… : PS1, Line 232: _construct = GreedyBytes in rsp.asn ProfileInfo the NotificationConfigurationInfo comes before the ProfilePolicyRules. Maybe swap the position of both to maintain order? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42058?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I727dbe34d87a42bb3b526bd7a8accd687d20a208 Gerrit-Change-Number: 42058 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 10 Feb 2026 13:18:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: gitignore: fix vim swp file pattern
by laforge 10 Feb '26

10 Feb '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/41916?usp=email ) Change subject: gitignore: fix vim swp file pattern ...................................................................... gitignore: fix vim swp file pattern Change-Id: I5a8351dc09f6ca7c8e9032ff8352e5cf1a4833a3 --- M .gitignore 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/.gitignore b/.gitignore index 7a2e150..0cd5b14 100644 --- a/.gitignore +++ b/.gitignore @@ -1,5 +1,5 @@ *.pyc -.*.swp +.*.sw? /docs/_* /docs/generated -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41916?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5a8351dc09f6ca7c8e9032ff8352e5cf1a4833a3 Gerrit-Change-Number: 41916 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: gitignore: fix vim swp file pattern
by laforge 10 Feb '26

10 Feb '26

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/41916?usp=email ) Change subject: gitignore: fix vim swp file pattern ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41916?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5a8351dc09f6ca7c8e9032ff8352e5cf1a4833a3 Gerrit-Change-Number: 41916 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Feb 2026 13:10:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: xua_snm: assert for unexpected condition
by laforge 10 Feb '26

10 Feb '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42103?usp=email ) Change subject: xua_snm: assert for unexpected condition ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42103?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I24bb335a2a856bf1a5ca255f7afbfe103ebcd86f Gerrit-Change-Number: 42103 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Feb 2026 13:10:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log February 2026