pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42092?usp=email )
Change subject: sua: Support rx SCON in role=SG
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42092?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ide2b4f876ddbdb1bb0bfed11fad6fc13aaf1afda
Gerrit-Change-Number: 42092
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 11 Feb 2026 14:59:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42091?usp=email )
Change subject: sua: Support rx SCON in role=ASP
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42091?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I1e4146c2cb8fab460d5e810b602c20293272c2e4
Gerrit-Change-Number: 42091
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 11 Feb 2026 14:59:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: daniel.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42074?usp=email )
Change subject: xua_default_fsm: Support IPSP role
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42074?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Id9ad8bbfce5cf15fedcba83034ae383e61d3b3a3
Gerrit-Change-Number: 42074
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 11 Feb 2026 14:58:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: daniel, laforge.
Hello Jenkins Builder, daniel, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42090?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by daniel, Code-Review+1 by laforge
Change subject: xua_aspm_fsm: Remove unneeded workaround submitting XUA_ASP_E_M_ASP_ACTIVE_REQ
......................................................................
xua_aspm_fsm: Remove unneeded workaround submitting XUA_ASP_E_M_ASP_ACTIVE_REQ
Sending that kind of event is up to the layer manager.
Right now, all ASPs (except ipa_aspm_fsm, which doesn't need that event
because there's no ACTIVATE in IPA) have an associated layer manager
FSM, so that workaround is not needed.
Change-Id: If6c2c5b6ffc4080320aadc550d823abc5d613d6f
---
M src/xua_asp_fsm.c
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/90/42090/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42090?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: If6c2c5b6ffc4080320aadc550d823abc5d613d6f
Gerrit-Change-Number: 42090
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Attention is currently required from: daniel.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42104?usp=email
to look at the new patch set (#2).
Change subject: cosmetic: ss7_asp.h: Drop comment no longer valid
......................................................................
cosmetic: ss7_asp.h: Drop comment no longer valid
Since a while ago, only the remote asp ID is stored in
asp->remote_asp_id. The SLS has its own field (ipa.sls).
Fixes: b8fe5e4a1adfb54f265efc81432eab6252e9b04f
Change-Id: I2253b1cb9e24270b9d6b3400d3fa20827c66ad23
---
M src/ss7_asp.h
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/04/42104/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42104?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I2253b1cb9e24270b9d6b3400d3fa20827c66ad23
Gerrit-Change-Number: 42104
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Attention is currently required from: daniel.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42104?usp=email )
Change subject: cosmetic: ss7_asp.h: Drop comment no longer valid
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42104/comment/22127725_97352… :
PS1, Line 9: Since a while ago, remote asp ID is stored in asp->remote_asp_id.
> ```suggestion […]
Done
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42104?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I2253b1cb9e24270b9d6b3400d3fa20827c66ad23
Gerrit-Change-Number: 42104
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 11 Feb 2026 14:33:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Attention is currently required from: daniel.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42090?usp=email )
Change subject: xua_aspm_fsm: Remove unneeded workaround submitting XUA_ASP_E_M_ASP_ACTIVE_REQ
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42090/comment/bd48ca40_3e34f… :
PS1, Line 10: Right now, all ASPs (except ipa_aspm_fsm, which don't need that event
> ```suggestion […]
Done
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42090?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: If6c2c5b6ffc4080320aadc550d823abc5d613d6f
Gerrit-Change-Number: 42090
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 11 Feb 2026 14:30:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Attention is currently required from: daniel.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42074?usp=email )
Change subject: xua_default_fsm: Support IPSP role
......................................................................
Patch Set 3:
(2 comments)
File src/xua_default_lm_fsm.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42074/comment/b13bf6bd_5be22… :
PS3, Line 235: ENSURE_ASP_OR_IPSP(fi, event);
> Just to check - this effectively adds logging in role SG?
Yes.
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42074/comment/49ebcb66_c3e0a… :
PS3, Line 308: ENSURE_IPSP(fi, event);
> This also "just" adds logging in role != IPSP?
Yes.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42074?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Id9ad8bbfce5cf15fedcba83034ae383e61d3b3a3
Gerrit-Change-Number: 42074
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 11 Feb 2026 14:29:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42071?usp=email )
Change subject: vty: Prohibit configuring an IPA ASP as IPSP
......................................................................
vty: Prohibit configuring an IPA ASP as IPSP
We could eventually define how the IPA CCM is expected to behave when in
IPSP role (eg. implementing/allowing both sides of IPA CCM, or assigning
an IPA CCM role based on TCP client/server), but that has not yet been
defined.
IPSP is actually a good candidate for IPA ASPs, since in IPA proto we
don't have SNM messaging either, and it's meant to be used
point-to-point (or through STP by assigning hardocded routes).
Change-Id: I18ad3e9ad4aac7a3d8e84483ba1bf09016520b54
---
M src/ss7_asp_vty.c
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
daniel: Looks good to me, approved
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
diff --git a/src/ss7_asp_vty.c b/src/ss7_asp_vty.c
index 27b7462..6731398 100644
--- a/src/ss7_asp_vty.c
+++ b/src/ss7_asp_vty.c
@@ -423,6 +423,11 @@
vty_out(vty, "IPSP role can't be used in an SG node since they are point-to-point%s", VTY_NEWLINE);
return CMD_WARNING;
}
+ if (asp->cfg.proto == OSMO_SS7_ASP_PROT_IPA) {
+ /* There's no definition yet on how IPA ASPs should behave in IPSP role... */
+ vty_out(vty, "IPSP role is not supported in ASP protol 'ipa'%s", VTY_NEWLINE);
+ return CMD_WARNING;
+ }
asp->cfg.role = OSMO_SS7_ASP_ROLE_IPSP;
} else {
OSMO_ASSERT(0);
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42071?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I18ad3e9ad4aac7a3d8e84483ba1bf09016520b54
Gerrit-Change-Number: 42071
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>