Attention is currently required from: pespin.
daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42093?usp=email )
Change subject: sua: Support rx SCON in role=IPSP
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42093?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I3f46b634084c1d71643812828d4f114ab45dffde
Gerrit-Change-Number: 42093
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 11 Feb 2026 14:01:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42091?usp=email )
Change subject: sua: Support rx SCON in role=ASP
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42091?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I1e4146c2cb8fab460d5e810b602c20293272c2e4
Gerrit-Change-Number: 42091
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 11 Feb 2026 14:00:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42090?usp=email )
Change subject: xua_aspm_fsm: Remove unneeded workaround submitting XUA_ASP_E_M_ASP_ACTIVE_REQ
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42090/comment/45c3836a_bdda9… :
PS1, Line 10: Right now, all ASPs (except ipa_aspm_fsm, which don't need that event
```suggestion
Right now, all ASPs (except ipa_aspm_fsm, which doesn't need that event
```
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42090?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: If6c2c5b6ffc4080320aadc550d823abc5d613d6f
Gerrit-Change-Number: 42090
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 11 Feb 2026 13:57:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42089?usp=email )
Change subject: xua_as_fsm: Trigger PC (un)availability to upper layers in IPSP
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42089?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I0e6015f04ad0647cc151d3c772355a18cb55547a
Gerrit-Change-Number: 42089
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 11 Feb 2026 13:55:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42073?usp=email )
Change subject: xua_asp_fsm: Improvements to support IPSP
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42073?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ia268848ee9bb2f97a47ba9be60ecd16fbeb4fb40
Gerrit-Change-Number: 42073
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 11 Feb 2026 13:47:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42072?usp=email )
Change subject: xua_rkm: Adapt RKM code to support IPSP
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42072?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I9c59d6fb43d4e7ceda552f156dd7761173545b11
Gerrit-Change-Number: 42072
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 11 Feb 2026 13:44:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42071?usp=email )
Change subject: vty: Prohibit configuring an IPA ASP as IPSP
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42071?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I18ad3e9ad4aac7a3d8e84483ba1bf09016520b54
Gerrit-Change-Number: 42071
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 11 Feb 2026 13:41:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria, pespin.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42106?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by pespin
Change subject: msc: f_tc_ho_inter_bsc0(): catch BSSMAP HandoverRequiredReject
......................................................................
msc: f_tc_ho_inter_bsc0(): catch BSSMAP HandoverRequiredReject
It may happen that the target BSC is not yet connected to the MSC.
In this case the MSC rejects handover with HandoverRequiredReject.
Let's catch this PDU to make the verdict cleaner in such case.
Change-Id: I5ba98e323e0c7794554ccb115d7697ad03ccbfa5
Related: OS#6951
---
M msc/MSC_Tests.ttcn
1 file changed, 12 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/06/42106/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42106?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5ba98e323e0c7794554ccb115d7697ad03ccbfa5
Gerrit-Change-Number: 42106
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42107?usp=email )
Change subject: msc: TC_ho_inter_bsc: wait for the target BSC to become ready
......................................................................
msc: TC_ho_inter_bsc: wait for the target BSC to become ready
A race condition may occur between the two testcase components
emulating BSCs: the source BSC initiates handover to the terget
BSC before the later completes connection establishment with the
MSC. In this case, the MSC fails to find the target peer and
rejects our HandoverRequired with HandoverRequiredReject.
Target RAN peer from neighbor config is not connected: Cell ID CGI:023-42-5-6 resolves to target address 0.24.2
Cannot find target peer for cell ID CGI:023-42-5-6
Attempted Handover to 1 cells without success
Let's avoid this by waiting for the target BSC to become available
before initiating the handover procedure. Use the COORD port
("intercom") to signal readiness of the target BSC.
Change-Id: I00b8a8b89ec7bb15590d30aadf40055981375a5d
Related: OS#6951
---
M msc/MSC_Tests.ttcn
1 file changed, 17 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/07/42107/1
diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index 17fac68..e9acddc 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -6023,6 +6023,12 @@
f_perform_lu();
f_mo_call_establish(cpars);
+ /* The target BSC needs to be ready for incoming handover.
+ * This is indicated by f_tc_ho_inter_bsc1() via the "intercom". */
+ log("Waiting for the target BSC to become ready...");
+ COORD.receive("READY");
+ log("The target BSC is ready, it's time for the handover!");
+
/* Remember the last n_sd (sequence number),
* we will need it when the other BSS hands over back to us. */
var N_Sd_Array last_n_sd := f_bssmap_last_n_sd();
@@ -6131,6 +6137,11 @@
f_init_handler(pars);
f_create_bssmap_exp_n_connect(194);
+ /* At this point, the target BSC is ready for incoming handover.
+ * Indicate this to f_tc_ho_inter_bsc0() via the "intercom". */
+ log("The target BSC becomes ready for handover");
+ COORD.send("READY");
+
var template BSSMAP_IE_EncryptionInformation encryptionInformation;
var template BSSMAP_IE_ChosenEncryptionAlgorithm chosenEncryptionAlgorithm;
var template BSSMAP_IE_KC128 kC128;
@@ -6236,8 +6247,12 @@
}
f_vty_config(MSCVTY, "network", "encryption a5 " & int2str(a5_n));
- vc_conn0 := f_start_handler_with_pars(refers(f_tc_ho_inter_bsc0), pars0);
- vc_conn1 := f_start_handler_with_pars(refers(f_tc_ho_inter_bsc1), pars1);
+ vc_conn0 := f_start_handler_create(pars0);
+ vc_conn1 := f_start_handler_create(pars1);
+ connect(vc_conn0:COORD, vc_conn1:COORD);
+
+ f_start_handler_run(vc_conn0, refers(f_tc_ho_inter_bsc0), pars0);
+ f_start_handler_run(vc_conn1, refers(f_tc_ho_inter_bsc1), pars1);
vc_conn0.done;
vc_conn1.done;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42107?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I00b8a8b89ec7bb15590d30aadf40055981375a5d
Gerrit-Change-Number: 42107
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: canghaiwuhen, laforge, pespin.
Jenkins Builder has posted comments on this change by canghaiwuhen. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/42050?usp=email )
Change subject: Some older modules, such as the Air20X module, may crash during PDP attachment due to excessively long QoS response packets. If the PDP is not released after successful attachment, the module will restart, and subsequent TCP connections will fail.
......................................................................
Patch Set 7:
(3 comments)
File src/sgsn/gprs_gmm.c:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/e7aa57dd_a2c0050e?us… :
PS7, Line 1347: LOGMMCTXP(LOGL_NOTICE, ctx,
trailing whitespace
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/b386a87e_e01e069f?us… :
PS7, Line 1348: "Re-Attach: Dropping stale PDP context for NSAPI=%u\n",
trailing whitespace
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/7db19eed_51469fc8?us… :
PS7, Line 1375: LOGMMCTXP(LOGL_NOTICE, ctx,
trailing whitespace
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/42050?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I11c24b64f0e49cf80c825969dbf018b2948d855c
Gerrit-Change-Number: 42050
Gerrit-PatchSet: 7
Gerrit-Owner: canghaiwuhen <canghaiwuhen(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: canghaiwuhen <canghaiwuhen(a)gmail.com>
Gerrit-Comment-Date: Wed, 11 Feb 2026 12:47:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No