February 2026 - gerrit-log - lists.osmocom.org

[NoOp] Change in dahdi-linux[master]: (do not merge) a patch for testing CI
by osmith 10 Feb '26

10 Feb '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42094?usp=email ) Change subject: (do not merge) a patch for testing CI ...................................................................... (do not merge) a patch for testing CI Change-Id: I93682eadb6790f5238af2c92c3126b6eea24dbb9 --- A test 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/94/42094/1 diff --git a/test b/test new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/test -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42094?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I93682eadb6790f5238af2c92c3126b6eea24dbb9 Gerrit-Change-Number: 42094 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: pySim/euicc: fix encoding/decoding of Iccid
by lynxis lazus 10 Feb '26

10 Feb '26

Attention is currently required from: dexter. lynxis lazus has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42086?usp=email ) Change subject: pySim/euicc: fix encoding/decoding of Iccid ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Might be relevant for the esim-mgr as well. Also there the imsi are shown with padding. @nhofmeyr@sysmocom.de -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42086?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I527a44ba454656a0d682ceb590eec6d9d0ac883a Gerrit-Change-Number: 42086 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Feb 2026 11:09:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: pySim/euicc: fix encoding/decoding of Iccid
by dexter 10 Feb '26

10 Feb '26

Attention is currently required from: lynxis lazus. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42086?usp=email ) Change subject: pySim/euicc: fix encoding/decoding of Iccid ...................................................................... Patch Set 1: (2 comments) File tests/pySim-shell_test/euicc/get_profiles_info.ok: https://gerrit.osmocom.org/c/pysim/+/42086/comment/72695480_3c90754b?usp=em… : PS1, Line 18: "iccid": "8949449999999990031", (the iccid is now displayed without the padding) File tests/pySim-shell_test/euicc/test_gen_notif.script: https://gerrit.osmocom.org/c/pysim/+/42086/comment/579de146_25c57324?usp=em… : PS1, Line 7: enable_profile --iccid 8949449999999990031 (This is a cosmetic change, the padded also works) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42086?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I527a44ba454656a0d682ceb590eec6d9d0ac883a Gerrit-Change-Number: 42086 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 10 Feb 2026 10:27:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in pysim[master]: gitignore: fix vim swp file pattern
by fixeria 10 Feb '26

10 Feb '26

Attention is currently required from: neels. fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/41916?usp=email ) Change subject: gitignore: fix vim swp file pattern ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41916?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5a8351dc09f6ca7c8e9032ff8352e5cf1a4833a3 Gerrit-Change-Number: 41916 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Feb 2026 10:01:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: compile_asn1_subdir: filter compiled files by .asn suffix
by fixeria 10 Feb '26

10 Feb '26

Attention is currently required from: neels. fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/42009?usp=email ) Change subject: compile_asn1_subdir: filter compiled files by .asn suffix ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42009?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I37df3fc081e51e2ed2198876c63f6e68ecc8fcd8 Gerrit-Change-Number: 42009 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Feb 2026 09:57:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmocore[master]: logging: Support nonblocking-io for log target stderr & file, make it...
by pespin 10 Feb '26

10 Feb '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/42088?usp=email ) Change subject: logging: Support nonblocking-io for log target stderr & file, make it default ...................................................................... logging: Support nonblocking-io for log target stderr & file, make it default The nonblocking-io used to be the mode used until recently, where wq only was used if the write buffer was full. This is more performant that always waiting for poll() to write, plus the fact that we write to system synchronously, hence seeing output immediatelly or not losing it if program crashes. Furthermore, It turns out using wq in multithreaded programs may cause problems, so better switch back to using nonblocking-io by default. Related: OS#6947 Change-Id: I46420f4b174d3a9ed01e993e2e89aea3b46c0dd7 --- M include/osmocom/core/logging.h M src/core/libosmocore.map M src/core/logging_file.c M src/vty/logging_vty.c M tests/logging/logging_vty_test.vty 5 files changed, 96 insertions(+), 24 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified daniel: Looks good to me, approved diff --git a/include/osmocom/core/logging.h b/include/osmocom/core/logging.h index ac6e553..1a5cb7c 100644 --- a/include/osmocom/core/logging.h +++ b/include/osmocom/core/logging.h @@ -457,6 +457,8 @@ int log_target_file_reopen(struct log_target *tgt); int log_target_file_switch_to_stream(struct log_target *tgt); int log_target_file_switch_to_wqueue(struct log_target *tgt); +int log_target_file_get_nonblock(const struct log_target *target); +int log_target_file_set_nonblock(struct log_target *target, int on); int log_targets_reopen(void); void log_add_target(struct log_target *target); diff --git a/src/core/libosmocore.map b/src/core/libosmocore.map index 5a3c3e8..06a9009 100644 --- a/src/core/libosmocore.map +++ b/src/core/libosmocore.map @@ -103,7 +103,9 @@ log_target_create_systemd; log_target_create_emscripten; log_target_destroy; +log_target_file_get_nonblock; log_target_file_reopen; +log_target_file_set_nonblock; log_target_file_switch_to_stream; log_target_file_switch_to_wqueue; log_target_find; diff --git a/src/core/logging_file.c b/src/core/logging_file.c index 067f993..0e99ca2 100644 --- a/src/core/logging_file.c +++ b/src/core/logging_file.c @@ -29,6 +29,7 @@ #include <errno.h> #include <fcntl.h> #include <stdarg.h> +#include <stdbool.h> #include <stdlib.h> #include <stdio.h> #include <string.h> @@ -60,10 +61,12 @@ return -ENOTSUP; if (target->tgt_file.out) { /* stream mode */ + int nonblock_flag = log_target_file_get_nonblock(target) != 0 ? 1 : 0; fclose(target->tgt_file.out); target->tgt_file.out = fopen(target->tgt_file.fname, "a"); if (!target->tgt_file.out) return -errno; + log_target_file_set_nonblock(target, nonblock_flag); return 0; } @@ -89,6 +92,62 @@ #if (!EMBEDDED) +/*! Set the log target fd as non-blocking (see sockopt O_NONBLOCK). + * \param[in] target log target which we should switch + * \param[in] on set to 1 to set as non-blocking, 0 to set as blocking. + * \returns 0 on success; negative on error + * + * This setting is ignored when \ref target is in wqueue mode. + */ +int log_target_file_set_nonblock(struct log_target *target, int on) +{ + int flags; + int fd; + + if (!target->tgt_file.out) + return 0; + + fd = fileno(target->tgt_file.out); + if (fd < 0) + return fd; + + flags = fcntl(fd, F_GETFL); + if (flags < 0) + return flags; + + if (on) + flags |= O_NONBLOCK; + else + flags &= ~O_NONBLOCK; + + flags = fcntl(fd, F_SETFL, flags); + if (flags < 0) + return flags; + return 0; +} + +/*! Find whether the log target fd is configured as non-blocking (see sockopt O_NONBLOCK). + * \param[in] target log target which we should switch + * \returns 1 if set as non-block; 0 otherwise; negative on error + */ +int log_target_file_get_nonblock(const struct log_target *target) +{ + int flags; + int fd; + + if (!target->tgt_file.out) + return -1; + + fd = fileno(target->tgt_file.out); + if (fd < 0) + return fd; + + flags = fcntl(fd, F_GETFL); + if (flags < 0) + return flags; + return (flags & O_NONBLOCK) ? 1 : 0; +} + /* This is the file-specific subclass destructor logic, called from * log_target_destroy(). User should call log_target_destroy() to destroy this * object. */ @@ -309,14 +368,13 @@ return 0; } -/*! Create a new file-based log target using non-blocking write_queue +/*! Create a new file-based log target using a stream * \param[in] fname File name of the new log file * \returns Log target in case of success, NULL otherwise */ struct log_target *log_target_create_file(const char *fname) { struct log_target *target; - int rc, fd; target = log_target_create(); if (!target) @@ -325,14 +383,10 @@ target->type = LOG_TGT_TYPE_FILE; target->tgt_file.fname = talloc_strdup(target, fname); OSMO_ASSERT(target->tgt_file.fname); - target->raw_output = _file_raw_output; + target->output = _file_output_stream; - fd = open(fname, O_WRONLY|O_APPEND|O_CREAT|O_NONBLOCK, 0660); - if (fd < 0) - goto free_ret; - - rc = _log_target_file_setup_iofd(target, fd); - if (rc < 0) + target->tgt_file.out = fopen(target->tgt_file.fname, "a"); + if (!target->tgt_file.out) goto free_ret; return target; diff --git a/src/vty/logging_vty.c b/src/vty/logging_vty.c index 3fa62a1..a7a9efa 100644 --- a/src/vty/logging_vty.c +++ b/src/vty/logging_vty.c @@ -886,11 +886,15 @@ } DEFUN(cfg_log_stderr, cfg_log_stderr_cmd, - "log stderr [blocking-io]", + "log stderr [(nonblocking-io|blocking-io|wq)]", LOG_STR "Logging via STDERR of the process\n" - "Use blocking, synchronous I/O\n") + "Use non-blocking, synchronous I/O (may lose msgs if file write buffer becomes full) (default)\n" + "Use blocking, synchronous I/O (only for debug purposes or when blocking is acceptable)\n" + "Use Tx workqueue, asynchronous I/O (may lose msgs if queue becomes full)\n") { struct log_target *tgt; + bool wq_mode = argc > 0 && (strcmp(argv[0], "wq") == 0); + bool blocking_io = argc > 0 && (strcmp(argv[0], "blocking-io") == 0); log_tgt_mutex_lock(); tgt = log_target_find(LOG_TGT_TYPE_STDERR, NULL); @@ -904,10 +908,12 @@ log_add_target(tgt); } - if (argc > 0 && !strcmp(argv[0], "blocking-io")) - log_target_file_switch_to_stream(tgt); - else + if (wq_mode) { log_target_file_switch_to_wqueue(tgt); + } else { + log_target_file_switch_to_stream(tgt); + log_target_file_set_nonblock(tgt, blocking_io ? 0 : 1); + } vty->index = tgt; vty->node = CFG_LOG_NODE; @@ -935,11 +941,15 @@ } DEFUN(cfg_log_file, cfg_log_file_cmd, - "log file FILENAME [blocking-io]", + "log file FILENAME [(nonblocking-io|blocking-io|wq)]", LOG_STR "Logging to text file\n" "Filename\n" - "Use blocking, synchronous I/O\n") + "Use non-blocking, synchronous I/O (may lose msgs if file write buffer becomes full) (default)\n" + "Use blocking, synchronous I/O (only for debug purposes or when blocking is acceptable)\n" + "Use Tx workqueue, asynchronous I/O (may lose msgs if queue becomes full)\n") { const char *fname = argv[0]; + bool wq_mode = argc > 1 && (strcmp(argv[1], "wq") == 0); + bool blocking_io = argc > 1 && (strcmp(argv[1], "blocking-io") == 0); struct log_target *tgt; log_tgt_mutex_lock(); @@ -954,10 +964,12 @@ log_add_target(tgt); } - if (argc > 1 && !strcmp(argv[1], "blocking-io")) - log_target_file_switch_to_stream(tgt); - else + if (wq_mode) { log_target_file_switch_to_wqueue(tgt); + } else { + log_target_file_switch_to_stream(tgt); + log_target_file_set_nonblock(tgt, blocking_io ? 0 : 1); + } vty->index = tgt; vty->node = CFG_LOG_NODE; @@ -1084,9 +1096,10 @@ break; case LOG_TGT_TYPE_STDERR: if (tgt->tgt_file.wqueue) - vty_out(vty, "log stderr%s", VTY_NEWLINE); + vty_out(vty, "log stderr wq%s", VTY_NEWLINE); else - vty_out(vty, "log stderr blocking-io%s", VTY_NEWLINE); + vty_out(vty, "log stderr%s%s", + log_target_file_get_nonblock(tgt) == 0 ? " blocking-io" : "", VTY_NEWLINE); break; case LOG_TGT_TYPE_SYSLOG: #ifdef ENABLE_SYSLOG_LOGGING @@ -1098,9 +1111,10 @@ break; case LOG_TGT_TYPE_FILE: if (tgt->tgt_file.wqueue) - vty_out(vty, "log file %s%s", tgt->tgt_file.fname, VTY_NEWLINE); + vty_out(vty, "log file %s wq%s", tgt->tgt_file.fname, VTY_NEWLINE); else - vty_out(vty, "log file %s blocking-io%s", tgt->tgt_file.fname, VTY_NEWLINE); + vty_out(vty, "log file %s%s%s", tgt->tgt_file.fname, + log_target_file_get_nonblock(tgt) == 0 ? " blocking-io" : "", VTY_NEWLINE); break; case LOG_TGT_TYPE_STRRB: vty_out(vty, "log alarms %zu%s", diff --git a/tests/logging/logging_vty_test.vty b/tests/logging/logging_vty_test.vty index edf0512..b78678b 100644 --- a/tests/logging/logging_vty_test.vty +++ b/tests/logging/logging_vty_test.vty @@ -2,7 +2,7 @@ logging_vty_test# show running-config ... -log stderr +log stderr wq ... !logging level all logging level aa debug logging level bb info -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42088?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I46420f4b174d3a9ed01e993e2e89aea3b46c0dd7 Gerrit-Change-Number: 42088 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmocore[master]: logging: Support nonblocking-io for log target stderr & file, make it...
by daniel 10 Feb '26

10 Feb '26

Attention is currently required from: fixeria, osmith, pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/42088?usp=email ) Change subject: logging: Support nonblocking-io for log target stderr & file, make it default ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42088?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I46420f4b174d3a9ed01e993e2e89aea3b46c0dd7 Gerrit-Change-Number: 42088 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Feb 2026 09:40:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-abis[master]: gitignore: ignore generated .wasm files
by fixeria 09 Feb '26

09 Feb '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41956?usp=email ) Change subject: gitignore: ignore generated .wasm files ...................................................................... gitignore: ignore generated .wasm files Change-Id: I879e698f2d514cf6e2f7bb33b4d6148f79aea6f6 --- M .gitignore 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/.gitignore b/.gitignore index 30a1cf7..a50ee62 100644 --- a/.gitignore +++ b/.gitignore @@ -6,6 +6,7 @@ *.lo *.la *.pc +*.wasm aclocal.m4 m4/*.m4 autom4te.cache -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41956?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I879e698f2d514cf6e2f7bb33b4d6148f79aea6f6 Gerrit-Change-Number: 41956 Gerrit-PatchSet: 3 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-abis[master]: gitignore: ignore generated .wasm files
by fixeria 09 Feb '26

09 Feb '26

Attention is currently required from: Timur Davydov. fixeria has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41956?usp=email ) Change subject: gitignore: ignore generated .wasm files ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41956?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I879e698f2d514cf6e2f7bb33b4d6148f79aea6f6 Gerrit-Change-Number: 41956 Gerrit-PatchSet: 3 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Mon, 09 Feb 2026 20:43:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: sua: Support rx SCON in role=IPSP
by pespin 09 Feb '26

09 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42093?usp=email ) Change subject: sua: Support rx SCON in role=IPSP ...................................................................... sua: Support rx SCON in role=IPSP Change-Id: I3f46b634084c1d71643812828d4f114ab45dffde --- M src/sua.c M src/xua_snm.c 2 files changed, 27 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/93/42093/1 diff --git a/src/sua.c b/src/sua.c index ceb5d7a..2eb93e3 100644 --- a/src/sua.c +++ b/src/sua.c @@ -1068,6 +1068,30 @@ return rc; } +/* received SNM message on IPSP side */ +static int sua_rx_snm_ipsp(struct osmo_ss7_asp *asp, struct xua_msg *xua) +{ + struct osmo_ss7_as *as = NULL; + struct xua_msg_part *rctx_ie; + int rc = 0; + + switch (xua->hdr.msg_type) { + case M3UA_SNM_SCON: + /* RFC3868 1.5.6: "The SUA layer at an ASP or IPSP MAY indicate local congestion to + * an SUA peer with an SCON message." */ + rctx_ie = xua_msg_find_tag(xua, SUA_IEI_ROUTE_CTX); + rc = xua_find_as_for_asp(&as, asp, rctx_ie); + if (rc) + return rc; + xua_snm_rx_scon(asp, as, xua); + break; + default: + return M3UA_ERR_UNSUPP_MSG_TYPE; + } + + return rc; +} + static int sua_rx_snm(struct osmo_ss7_asp *asp, struct xua_msg *xua) { /* SNM only permitted in ACTIVE state */ @@ -1087,6 +1111,8 @@ return sua_rx_snm_sg(asp, xua); case OSMO_SS7_ASP_ROLE_ASP: return sua_rx_snm_asp(asp, xua); + case OSMO_SS7_ASP_ROLE_IPSP: + return sua_rx_snm_ipsp(asp, xua); default: return SUA_ERR_UNSUPP_MSG_CLASS; } diff --git a/src/xua_snm.c b/src/xua_snm.c index e983293..f7d3192 100644 --- a/src/xua_snm.c +++ b/src/xua_snm.c @@ -587,7 +587,7 @@ xua_snm_upu(as, aff_pc, user, cause, info_str); } -/* an incoming SUA/M3UA SCON was received from a remote SG */ +/* an incoming SUA/M3UA SCON was received from a remote ASP/SG/IPSP */ void xua_snm_rx_scon(struct osmo_ss7_asp *asp, struct osmo_ss7_as *as, struct xua_msg *xua) { struct xua_msg_part *ie_aff_pc = xua_msg_find_tag(xua, M3UA_IEI_AFFECTED_PC); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42093?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3f46b634084c1d71643812828d4f114ab45dffde Gerrit-Change-Number: 42093 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log February 2026