February 2026 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[master]: vty: Prohibit configuring an ASP as IPSP in an SG node
by pespin 09 Feb '26

09 Feb '26

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42028?usp=email ) Change subject: vty: Prohibit configuring an ASP as IPSP in an SG node ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42028?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I38bbd9226bad478f8068d02f7a4d7b3711596208 Gerrit-Change-Number: 42028 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Feb 2026 14:25:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: IPSP: Allow vty-configuration of IPSP role "ASPs"
by pespin 09 Feb '26

09 Feb '26

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42027?usp=email ) Change subject: IPSP: Allow vty-configuration of IPSP role "ASPs" ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42027?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0f0fa881471b87a4bb82a0211c6fb6e4c50b48ec Gerrit-Change-Number: 42027 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Feb 2026 14:25:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: IPSP: don't route any incoming M3UA messages in IPSP case
by pespin 09 Feb '26

09 Feb '26

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42025?usp=email ) Change subject: IPSP: don't route any incoming M3UA messages in IPSP case ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42025?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Iad7280619ec5814cda7a179418079048a5955976 Gerrit-Change-Number: 42025 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Feb 2026 14:25:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: lm: Initialize layer manager also on role=SG
by pespin 09 Feb '26

09 Feb '26

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42062?usp=email ) Change subject: lm: Initialize layer manager also on role=SG ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42062?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I1f25cf8371ba72d710796e01a9a967d3fafffb99 Gerrit-Change-Number: 42062 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Feb 2026 14:25:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: lm: Use layer manager also on transport-role=server
by pespin 09 Feb '26

09 Feb '26

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42059?usp=email ) Change subject: lm: Use layer manager also on transport-role=server ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42059?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I5f0109463323f214e15610b2c4fe253b828fce3b Gerrit-Change-Number: 42059 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Feb 2026 14:25:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: Refactor xua_layer_manager object
by pespin 09 Feb '26

09 Feb '26

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42054?usp=email ) Change subject: Refactor xua_layer_manager object ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42054?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ia96ebf40444f46ad718d61befbecb523f267fd6c Gerrit-Change-Number: 42054 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Feb 2026 14:25:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmocore[master]: logging: Support nonblocking-io for log target stderr & file, make it...
by pespin 09 Feb '26

09 Feb '26

Attention is currently required from: fixeria, laforge, osmith, pespin. Hello Jenkins Builder, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/42088?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: logging: Support nonblocking-io for log target stderr & file, make it default ...................................................................... logging: Support nonblocking-io for log target stderr & file, make it default The nonblocking-io used to be the mode used until recently, where wq only was used if the write buffer was full. This is more performant that always waiting for poll() to write, plus the fact that we write to system synchronously, hence seeing output immediatelly or not losing it if program crashes. Furthermore, It turns out using wq in multithreaded programs may cause problems, so better switch back to using nonblocking-io by default. Related: OS#6947 Change-Id: I46420f4b174d3a9ed01e993e2e89aea3b46c0dd7 --- M include/osmocom/core/logging.h M src/core/libosmocore.map M src/core/logging_file.c M src/vty/logging_vty.c M tests/logging/logging_vty_test.vty 5 files changed, 96 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/88/42088/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42088?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I46420f4b174d3a9ed01e993e2e89aea3b46c0dd7 Gerrit-Change-Number: 42088 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: osmo_io: Lazy-initialize during osmo_iofd_setup()
by pespin 09 Feb '26

09 Feb '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/42084?usp=email ) Change subject: osmo_io: Lazy-initialize during osmo_iofd_setup() ...................................................................... osmo_io: Lazy-initialize during osmo_iofd_setup() This way new threads (!=main) don't need to explicitly call osmo_iofd_init() explicitly before using osmo_io. This is specially useful for threads using osmo_io indirectly, eg, when logging. The osmo_iofd_setup() API is really the only main API which requires initialization. All other APIs requiring it come after osmo_iofd_setup() since they use an osmo_iofd pointer. Change-Id: Ia543c1b9d111c929cd9dbed266b6d21b74e47e4b --- M src/core/osmo_io.c 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index 9e159a1..7c59a61 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -69,9 +69,14 @@ /* Used by some tests, can't be static */ struct iofd_backend_ops osmo_iofd_ops; +static __thread bool g_thread_initialized = false; + /*! initialize osmo_io for the current thread */ void osmo_iofd_init(void) { + if (g_thread_initialized) + return; + switch (g_io_backend) { case OSMO_IO_BACKEND_POLL: break; @@ -84,6 +89,7 @@ OSMO_ASSERT(0); break; } + g_thread_initialized = true; } /* ensure main thread always has pre-initialized osmo_io @@ -833,6 +839,7 @@ const struct osmo_io_ops *ioops, void *data) { struct osmo_io_fd *iofd; + osmo_iofd_init(); /* reject unsupported/unknown modes */ switch (mode) { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42084?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia543c1b9d111c929cd9dbed266b6d21b74e47e4b Gerrit-Change-Number: 42084 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: osmo_io_uring: Split global init from per-thread init
by pespin 09 Feb '26

09 Feb '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/42083?usp=email ) Change subject: osmo_io_uring: Split global init from per-thread init ...................................................................... osmo_io_uring: Split global init from per-thread init osmo_iofd_init() is expected to be called per-thread, while some code in osmo_iofd_uring_init() was only expected to be called once. Change-Id: Ifa5c46d7532ea49869f3cfe7268fdd082906fd10 --- M src/core/osmo_io.c M src/core/osmo_io_internal.h M src/core/osmo_io_uring.c 3 files changed, 19 insertions(+), 10 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index e7645cb..9e159a1 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -101,6 +101,7 @@ } else if (!strcmp("IO_URING", backend)) { g_io_backend = OSMO_IO_BACKEND_IO_URING; osmo_iofd_ops = iofd_uring_ops; + osmo_iofd_uring_constructor(); #endif } else { fprintf(stderr, "Invalid osmo_io backend requested: \"%s\"\nCheck the environment variable %s\n", backend, OSMO_IO_BACKEND_ENV); diff --git a/src/core/osmo_io_internal.h b/src/core/osmo_io_internal.h index 6b642b9..81a70f3 100644 --- a/src/core/osmo_io_internal.h +++ b/src/core/osmo_io_internal.h @@ -21,6 +21,7 @@ #if defined(HAVE_URING) extern const struct iofd_backend_ops iofd_uring_ops; +void osmo_iofd_uring_constructor(void); void osmo_iofd_uring_init(void); #endif diff --git a/src/core/osmo_io_uring.c b/src/core/osmo_io_uring.c index 3925f94..6ae21cf 100644 --- a/src/core/osmo_io_uring.c +++ b/src/core/osmo_io_uring.c @@ -107,15 +107,15 @@ } /*! initialize the uring and tie it into our event loop */ -void osmo_iofd_uring_init(void) +void osmo_iofd_uring_constructor(void) { const char *env; - int rc, evfd; + int rc; if ((env = getenv(OSMO_IO_URING_BATCH))) g_io_uring_batch = true; - if (!g_ring && (env = getenv(OSMO_IO_URING_INITIAL_SIZE))) { + if ((env = getenv(OSMO_IO_URING_INITIAL_SIZE))) { int env_value; rc = osmo_str_to_int(&env_value, env, 10, 1, IOFD_URING_MAXIMUM_SIZE); if (rc < 0) { @@ -130,13 +130,6 @@ g_io_uring_size = env_value; } - g_ring = talloc_zero(OTC_GLOBAL, struct osmo_io_uring); - INIT_LLIST_HEAD(&g_ring->cancel_queue); - - rc = io_uring_queue_init(g_io_uring_size, &g_ring->ring, 0); - if (rc < 0) - osmo_panic("failure during io_uring_queue_init(): %s\n", strerror(-rc)); - if ((env = getenv(OSMO_IO_URING_READ_SQE))) { g_io_uring_read_sqes = atoi(env); if (g_io_uring_read_sqes < 1 || g_io_uring_read_sqes > IOFD_MSGHDR_MAX_READ_SQES) { @@ -145,6 +138,20 @@ exit(1); } } +} + +/*! Per-thread: initialize the uring and tie it into our event loop */ +void osmo_iofd_uring_init(void) +{ + int rc, evfd; + + g_ring = talloc_zero(OTC_GLOBAL, struct osmo_io_uring); + OSMO_ASSERT(g_ring); + INIT_LLIST_HEAD(&g_ring->cancel_queue); + + rc = io_uring_queue_init(g_io_uring_size, &g_ring->ring, 0); + if (rc < 0) + osmo_panic("failure during io_uring_queue_init(): %s\n", strerror(-rc)); rc = eventfd(0, 0); if (rc < 0) { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42083?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ifa5c46d7532ea49869f3cfe7268fdd082906fd10 Gerrit-Change-Number: 42083 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: osmo_io: Lazy-initialize during osmo_iofd_setup()
by pespin 09 Feb '26

09 Feb '26

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/42084?usp=email ) Change subject: osmo_io: Lazy-initialize during osmo_iofd_setup() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42084?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia543c1b9d111c929cd9dbed266b6d21b74e47e4b Gerrit-Change-Number: 42084 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Feb 2026 14:23:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log February 2026