February 2026 - gerrit-log - lists.osmocom.org

[M] Change in libosmocore[master]: logging: Support nonblocking-io for log target stderr & file, make it...
by pespin 09 Feb '26

09 Feb '26

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/42088?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: logging: Support nonblocking-io for log target stderr & file, make it default ...................................................................... logging: Support nonblocking-io for log target stderr & file, make it default The nonblocking-io used to be the mode used until recently, where wq only was used if the write buffer was full. This is more performant that always waiting for poll() to write, plus the fact that we write to system synchronously, hence seeing output immediatelly or not losing it if program crashes. Furthermore, It turns out using wq in multithreaded programs may cause problems, so better switch back to using nonblocking-io by default. Related: OS#6947 Change-Id: I46420f4b174d3a9ed01e993e2e89aea3b46c0dd7 --- M include/osmocom/core/logging.h M src/core/libosmocore.map M src/core/logging_file.c M src/vty/logging_vty.c M tests/logging/logging_vty_test.vty 5 files changed, 96 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/88/42088/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42088?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I46420f4b174d3a9ed01e993e2e89aea3b46c0dd7 Gerrit-Change-Number: 42088 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[XS] Change in pysim[master]: pySim/global_platform: replace deprecated argument group() creation
by osmith 09 Feb '26

09 Feb '26

Attention is currently required from: lynxis lazus. osmith has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/pysim/+/42066?usp=email ) Change subject: pySim/global_platform: replace deprecated argument group() creation ...................................................................... Patch Set 3: (1 comment) File pySim/global_platform/__init__.py: https://gerrit.osmocom.org/c/pysim/+/42066/comment/521c13db_afe48a16?usp=em… : PS3, Line 868: install_cap_parser_inst_prm_g_grp = install_cap_parser.add_argument_group() I looked into the CI failure (docs): ``` File "/usr/local/lib/python3.13/dist-packages/sphinxarg/ext.py", line 96, in print_action_groups section = nodes.section(ids=[action_group['title'].replace(' ', '-').lower()]) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ AttributeError: 'NoneType' object has no attribute 'replace' ``` sphinxargs trips over the group not having a title for some reason, with this it works: ```py install_cap_parser_inst_prm_g_grp = install_cap_parser.add_argument_group("title") ``` upstream code: https://github.com/sphinx-doc/sphinx-argparse/blob/61b8bf0e2ffab20664acaba9… -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42066?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4f73d3417a12b7fe94e33a265cdae244f3c9a1e9 Gerrit-Change-Number: 42066 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 09 Feb 2026 13:23:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in pysim[master]: pySim/global_platform: replace deprecated argument group() creation
by laforge 09 Feb '26

09 Feb '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/pysim/+/42066?usp=email ) Change subject: pySim/global_platform: replace deprecated argument group() creation ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: ``` File "/usr/local/lib/python3.13/dist-packages/sphinxarg/ext.py", line 96, in print_action_groups section = nodes.section(ids=[action_group['title'].replace(' ', '-').lower()]) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ AttributeError: 'NoneType' object has no attribute 'replace' ``` -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42066?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4f73d3417a12b7fe94e33a265cdae244f3c9a1e9 Gerrit-Change-Number: 42066 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 09 Feb 2026 13:10:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in libosmocore[master]: logging: Support nonblocking-io for log target stderr & file, make it...
by pespin 09 Feb '26

09 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/42088?usp=email ) Change subject: logging: Support nonblocking-io for log target stderr & file, make it default ...................................................................... logging: Support nonblocking-io for log target stderr & file, make it default The nonblocking-io used to be the mode used until recently, where wq only was used if the write buffer was full. This is more performant that always waiting for poll() to write, plus the fact that we write to system synchronously, hence seeing output immediatelly or not losing it if program crashes. Furthermore, It turns out using wq in multithreaded programs may cause problems, so better switch back to using nonblocking-io by default. Related: OS#6947 Change-Id: I46420f4b174d3a9ed01e993e2e89aea3b46c0dd7 --- M include/osmocom/core/logging.h M src/core/libosmocore.map M src/core/logging_file.c M src/vty/logging_vty.c 4 files changed, 89 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/88/42088/1 diff --git a/include/osmocom/core/logging.h b/include/osmocom/core/logging.h index ac6e553..1a5cb7c 100644 --- a/include/osmocom/core/logging.h +++ b/include/osmocom/core/logging.h @@ -457,6 +457,8 @@ int log_target_file_reopen(struct log_target *tgt); int log_target_file_switch_to_stream(struct log_target *tgt); int log_target_file_switch_to_wqueue(struct log_target *tgt); +int log_target_file_get_nonblock(const struct log_target *target); +int log_target_file_set_nonblock(struct log_target *target, int on); int log_targets_reopen(void); void log_add_target(struct log_target *target); diff --git a/src/core/libosmocore.map b/src/core/libosmocore.map index 5a3c3e8..06a9009 100644 --- a/src/core/libosmocore.map +++ b/src/core/libosmocore.map @@ -103,7 +103,9 @@ log_target_create_systemd; log_target_create_emscripten; log_target_destroy; +log_target_file_get_nonblock; log_target_file_reopen; +log_target_file_set_nonblock; log_target_file_switch_to_stream; log_target_file_switch_to_wqueue; log_target_find; diff --git a/src/core/logging_file.c b/src/core/logging_file.c index 067f993..3657d16 100644 --- a/src/core/logging_file.c +++ b/src/core/logging_file.c @@ -52,6 +52,7 @@ { struct osmo_io_fd *iofd; int rc; + int nonblock_flag = O_NONBLOCK; OSMO_ASSERT(target->type == LOG_TGT_TYPE_FILE || target->type == LOG_TGT_TYPE_STDERR); @@ -60,6 +61,7 @@ return -ENOTSUP; if (target->tgt_file.out) { /* stream mode */ + nonblock_flag = log_target_file_get_nonblock(target) == 1 ? O_NONBLOCK : 0; fclose(target->tgt_file.out); target->tgt_file.out = fopen(target->tgt_file.fname, "a"); if (!target->tgt_file.out) @@ -73,7 +75,7 @@ osmo_iofd_close(iofd); target->tgt_file.wqueue->bfd.fd = -1; /* Keep public field changes despite not used internally... */ - rc = open(target->tgt_file.fname, O_WRONLY|O_APPEND|O_CREAT|O_NONBLOCK, 0660); + rc = open(target->tgt_file.fname, O_WRONLY|O_APPEND|O_CREAT|nonblock_flag, 0660); if (rc < 0) return -errno; @@ -89,6 +91,62 @@ #if (!EMBEDDED) +/*! Set the log target fd as non-blocking (see sockopt O_NONBLOCK). + * \param[in] target log target which we should switch + * \param[in] on set to 1 to set as non-blocking, 0 to set as blocking. + * \returns 0 on success; negative on error + * + * This setting is ignored when \ref target is in wqueue mode. + */ +int log_target_file_set_nonblock(struct log_target *target, int on) +{ + int flags; + int fd; + + if (!target->tgt_file.out) + return 0; + + fd = fileno(target->tgt_file.out); + if (fd < 0) + return fd; + + flags = fcntl(fd, F_GETFL); + if (flags < 0) + return flags; + + if (on) + flags |= O_NONBLOCK; + else + flags &= ~O_NONBLOCK; + + flags = fcntl(fd, F_SETFL, flags); + if (flags < 0) + return flags; + return 0; +} + +/*! Find whether the log target fd is confiured as non-blocking (see sockopt O_NONBLOCK). + * \param[in] target log target which we should switch + * \returns 1 if set as non-block; 0 otherse; negative on error + */ +int log_target_file_get_nonblock(const struct log_target *target) +{ + int flags; + int fd; + + if (!target->tgt_file.out) + return -1; + + fd = fileno(target->tgt_file.out); + if (fd < 0) + return fd; + + flags = fcntl(fd, F_GETFL); + if (flags < 0) + return flags; + return (flags & O_NONBLOCK) ? 1 : 0; +} + /* This is the file-specific subclass destructor logic, called from * log_target_destroy(). User should call log_target_destroy() to destroy this * object. */ diff --git a/src/vty/logging_vty.c b/src/vty/logging_vty.c index 3fa62a1..5d5fa85 100644 --- a/src/vty/logging_vty.c +++ b/src/vty/logging_vty.c @@ -886,11 +886,15 @@ } DEFUN(cfg_log_stderr, cfg_log_stderr_cmd, - "log stderr [blocking-io]", + "log stderr [(nonblocking-io|blocking-io|wq)]", LOG_STR "Logging via STDERR of the process\n" - "Use blocking, synchronous I/O\n") + "Use non-blocking, synchronous I/O (may lose msgs if file write buffer becomes full) (default)\n" + "Use blocking, synchronous I/O (only for debug purposes or when blocking is acceptable)\n" + "Use Tx workqueue, asynchronous I/O (may lose msgs if queue becomes full)\n") { struct log_target *tgt; + bool wq_mode = argc > 0 && (strcmp(argv[0], "wq") == 0); + bool blocking_io = argc > 0 && (strcmp(argv[0], "blocking-io") == 0); log_tgt_mutex_lock(); tgt = log_target_find(LOG_TGT_TYPE_STDERR, NULL); @@ -904,10 +908,12 @@ log_add_target(tgt); } - if (argc > 0 && !strcmp(argv[0], "blocking-io")) - log_target_file_switch_to_stream(tgt); - else + if (wq_mode) { log_target_file_switch_to_wqueue(tgt); + } else { + log_target_file_switch_to_stream(tgt); + log_target_file_set_nonblock(tgt, blocking_io ? 0 : 1); + } vty->index = tgt; vty->node = CFG_LOG_NODE; @@ -935,11 +941,15 @@ } DEFUN(cfg_log_file, cfg_log_file_cmd, - "log file FILENAME [blocking-io]", + "log file FILENAME [(nonblocking-io|blocking-io|wq)]", LOG_STR "Logging to text file\n" "Filename\n" - "Use blocking, synchronous I/O\n") + "Use non-blocking, synchronous I/O (may lose msgs if file write buffer becomes full) (default)\n" + "Use blocking, synchronous I/O (only for debug purposes or when blocking is acceptable)\n" + "Use Tx workqueue, asynchronous I/O (may lose msgs if queue becomes full)\n") { const char *fname = argv[0]; + bool wq_mode = argc > 1 && (strcmp(argv[1], "wq") == 0); + bool blocking_io = argc > 1 && (strcmp(argv[1], "blocking-io") == 0); struct log_target *tgt; log_tgt_mutex_lock(); @@ -954,10 +964,12 @@ log_add_target(tgt); } - if (argc > 1 && !strcmp(argv[1], "blocking-io")) - log_target_file_switch_to_stream(tgt); - else + if (wq_mode) { log_target_file_switch_to_wqueue(tgt); + } else { + log_target_file_switch_to_stream(tgt); + log_target_file_set_nonblock(tgt, blocking_io ? 0 : 1); + } vty->index = tgt; vty->node = CFG_LOG_NODE; @@ -1086,7 +1098,8 @@ if (tgt->tgt_file.wqueue) vty_out(vty, "log stderr%s", VTY_NEWLINE); else - vty_out(vty, "log stderr blocking-io%s", VTY_NEWLINE); + vty_out(vty, "log stderr%s%s", + log_target_file_get_nonblock(tgt) == 0 ? " blocking-io" : "", VTY_NEWLINE); break; case LOG_TGT_TYPE_SYSLOG: #ifdef ENABLE_SYSLOG_LOGGING @@ -1100,7 +1113,8 @@ if (tgt->tgt_file.wqueue) vty_out(vty, "log file %s%s", tgt->tgt_file.fname, VTY_NEWLINE); else - vty_out(vty, "log file %s blocking-io%s", tgt->tgt_file.fname, VTY_NEWLINE); + vty_out(vty, "log file %s%s%s", tgt->tgt_file.fname, + log_target_file_get_nonblock(tgt) == 0 ? " blocking-io" : "", VTY_NEWLINE); break; case LOG_TGT_TYPE_STRRB: vty_out(vty, "log alarms %zu%s", -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42088?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I46420f4b174d3a9ed01e993e2e89aea3b46c0dd7 Gerrit-Change-Number: 42088 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: Osmocom_OBS_sync: fix failing on new scmsync tag
by pespin 09 Feb '26

09 Feb '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42087?usp=email ) Change subject: Osmocom_OBS_sync: fix failing on new scmsync tag ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42087?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia2d2ce3a2eeda9a0ed7ce7c7de54293081b44f4e Gerrit-Change-Number: 42087 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Feb 2026 12:58:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: pySim.esim.saip: Fix docstring warnings:
by laforge 09 Feb '26

09 Feb '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42078?usp=email ) Change subject: pySim.esim.saip: Fix docstring warnings: ...................................................................... pySim.esim.saip: Fix docstring warnings: this fixes the following two warnings: pySim/esim/saip/__init__.py:docstring of pySim.esim.saip.FsNode.walk:1: WARNING: Inline strong start-string without end-string. [docutils] pySim/esim/saip/__init__.py:docstring of pySim.esim.saip.FsNodeDF.walk:1: WARNING: Inline strong start-string without end-string. [docutils] Change-Id: Id7debf9296923b735f76623808cee68967a1ece7 --- M pySim/esim/saip/__init__.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py index 6962ee8..a50e86f 100644 --- a/pySim/esim/saip/__init__.py +++ b/pySim/esim/saip/__init__.py @@ -2004,7 +2004,7 @@ return x def walk(self, fn, **kwargs): - """call 'fn(self, **kwargs) for the File.""" + """call 'fn(self, ``**kwargs``) for the File.""" return [fn(self, **kwargs)] class FsNodeEF(FsNode): @@ -2094,7 +2094,7 @@ return cur def walk(self, fn, **kwargs): - """call 'fn(self, **kwargs) for the DF and recursively for all children.""" + """call 'fn(self, ``**kwargs``) for the DF and recursively for all children.""" ret = super().walk(fn, **kwargs) for c in self.children.values(): ret += c.walk(fn, **kwargs) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42078?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id7debf9296923b735f76623808cee68967a1ece7 Gerrit-Change-Number: 42078 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: pysim.utils.decomposeATR: Fix docutils warning
by laforge 09 Feb '26

09 Feb '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42079?usp=email ) Change subject: pysim.utils.decomposeATR: Fix docutils warning ...................................................................... pysim.utils.decomposeATR: Fix docutils warning pySim/utils.py:docstring of pySim.utils.decomposeATR:9: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils] Change-Id: Ifda4ba15014ba97634fd5bd5c9b19d9110f4670e --- M pySim/utils.py 1 file changed, 11 insertions(+), 9 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/pySim/utils.py b/pySim/utils.py index 7d8e3fa..1fdcefe 100644 --- a/pySim/utils.py +++ b/pySim/utils.py @@ -631,15 +631,17 @@ Returns: dictionary of field and values - >>> decomposeATR("3B A7 00 40 18 80 65 A2 08 01 01 52") - { 'T0': {'value': 167}, - 'TB': {1: {'value': 0}}, - 'TC': {2: {'value': 24}}, - 'TD': {1: {'value': 64}}, - 'TS': {'value': 59}, - 'atr': [59, 167, 0, 64, 24, 128, 101, 162, 8, 1, 1, 82], - 'hb': {'value': [128, 101, 162, 8, 1, 1, 82]}, - 'hbn': 7} + Example:: + + >>> decomposeATR("3B A7 00 40 18 80 65 A2 08 01 01 52") + { 'T0': {'value': 167}, + 'TB': {1: {'value': 0}}, + 'TC': {2: {'value': 24}}, + 'TD': {1: {'value': 64}}, + 'TS': {'value': 59}, + 'atr': [59, 167, 0, 64, 24, 128, 101, 162, 8, 1, 1, 82], + 'hb': {'value': [128, 101, 162, 8, 1, 1, 82]}, + 'hbn': 7} """ ATR_PROTOCOL_TYPE_T0 = 0 atr_txt = normalizeATR(atr_txt) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42079?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ifda4ba15014ba97634fd5bd5c9b19d9110f4670e Gerrit-Change-Number: 42079 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: pySim.esim.saip.personalization: Fix docstring error
by laforge 09 Feb '26

09 Feb '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42080?usp=email ) Change subject: pySim.esim.saip.personalization: Fix docstring error ...................................................................... pySim.esim.saip.personalization: Fix docstring error pySim/esim/saip/personalization.py:docstring of pySim.esim.saip.personalization.MilenageXoringConstants:4: ERROR: Unexpected indentation. [docutils] Change-Id: If6ae360b7f74c095fa9075ae9aa988440496e6de --- M pySim/esim/saip/personalization.py 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py index 54aaa43..c61675f 100644 --- a/pySim/esim/saip/personalization.py +++ b/pySim/esim/saip/personalization.py @@ -640,12 +640,14 @@ class MilenageXoringConstants(BinaryParam, AlgoConfig): """XOR-ing constants c1,c2,c3,c4,c5 of Milenage, 128bit each. See 3GPP TS 35.206 Sections 2.3 + 5.3. Provided as octet-string concatenation of all 5 constants. The default value by 3GPP is the concetenation - of: + of:: + 00000000000000000000000000000000 00000000000000000000000000000001 00000000000000000000000000000002 00000000000000000000000000000004 00000000000000000000000000000008 + """ name = 'MilenageXOR' algo_config_key = 'xoringConstants' -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42080?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If6ae360b7f74c095fa9075ae9aa988440496e6de Gerrit-Change-Number: 42080 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[M] Change in pysim[master]: pySim.esim.saip.personalization: Fix docstring errors + warnings
by laforge 09 Feb '26

09 Feb '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42081?usp=email ) Change subject: pySim.esim.saip.personalization: Fix docstring errors + warnings ...................................................................... pySim.esim.saip.personalization: Fix docstring errors + warnings pysim/pySim/esim/saip/personalization.py:docstring of pySim.esim.saip.personalization.ConfigurableParameter:27: ERROR: Unexpected indentation. [docutils] pysim/pySim/esim/saip/personalization.py:docstring of pySim.esim.saip.personalization.ConfigurableParameter:29: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils] pysim/pySim/esim/saip/personalization.py:docstring of pySim.esim.saip.personalization.ConfigurableParameter:34: ERROR: Unexpected indentation. [docutils] pysim/pySim/esim/saip/personalization.py:docstring of pySim.esim.saip.personalization.ConfigurableParameter:35: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils] pysim/pySim/esim/saip/personalization.py:docstring of pySim.esim.saip.personalization.ConfigurableParameter:52: ERROR: Unexpected indentation. [docutils] pysim/pySim/esim/saip/personalization.py:docstring of pySim.esim.saip.personalization.ConfigurableParameter:53: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils] Change-Id: I3918308856c3a1a5e6e90561c3e2a6b88040670d --- M pySim/esim/saip/personalization.py 1 file changed, 27 insertions(+), 26 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py index c61675f..8bf9a70 100644 --- a/pySim/esim/saip/personalization.py +++ b/pySim/esim/saip/personalization.py @@ -69,40 +69,41 @@ Usage examples, by example of Iccid: - 1) use a ConfigurableParameter instance, with .input_value and .value state: + 1) use a ConfigurableParameter instance, with .input_value and .value state:: - iccid = Iccid() - try: - iccid.input_value = '123456789012345678' - iccid.validate() - except ValueError: - print(f"failed to validate {iccid.name} == {iccid.input_value}") + iccid = Iccid() + try: + iccid.input_value = '123456789012345678' + iccid.validate() + except ValueError: + print(f"failed to validate {iccid.name} == {iccid.input_value}") - pes = ProfileElementSequence.from_der(der_data_from_file) - try: - iccid.apply(pes) - except ValueError: - print(f"failed to apply {iccid.name} := {iccid.input_value}") + pes = ProfileElementSequence.from_der(der_data_from_file) + try: + iccid.apply(pes) + except ValueError: + print(f"failed to apply {iccid.name} := {iccid.input_value}") - changed_der = pes.to_der() + changed_der = pes.to_der() - 2) use a ConfigurableParameter class, without state: + 2) use a ConfigurableParameter class, without state:: - cls = Iccid - input_val = '123456789012345678' + cls = Iccid + input_val = '123456789012345678' - try: - clean_val = cls.validate_val(input_val) - except ValueError: - print(f"failed to validate {cls.get_name()} = {input_val}") + try: + clean_val = cls.validate_val(input_val) + except ValueError: + print(f"failed to validate {cls.get_name()} = {input_val}") - pes = ProfileElementSequence.from_der(der_data_from_file) - try: - cls.apply_val(pes, clean_val) - except ValueError: - print(f"failed to apply {cls.get_name()} = {input_val}") + pes = ProfileElementSequence.from_der(der_data_from_file) + try: + cls.apply_val(pes, clean_val) + except ValueError: + print(f"failed to apply {cls.get_name()} = {input_val}") - changed_der = pes.to_der() + changed_der = pes.to_der() + """ # A subclass can set an explicit string as name (like name = "PIN1"). -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42081?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3918308856c3a1a5e6e90561c3e2a6b88040670d Gerrit-Change-Number: 42081 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[M] Change in pysim[master]: pySim.esim.saip.personalization: Fix docstring errors + warnings
by laforge 09 Feb '26

09 Feb '26

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/42081?usp=email ) Change subject: pySim.esim.saip.personalization: Fix docstring errors + warnings ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42081?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3918308856c3a1a5e6e90561c3e2a6b88040670d Gerrit-Change-Number: 42081 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 09 Feb 2026 12:50:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log February 2026