February 2026 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-asn1-tcap[master]: WIP: talloc
by pespin 26 Feb '26

26 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219?usp=email ) Change subject: WIP: talloc ...................................................................... WIP: talloc Change-Id: I6d885527caa5b60011b4fac341b93026ab1833d9 --- M configure.ac M debian/control M include/osmocom/tcap/asn_internal.h M libosmo-asn1-tcap.pc.in M src/Makefile.am M src/tcap.c M tests/parse/Makefile.am 7 files changed, 27 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-asn1-tcap refs/changes/19/42219/1 diff --git a/configure.ac b/configure.ac index 5082daf..28aa608 100644 --- a/configure.ac +++ b/configure.ac @@ -31,6 +31,8 @@ AC_SUBST([ASN_MODULE_CFLAGS]) +PKG_CHECK_MODULES(TALLOC, [talloc >= 2.1.0]) + # The following test is taken from WebKit's webkit.m4 saved_CFLAGS="$CFLAGS" CFLAGS="$CFLAGS -fvisibility=hidden " diff --git a/debian/control b/debian/control index 2dee434..52ffffe 100644 --- a/debian/control +++ b/debian/control @@ -10,6 +10,7 @@ git, libtool, pkg-config, + libtalloc-dev (>= 2.1.0) Standards-Version: 3.9.6 Vcs-Browser: https://gitea.osmocom.org/ss7-in-c/libosmo-asn1-tcap Vcs-Git: https://gitea.osmocom.org/ss7-in-c/libosmo-asn1-tcap @@ -25,7 +26,9 @@ Package: libosmo-asn1-tcap-dev Section: libdevel Architecture: any -Depends: libosmo-asn1-tcap1 (= ${binary:Version}), ${misc:Depends} +Depends: libosmo-asn1-tcap1 (= ${binary:Version}), + libtalloc-dev (>= 2.1.0), + ${misc:Depends} Multi-Arch: same Description: Development headers for utility library for ASN.1 of TCAP (SS7) diff --git a/include/osmocom/tcap/asn_internal.h b/include/osmocom/tcap/asn_internal.h index bf5b510..f4337d3 100644 --- a/include/osmocom/tcap/asn_internal.h +++ b/include/osmocom/tcap/asn_internal.h @@ -7,6 +7,7 @@ */ #ifndef ASN_INTERNAL_H #define ASN_INTERNAL_H +#include <talloc.h> #ifndef __EXTENSIONS__ #define __EXTENSIONS__ /* for Sun */ #endif @@ -34,10 +35,11 @@ #define ASN1C_ENVIRONMENT_VERSION 923 /* Compile-time version */ int get_asn1c_environment_version(void); /* Run-time version */ -#define CALLOC(nmemb, size) calloc(nmemb, size) -#define MALLOC(size) malloc(size) -#define REALLOC(oldptr, size) realloc(oldptr, size) -#define FREEMEM(ptr) free(ptr) +extern void *tcap_talloc_asn1_ctx; +#define CALLOC(nmemb, size) talloc_zero_size(tcap_talloc_asn1_ctx, (nmemb) * (size)) +#define MALLOC(size) talloc_size(tcap_talloc_asn1_ctx, size) +#define REALLOC(oldptr, size) talloc_realloc_size(tcap_talloc_asn1_ctx, oldptr, size) +#define FREEMEM(ptr) talloc_free(ptr) #define asn_debug_indent 0 #define ASN_DEBUG_INDENT_ADD(i) do{}while(0) diff --git a/libosmo-asn1-tcap.pc.in b/libosmo-asn1-tcap.pc.in index 17971a1..80dd622 100644 --- a/libosmo-asn1-tcap.pc.in +++ b/libosmo-asn1-tcap.pc.in @@ -6,5 +6,6 @@ Name: ASN.1 library for TCAP protocol (SS7) Description: C Utility Library Version: @VERSION@ +Requires.private: talloc Libs: -L${libdir} -losmo-asn1-tcap Cflags: -I${includedir}/ diff --git a/src/Makefile.am b/src/Makefile.am index 6c2f830..42089af 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1,4 +1,4 @@ -AM_CFLAGS = -I$(top_srcdir)/include/ -I$(top_srcdir)/src/skel $(ASN_MODULE_CFLAGS) +AM_CFLAGS = -I$(top_srcdir)/include/ -I$(top_srcdir)/src/skel $(ASN_MODULE_CFLAGS) $(TALLOC_CFLAGS) SKEL_SRC = \ skel/ANY.c \ @@ -201,6 +201,8 @@ libosmo_asn1_tcap_la_LDFLAGS = -version-info $(LIBVERSION) -no-undefined -export-symbols-regex '^osmo_' +libosmo_asn1_tcap_la_LIBADD = $(TALLOC_LIBS) + libosmo_asn1_tcap_la_SOURCES = \ tcap.c \ $(ASN_MODULE_SRC) @@ -239,6 +241,13 @@ # #include <...> in *.c and *.h files cd $(top_srcdir)/src/gen && \ ../../move-asn1-header-files.sh osmocom/tcap $(ASN_MODULE_INC) +#Patch mem alloc defines to use talloc: + sed -i "s/#define\tASN_INTERNAL_H/#define\tASN_INTERNAL_H\n#include <talloc.h>/g" $(top_srcdir)/include/osmocom/tcap/asn_internal.h + sed -i "s/#define\tCALLOC/extern void *tcap_talloc_asn1_ctx;\n#define\tCALLOC/g" $(top_srcdir)/include/osmocom/tcap/asn_internal.h + sed -i "s/calloc(nmemb, size)/talloc_zero_size(tcap_talloc_asn1_ctx, (nmemb) * (size))/g" $(top_srcdir)/include/osmocom/tcap/asn_internal.h + sed -i "s/malloc(size)/talloc_size(tcap_talloc_asn1_ctx, size)/g" $(top_srcdir)/include/osmocom/tcap/asn_internal.h + sed -i "s/realloc(oldptr, size)/talloc_realloc_size(tcap_talloc_asn1_ctx, oldptr, size)/g" $(top_srcdir)/include/osmocom/tcap/asn_internal.h + sed -i "s/free(ptr)/talloc_free(ptr)/g" $(top_srcdir)/include/osmocom/tcap/asn_internal.h # Move skeleton *.c files to src/skel rm -rf $(top_srcdir)/src/skel mkdir $(top_srcdir)/src/skel diff --git a/src/tcap.c b/src/tcap.c index 68c7d9c..f5303ac 100644 --- a/src/tcap.c +++ b/src/tcap.c @@ -26,6 +26,8 @@ #include <osmocom/tcap/asn_codecs.h> #include <osmocom/tcap/TCAP_TCMessage.h> +void *tcap_talloc_asn1_ctx; + int osmo_asn1_tcap_decode(struct TCAP_TCMessage *tcapmsg, const uint8_t *data, size_t data_len) { diff --git a/tests/parse/Makefile.am b/tests/parse/Makefile.am index 821865d..1a449fe 100644 --- a/tests/parse/Makefile.am +++ b/tests/parse/Makefile.am @@ -1,8 +1,8 @@ AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_srcdir)/src -AM_CFLAGS = -Wall +AM_CFLAGS = -Wall $(TALLOC_CFLAGS) AM_LDFLAGS = -no-install -LDADD = $(top_builddir)/src/.libs/libosmo-asn1-tcap.a +LDADD = $(top_builddir)/src/.libs/libosmo-asn1-tcap.a $(TALLOC_LIBS) check_PROGRAMS = \ tcap_parse_test \ -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I6d885527caa5b60011b4fac341b93026ab1833d9 Gerrit-Change-Number: 42219 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ci[master]: lint/checkpatch: support multiple configs
by osmith 26 Feb '26

26 Feb '26

Attention is currently required from: osmith, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42215?usp=email ) Change subject: lint/checkpatch: support multiple configs ...................................................................... Patch Set 1: (1 comment) File lint/lint_all.sh: https://gerrit.osmocom.org/c/osmo-ci/+/42215/comment/3009a604_02aa63ab?usp=… : PS1, Line 19: echo "" | "$SCRIPT_DIR"/checkpatch/checkpatch.pl \ > actually it is only needed below, here checkpatch.pl gets called directly, will update the patch. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42215?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia2e75d9783382cefc3900a4ab51a5a919a2cbbbc Gerrit-Change-Number: 42215 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Feb 2026 13:22:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ci[master]: lint/checkpatch: support multiple configs
by osmith 26 Feb '26

26 Feb '26

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/42215?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: lint/checkpatch: support multiple configs ...................................................................... lint/checkpatch: support multiple configs Run checkpatch with any .checkpatch*.conf found in the project dir. This is in preparation for having two .checkpatch.conf files in osmo-trx, in order to use different linting rules for C++ code: * .checkpatch.c.conf * .checkpatch.c++.conf Related: osmo-trx I0df5b6f2f0bf1469a80a1f5859809c30f523f683 Change-Id: Ia2e75d9783382cefc3900a4ab51a5a919a2cbbbc --- M .gitignore M lint/checkpatch/checkpatch.pl M lint/checkpatch/checkpatch_json.py M lint/checkpatch/checkpatch_osmo.sh M lint/lint_all.sh 5 files changed, 74 insertions(+), 47 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/15/42215/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42215?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia2e75d9783382cefc3900a4ab51a5a919a2cbbbc Gerrit-Change-Number: 42215 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ci[master]: lint/checkpatch: support multiple configs
by pespin 26 Feb '26

26 Feb '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42215?usp=email ) Change subject: lint/checkpatch: support multiple configs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42215?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia2e75d9783382cefc3900a4ab51a5a919a2cbbbc Gerrit-Change-Number: 42215 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Feb 2026 13:21:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ci[master]: lint/checkpatch: support multiple configs
by osmith 26 Feb '26

26 Feb '26

Attention is currently required from: pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42215?usp=email ) Change subject: lint/checkpatch: support multiple configs ...................................................................... Patch Set 1: (1 comment) File lint/lint_all.sh: https://gerrit.osmocom.org/c/osmo-ci/+/42215/comment/f31022a6_88ebaa89?usp=… : PS1, Line 19: echo "" | "$SCRIPT_DIR"/checkpatch/checkpatch.pl \ > The other script `lint/lint_diff.sh` passes `git diff -U0 $COMMIT` on stdin to `checkpatch_osmo.sh`. […] actually it is only needed below, here checkpatch.pl gets called directly, will update the patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42215?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia2e75d9783382cefc3900a4ab51a5a919a2cbbbc Gerrit-Change-Number: 42215 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Feb 2026 13:21:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ci[master]: lint/checkpatch: support multiple configs
by osmith 26 Feb '26

26 Feb '26

Attention is currently required from: pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42215?usp=email ) Change subject: lint/checkpatch: support multiple configs ...................................................................... Patch Set 1: (1 comment) File lint/lint_all.sh: https://gerrit.osmocom.org/c/osmo-ci/+/42215/comment/9b76ac60_ad68ed2c?usp=… : PS1, Line 19: echo "" | "$SCRIPT_DIR"/checkpatch/checkpatch.pl \ > why is this echo needed now? The other script `lint/lint_diff.sh` passes `git diff -U0 $COMMIT` on stdin to `checkpatch_osmo.sh`. This needs to be stored in a temp file and sent to each instance of `checkpatch` now that we potentially run it multiple times. I've implemented this with: ``` # This script gets called with stdin set to a git diff or empty string. Put it # into a temp file so we can pass it along to checkpatch multiple times. cat >"$STDIN_TEMP" ``` The `echo ""` is needed so the script doesn't stop at this `cat` line. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42215?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia2e75d9783382cefc3900a4ab51a5a919a2cbbbc Gerrit-Change-Number: 42215 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Feb 2026 13:20:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ci[master]: lint/checkpatch: support multiple configs
by pespin 26 Feb '26

26 Feb '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42215?usp=email ) Change subject: lint/checkpatch: support multiple configs ...................................................................... Patch Set 1: (1 comment) File lint/lint_all.sh: https://gerrit.osmocom.org/c/osmo-ci/+/42215/comment/cec2aaf8_a6bb9934?usp=… : PS1, Line 19: echo "" | "$SCRIPT_DIR"/checkpatch/checkpatch.pl \ why is this echo needed now? -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42215?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia2e75d9783382cefc3900a4ab51a5a919a2cbbbc Gerrit-Change-Number: 42215 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Feb 2026 13:17:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-trx[master]: checkpatch.conf: lint more code
by pespin 26 Feb '26

26 Feb '26

Attention is currently required from: Hoernchen, laforge, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-trx/+/42204?usp=email ) Change subject: checkpatch.conf: lint more code ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42204?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I0df5b6f2f0bf1469a80a1f5859809c30f523f683 Gerrit-Change-Number: 42204 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 26 Feb 2026 13:14:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-trx[master]: checkpatch.conf: lint more code
by osmith 26 Feb '26

26 Feb '26

Attention is currently required from: Hoernchen, laforge, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-trx/+/42204?usp=email ) Change subject: checkpatch.conf: lint more code ...................................................................... Patch Set 3: (1 comment) File .checkpatch.conf: https://gerrit.osmocom.org/c/osmo-trx/+/42204/comment/71e78a11_6c390f93?usp… : PS2, Line 4: --ignore INDENTED_LABEL > Can we apply these ignores only to c++ files? We still have multiple . […] I have updated the patch to now have separate configs for C and C++ files. It now depends on https://gerrit.osmocom.org/c/osmo-ci/+/42215. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42204?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I0df5b6f2f0bf1469a80a1f5859809c30f523f683 Gerrit-Change-Number: 42204 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Feb 2026 13:10:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-trx[master]: checkpatch.conf: lint more code
by osmith 26 Feb '26

26 Feb '26

Attention is currently required from: Hoernchen, laforge, osmith. Hello Hoernchen, Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/42204?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: checkpatch.conf: lint more code ...................................................................... checkpatch.conf: lint more code The current linter configuration misses to find lots of formatting errors as we've seen here: https://gerrit.osmocom.org/c/osmo-trx/+/42198/comments/f8f1b5a2_3c7e1389 This is caused by the following exclude rules in .checkpatch.conf, which were added there to avoid that some of the checkpatch rules don't work correctly with C++ code: ---exclude .*h ---exclude Transceiver52M/grgsm_vitac/.* ---exclude utils/va-test/.* Fix this by splitting the .checkpatch.conf into two files, .checkpatch.c.conf and .checkpatch.c++.conf. Let the C version use the default rules. Let the C++ version ignore the rules that don't work with C++ code: * SPACING Fails on: std::vector<std::string> With: ERROR:SPACING: spaces required around that '<' (ctx:VxV) ERROR:SPACING: spaces required around that '>' (ctx:VxW) * FUNCTION_ARGUMENTS Fails on: ScopedLock lock(mLock); With: WARNING:FUNCTION_ARGUMENTS: function definition argument 'mLock' should also have an identifier name * INDENTED_LABEL Fails on: private: protected: With: WARNING:INDENTED_LABEL: labels should not be indented * NEW_TYPEDEFS Fails on: typedef std::map<K,D*> Map; With: WARNING:NEW_TYPEDEFS: do not add new typedefs With the new config, the linter only complains about the following things across the existing C++ code, which seem to be legitimate linting problems (and if not, can be ignored as well): BRACES_NOT_NECESSARY, CODE_INDENT, LEADING_SPACE, MULTISTATEMENT_MACRO_USE_DO_WHILE, OPEN_BRACE, POINTER_LOCATION, PRINTF_I_OSMO, SINGLE_STATEMENT_DO_WHILE_MACRO, SPACE_BEFORE_TAB, STATIC_CONST_CHAR_ARRAY, TABSTOP, TRAILING_WHITESPACE Depends: osmo-ci Ia2e75d9783382cefc3900a4ab51a5a919a2cbbbc Change-Id: I0df5b6f2f0bf1469a80a1f5859809c30f523f683 --- A .checkpatch.c++.conf A .checkpatch.c.conf D .checkpatch.conf 3 files changed, 10 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/04/42204/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42204?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I0df5b6f2f0bf1469a80a1f5859809c30f523f683 Gerrit-Change-Number: 42204 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log February 2026