February 2026 - gerrit-log - lists.osmocom.org

[XS] Change in libosmo-sigtran[master]: tcap: Fix return code in tcap_as_rx_sccp_asp()
by fixeria 26 Feb '26

26 Feb '26

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42210?usp=email ) Change subject: tcap: Fix return code in tcap_as_rx_sccp_asp() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42210?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I54c4a1bbaa8e107cf433cc898658a672c2b53c3c Gerrit-Change-Number: 42210 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Feb 2026 11:22:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: tcap: Avoid updating trans_track if AS doesn't have tcap-routing enabled
by fixeria 26 Feb '26

26 Feb '26

Attention is currently required from: daniel, lynxis lazus, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42207?usp=email ) Change subject: tcap: Avoid updating trans_track if AS doesn't have tcap-routing enabled ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Adding CR+1 to give others a chance to review this patchset. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42207?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0106df80f6c186b184bada8f06d38d0d54cce735 Gerrit-Change-Number: 42207 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 26 Feb 2026 11:20:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: stp: Enable tracking of NULL memory context
by pespin 26 Feb '26

26 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42213?usp=email ) Change subject: stp: Enable tracking of NULL memory context ...................................................................... stp: Enable tracking of NULL memory context Similar to what's done in most of the OsmoCNI programs. This allows dumpinng the NULL context using VTY command 'show talloc-context all'. Change-Id: I4a925967e5bb61c346cf6c4dd2c89b6aaea44b94 --- M stp/stp_main.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/13/42213/1 diff --git a/stp/stp_main.c b/stp/stp_main.c index fb5d202..4a1b59b 100644 --- a/stp/stp_main.c +++ b/stp/stp_main.c @@ -216,6 +216,9 @@ srand(time(NULL)); + /* Track the use of talloc NULL memory contexts */ + talloc_enable_null_tracking(); + tall_stp_ctx = talloc_named_const(NULL, 1, "osmo-stp"); msgb_talloc_ctx_init(tall_stp_ctx, 0); osmo_init_logging2(tall_stp_ctx, &log_info); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42213?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4a925967e5bb61c346cf6c4dd2c89b6aaea44b94 Gerrit-Change-Number: 42213 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: tcap: Support TID with length 1..4
by pespin 26 Feb '26

26 Feb '26

Attention is currently required from: daniel, laforge, lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42212?usp=email ) Change subject: tcap: Support TID with length 1..4 ...................................................................... Patch Set 2: (1 comment) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42212/comment/50c719cd_05c8b… : PS2, Line 81: OSMO_ASSERT > why would we want to assert here? Does that mean anyone can crash osmo-stp or libosmo-sigtran by sen […] My understanding is that since asn1 states "OrigTransactionID ::= [APPLICATION 8] IMPLICIT OCTET STRING (SIZE (1..4) )", if an octet string with size != 1..4 is received, then the decode function will return an error since it's a wrongly encoded message. So in theory it should be impossible to hit this assert. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42212?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2748d85624e4be708f7554ee3e60a5bda9162845 Gerrit-Change-Number: 42212 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 26 Feb 2026 10:44:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in libosmo-sigtran[master]: tcap: Fix return code in tcap_as_rx_sccp_asp()
by pespin 26 Feb '26

26 Feb '26

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42210?usp=email ) Change subject: tcap: Fix return code in tcap_as_rx_sccp_asp() ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > In my opinion, if the code calls a function that has *tcap* in the name, and the caller passes somet […] IMHO that function is tcap related (and allows it to quickly find it in tcap related routines files), but as its name indicates it receives a SCCP message and decides if it is TCAP-related, and if that's the case, does stuff with it. I think it's fine to keep it this way, specially since finding out if it's tcap requires a previous step of decoding SCCP, so better have it in the same path. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42210?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I54c4a1bbaa8e107cf433cc898658a672c2b53c3c Gerrit-Change-Number: 42210 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 26 Feb 2026 10:43:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[S] Change in libosmocore[master]: core: fix config.h
by laforge 26 Feb '26

26 Feb '26

Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email ) Change subject: core: fix config.h ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > I'm fine with @vyanitskiy@sysmocom.de proposal for this specific topic. I did fully understand the proposal by @fixeria and I would be fine if we did that. However, I described an alternative mechanism contained within this repo/project/CI which I think is also acceptable. Only relying on config.h inclusion everywhere *without* A linter/CI that verifies that and only relying on some third-party other jenkins job of another project failing is not tight enough from my PoV. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic2cf52a3b60f43a2f5d3fe01c41a41f6fd9a8000 Gerrit-Change-Number: 42205 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Feb 2026 10:41:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: tcap: Lower log level failing to parse msg
by laforge 26 Feb '26

26 Feb '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42211?usp=email ) Change subject: tcap: Lower log level failing to parse msg ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: Agred. However, they are probably even more so events that one would want to have metrics for (rate_ctr) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42211?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Idef5736ee2481260f958eece2f5a3bfc009b3d69 Gerrit-Change-Number: 42211 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Feb 2026 10:38:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: tcap: Fix return code in tcap_as_rx_sccp_asp()
by laforge 26 Feb '26

26 Feb '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42210?usp=email ) Change subject: tcap: Fix return code in tcap_as_rx_sccp_asp() ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: In my opinion, if the code calls a function that has *tcap* in the name, and the caller passes something that's not TCAP, it is very much an error. IMHO the problem is more in the caller then? Maybe the caller first needs a is_this_tcap() function followed by calling a tcap_*_rx_* function? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42210?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I54c4a1bbaa8e107cf433cc898658a672c2b53c3c Gerrit-Change-Number: 42210 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Feb 2026 10:37:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in libosmo-sigtran[master]: tcap: Support TID with length 1..4
by laforge 26 Feb '26

26 Feb '26

Attention is currently required from: daniel, lynxis lazus, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42212?usp=email ) Change subject: tcap: Support TID with length 1..4 ...................................................................... Patch Set 2: (1 comment) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42212/comment/8db50249_5a590… : PS2, Line 81: OSMO_ASSERT why would we want to assert here? Does that mean anyone can crash osmo-stp or libosmo-sigtran by sending it a malformed TCAP message with length==0 or length>=5 ? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42212?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2748d85624e4be708f7554ee3e60a5bda9162845 Gerrit-Change-Number: 42212 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 26 Feb 2026 10:34:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in libosmo-sigtran[master]: tcap: Lower log level failing to parse msg
by pespin 26 Feb '26

26 Feb '26

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42211?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: tcap: Lower log level failing to parse msg ...................................................................... tcap: Lower log level failing to parse msg invalid rx packets should be logged as NOTICED, not as ERROR. Change-Id: Idef5736ee2481260f958eece2f5a3bfc009b3d69 --- M src/tcap_as_loadshare.c 1 file changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/11/42211/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42211?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Idef5736ee2481260f958eece2f5a3bfc009b3d69 Gerrit-Change-Number: 42211 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

2026

2025

2024

2023

2022

gerrit-log February 2026