Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42133?usp=email )
Change subject: rspro_server: fix releasing timed out clients
......................................................................
Patch Set 1:
(1 comment)
File src/server/rspro_server.c:
https://gerrit.osmocom.org/c/osmo-remsim/+/42133/comment/33a52291_8cd4f87d?… :
PS1, Line 923: /* this will internally call closed_cb() which will dispatch a TCP_DOWN event */
> This is your comment which would set it to NULL
With your proposal you'll end up with a double free of the osmo_stream_srv afaict, from the parent talloc_free(conn) at the end of this function, and from within osmo_stream_srv_destroy() after closed_cb returns.
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42133?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I1f7faf5ffdd909362c492ab434b63fa7e79ada95
Gerrit-Change-Number: 42133
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Tue, 17 Feb 2026 11:32:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42133?usp=email )
Change subject: rspro_server: fix releasing timed out clients
......................................................................
Patch Set 1:
(1 comment)
File src/server/rspro_server.c:
https://gerrit.osmocom.org/c/osmo-remsim/+/42133/comment/b6cba27c_1fe94147?… :
PS1, Line 923: /* this will internally call closed_cb() which will dispatch a TCP_DOWN event */
This is your comment which would set it to NULL
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42133?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I1f7faf5ffdd909362c492ab434b63fa7e79ada95
Gerrit-Change-Number: 42133
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 17 Feb 2026 11:03:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42133?usp=email )
Change subject: rspro_server: fix releasing timed out clients
......................................................................
Patch Set 1: Code-Review-1
(2 comments)
File src/server/rspro_server.c:
https://gerrit.osmocom.org/c/osmo-remsim/+/42133/comment/37bbf8b4_f8a3fae8?… :
PS1, Line 926: osmo_stream_srv_destroy(peer);
osmo_stream_srv_destroy(conn->peer) calls talloc_free(conn->peer), so it totally makes sense to do conn->peer here in order to avoid double free.
https://gerrit.osmocom.org/c/osmo-remsim/+/42133/comment/71677556_b7179cb8?… :
PS1, Line 938:
if (conn->fi) {
osmo_fsm_inst_free(conn->fi);
conn->fi = NULL;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42133?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I1f7faf5ffdd909362c492ab434b63fa7e79ada95
Gerrit-Change-Number: 42133
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Tue, 17 Feb 2026 10:57:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
daniel has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41509?usp=email )
Change subject: Avoid removing ASP from all AS during osmo_ss7_as_del_asp()
......................................................................
Abandoned
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41509?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I37093f5a2fae17a6ef117ac880436bb813bcb2b1
Gerrit-Change-Number: 41509
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Attention is currently required from: daniel.
pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42135?usp=email )
Change subject: Fix/change TC_tcap_loadshare_ipa_tcap_udts()
......................................................................
Patch Set 1:
(1 comment)
File stp/STP_Tests_TCAP.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42135/comment/564a04fd_9ac7… :
PS1, Line 663: /* TODO: Get the asp_idx of the received message to verify related
AFAIU, from tcap_configs above, you have 2 possible ASPs where it can be recieved, so it should be fairy simple to alt-receive on any of the 2 and store the idx and use it.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42135?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibffa98702fd6eb276410630ab525d986fa0f36e0
Gerrit-Change-Number: 42135
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 17 Feb 2026 09:23:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42077?usp=email )
Change subject: pySim-shell_test/euicc: ensure test-profile is enabled
......................................................................
pySim-shell_test/euicc: ensure test-profile is enabled
When testing commands like get_profile_info, enable_profile,
disable_profile or the commands to manage notifications, we
should ensure that the correct profile is enabled before
executing the actual testcase.
Change-Id: Ie57b0305876bc5001ab3a9c3a3b5711408161b74
---
M tests/pySim-shell_test/euicc/test_enable_disable_profile.script
M tests/pySim-shell_test/euicc/test_gen_notif.script
M tests/pySim-shell_test/euicc/test_get_profiles_info.script
3 files changed, 13 insertions(+), 0 deletions(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/tests/pySim-shell_test/euicc/test_enable_disable_profile.script b/tests/pySim-shell_test/euicc/test_enable_disable_profile.script
index 2efbf6e..f56f1d4 100644
--- a/tests/pySim-shell_test/euicc/test_enable_disable_profile.script
+++ b/tests/pySim-shell_test/euicc/test_enable_disable_profile.script
@@ -3,6 +3,9 @@
select ADF.ISD-R
+# Ensure that the test-profile we intend to test with is actually enabled
+enable_profile --iccid 89000123456789012341
+
# by ICCID (pre-installed test profile on sysmoEUICC1-C2T)
disable_profile --iccid 89000123456789012341 > enable_disable_profile.tmp
enable_profile --iccid 89000123456789012341 >> enable_disable_profile.tmp
diff --git a/tests/pySim-shell_test/euicc/test_gen_notif.script b/tests/pySim-shell_test/euicc/test_gen_notif.script
index feb7ef2..a7dc63c 100644
--- a/tests/pySim-shell_test/euicc/test_gen_notif.script
+++ b/tests/pySim-shell_test/euicc/test_gen_notif.script
@@ -3,6 +3,11 @@
select ADF.ISD-R
+# Ensure that the test-profile is actually enabled. (In case te test-profile
+# was disabled, a notification may be generated. The testcase should tolerate
+# that)
+enable_profile --iccid 89000123456789012341
+
# Generate two (additional) notifications by quickly enabeling the test profile
enable_profile --iccid 8949449999999990031
enable_profile --iccid 89000123456789012341
diff --git a/tests/pySim-shell_test/euicc/test_get_profiles_info.script b/tests/pySim-shell_test/euicc/test_get_profiles_info.script
index 352be7a..668f7eb 100644
--- a/tests/pySim-shell_test/euicc/test_get_profiles_info.script
+++ b/tests/pySim-shell_test/euicc/test_get_profiles_info.script
@@ -1,5 +1,10 @@
set debug true
set echo true
+# The output of get_profiles_info will also include the "profile_state", which
+# can be either "enabled" or "disabled". Ensure that the correct profile is
+# enabled.
+enable_profile --iccid 89000123456789012341
+
select ADF.ISD-R
get_profiles_info > get_profiles_info.tmp
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42077?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie57b0305876bc5001ab3a9c3a3b5711408161b74
Gerrit-Change-Number: 42077
Gerrit-PatchSet: 6
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
laforge has submitted this change. ( https://gerrit.osmocom.org/c/gapk/+/42134?usp=email )
Change subject: libgsmhr/fetch_sources: fix download from 3gpp.org
......................................................................
libgsmhr/fetch_sources: fix download from 3gpp.org
Fix that the script gets a 403 forbidden error since 2026-01-26. Set a
user-agent string and switch the protocol to https while at it.
Change-Id: I5679bc519e7891e3342d8e78c11bf5eb6b44a217
---
M libgsmhr/fetch_sources.py
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
diff --git a/libgsmhr/fetch_sources.py b/libgsmhr/fetch_sources.py
index 178125c..a7b185a 100755
--- a/libgsmhr/fetch_sources.py
+++ b/libgsmhr/fetch_sources.py
@@ -8,7 +8,8 @@
import zipfile
-URL = "http://www.3gpp.org/ftp/Specs/archive/06_series/06.06/0606-421.zip"
+URL = "https://www.3gpp.org/ftp/Specs/archive/06_series/06.06/0606-421.zip"
+USER_AGENT = "fetch_sources.py"
def get_zipfile(data: bytes) -> zipfile.ZipFile:
@@ -45,7 +46,8 @@
# Get the original data
log.info('Requesting file: %s', URL)
- with urllib.request.urlopen(URL) as response:
+ request = urllib.request.Request(URL, headers={"User-Agent": USER_AGENT})
+ with urllib.request.urlopen(request) as response:
log.debug('Response code: %d', response.code)
assert response.code == 200
--
To view, visit https://gerrit.osmocom.org/c/gapk/+/42134?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: gapk
Gerrit-Branch: master
Gerrit-Change-Id: I5679bc519e7891e3342d8e78c11bf5eb6b44a217
Gerrit-Change-Number: 42134
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>