February 2026 - gerrit-log - lists.osmocom.org

[XS] Change in libosmo-sigtran[master]: tcap: Fix return code in tcap_as_rx_sccp_asp()
by pespin 26 Feb '26

26 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42210?usp=email ) Change subject: tcap: Fix return code in tcap_as_rx_sccp_asp() ...................................................................... tcap: Fix return code in tcap_as_rx_sccp_asp() That code path is not an error, simply the message is not TCAP. Change-Id: I54c4a1bbaa8e107cf433cc898658a672c2b53c3c --- M src/tcap_as_loadshare.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/10/42210/1 diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index 9c969d3..ca0d209 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -286,7 +286,7 @@ /* TCAP uses only connectionless SCCP messages */ if (sua->hdr.msg_class != SUA_MSGC_CL && sua->hdr.msg_class != SUA_CL_CLDT) - return -2; + return 0; rc = sua_addr_parse(&calling_addr, sua, SUA_IEI_SRC_ADDR); if (rc < 0) { -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42210?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I54c4a1bbaa8e107cf433cc898658a672c2b53c3c Gerrit-Change-Number: 42210 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: tcap: Support TID with length 1..4
by pespin 26 Feb '26

26 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42212?usp=email ) Change subject: tcap: Support TID with length 1..4 ...................................................................... tcap: Support TID with length 1..4 As described in ITU Q.773 4.2.1.3: "The length of a Transaction ID is 1 to 4 octets." asn.1 files also describe TIDs the following way: OrigTransactionID ::= [APPLICATION 8] IMPLICIT OCTET STRING (SIZE (1..4) ) DestTransactionID ::=[APPLICATION 9] IMPLICIT OCTET STRING (SIZE (1..4) ) Related: SYS#5423 Change-Id: I2748d85624e4be708f7554ee3e60a5bda9162845 --- M src/sccp2sua.c M src/ss7_internal.h M src/tcap_as_loadshare.c 3 files changed, 28 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/12/42212/1 diff --git a/src/sccp2sua.c b/src/sccp2sua.c index 87d9d05..9ca1d7a 100644 --- a/src/sccp2sua.c +++ b/src/sccp2sua.c @@ -35,8 +35,8 @@ #include <osmocom/sigtran/sccp_helpers.h> #include <osmocom/sigtran/protocol/sua.h> #include "xua_msg.h" - #include "xua_internal.h" +#include "ss7_internal.h" #include "sccp_internal.h" /* libosmocore candidates */ @@ -54,14 +54,6 @@ msgb_put_u8(msg, (val >> 8) & 0xff); } -/*! \brief load a 24bit value as big-endian */ -static uint32_t load_24be(const void *ptr) -{ - const uint8_t *data = ptr; - return (data[0] << 16) | (data[1] << 8) | data[2]; -} - - /*! \brief Parse ISUP style address of BCD digets * \param[out] out_digits user-allocated buffer for ASCII digits diff --git a/src/ss7_internal.h b/src/ss7_internal.h index b70954e..f93eb52 100644 --- a/src/ss7_internal.h +++ b/src/ss7_internal.h @@ -44,5 +44,12 @@ #define ss7_llist_round_robin(list, state, struct_type, entry_name) \ llist_entry(_ss7_llist_round_robin(list, state), struct_type, entry_name) +/*! \brief load a 24bit value as big-endian */ +static inline uint32_t load_24be(const void *ptr) +{ + const uint8_t *data = ptr; + return (data[0] << 16) | (data[1] << 8) | data[2]; +} + /* VTY */ #define XUA_VAR_STR "(sua|m3ua|ipa)" diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index 3208c64..c3fa8b4 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -1,4 +1,4 @@ -/* TCAP ID based ASP Load-Sharing */ +/* TCAP ID based ASP Load-Sharing, ITU-T Q.771-Q.775 */ /* (C) 2025 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de> * All Rights Reserved @@ -62,9 +62,26 @@ static inline uint32_t tcap_id_from_octet_str(const OCTET_STRING_t *src) { - OSMO_ASSERT(src->size == 4); + uint32_t tid; - return osmo_load32be(src->buf); + switch (src->size) { + case 4: + tid = osmo_load32be(src->buf); + break; + case 3: + tid = load_24be(src->buf); + break; + case 2: + tid = osmo_load16be(src->buf); + break; + case 1: + tid = src->buf[0]; + break; + default: + OSMO_ASSERT(0); + } + + return tid; } /* returns negative on error, mask with any/both OTID_SET|DTID_SET on success */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42212?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2748d85624e4be708f7554ee3e60a5bda9162845 Gerrit-Change-Number: 42212 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: tcap: Lower log level failing to parse msg
by pespin 26 Feb '26

26 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42211?usp=email ) Change subject: tcap: Lower log level failing to parse msg ...................................................................... tcap: Lower log level failing to parse msg invalid rx packets should be logged as NOTICED, not as ERROR. Change-Id: Idef5736ee2481260f958eece2f5a3bfc009b3d69 --- M src/tcap_as_loadshare.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/11/42211/1 diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index ca0d209..3208c64 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -78,7 +78,7 @@ rc = osmo_asn1_tcap_decode(tcapmsg, data, len); if (rc < 0) { - LOGPAS(as, DLTCAP, LOGL_DEBUG, "Error decoding TCAP message rc: %d, message: %s\n", + LOGPAS(as, DLTCAP, LOGL_NOTICE, "Error decoding TCAP message rc: %d, message: %s\n", rc, osmo_hexdump(data, len)); goto free_asn; } @@ -325,7 +325,7 @@ rc = parse_tcap(as, ie_data->dat, ie_data->len, &parsed); if (rc <= 0) { - LOGPAS(as, DLTCAP, LOGL_ERROR, "Failed get TCAP otid/dtid.\n"); + LOGPAS(as, DLTCAP, LOGL_NOTICE, "Failed get TCAP otid/dtid.\n"); return -7; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42211?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Idef5736ee2481260f958eece2f5a3bfc009b3d69 Gerrit-Change-Number: 42211 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: core: fix config.h
by pespin 26 Feb '26

26 Feb '26

Attention is currently required from: Hoernchen. pespin has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email ) Change subject: core: fix config.h ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS4: > Just to clarify my idea, conditionally injecting `-DLIBOSMOCORE_NO_LOGGING` into `CPPFLAGS` in `conf […] I'm fine with @vyanitskiy@sysmocom.de proposal for this specific topic. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic2cf52a3b60f43a2f5d3fe01c41a41f6fd9a8000 Gerrit-Change-Number: 42205 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Feb 2026 09:26:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: core: fix config.h
by fixeria 26 Feb '26

26 Feb '26

Attention is currently required from: Hoernchen, pespin. fixeria has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email ) Change subject: core: fix config.h ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > if we add such a check to libosmocore gerrit build verification, then I am happy to accept the need […] Just to clarify my idea, conditionally injecting `-DLIBOSMOCORE_NO_LOGGING` into `CPPFLAGS` in `configure.ac` achieves the same goal (turning logging macros into no-ops) as including `config.h` in each and every file. This way there's no need to enforce adding `config.h` everywhere. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic2cf52a3b60f43a2f5d3fe01c41a41f6fd9a8000 Gerrit-Change-Number: 42205 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Feb 2026 09:20:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: octsim_osmo-ccid-firmware: add myself to the recipients
by pespin 26 Feb '26

26 Feb '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ci/+/42209?usp=email ) Change subject: octsim_osmo-ccid-firmware: add myself to the recipients ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42209?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2b96ad0d34e4344ccb0351737df31b08cb65e116 Gerrit-Change-Number: 42209 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 26 Feb 2026 09:01:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: fix --disable-log-macros
by fixeria 26 Feb '26

26 Feb '26

Attention is currently required from: Hoernchen, laforge, pespin. fixeria has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email ) Change subject: fix --disable-log-macros ...................................................................... Patch Set 4: (1 comment) File configure.ac: https://gerrit.osmocom.org/c/libosmocore/+/42203/comment/60a0a63c_c2780f7a?… : PS1, Line 511: if test x"$log_macros" == x"yes" > https://www.gnu.org/software/autoconf/manual/autoconf-2.66/html_node/Packag… […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I809ab2f61e72428ba21061055296eb83d6d710ab Gerrit-Change-Number: 42203 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Feb 2026 05:13:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: fix --disable-log-macros
by fixeria 26 Feb '26

26 Feb '26

Attention is currently required from: Hoernchen, laforge. fixeria has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email ) Change subject: fix --disable-log-macros ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I809ab2f61e72428ba21061055296eb83d6d710ab Gerrit-Change-Number: 42203 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 26 Feb 2026 05:13:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: octsim_osmo-ccid-firmware: add myself to the recipients
by lynxis lazus 25 Feb '26

25 Feb '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/42209?usp=email ) Change subject: octsim_osmo-ccid-firmware: add myself to the recipients ...................................................................... octsim_osmo-ccid-firmware: add myself to the recipients Change-Id: I2b96ad0d34e4344ccb0351737df31b08cb65e116 --- M jobs/octsim_osmo-ccid-firmware.yml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/09/42209/1 diff --git a/jobs/octsim_osmo-ccid-firmware.yml b/jobs/octsim_osmo-ccid-firmware.yml index 24e8d3b..61e609c 100644 --- a/jobs/octsim_osmo-ccid-firmware.yml +++ b/jobs/octsim_osmo-ccid-firmware.yml @@ -43,7 +43,7 @@ publishers: - email: notify-every-unstable-build: true - recipients: jsteiger(a)sysmocom.de + recipients: jsteiger(a)sysmocom.de acouzens(a)sysmocom.de send-to-individuals: true retry-count: '3' triggers: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42209?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2b96ad0d34e4344ccb0351737df31b08cb65e116 Gerrit-Change-Number: 42209 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-trx[master]: fix(threads): centralize portable strerror handling
by pespin 25 Feb '26

25 Feb '26

Attention is currently required from: Timur Davydov. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email ) Change subject: fix(threads): centralize portable strerror handling ...................................................................... Patch Set 4: (1 comment) File CommonLibs/Utils.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42199/comment/06c9d523_787c39a8?usp… : PS2, Line 36: > Yes, agreed. I dropped the C++ wrapper and kept only the C helper `strerror_buf()`. […] I'm fine with updating all of them in this project. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42199?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I642aff8a9f98823e117c4debd19384ddf5975039 Gerrit-Change-Number: 42199 Gerrit-PatchSet: 4 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Wed, 25 Feb 2026 20:51:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

2026

2025

2024

2023

2022

gerrit-log February 2026