February 2026 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-asn1-tcap[master]: Use talloc to allocate asn1c decoded structs
by pespin 26 Feb '26

26 Feb '26

Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219?usp=email ) Change subject: Use talloc to allocate asn1c decoded structs ...................................................................... Patch Set 2: (1 comment) File src/tcap.c: https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219/comment/4ab53ba3_781… : PS2, Line 29: vo > Other topic: Naming-wise, all other symbols exported by the library are called osmo_asn1_tcap_ whereas thisone forgoes the prefix. That's done on purpose, because the talloc context pointer is not exported, see: libosmo_asn1_tcap_la_LDFLAGS = -version-info $(LIBVERSION) -no-undefined -export-symbols-regex '^osmo_' See next patch on how to set it. -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I6d885527caa5b60011b4fac341b93026ab1833d9 Gerrit-Change-Number: 42219 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 26 Feb 2026 15:50:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: tcap: Fix return code in tcap_as_rx_sccp_asp()
by pespin 26 Feb '26

26 Feb '26

Attention is currently required from: daniel, fixeria, lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42210?usp=email ) Change subject: tcap: Fix return code in tcap_as_rx_sccp_asp() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42210?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I54c4a1bbaa8e107cf433cc898658a672c2b53c3c Gerrit-Change-Number: 42210 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 26 Feb 2026 15:47:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ccid-firmware[master]: ccid_device: Reject XfrBlock with zero-length data
by laforge 26 Feb '26

26 Feb '26

Attention is currently required from: Hoernchen, dexter, jolly, lynxis lazus. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42192?usp=email ) Change subject: ccid_device: Reject XfrBlock with zero-length data ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > When using your patch, the bankd will close the connection, because pcsc fail the transaction. well, that is then how pcscd + the application deals with it, fine. If they want to deal with it differently, it's up to then. From the firmware/protocol point of view, returning a dwLength error looks like the right thing to do? Or do you have a different idea/understanding? Asking since you didn't +1 it yet. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42192?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I65df88477e4b1c03dc20a8d41e5cbd1c9f363ba8 Gerrit-Change-Number: 42192 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Feb 2026 15:45:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in libosmo-asn1-tcap[master]: Use talloc to allocate asn1c decoded structs
by pespin 26 Feb '26

26 Feb '26

Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219?usp=email ) Change subject: Use talloc to allocate asn1c decoded structs ...................................................................... Patch Set 2: (1 comment) File src/tcap.c: https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219/comment/9bbe606c_40e… : PS2, Line 29: vo > ok, this is differnt from how we havndle talloc_asn1_ctx in libasn1c so far. […] Please see follow-up patch https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42220 and https://gerrit.osmocom.org/c/libosmo-sigtran/+/42221 . The alternative would be not to call it in libosmo-sigtran, but instead let the final app handle that (eg. calling it in stp_main.c). -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I6d885527caa5b60011b4fac341b93026ab1833d9 Gerrit-Change-Number: 42219 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 26 Feb 2026 15:44:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-ccid-firmware[master]: ccid_device: Reject XfrBlock with zero-length data
by laforge 26 Feb '26

26 Feb '26

Attention is currently required from: Hoernchen, dexter, jolly, lynxis lazus. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42192?usp=email ) Change subject: ccid_device: Reject XfrBlock with zero-length data ...................................................................... Patch Set 1: -Code-Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42192?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I65df88477e4b1c03dc20a8d41e5cbd1c9f363ba8 Gerrit-Change-Number: 42192 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Feb 2026 15:44:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ccid-firmware[master]: ccid_device: Reject XfrBlock with zero-length data
by laforge 26 Feb '26

26 Feb '26

Attention is currently required from: Hoernchen, dexter, jolly, lynxis lazus. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42192?usp=email ) Change subject: ccid_device: Reject XfrBlock with zero-length data ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: > Yes, that is correct. […] to be precise: CCID also has an APDU mode. However, our implementation only advertises TPDU level support, and hence we never run into the situation where we only see an APDU. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42192?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I65df88477e4b1c03dc20a8d41e5cbd1c9f363ba8 Gerrit-Change-Number: 42192 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Feb 2026 15:44:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: tcap: Use osmo_asn1_tcap_set_talloc_ctx() to set app talloc ctx
by pespin 26 Feb '26

26 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42221?usp=email ) Change subject: tcap: Use osmo_asn1_tcap_set_talloc_ctx() to set app talloc ctx ...................................................................... tcap: Use osmo_asn1_tcap_set_talloc_ctx() to set app talloc ctx Change-Id: I9c1abc040fdeb58cb97e9b99a2382f336146bc40 --- M TODO-RELEASE M src/ss7_vty.c M src/tcap_as_loadshare_vty.c M src/tcap_as_loadshare_vty.h 4 files changed, 8 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/21/42221/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index 0ed7189..43bef24 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,3 +7,4 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line +libosmo-asn1-tcap >0.2.1 osmo_asn1_tcap_set_talloc_ctx() diff --git a/src/ss7_vty.c b/src/ss7_vty.c index 56633f3..63c0dce 100644 --- a/src/ss7_vty.c +++ b/src/ss7_vty.c @@ -1564,7 +1564,7 @@ vty_init_shared(ctx); #ifdef WITH_TCAP_LOADSHARING - tcap_as_vty_init(); + tcap_as_vty_init(ctx); #endif /* WITH_TCAP_LOADSHARING */ install_node(&rtable_node, NULL); install_lib_element(L_CS7_NODE, &cs7_route_table_cmd); diff --git a/src/tcap_as_loadshare_vty.c b/src/tcap_as_loadshare_vty.c index e6506e8..2ac69d0 100644 --- a/src/tcap_as_loadshare_vty.c +++ b/src/tcap_as_loadshare_vty.c @@ -27,7 +27,7 @@ #include <osmocom/core/hashtable.h> -#include <osmocom/sigtran/osmo_ss7.h> +#include <osmocom/tcap/tcap.h> #include <osmocom/vty/vty.h> #include <osmocom/vty/command.h> @@ -35,6 +35,7 @@ #include <osmocom/vty/telnet_interface.h> #include <osmocom/vty/misc.h> +#include <osmocom/sigtran/osmo_ss7.h> #include "ss7_as.h" #include "ss7_asp.h" #include "ss7_vty.h" @@ -125,8 +126,10 @@ return CMD_SUCCESS; } -void tcap_as_vty_init(void) +void tcap_as_vty_init(void *ctx) { + osmo_asn1_tcap_set_talloc_ctx(ctx); + install_lib_element_ve(&show_cs7_as_name_tcapranges_cmd); install_lib_element_ve(&show_cs7_as_name_tcapranges_tid_cmd); } diff --git a/src/tcap_as_loadshare_vty.h b/src/tcap_as_loadshare_vty.h index cecd26f..dfb2d65 100644 --- a/src/tcap_as_loadshare_vty.h +++ b/src/tcap_as_loadshare_vty.h @@ -4,4 +4,4 @@ struct osmo_ss7_instance; /* Register tcap vty commands */ -void tcap_as_vty_init(void); +void tcap_as_vty_init(void *ctx); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42221?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9c1abc040fdeb58cb97e9b99a2382f336146bc40 Gerrit-Change-Number: 42221 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-trx[master]: checkpatch.conf: lint more code
by laforge 26 Feb '26

26 Feb '26

Attention is currently required from: Hoernchen, osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-trx/+/42204?usp=email ) Change subject: checkpatch.conf: lint more code ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42204?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I0df5b6f2f0bf1469a80a1f5859809c30f523f683 Gerrit-Change-Number: 42204 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Feb 2026 15:43:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: tcap: Fix wrong address type printed in log line
by laforge 26 Feb '26

26 Feb '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42214?usp=email ) Change subject: tcap: Fix wrong address type printed in log line ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42214?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I28b0d488159d9fa88e69e8c8b2e53a97b461763a Gerrit-Change-Number: 42214 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Feb 2026 15:42:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: tcap: Fix return code in tcap_as_rx_sccp_asp()
by laforge 26 Feb '26

26 Feb '26

Attention is currently required from: daniel, fixeria, lynxis lazus, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42210?usp=email ) Change subject: tcap: Fix return code in tcap_as_rx_sccp_asp() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42210?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I54c4a1bbaa8e107cf433cc898658a672c2b53c3c Gerrit-Change-Number: 42210 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 26 Feb 2026 15:41:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log February 2026