Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/42130?usp=email )
Change subject: Tear down context_maps when UPF assoc goes down
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/42130?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I7dcd9114861fa8f4bf855a02c286f85083ad75fe
Gerrit-Change-Number: 42130
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 18 Feb 2026 19:41:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria, pespin.
daniel has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42135?usp=email )
Change subject: Fix/change TC_tcap_loadshare_ipa_tcap_udts()
......................................................................
Patch Set 2:
(2 comments)
File stp/STP_Tests_TCAP.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42135/comment/cbdc616c_8774… :
PS1, Line 663: /* TODO: Get the asp_idx of the received message to verify related
> AFAIU, from tcap_configs above, you have 2 possible ASPs where it can be recieved, so it should be f […]
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42135/comment/fe6b9946_3dea… :
PS1, Line 693: TC_tcap_loadshare_ipa_tcap_norange
> Please update `stp/expected-results.xml`.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42135?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibffa98702fd6eb276410630ab525d986fa0f36e0
Gerrit-Change-Number: 42135
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 18 Feb 2026 18:31:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: daniel.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42135?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: Fix/change TC_tcap_loadshare_ipa_tcap_udts()
......................................................................
Fix/change TC_tcap_loadshare_ipa_tcap_udts()
The behaviour changed to not reject tcap messages outside of any valid
route. Change the test expectation that these messages are indeed
forwarded.
Change-Id: Ibffa98702fd6eb276410630ab525d986fa0f36e0
---
M stp/STP_Tests_TCAP.ttcn
M stp/expected-results.xml
2 files changed, 25 insertions(+), 14 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/35/42135/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42135?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibffa98702fd6eb276410630ab525d986fa0f36e0
Gerrit-Change-Number: 42135
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Attention is currently required from: fixeria, pespin.
falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/42141?usp=email )
Change subject: twjit: add underrun extension feature
......................................................................
Patch Set 2:
(3 comments)
File src/twjit.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/42141/comment/234ed583_004ff8f… :
PS1, Line 554: twjit->stats.underruns++;
> In the new iteration of my patch, I added a comment explaining while this stats counter should not b […]
PS2 got CR+1 from @pespin@sysmocom.de with no further comments. Is it OK to mark this comment as resolved?
https://gerrit.osmocom.org/c/libosmo-netif/+/42141/comment/53823e88_a25dbff… :
PS1, Line 630: static void handle_flowing_underrun(struct osmo_twjit *twjit)
> I added an explanatory comment in the new iteration of my patch - is it good enough?
PS2 got CR+1 from @pespin@sysmocom.de with no further comments. Is it OK to mark this comment as resolved?
https://gerrit.osmocom.org/c/libosmo-netif/+/42141/comment/401d686a_482c997… :
PS1, Line 671: if (read_sb_is_empty(twjit)) {
> if (!read_sb_is_empty(twjit)) { […]
PS2 got CR+1 from @pespin@sysmocom.de with no further comments. Is it OK to mark this comment as resolved?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/42141?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ibda74c0dbfb163f5d0e3fb13f593a6e2c6817673
Gerrit-Change-Number: 42141
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 18 Feb 2026 17:58:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>