February 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-pcap[master]: server: wr_file: Request up to 8 iofd write buffers if available
by pespin 04 Feb '26

04 Feb '26

Attention is currently required from: daniel, fixeria, jolly, laforge, pespin. Hello Jenkins Builder, daniel, fixeria, jolly, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcap/+/42015?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by fixeria Change subject: server: wr_file: Request up to 8 iofd write buffers if available ...................................................................... server: wr_file: Request up to 8 iofd write buffers if available Writing to disk is usually slower than handling network traffic, so it's a desirable to increase write buffers to try to submit our write queue to the kernel/VFS as fast as possible, to avoid it growing too much. This should also improve CPU use at the expense of some dozen KBs of extra use, which in the server should be plenty available. Using up to 8 buffer sounds like a good start, being it a good compromise between memory requirements and batching of msgbs. It also turns outs it's the maximum amount of buffers allowed by osmo_io current implementation ;) Depends: libosmocore.git 378cf564c8859311415aa70adeb220cedbe56eb3 Change-Id: I167e5f9b7f9d5693b3df05f713288c741031c532 --- M TODO-RELEASE M src/osmo_pcap_wr_file.c 2 files changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/15/42015/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/42015?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I167e5f9b7f9d5693b3df05f713288c741031c532 Gerrit-Change-Number: 42015 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[XS] Change in osmo-pcap[master]: server: wr_file: Request up to 8 iofd write buffers if available
by fixeria 04 Feb '26

04 Feb '26

Attention is currently required from: daniel, jolly, laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/42015?usp=email ) Change subject: server: wr_file: Request up to 8 iofd write buffers if available ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-pcap/+/42015/comment/a930a9fd_539051d3?us… : PS2, Line 17: allows allowed -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/42015?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I167e5f9b7f9d5693b3df05f713288c741031c532 Gerrit-Change-Number: 42015 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Feb 2026 17:11:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-pcap[master]: server: wr_file: Request up to 8 iofd write buffers if available
by pespin 04 Feb '26

04 Feb '26

Attention is currently required from: daniel, fixeria, jolly, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/42015?usp=email ) Change subject: server: wr_file: Request up to 8 iofd write buffers if available ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-pcap/+/42015/comment/d68f4cde_ec3aa667?us… : PS1, Line 7: 8 > Well, I am not starting a discussion whether 8 is great or not. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/42015?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I167e5f9b7f9d5693b3df05f713288c741031c532 Gerrit-Change-Number: 42015 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Feb 2026 17:10:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-pcap[master]: server: wr_file: Request up to 8 iofd write buffers if available
by pespin 04 Feb '26

04 Feb '26

Attention is currently required from: daniel, fixeria, jolly, laforge, pespin. Hello Jenkins Builder, daniel, fixeria, jolly, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcap/+/42015?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria Change subject: server: wr_file: Request up to 8 iofd write buffers if available ...................................................................... server: wr_file: Request up to 8 iofd write buffers if available Writing to disk is usually slower than handling network traffic, so it's a desirable to increase write buffers to try to submit our write queue to the kernel/VFS as fast as possible, to avoid it growing too much. This should also improve CPU use at the expense of some dozen KBs of extra use, which in the server should be plenty available. Using up to 8 buffer sounds like a good start, being it a good compromise between memory requirements and batching of msgbs. It also turns outs it's the maximum amount of buffers allows by osmo_io current implementation ;) Depends: libosmocore.git 378cf564c8859311415aa70adeb220cedbe56eb3 Change-Id: I167e5f9b7f9d5693b3df05f713288c741031c532 --- M TODO-RELEASE M src/osmo_pcap_wr_file.c 2 files changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/15/42015/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/42015?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I167e5f9b7f9d5693b3df05f713288c741031c532 Gerrit-Change-Number: 42015 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[M] Change in libosmocore[master]: Add Emscripten build support and JS callback logging backend
by pespin 04 Feb '26

04 Feb '26

Attention is currently required from: Timur Davydov, fixeria, laforge, neels, osmith. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email ) Change subject: Add Emscripten build support and JS callback logging backend ...................................................................... Patch Set 25: Code-Review-1 (4 comments) Patchset: PS25: Now that the build part is solved, I looked a bit more in detail at the C logic and found some flaws, please fix the comments and resubmit. File src/core/logging_emscripten.c: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/c861d323_3c25ec3e?… : PS25, Line 44: const int msgLen = 4096; Use MAX_LOG_SIZE from ./include/osmocom/core/logging_internal.h instead. https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/d771449b_7e3c2140?… : PS25, Line 47: char subsys_buf[16]; why is this 16 bytes? https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/fca1ba80_130cb978?… : PS25, Line 57: if (msg[rc - 1] == '\n') msg[rc - 1] = '\0'; man vsnprintf: If the output was truncated due to this limit, then the return value is the number of characters (excluding the terminating null byte) which would have been written to the final string if enough space had been available. You may be writing out of "msg" here if the input string is more than 4096 chars. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia8d5f4bb6570b5e055826f3a051e5e5896866e31 Gerrit-Change-Number: 41813 Gerrit-PatchSet: 25 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Tue, 03 Feb 2026 17:07:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-netif[master]: gitignore: ignore generated .wasm files
by fixeria 04 Feb '26

04 Feb '26

Attention is currently required from: Timur Davydov, laforge. fixeria has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmo-netif/+/41953?usp=email ) Change subject: gitignore: ignore generated .wasm files ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/41953?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I023158cc39989d6fe98080fecb61410aa4e535ab Gerrit-Change-Number: 41953 Gerrit-PatchSet: 5 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Tue, 03 Feb 2026 17:05:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-pcap[master]: server: wr_file: Request up to 8 iofd write buffers if available
by fixeria 04 Feb '26

04 Feb '26

Attention is currently required from: daniel, jolly, laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/42015?usp=email ) Change subject: server: wr_file: Request up to 8 iofd write buffers if available ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-pcap/+/42015/comment/27ed9747_062e5f96?us… : PS1, Line 7: 8 > So one could recurse to discuss: […] Well, I am not starting a discussion whether 8 is great or not. I just want this (what you wrote) to be stated in code. Otherwise it looks like a magic number to those who are not familiar with the osmo_io internals. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/42015?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I167e5f9b7f9d5693b3df05f713288c741031c532 Gerrit-Change-Number: 42015 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Feb 2026 17:03:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-pcap[master]: server: wr_file: Request up to 8 iofd write buffers if available
by pespin 04 Feb '26

04 Feb '26

Attention is currently required from: daniel, fixeria, jolly, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/42015?usp=email ) Change subject: server: wr_file: Request up to 8 iofd write buffers if available ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-pcap/+/42015/comment/b6222b49_95226545?us… : PS1, Line 7: 8 > Because 8 is g8, which is great 😊 […] So one could recurse to discuss: Why is 8 the maximum allowed amount of buffers? Potential answer: Sounds like a good compromise. I guess it's like discussing hashtable sizes. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/42015?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I167e5f9b7f9d5693b3df05f713288c741031c532 Gerrit-Change-Number: 42015 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Feb 2026 16:57:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmo-netif[master]: gitignore: ignore generated .wasm files
by Timur Davydov 04 Feb '26

04 Feb '26

Attention is currently required from: laforge, pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmo-netif/+/41953?usp=email ) Change subject: gitignore: ignore generated .wasm files ...................................................................... Patch Set 5: (1 comment) Patchset: PS1: > Understood, auto-detection has been dropped. The change is now limited to the .gitignore part only. Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/41953?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I023158cc39989d6fe98080fecb61410aa4e535ab Gerrit-Change-Number: 41953 Gerrit-PatchSet: 5 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Feb 2026 16:57:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[L] Change in pysim[master]: tests/pySim-smpp2sim_test: add integration test
by daniel 04 Feb '26

04 Feb '26

Attention is currently required from: dexter. daniel has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41983?usp=email ) Change subject: tests/pySim-smpp2sim_test: add integration test ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41983?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If25e38be004cc1c7aeeb130431831377e78fe28d Gerrit-Change-Number: 41983 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Feb 2026 16:56:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log February 2026