[XS] Change in osmo-pcap[master]: server: wr_file: Request up to 8 iofd write buffers if available
Attention is currently required from: daniel, jolly, laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/42015?usp=email ) Change subject: server: wr_file: Request up to 8 iofd write buffers if available ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-pcap/+/42015/comment/27ed9747_062e5f96?usp... : PS1, Line 7: 8
So one could recurse to discuss: […] Well, I am not starting a discussion whether 8 is great or not. I just want this (what you wrote) to be stated in code. Otherwise it looks like a magic number to those who are not familiar with the osmo_io internals.
-- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/42015?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I167e5f9b7f9d5693b3df05f713288c741031c532 Gerrit-Change-Number: 42015 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: jolly <andreas@eversberg.eu> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: daniel <dwillmann@sysmocom.de> Gerrit-Comment-Date: Tue, 03 Feb 2026 17:03:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
participants (1)
-
fixeria