February 2026 - gerrit-log - lists.osmocom.org

[XS] Change in libosmo-sigtran[master]: cosmetic: Fix typo in comment
by pespin 04 Feb '26

04 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42040?usp=email ) Change subject: cosmetic: Fix typo in comment ...................................................................... cosmetic: Fix typo in comment Change-Id: If5adb80baaae78cae7164e1f85c53195eafa6e3e --- M src/ss7_as_vty.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/40/42040/1 diff --git a/src/ss7_as_vty.c b/src/ss7_as_vty.c index 92e16bb..2d919bb 100644 --- a/src/ss7_as_vty.c +++ b/src/ss7_as_vty.c @@ -666,7 +666,7 @@ /* AS in ASP role should be configured with a local PC which they can * then announce using RKM. * Still, allow STPs to have AS(P) configured in an ASP mode to talk to a - * peer STP by announcing remove PCs. */ + * peer STP by announcing remote PCs. */ if (as_role == OSMO_SS7_ASP_ROLE_ASP && !osmo_ss7_pc_is_local(as->inst, as->cfg.routing_key.pc)) vty_out(vty, "%% AS '%s' with local role ASP should have a local PC configured in its " -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42040?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: If5adb80baaae78cae7164e1f85c53195eafa6e3e Gerrit-Change-Number: 42040 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmocore[master]: Add Emscripten build support and JS callback logging backend
by pespin 04 Feb '26

04 Feb '26

Attention is currently required from: Timur Davydov, fixeria, laforge, neels, osmith. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email ) Change subject: Add Emscripten build support and JS callback logging backend ...................................................................... Patch Set 27: Code-Review+1 (2 comments) File src/core/logging_emscripten.c: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/3d912597_231ddb50?… : PS26, Line 45: const int msgLen = MAX_LOG_SIZE; > Sounds good, I’ve updated the code accordingly and now use MAX_LOG_SIZE directly, dropping the extra […] Done File src/core/logging_emscripten.c: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/f96df132_fe0f2623?… : PS27, Line 49: rc = vsnprintf(msg, sizeof(msg), format, ap); BTW, you are losing context information here, like file&line. You may want to call log_output_buf() here instead (or implement parts of it here to add file&line), but up to you, you know better how the stuff shows up in the emscripten log. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia8d5f4bb6570b5e055826f3a051e5e5896866e31 Gerrit-Change-Number: 41813 Gerrit-PatchSet: 27 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Wed, 04 Feb 2026 11:23:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[M] Change in libosmocore[master]: Add Emscripten build support and JS callback logging backend
by Timur Davydov 04 Feb '26

04 Feb '26

Attention is currently required from: Timur Davydov, fixeria, laforge, neels, osmith. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email ) Change subject: Add Emscripten build support and JS callback logging backend ...................................................................... Patch Set 26: (2 comments) File src/core/logging_emscripten.c: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/83cbc39d_1d5cedc4?… : PS25, Line 47: char subsys_buf[16]; > That's due to "struct gsmtap_osmocore_log_hdr" being "char subsys[16]" because it's sent as fixed si […] Thanks for the note. You’re right: the 16-byte limit comes from the GSMTAP on-wire header. For the Emscripten logging path there is no such limitation: `on_log_wrapper()` receives pointers to NUL-terminated C strings, and on the JS/TS side we convert them using `AsciiToString()` (i.e. read until the terminating \0). So, keeping a separate `subsys_buf[16]` here is unnecessary “buffer-to-buffer” copying just to pass the subsystem name through. I’ve updated the implementation accordingly to pass the subsystem name directly (falling back to an empty string when not available). File src/core/logging_emscripten.c: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/845c52af_a00924ab?… : PS26, Line 45: const int msgLen = MAX_LOG_SIZE; > Simply drop the variable and use MAX_LOG_SIZE directly, otherwise you are simply duplicating stuff a […] Sounds good, I’ve updated the code accordingly and now use MAX_LOG_SIZE directly, dropping the extra variable as suggested. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia8d5f4bb6570b5e055826f3a051e5e5896866e31 Gerrit-Change-Number: 41813 Gerrit-PatchSet: 26 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Wed, 04 Feb 2026 11:14:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[M] Change in libosmocore[master]: Add Emscripten build support and JS callback logging backend
by Timur Davydov 04 Feb '26

04 Feb '26

Attention is currently required from: Timur Davydov, fixeria, laforge, neels, osmith. Hello Jenkins Builder, fixeria, neels, osmith, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email to look at the new patch set (#27). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Add Emscripten build support and JS callback logging backend ...................................................................... Add Emscripten build support and JS callback logging backend This change enables building libosmocore for sandboxed, non-POSIX environments, specifically WebAssembly targets produced via the Emscripten toolchain. The broader motivation is to allow partial execution of selected Osmocom components in isolated runtime environments where direct access to hardware and traditional operating system facilities (filesystem, sockets, privileged execution) is not available. One intended use case is running a GSM 2G base station where the radio-facing components are executed inside a web environment, while the remaining Osmocom stack and core network components continue to run unchanged on a conventional backend server. In this model, highly stripped-down variants of osmo-bts and osmo-trx are built as static WebAssembly libraries and executed in the browser, while depending on core libraries such as libosmocore, libosmo-netif, and libosmo-abis. A practical advantage of this approach is that no deployment or privileged setup is required on the radio endpoint side. A user can instantiate a radio endpoint with minimal configuration, while all stateful logic and operational complexity remains centralized on the backend. Multiple such radio endpoints may connect to the same backend core network, effectively forming a single logical network from the core network perspective, independent of the physical location of the radio endpoints. Existing libosmocore build logic and platform assumptions rely on the availability of POSIX APIs and OS services which are not present in WebAssembly runtimes. This currently prevents libosmocore from being built for such targets without targeted, build-time adjustments. This patch introduces the minimal set of changes required to enable such builds, without affecting native platforms. As part of this groundwork, a minimal callback-based logging hook is introduced. When building for Emscripten, this hook allows forwarding log messages to an external environment via a user-provided JavaScript callback. This enables integration with browser-side logging or UI infrastructure without introducing new logging backends or runtime dependencies. For all other build targets, the hook resolves to a no-op implementation and does not alter existing logging behavior. No runtime behavior, protocol semantics, or network interactions are changed by this patch. All modifications are strictly limited to build-time and platform-specific code paths and are only active when targeting Emscripten. Native builds and existing deployment scenarios remain unaffected. This patch is intended as groundwork. Follow-up changes, proposed separately and incrementally, may extend similar support to other Osmocom components such as libosmo-netif, libosmo-abis, osmo-bts, and osmo-trx, while keeping all such changes optional and isolated from native builds. Change-Id: Ia8d5f4bb6570b5e055826f3a051e5e5896866e31 --- M .gitignore M configure.ac M include/osmocom/core/logging.h M src/core/Makefile.am M src/core/libosmocore.map A src/core/logging_emscripten.c M src/vty/logging_vty.c 7 files changed, 158 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/13/41813/27 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia8d5f4bb6570b5e055826f3a051e5e5896866e31 Gerrit-Change-Number: 41813 Gerrit-PatchSet: 27 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[S] Change in libosmo-sigtran[master]: xua_rkm: Add checks for ASP role in rx msg path
by pespin 04 Feb '26

04 Feb '26

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42039?usp=email ) Change subject: xua_rkm: Add checks for ASP role in rx msg path ...................................................................... xua_rkm: Add checks for ASP role in rx msg path Change-Id: I672060c24571586b37102c7f7f60e4b0e20e07a9 --- M src/m3ua.c M src/xua_internal.h M src/xua_rkm.c 3 files changed, 30 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/39/42039/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42039?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I672060c24571586b37102c7f7f60e4b0e20e07a9 Gerrit-Change-Number: 42039 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder

1 0

[S] Change in libosmo-sigtran[master]: xua_rkm: Add checks for ASP role in rx msg path
by pespin 04 Feb '26

04 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42039?usp=email ) Change subject: xua_rkm: Add checks for ASP role in rx msg path ...................................................................... xua_rkm: Add checks for ASP role in rx msg path Change-Id: I672060c24571586b37102c7f7f60e4b0e20e07a9 --- M src/m3ua.c M src/xua_internal.h M src/xua_rkm.c 3 files changed, 30 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/39/42039/1 diff --git a/src/m3ua.c b/src/m3ua.c index e4173bd..cad7889 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -266,7 +266,7 @@ static const uint16_t dereg_rsp_ies[] = { M3UA_IEI_DEREG_RESULT, 0 }; -static const struct value_string m3ua_rkm_msgt_names[] = { +const struct value_string m3ua_rkm_msgt_names[] = { { M3UA_RKM_REG_REQ, "REG-REQ" }, { M3UA_RKM_REG_RSP, "REG-RESP" }, { M3UA_RKM_DEREG_REQ, "DEREG-REQ" }, diff --git a/src/xua_internal.h b/src/xua_internal.h index c5bd009..a2f0af6 100644 --- a/src/xua_internal.h +++ b/src/xua_internal.h @@ -135,6 +135,7 @@ extern struct osmo_fsm xua_default_lm_fsm; extern const struct value_string m3ua_rkm_reg_status_vals[]; extern const struct value_string m3ua_rkm_dereg_status_vals[]; +extern const struct value_string m3ua_rkm_msgt_names[]; int xua_as_transmit_msg(struct osmo_ss7_as *as, struct xua_msg *xua); diff --git a/src/xua_rkm.c b/src/xua_rkm.c index 9713e3a..fabe116 100644 --- a/src/xua_rkm.c +++ b/src/xua_rkm.c @@ -561,6 +561,30 @@ return 0; } +#define ENSURE_ASP_OR_IPSP(asp, xua) \ + do { \ + if (asp->cfg.role != OSMO_SS7_ASP_ROLE_ASP && \ + asp->cfg.role != OSMO_SS7_ASP_ROLE_IPSP) { \ + LOGPASP(asp, DLSS7, LOGL_ERROR, "Rx %s not permitted in role %s\n", \ + get_value_string(m3ua_rkm_msgt_names, xua->hdr.msg_type), \ + get_value_string(osmo_ss7_asp_role_names, asp->cfg.role)); \ + xua_msg_free(xua); \ + return -1; \ + } \ + } while (0) + +#define ENSURE_SG_OR_IPSP(asp, xua) \ + do { \ + if (asp->cfg.role != OSMO_SS7_ASP_ROLE_SG && \ + asp->cfg.role != OSMO_SS7_ASP_ROLE_IPSP) { \ + LOGPASP(asp, DLSS7, LOGL_ERROR, "Rx %s not permitted in role %s\n", \ + get_value_string(m3ua_rkm_msgt_names, xua->hdr.msg_type), \ + get_value_string(osmo_ss7_asp_role_names, asp->cfg.role)); \ + xua_msg_free(xua); \ + return -1; \ + } \ + } while (0) + /* process an incoming RKM message in xua format * This function takes ownership of xua msg passed to it. */ int m3ua_rx_rkm(struct osmo_ss7_asp *asp, struct xua_msg *xua) @@ -570,20 +594,20 @@ switch (xua->hdr.msg_type) { /* SG Side */ case M3UA_RKM_REG_REQ: - /* TOOD: ensure we are role SG */ + ENSURE_SG_OR_IPSP(asp, xua); rc = m3ua_rx_rkm_reg_req(asp, xua); break; case M3UA_RKM_DEREG_REQ: - /* TOOD: ensure we are role SG */ + ENSURE_SG_OR_IPSP(asp, xua); rc = m3ua_rx_rkm_dereg_req(asp, xua); break; /* ASP Side */ case M3UA_RKM_REG_RSP: - /* TOOD: ensure we are role ASP */ + ENSURE_ASP_OR_IPSP(asp, xua); rc = m3ua_rx_rkm_reg_rsp(asp, xua); break; case M3UA_RKM_DEREG_RSP: - /* TOOD: ensure we are role ASP */ + ENSURE_ASP_OR_IPSP(asp, xua); rc = m3ua_rx_rkm_dereg_rsp(asp, xua); break; default: -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42039?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I672060c24571586b37102c7f7f60e4b0e20e07a9 Gerrit-Change-Number: 42039 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bts[master]: doc: fix default 'max-initial' value
by fixeria 04 Feb '26

04 Feb '26

Attention is currently required from: Hoernchen, laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42031?usp=email ) Change subject: doc: fix default 'max-initial' value ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I don't know, hence why I'm asking to somebody else to review 😊 For the record, I found the commit changing the value from 23 dBm to 0 dBm: https://gerrit.osmocom.org/c/osmo-bts/+/2231 ``` commit bbe90fd6511c9a0abdb5f41d13c5ab0135b903f7 Author: Harald Welte <laforge(a)gnumonks.org> Date: Fri Mar 24 10:41:04 2017 +0100 sysmobts: Don't start with 0dBm TRX output power before ramping In case a system has a high-gain external PA (like a 40dB PA) connected externally, we cannot simply switch the transceiver to 0 dBm in trx_init() only to then start the ramping at much lower levels once the PHJ completes in trx_init_compl_cb(). The result would be a short 0 + 40 dBm spike followed by later ramping. We want to avoid that spike, particularly its associated inrush current, so let's bring up the board with smething very conservative like -50 dBm, and then ramp from there. Change-Id: I0ad91fce64f65e0213c9fcfde3390ace519055db Fixes: SYS#3259 ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42031?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I178e0664f6818d0eda15701b57bb030916b06006 Gerrit-Change-Number: 42031 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Feb 2026 09:41:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: xua_asp_fsm: Remove duplicated role field
by pespin 04 Feb '26

04 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42038?usp=email ) Change subject: xua_asp_fsm: Remove duplicated role field ...................................................................... xua_asp_fsm: Remove duplicated role field The role is actually taken from the asp object, and it's not expected to change during its lifetime, so there's no really a need to keep a copy of it. Simplify the code by using the asp role everywhere. Change-Id: Ia6de131ce50f07261736645fe5b2ed1ad39eb01b --- M src/ss7_asp.c M src/ss7_xua_srv.c M src/xua_asp_fsm.c M src/xua_asp_fsm.h 4 files changed, 19 insertions(+), 29 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/38/42038/1 diff --git a/src/ss7_asp.c b/src/ss7_asp.c index 161e070..4ca1fb4 100644 --- a/src/ss7_asp.c +++ b/src/ss7_asp.c @@ -915,7 +915,7 @@ osmo_ss7_asp_remove_default_lm(asp); } - if ((rc = xua_asp_fsm_start(asp, asp->cfg.role, LOGL_DEBUG)) < 0) + if ((rc = xua_asp_fsm_start(asp, LOGL_DEBUG)) < 0) return rc; OSMO_ASSERT(asp->fi); diff --git a/src/ss7_xua_srv.c b/src/ss7_xua_srv.c index 85906b7..deb1808 100644 --- a/src/ss7_xua_srv.c +++ b/src/ss7_xua_srv.c @@ -178,7 +178,7 @@ oxs->cfg.local.host_cnt); ss7_asp_peer_set_hosts(&asp->cfg.remote, asp, &hostbuf_ptr, 1); - if ((rc = xua_asp_fsm_start(asp, asp->cfg.role, LOGL_DEBUG)) < 0) { + if ((rc = xua_asp_fsm_start(asp, LOGL_DEBUG)) < 0) { talloc_free(sock_name); osmo_ss7_asp_destroy(asp); return rc; diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c index f70e313..580a298 100644 --- a/src/xua_asp_fsm.c +++ b/src/xua_asp_fsm.c @@ -86,8 +86,6 @@ struct xua_asp_fsm_priv { /* pointer back to ASP to which we belong */ struct osmo_ss7_asp *asp; - /* Role (ASP/SG/IPSP) */ - enum osmo_ss7_asp_role role; /* routing context[s]: list of 32bit integers */ /* ACTIVE: traffic mode type, tid label, drn label ? */ @@ -515,12 +513,13 @@ #define ENSURE_ASP_OR_IPSP(fi, event) \ do { \ struct xua_asp_fsm_priv *_xafp = fi->priv; \ - if (_xafp->role != OSMO_SS7_ASP_ROLE_ASP && \ - _xafp->role != OSMO_SS7_ASP_ROLE_IPSP) { \ + enum osmo_ss7_asp_role _role = _xafp->asp->cfg.role; \ + if (_role != OSMO_SS7_ASP_ROLE_ASP && \ + _role != OSMO_SS7_ASP_ROLE_IPSP) { \ LOGPFSML(fi, LOGL_ERROR, "event %s not permitted " \ "in role %s\n", \ osmo_fsm_event_name(fi->fsm, event), \ - get_value_string(osmo_ss7_asp_role_names, _xafp->role));\ + get_value_string(osmo_ss7_asp_role_names, _role));\ return; \ } \ } while(0) @@ -528,12 +527,13 @@ #define ENSURE_SG_OR_IPSP(fi, event) \ do { \ struct xua_asp_fsm_priv *_xafp = fi->priv; \ - if (_xafp->role != OSMO_SS7_ASP_ROLE_SG && \ - _xafp->role != OSMO_SS7_ASP_ROLE_IPSP) { \ + enum osmo_ss7_asp_role _role = _xafp->asp->cfg.role; \ + if (_role != OSMO_SS7_ASP_ROLE_SG && \ + _role != OSMO_SS7_ASP_ROLE_IPSP) { \ LOGPFSML(fi, LOGL_ERROR, "event %s not permitted " \ "in role %s\n", \ osmo_fsm_event_name(fi->fsm, event), \ - get_value_string(osmo_ss7_asp_role_names, _xafp->role));\ + get_value_string(osmo_ss7_asp_role_names, _role));\ return; \ } \ } while(0) @@ -959,22 +959,19 @@ .cleanup = xua_asp_fsm_cleanup, }; -static int ipa_asp_fsm_start(struct osmo_ss7_asp *asp, - enum osmo_ss7_asp_role role, int log_level); +static int ipa_asp_fsm_start(struct osmo_ss7_asp *asp, int log_level); /*! \brief Start a new ASP finite state machine for given ASP (stored in asp->fi) * \param[in] asp Application Server Process for which to start FSM - * \param[in] role Role (ASP, SG, IPSP) of this FSM * \param[in] log_level Logging Level for ASP FSM logging * \returns 0 on success; negative on error */ -int xua_asp_fsm_start(struct osmo_ss7_asp *asp, - enum osmo_ss7_asp_role role, int log_level) +int xua_asp_fsm_start(struct osmo_ss7_asp *asp, int log_level) { struct osmo_fsm_inst *fi; struct xua_asp_fsm_priv *xafp; if (asp->cfg.proto == OSMO_SS7_ASP_PROT_IPA) - return ipa_asp_fsm_start(asp, role, log_level); + return ipa_asp_fsm_start(asp, log_level); /* allocate as child of AS? */ fi = osmo_fsm_inst_alloc(&xua_asp_fsm, asp, NULL, log_level, asp->cfg.name); @@ -986,7 +983,6 @@ osmo_fsm_inst_term(fi, OSMO_FSM_TERM_ERROR, NULL); return -ENOMEM; } - xafp->role = role; xafp->asp = asp; osmo_timer_setup(&xafp->t_beat.timer, xua_t_beat_cb, fi); @@ -1026,8 +1022,6 @@ struct ipa_asp_fsm_priv { /* pointer back to ASP to which we belong */ struct osmo_ss7_asp *asp; - /* Role (ASP/SG/IPSP) */ - enum osmo_ss7_asp_role role; /* Structure holding parsed data of the IPA CCM ID exchange */ struct ipaccess_unit *ipa_unit; @@ -1146,7 +1140,7 @@ switch (event) { case XUA_ASP_E_M_ASP_UP_REQ: case XUA_ASP_E_SCTP_EST_IND: - if (iafp->role == OSMO_SS7_ASP_ROLE_SG) { + if (iafp->asp->cfg.role == OSMO_SS7_ASP_ROLE_SG) { /* Server: Transmit IPA ID GET + Wait for Response */ if (fd >= 0) { ipa_ccm_send_id_req(fd); @@ -1407,7 +1401,7 @@ * It will be applied to PDUs received from the IPA socket. */ _ipa_asp_pick_unused_sls(iafp->asp, as); /* Now that the AS is known, start the client side: */ - if (iafp->role == OSMO_SS7_ASP_ROLE_ASP && fi->state == IPA_ASP_S_DOWN) { + if (iafp->asp->cfg.role == OSMO_SS7_ASP_ROLE_ASP && fi->state == IPA_ASP_S_DOWN) { LOGPFSML(fi, LOGL_NOTICE, "Bringing up ASP now once it has been assigned to an AS\n"); osmo_fsm_inst_dispatch(fi, XUA_ASP_E_M_ASP_UP_REQ, NULL); } @@ -1522,11 +1516,9 @@ /*! \brief Start a new ASP finite state machine for given ASP (stored on asp->fi) * \param[in] asp Application Server Process for which to start FSM - * \param[in] role Role (ASP, SG, IPSP) of this FSM * \param[in] log_level Logging Level for ASP FSM logging * \returns 0 on success; negative on error */ -static int ipa_asp_fsm_start(struct osmo_ss7_asp *asp, - enum osmo_ss7_asp_role role, int log_level) +static int ipa_asp_fsm_start(struct osmo_ss7_asp *asp, int log_level) { struct osmo_fsm_inst *fi; struct ipa_asp_fsm_priv *iafp; @@ -1557,7 +1549,7 @@ } else { /* ASP in client mode will be brought up when this ASP is added * to an AS, see XUA_ASP_E_AS_ASSIGNED. */ - if (role == OSMO_SS7_ASP_ROLE_ASP) { + if (asp->cfg.role == OSMO_SS7_ASP_ROLE_ASP) { LOGPFSML(fi, LOGL_NOTICE, "ASP is not assigned to any AS. ASP bring up delayed\n"); can_start = false; } @@ -1565,7 +1557,6 @@ /* asp->ipa.sls will be assigned together with AS unit_name during XUA_ASP_E_AS_ASSIGNED. */ } - iafp->role = role; iafp->asp = asp; iafp->ipa_unit = talloc_zero(iafp, struct ipaccess_unit); iafp->ipa_unit->unit_name = talloc_strdup(iafp->ipa_unit, unit_name); @@ -1576,7 +1567,7 @@ /* Attach FSM to ASP: */ asp->fi = fi; - if (can_start && role == OSMO_SS7_ASP_ROLE_ASP) + if (can_start && asp->cfg.role == OSMO_SS7_ASP_ROLE_ASP) osmo_fsm_inst_dispatch(fi, XUA_ASP_E_M_ASP_UP_REQ, NULL); return 0; diff --git a/src/xua_asp_fsm.h b/src/xua_asp_fsm.h index ab19e36..61a43a1 100644 --- a/src/xua_asp_fsm.h +++ b/src/xua_asp_fsm.h @@ -42,5 +42,4 @@ extern struct osmo_fsm xua_asp_fsm; extern struct osmo_fsm ipa_asp_fsm; -int xua_asp_fsm_start(struct osmo_ss7_asp *asp, - enum osmo_ss7_asp_role role, int log_level); +int xua_asp_fsm_start(struct osmo_ss7_asp *asp, int log_level); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42038?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ia6de131ce50f07261736645fe5b2ed1ad39eb01b Gerrit-Change-Number: 42038 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bts[master]: doc: fix default 'max-initial' value
by pespin 04 Feb '26

04 Feb '26

Attention is currently required from: Hoernchen, fixeria, laforge. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42031?usp=email ) Change subject: doc: fix default 'max-initial' value ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Why should it be 23 dBm in the first place? 0 dB looks like a reasonable default. […] I don't know, hence why I'm asking to somebody else to review 😊 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42031?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I178e0664f6818d0eda15701b57bb030916b06006 Gerrit-Change-Number: 42031 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Feb 2026 08:13:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bts[master]: doc: fix default 'max-initial' value
by fixeria 04 Feb '26

04 Feb '26

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42031?usp=email ) Change subject: doc: fix default 'max-initial' value ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > @laforge@gnumonks. […] Why should it be 23 dBm in the first place? 0 dB looks like a reasonable default. 23 dBm is ~200 mW, which is the maximum Tx power of USRP B2xx. This is also the default assumed Tx power of osmo-bts-trx before the actual value is known. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42031?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I178e0664f6818d0eda15701b57bb030916b06006 Gerrit-Change-Number: 42031 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Feb 2026 08:12:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log February 2026