Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42032?usp=email )
Change subject: osmo-bts-trx: add missing \n to a logging message
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42032?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I5b3091b5ed96e28ae056272398c5eddbdef4b8b5
Gerrit-Change-Number: 42032
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Feb 2026 07:47:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria, laforge.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42031?usp=email )
Change subject: doc: fix default 'max-initial' value
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
@laforge@gnumonks.org do we want to keep the default as 0 or should the code fixed to be 23?
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42031?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I178e0664f6818d0eda15701b57bb030916b06006
Gerrit-Change-Number: 42031
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Feb 2026 07:47:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Timur Davydov, fixeria, laforge, neels, osmith.
pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email )
Change subject: Add Emscripten build support and JS callback logging backend
......................................................................
Patch Set 26:
(2 comments)
File src/core/logging_emscripten.c:
https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/05b17747_9b375ccc?… :
PS25, Line 47: char subsys_buf[16];
> This is kept at 16 bytes for consistency with `logging_gsmtap.c` […]
That's due to "struct gsmtap_osmocore_log_hdr" being "char subsys[16]" because it's sent as fixed size over the wire.
It may make sense to look at emscripten.h or on_log_wrapper() API doc to see if there's another limitation in your case.
In practice 16 is fine, just mentioning in case you want to look at it.
In any case, we tend to better use C style comments "/\* \*/" in osmocom code.
File src/core/logging_emscripten.c:
https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/ccc0bb60_bf465a68?… :
PS26, Line 45: const int msgLen = MAX_LOG_SIZE;
Simply drop the variable and use MAX_LOG_SIZE directly, otherwise you are simply duplicating stuff and making code more complex for no good reason.
char msg[MAX_LOG_SIZE];
rc = vsnprintf(msg, sizeof(msg), format, ap);
if (rc <= 0)
return;
if (rc >= sizeof(msg))
rc = sizeof(msg) - 1;
/* Drop newline at the end if exists: */
if (msg[rc - 1] == '\n')
msg[rc - 1] = '\0';
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia8d5f4bb6570b5e055826f3a051e5e5896866e31
Gerrit-Change-Number: 41813
Gerrit-PatchSet: 26
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Comment-Date: Wed, 04 Feb 2026 07:45:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>
Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42022?usp=email )
Change subject: bts: f_verify_ramp_up(): fix RxLev / dBm mixup
......................................................................
Patch Set 2:
(1 comment)
File bts/BTS_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42022/comment/28830f85_b700… :
PS2, Line 2804: Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
> Next time you review my patches please don't tell me to avoid changing the formatting of these ;)
Just to be clear, adding dBm units makes the strings even longer. I could have kept these clumsy `log2str()` constructs, but editing and reading them gets even harder as the amount of arguments grows. Hence I changed to `setverdict(fail, ...)`.
But since this is mostly your code, I can revert back to using `log2str()` if you prefer.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42022?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I818d18d6e0711247b73ee1f336133e2ed3f6e2cb
Gerrit-Change-Number: 42022
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Feb 2026 07:44:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42022?usp=email )
Change subject: bts: f_verify_ramp_up(): fix RxLev / dBm mixup
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File bts/BTS_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42022/comment/d07e83ae_5516… :
PS2, Line 2804: Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
Next time you review my patches please don't tell me to avoid changing the formatting of these ;)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42022?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I818d18d6e0711247b73ee1f336133e2ed3f6e2cb
Gerrit-Change-Number: 42022
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Feb 2026 07:29:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42020?usp=email )
Change subject: bts: f_TC_acch_overpower(): use f_wait_ramp_up()
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42020?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id9b8bfc70cb26508e12ccd2b142bb458a3912c09
Gerrit-Change-Number: 42020
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Feb 2026 07:25:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42037?usp=email )
Change subject: bts: limit stderr logging to ERROR to avoid long write() to ext4 fs
......................................................................
bts: limit stderr logging to ERROR to avoid long write() to ext4 fs
Commit c3ab9ec33f37c6837fb8bcb0fa0bbd2e98781fb7 already decreased
verbosity to NOTICE, but that's not enough since we still get plenty of
logging and hence plenty of long write()s during test execution.
Let's try decreasing to ERROR and see if that's enough for now to
stabilize the tests.
Change-Id: I41982fd83a9f46609464afb6b7242240063d4d91
---
M bts/osmo-bts.cfg
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/37/42037/1
diff --git a/bts/osmo-bts.cfg b/bts/osmo-bts.cfg
index 7ac38a1..b2f5190 100644
--- a/bts/osmo-bts.cfg
+++ b/bts/osmo-bts.cfg
@@ -16,7 +16,7 @@
logging print category-hex 0
logging print level 1
!
- logging level set-all notice
+ logging level set-all error
!Disabled due to stderr redirect to ext4 filesystem creating long writes of >500ms (OS#6794):
!logging level rsl info
!logging level meas info
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42037?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I41982fd83a9f46609464afb6b7242240063d4d91
Gerrit-Change-Number: 42037
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>