September 2025 - gerrit-log - lists.osmocom.org

[XL] Change in osmo-ttcn3-hacks[master]: smdpp: proper headers for native code

by Jenkins Builder

Attention is currently required from: Hoernchen. Jenkins Builder has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122?usp=email ) Change subject: smdpp: proper headers for native code ...................................................................... Patch Set 3: (317 comments) File smdpp/helpers.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/a7836bc2_af0e… : PS3, Line 56: void operator()(EVP_PKEY* key) const { Bad function definition - void operator() should probably be void operator(void) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/88925d19_37b6… : PS3, Line 56: void operator()(EVP_PKEY* key) const { need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/72f3250b_d3d8… : PS3, Line 171: #endif // HELPERS_H adding a line without newline at end of file File smdpp/http_client.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/e75bc8d7_a8b8… : PS3, Line 21: public: labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/6759e5bc_1a68… : PS3, Line 26: std::string body; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/e990e808_3271… : PS3, Line 28: std::string headers; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/413053bc_276a… : PS3, Line 33: std::string clientCertPath; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/75657654_48ee… : PS3, Line 34: std::string clientKeyPath; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/ffa72c6f_2ea7… : PS3, Line 37: std::string contentType = "application/json"; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/8c0e87a9_837f… : PS3, Line 40: ResponseData postJson(const std::string& url, unsigned int port, const std::string& jsonData, X509_STORE* store, std::vector<X509*>& certPool, "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/e72d70e2_f400… : PS3, Line 40: ResponseData postJson(const std::string& url, unsigned int port, const std::string& jsonData, X509_STORE* store, std::vector<X509*>& certPool, need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/9b2e36aa_805d… : PS3, Line 40: ResponseData postJson(const std::string& url, unsigned int port, const std::string& jsonData, X509_STORE* store, std::vector<X509*>& certPool, need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/954d0797_2ea3… : PS3, Line 40: ResponseData postJson(const std::string& url, unsigned int port, const std::string& jsonData, X509_STORE* store, std::vector<X509*>& certPool, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/bb3475a2_2a9c… : PS3, Line 40: ResponseData postJson(const std::string& url, unsigned int port, const std::string& jsonData, X509_STORE* store, std::vector<X509*>& certPool, spaces required around that '>' (ctx:OxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/fbc45b98_9a88… : PS3, Line 40: ResponseData postJson(const std::string& url, unsigned int port, const std::string& jsonData, X509_STORE* store, std::vector<X509*>& certPool, space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/d4bf1ab1_5fbc… : PS3, Line 40: ResponseData postJson(const std::string& url, unsigned int port, const std::string& jsonData, X509_STORE* store, std::vector<X509*>& certPool, space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/3288b097_7596… : PS3, Line 41: const PostConfig& config); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/164dff42_5f41… : PS3, Line 43: private: labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/ff01acd4_f322… : PS3, Line 44: static size_t writeCallback(void* contents, size_t size, size_t nmemb, void* userp); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/8036c54d_4592… : PS3, Line 44: static size_t writeCallback(void* contents, size_t size, size_t nmemb, void* userp); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/53aaa731_e912… : PS3, Line 45: static size_t headerCallback(void* contents, size_t size, size_t nmemb, void* userp); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/12de7764_6777… : PS3, Line 45: static size_t headerCallback(void* contents, size_t size, size_t nmemb, void* userp); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/701cb46b_977a… : PS3, Line 48: X509_STORE* store; "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/c5491b1a_89fa… : PS3, Line 49: std::vector<X509*>* certPool; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/2ed257bf_902c… : PS3, Line 49: std::vector<X509*>* certPool; spaces required around that '>' (ctx:OxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/702a7543_355e… : PS3, Line 49: std::vector<X509*>* certPool; space required before that '*' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/cf6b16cc_21af… : PS3, Line 49: std::vector<X509*>* certPool; space prohibited after that '*' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/f4375ff7_0f7f… : PS3, Line 49: std::vector<X509*>* certPool; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/203fdfd5_11eb… : PS3, Line 51: std::string errorMessage; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/44e256dd_f6b2… : PS3, Line 54: static std::string get_cn_name(X509_NAME* const name); need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/343b87a5_f23e… : PS3, Line 55: static CURLcode sslCtxFunction(CURL* curl, SSL_CTX* sslCtx, void* arg); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/f71c79ff_a5aa… : PS3, Line 55: static CURLcode sslCtxFunction(CURL* curl, SSL_CTX* sslCtx, void* arg); need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/5a23764f_a699… : PS3, Line 55: static CURLcode sslCtxFunction(CURL* curl, SSL_CTX* sslCtx, void* arg); need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/2feaa6ba_94bd… : PS3, Line 60: #endif // HTTP_CLIENT_H adding a line without newline at end of file File smdpp/logger.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/a30c6e4c_0e9f… : PS3, Line 256: #endif // LOGGER_H adding a line without newline at end of file File smdpp/rsp_client.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/06edc4d1_a02c… : PS3, Line 20: typedef struct x509_st X509; do not add new typedefs Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/778c33f7_43d5… : PS3, Line 21: typedef struct evp_pkey_st EVP_PKEY; do not add new typedefs Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/adb0168f_f3f6… : PS3, Line 22: typedef struct x509_store_st X509_STORE; do not add new typedefs Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/e6f86d94_2529… : PS3, Line 36: public: labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/e2fc2bc5_ab83… : PS3, Line 44: RSPClient(const std::string& serverUrl, const unsigned int serverPort, const std::vector<std::string>& certPath, need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/297be6f8_cd76… : PS3, Line 44: RSPClient(const std::string& serverUrl, const unsigned int serverPort, const std::vector<std::string>& certPath, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/3d22d3ad_b92f… : PS3, Line 44: RSPClient(const std::string& serverUrl, const unsigned int serverPort, const std::vector<std::string>& certPath, spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/0b337c4b_7fa4… : PS3, Line 44: RSPClient(const std::string& serverUrl, const unsigned int serverPort, const std::vector<std::string>& certPath, space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/b17c5d28_5b18… : PS3, Line 44: RSPClient(const std::string& serverUrl, const unsigned int serverPort, const std::vector<std::string>& certPath, space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/93932935_ec2a… : PS3, Line 45: const std::vector<std::string>& name_filters = {}); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/19613ee7_5fbe… : PS3, Line 45: const std::vector<std::string>& name_filters = {}); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/9ae309a4_b28f… : PS3, Line 45: const std::vector<std::string>& name_filters = {}); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/3fe797f0_c4ce… : PS3, Line 45: const std::vector<std::string>& name_filters = {}); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/6cb87028_14b2… : PS3, Line 53: void setCACertPath(const std::string& path); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/c948f6f1_7887… : PS3, Line 54: void loadEUICCCertificate(const std::string& euiccCertPath); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/c56a9ae3_da0d… : PS3, Line 55: void loadEUICCKeyPair(const std::string& euiccPrivateKeyPath, const std::string& euiccPublicKeyPath = ""); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/1f63a823_f584… : PS3, Line 55: void loadEUICCKeyPair(const std::string& euiccPrivateKeyPath, const std::string& euiccPublicKeyPath = ""); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/43fd90bd_0688… : PS3, Line 56: void loadEUMCertificate(const std::string& eumCertPath); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/4f252998_dec0… : PS3, Line 57: void loadEUMKeyPair(const std::string& eumPrivateKeyPath, const std::string& eumPublicKeyPath = ""); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/2590f5bc_dbc0… : PS3, Line 57: void loadEUMKeyPair(const std::string& eumPrivateKeyPath, const std::string& eumPublicKeyPath = ""); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/4587e4cb_f5ae… : PS3, Line 60: std::vector<uint8_t> getEUMCertificate(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/be579b7f_3797… : PS3, Line 60: std::vector<uint8_t> getEUMCertificate(); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/4715569a_8f4b… : PS3, Line 60: std::vector<uint8_t> getEUMCertificate(); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/c422853b_98c2… : PS3, Line 61: std::vector<uint8_t> getEUICCCertificate(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/0224ad71_f0d4… : PS3, Line 61: std::vector<uint8_t> getEUICCCertificate(); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/834ca507_fa3a… : PS3, Line 61: std::vector<uint8_t> getEUICCCertificate(); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/64f1c7e7_5752… : PS3, Line 62: std::vector<uint8_t> getCICertificate(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/95a592e8_6252… : PS3, Line 62: std::vector<uint8_t> getCICertificate(); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/15ff6f11_bd55… : PS3, Line 62: std::vector<uint8_t> getCICertificate(); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/da79fe1d_5112… : PS3, Line 65: std::vector<uint8_t> generateChallenge(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/7f0bb054_a25c… : PS3, Line 65: std::vector<uint8_t> generateChallenge(); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/8923d519_3ba9… : PS3, Line 65: std::vector<uint8_t> generateChallenge(); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/15e24e12_ed90… : PS3, Line 66: void generateEUICCOtpk(); Bad function definition - void generateEUICCOtpk() should probably be void generateEUICCOtpk(void) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/5d33c09e_3933… : PS3, Line 67: std::vector<uint8_t> getEUICCOtpk(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/4535b7be_9460… : PS3, Line 67: std::vector<uint8_t> getEUICCOtpk(); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/a4cfb107_9350… : PS3, Line 67: std::vector<uint8_t> getEUICCOtpk(); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/3c7d6181_5f76… : PS3, Line 68: std::vector<uint8_t> signDataWithEUICC(const std::vector<uint8_t>& dataToSign); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/ea6c5f38_13bd… : PS3, Line 68: std::vector<uint8_t> signDataWithEUICC(const std::vector<uint8_t>& dataToSign); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/55f74853_a5dc… : PS3, Line 68: std::vector<uint8_t> signDataWithEUICC(const std::vector<uint8_t>& dataToSign); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/b0863f5c_2fb0… : PS3, Line 68: std::vector<uint8_t> signDataWithEUICC(const std::vector<uint8_t>& dataToSign); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/372a938c_210c… : PS3, Line 68: std::vector<uint8_t> signDataWithEUICC(const std::vector<uint8_t>& dataToSign); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/0f935a97_c11d… : PS3, Line 68: std::vector<uint8_t> signDataWithEUICC(const std::vector<uint8_t>& dataToSign); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/76ab45bd_8269… : PS3, Line 68: std::vector<uint8_t> signDataWithEUICC(const std::vector<uint8_t>& dataToSign); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/36c858cd_3bab… : PS3, Line 69: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/c2a04e99_dbf8… : PS3, Line 69: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/734a1e19_05b4… : PS3, Line 69: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/0a391efa_eb08… : PS3, Line 69: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/90c6f059_841d… : PS3, Line 69: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/8af3ab1b_2391… : PS3, Line 69: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/26603c91_a240… : PS3, Line 69: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/13d559cd_1e0a… : PS3, Line 69: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/a4ffe5dc_c50e… : PS3, Line 69: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature); function definition argument 'uint8_t' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/027cb963_51b1… : PS3, Line 69: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature); function definition argument 'uint8_t' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/bf66bf18_18c0… : PS3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/053c60f4_e2d9… : PS3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1, spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/93fed03a_a68b… : PS3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1, space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/3fa38635_7e83… : PS3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1, space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/16b382c5_b450… : PS3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/a73e6052_3bd7… : PS3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1, spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/11790386_c69c… : PS3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1, space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/0c2f274d_619d… : PS3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1, space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/352343d5_4eda… : PS3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1, function definition argument 'uint8_t' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/c9d93102_0722… : PS3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1, function definition argument 'uint8_t' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/9e080112_7f62… : PS3, Line 70: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& serverSignature1, function definition argument 'uint8_t' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/e46b34d5_b434… : PS3, Line 71: const std::vector<uint8_t>& derDataServerCert); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/3e96c5e2_c379… : PS3, Line 71: const std::vector<uint8_t>& derDataServerCert); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/6869e4b7_c0c9… : PS3, Line 71: const std::vector<uint8_t>& derDataServerCert); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/2dc606bd_7529… : PS3, Line 71: const std::vector<uint8_t>& derDataServerCert); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/0747769b_4000… : PS3, Line 72: std::vector<uint8_t> computeECDHSharedSecret(const std::vector<uint8_t>& otherPublicKey); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/b3a474e4_cb29… : PS3, Line 72: std::vector<uint8_t> computeECDHSharedSecret(const std::vector<uint8_t>& otherPublicKey); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/635c8ffa_b86f… : PS3, Line 72: std::vector<uint8_t> computeECDHSharedSecret(const std::vector<uint8_t>& otherPublicKey); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/bb811f0c_2c04… : PS3, Line 72: std::vector<uint8_t> computeECDHSharedSecret(const std::vector<uint8_t>& otherPublicKey); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/7d565577_824a… : PS3, Line 72: std::vector<uint8_t> computeECDHSharedSecret(const std::vector<uint8_t>& otherPublicKey); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/6a669a47_7e42… : PS3, Line 72: std::vector<uint8_t> computeECDHSharedSecret(const std::vector<uint8_t>& otherPublicKey); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/009d0b76_8859… : PS3, Line 72: std::vector<uint8_t> computeECDHSharedSecret(const std::vector<uint8_t>& otherPublicKey); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/60614fd7_619f… : PS3, Line 75: void setConfirmationCode(const std::string& confirmationCode); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/88c8a0b4_28fb… : PS3, Line 76: void setTransactionId(const std::vector<uint8_t>& transactionId); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/d3c8da77_e3e4… : PS3, Line 76: void setTransactionId(const std::vector<uint8_t>& transactionId); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/b10d2a05_b854… : PS3, Line 76: void setTransactionId(const std::vector<uint8_t>& transactionId); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/e7dd3982_dc9b… : PS3, Line 76: void setTransactionId(const std::vector<uint8_t>& transactionId); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/b18ebdc5_e17e… : PS3, Line 76: void setTransactionId(const std::vector<uint8_t>& transactionId); function definition argument 'uint8_t' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/a1c81862_c97a… : PS3, Line 77: std::vector<uint8_t> getConfirmationCodeHash() const; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/1bed5134_8e00… : PS3, Line 77: std::vector<uint8_t> getConfirmationCodeHash() const; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/f38b9687_34e5… : PS3, Line 77: std::vector<uint8_t> getConfirmationCodeHash() const; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/05be8fc5_0f05… : PS3, Line 78: void setConfirmationCodeHash(const std::vector<uint8_t>& hash); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/1945b33c_29a6… : PS3, Line 78: void setConfirmationCodeHash(const std::vector<uint8_t>& hash); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/289a1fd6_20c0… : PS3, Line 78: void setConfirmationCodeHash(const std::vector<uint8_t>& hash); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/fbd7768b_eaea… : PS3, Line 78: void setConfirmationCodeHash(const std::vector<uint8_t>& hash); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/2c00a494_d8df… : PS3, Line 78: void setConfirmationCodeHash(const std::vector<uint8_t>& hash); function definition argument 'uint8_t' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/2987e011_8410… : PS3, Line 81: void configureHttpClient(bool useCustomTlsCert, const std::string& customTlsCertPath = ""); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/92c5e590_3744… : PS3, Line 82: void setAuthParams(bool useMutualTLS, const std::string& clientCertPath, const std::string& clientKeyPath); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/9c2806b3_30f5… : PS3, Line 82: void setAuthParams(bool useMutualTLS, const std::string& clientCertPath, const std::string& clientKeyPath); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/48683a81_70d9… : PS3, Line 85: std::string sendHttpsPost(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/e5c834be_ede8… : PS3, Line 85: std::string sendHttpsPost(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/f94ec7c3_964c… : PS3, Line 85: std::string sendHttpsPost(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/41da2d1d_1e98… : PS3, Line 85: std::string sendHttpsPost(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/e10e779b_4fb3… : PS3, Line 86: std::string sendHttpsPostWithAuth(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/1f3e6bb2_42bb… : PS3, Line 86: std::string sendHttpsPostWithAuth(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/2a042a6d_df40… : PS3, Line 86: std::string sendHttpsPostWithAuth(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/938aa22e_feeb… : PS3, Line 86: std::string sendHttpsPostWithAuth(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/1bf904b1_e29e… : PS3, Line 87: std::string sendHttpsPostWithContentType(const std::string& endpoint, const std::string& body, const std::string& contentType, int& httpStatusCode, need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/69d24961_c13b… : PS3, Line 87: std::string sendHttpsPostWithContentType(const std::string& endpoint, const std::string& body, const std::string& contentType, int& httpStatusCode, need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/210fada4_bc5a… : PS3, Line 87: std::string sendHttpsPostWithContentType(const std::string& endpoint, const std::string& body, const std::string& contentType, int& httpStatusCode, need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/283f0814_4d37… : PS3, Line 87: std::string sendHttpsPostWithContentType(const std::string& endpoint, const std::string& body, const std::string& contentType, int& httpStatusCode, need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/b5f7dd73_a33d… : PS3, Line 87: std::string sendHttpsPostWithContentType(const std::string& endpoint, const std::string& body, const std::string& contentType, int& httpStatusCode, labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/1bdedf00_2614… : PS3, Line 89: std::string sendHttpsPostUnified(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride, need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/3a3488c2_a0a4… : PS3, Line 89: std::string sendHttpsPostUnified(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride, need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/267cb1e7_4977… : PS3, Line 89: std::string sendHttpsPostUnified(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride, need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/6b2dc5ba_7308… : PS3, Line 89: std::string sendHttpsPostUnified(const std::string& endpoint, const std::string& body, int& httpStatusCode, unsigned int portOverride, labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/5693a859_c29b… : PS3, Line 90: bool useMutualTLS = false, const std::string& clientCertPath = "", const std::string& clientKeyPath = "", Statements should start on a tabstop Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/18d62ec4_4270… : PS3, Line 90: bool useMutualTLS = false, const std::string& clientCertPath = "", const std::string& clientKeyPath = "", need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/decbf24c_d772… : PS3, Line 90: bool useMutualTLS = false, const std::string& clientCertPath = "", const std::string& clientKeyPath = "", need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/8d35117e_a785… : PS3, Line 91: const std::string& contentType = "application/json"); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/06b70c4b_4690… : PS3, Line 93: private: labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/c41f8af2_980d… : PS3, Line 95: void loadCertificate(const std::string& certPath, const std::string& certType, std::unique_ptr<X509, X509Deleter>& certStorage); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/97dbce9d_6922… : PS3, Line 95: void loadCertificate(const std::string& certPath, const std::string& certType, std::unique_ptr<X509, X509Deleter>& certStorage); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/8ec219bc_fde3… : PS3, Line 95: void loadCertificate(const std::string& certPath, const std::string& certType, std::unique_ptr<X509, X509Deleter>& certStorage); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/ee76880e_2b31… : PS3, Line 95: void loadCertificate(const std::string& certPath, const std::string& certType, std::unique_ptr<X509, X509Deleter>& certStorage); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/d4b6acd4_ea06… : PS3, Line 95: void loadCertificate(const std::string& certPath, const std::string& certType, std::unique_ptr<X509, X509Deleter>& certStorage); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/d2f2bdc6_ac8a… : PS3, Line 95: void loadCertificate(const std::string& certPath, const std::string& certType, std::unique_ptr<X509, X509Deleter>& certStorage); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/51a39e2b_703d… : PS3, Line 96: void loadKeyPair(const std::string& privateKeyPath, const std::string& publicKeyPath, const std::string& keyType, need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/3d8d6e54_bac5… : PS3, Line 96: void loadKeyPair(const std::string& privateKeyPath, const std::string& publicKeyPath, const std::string& keyType, need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/d952a3fd_90d6… : PS3, Line 96: void loadKeyPair(const std::string& privateKeyPath, const std::string& publicKeyPath, const std::string& keyType, need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/1e34158e_e886… : PS3, Line 96: void loadKeyPair(const std::string& privateKeyPath, const std::string& publicKeyPath, const std::string& keyType, function definition argument 'uint8_t' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/e2a4d91d_9c51… : PS3, Line 97: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter>& privateKeyStorage, std::vector<uint8_t>& publicKeyStorage); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/27994f24_28e1… : PS3, Line 97: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter>& privateKeyStorage, std::vector<uint8_t>& publicKeyStorage); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/4009f09b_4173… : PS3, Line 97: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter>& privateKeyStorage, std::vector<uint8_t>& publicKeyStorage); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/25a55cb2_daef… : PS3, Line 97: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter>& privateKeyStorage, std::vector<uint8_t>& publicKeyStorage); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/be3c4157_6c11… : PS3, Line 97: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter>& privateKeyStorage, std::vector<uint8_t>& publicKeyStorage); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/82ee5fe9_3eb9… : PS3, Line 97: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter>& privateKeyStorage, std::vector<uint8_t>& publicKeyStorage); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/336e8499_468c… : PS3, Line 97: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter>& privateKeyStorage, std::vector<uint8_t>& publicKeyStorage); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/7f7db813_ff0a… : PS3, Line 97: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter>& privateKeyStorage, std::vector<uint8_t>& publicKeyStorage); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/9c98a44d_525e… : PS3, Line 97: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter>& privateKeyStorage, std::vector<uint8_t>& publicKeyStorage); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/83aff81c_82a8… : PS3, Line 98: std::vector<uint8_t> signDataWithKey(const std::vector<uint8_t>& dataToSign, EVP_PKEY* pkey); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/832c4f3d_3781… : PS3, Line 98: std::vector<uint8_t> signDataWithKey(const std::vector<uint8_t>& dataToSign, EVP_PKEY* pkey); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/4bf336fe_9f17… : PS3, Line 98: std::vector<uint8_t> signDataWithKey(const std::vector<uint8_t>& dataToSign, EVP_PKEY* pkey); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/2d811d85_daba… : PS3, Line 98: std::vector<uint8_t> signDataWithKey(const std::vector<uint8_t>& dataToSign, EVP_PKEY* pkey); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/b5e9de37_49d4… : PS3, Line 98: std::vector<uint8_t> signDataWithKey(const std::vector<uint8_t>& dataToSign, EVP_PKEY* pkey); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/fdd43d84_16c2… : PS3, Line 98: std::vector<uint8_t> signDataWithKey(const std::vector<uint8_t>& dataToSign, EVP_PKEY* pkey); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/b1730ab1_474f… : PS3, Line 98: std::vector<uint8_t> signDataWithKey(const std::vector<uint8_t>& dataToSign, EVP_PKEY* pkey); need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/bbb14461_002f… : PS3, Line 98: std::vector<uint8_t> signDataWithKey(const std::vector<uint8_t>& dataToSign, EVP_PKEY* pkey); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/a701e5ad_35ae… : PS3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/f6775912_2398… : PS3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/3e6360cd_2e36… : PS3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/206c683b_2915… : PS3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/46ec6c51_62f6… : PS3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/ae595a55_8a6d… : PS3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/6cc6d46a_52df… : PS3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/d0ec9c25_fc30… : PS3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/b455158b_266a… : PS3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/d8ba1f7d_7588… : PS3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert); function definition argument 'uint8_t' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/fe6bbaa1_c42f… : PS3, Line 99: bool verifyServerSignature(const std::vector<uint8_t>& signedData, const std::vector<uint8_t>& signature, X509* serverCert); function definition argument 'uint8_t' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/420473b8_c0bd… : PS3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert, "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/239936bf_b643… : PS3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/af87c7fc_c750… : PS3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert, spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/6d77f78d_6b0c… : PS3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert, space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/1dd6cae0_709d… : PS3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert, space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/ffce72c3_6ab2… : PS3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/f289cc8f_1c52… : PS3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert, spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/00868cd5_fa74… : PS3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert, space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/637bdfd7_fb6c… : PS3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert, space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/ed991800_b601… : PS3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert, function definition argument 'uint8_t' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/c8915922_7de3… : PS3, Line 100: bool verifyServerSignature(const std::vector<uint8_t>& serverSigned1, const std::vector<uint8_t>& signature, X509* serverCert, function definition argument 'uint8_t' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/5143630e_b445… : PS3, Line 101: const std::string& certSource); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/b8ce2e59_0dcf… : PS3, Line 102: int getEUICCCurveNID(); Bad function definition - int getEUICCCurveNID() should probably be int getEUICCCurveNID(void) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/8b4f265c_ff15… : PS3, Line 105: std::string m_serverUrl; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/bef2b79d_dd1e… : PS3, Line 107: std::unique_ptr<X509, X509Deleter> m_rootCA; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/0381be25_61d2… : PS3, Line 107: std::unique_ptr<X509, X509Deleter> m_rootCA; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/f161b7e7_7af3… : PS3, Line 107: std::unique_ptr<X509, X509Deleter> m_rootCA; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/b03b35a5_7baa… : PS3, Line 108: std::vector<std::unique_ptr<X509, X509Deleter>> m_intermediateCA; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/8379037c_f149… : PS3, Line 108: std::vector<std::unique_ptr<X509, X509Deleter>> m_intermediateCA; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/2d3bbb1e_ae2a… : PS3, Line 108: std::vector<std::unique_ptr<X509, X509Deleter>> m_intermediateCA; need consistent spacing around '>>' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/dce21a06_522f… : PS3, Line 108: std::vector<std::unique_ptr<X509, X509Deleter>> m_intermediateCA; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/f493e300_2fa2… : PS3, Line 109: std::unique_ptr<X509, X509Deleter> m_serverCert; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/29946b00_c0a4… : PS3, Line 109: std::unique_ptr<X509, X509Deleter> m_serverCert; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/4b5627c5_a0c0… : PS3, Line 109: std::unique_ptr<X509, X509Deleter> m_serverCert; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/73039811_b1e1… : PS3, Line 110: std::vector<std::unique_ptr<X509, X509Deleter>> m_certPool; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/3e20183d_4f2e… : PS3, Line 110: std::vector<std::unique_ptr<X509, X509Deleter>> m_certPool; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/81ef86e6_759d… : PS3, Line 110: std::vector<std::unique_ptr<X509, X509Deleter>> m_certPool; need consistent spacing around '>>' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/3d4f0bba_13cd… : PS3, Line 110: std::vector<std::unique_ptr<X509, X509Deleter>> m_certPool; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/57b853ea_a376… : PS3, Line 112: std::vector<uint8_t> m_euiccSKI; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/6eb46dc8_547f… : PS3, Line 112: std::vector<uint8_t> m_euiccSKI; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/27b54947_37be… : PS3, Line 112: std::vector<uint8_t> m_euiccSKI; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/f2347efb_a428… : PS3, Line 113: std::string m_EID; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/77f6f5fb_4a76… : PS3, Line 114: std::unique_ptr<X509, X509Deleter> m_euiccCert; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/8fded099_aebf… : PS3, Line 114: std::unique_ptr<X509, X509Deleter> m_euiccCert; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/4bc12274_fd84… : PS3, Line 114: std::unique_ptr<X509, X509Deleter> m_euiccCert; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/21922396_57ad… : PS3, Line 115: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter> m_euiccPrivateKey; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/ab9c59bd_1d10… : PS3, Line 115: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter> m_euiccPrivateKey; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/7c1fd285_1df0… : PS3, Line 115: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter> m_euiccPrivateKey; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/8f13e1dd_4ee5… : PS3, Line 116: std::vector<uint8_t> m_euiccPublicKeyData; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/21f9d50a_7d4a… : PS3, Line 116: std::vector<uint8_t> m_euiccPublicKeyData; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/6403f0ab_856f… : PS3, Line 116: std::vector<uint8_t> m_euiccPublicKeyData; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/807a9b46_16c7… : PS3, Line 117: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter> m_euicc_ot_PrivateKey; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/e9bf49e3_5067… : PS3, Line 117: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter> m_euicc_ot_PrivateKey; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/62f74ed2_ae14… : PS3, Line 117: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter> m_euicc_ot_PrivateKey; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/fc8ed102_54ff… : PS3, Line 118: std::vector<uint8_t> m_euiccOtpk; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/12700654_69a2… : PS3, Line 118: std::vector<uint8_t> m_euiccOtpk; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/f564784d_59e9… : PS3, Line 118: std::vector<uint8_t> m_euiccOtpk; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/16958c21_f49e… : PS3, Line 120: std::unique_ptr<X509, X509Deleter> m_eumCert; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/12cd723e_4de2… : PS3, Line 120: std::unique_ptr<X509, X509Deleter> m_eumCert; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/8793ce2b_6744… : PS3, Line 120: std::unique_ptr<X509, X509Deleter> m_eumCert; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/b7e3b409_8172… : PS3, Line 121: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter> m_eumPrivateKey; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/20dc5493_5709… : PS3, Line 121: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter> m_eumPrivateKey; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/ffcb7700_6fdf… : PS3, Line 121: std::unique_ptr<EVP_PKEY, EVP_PKEY_Deleter> m_eumPrivateKey; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/9880fe95_f0b5… : PS3, Line 122: std::vector<uint8_t> m_eumPublicKeyData; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/f2c947d3_ccd7… : PS3, Line 122: std::vector<uint8_t> m_eumPublicKeyData; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/feda9ee7_255b… : PS3, Line 122: std::vector<uint8_t> m_eumPublicKeyData; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/8886cae7_c8d3… : PS3, Line 124: std::string m_confirmationCode; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/005651bd_87a6… : PS3, Line 125: std::vector<uint8_t> m_confirmationCodeHash; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/4f2f18c9_4879… : PS3, Line 125: std::vector<uint8_t> m_confirmationCodeHash; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/f2112298_7cdd… : PS3, Line 125: std::vector<uint8_t> m_confirmationCodeHash; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/c6657606_104c… : PS3, Line 126: std::vector<uint8_t> m_transactionId; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/67b2b2e6_34a8… : PS3, Line 126: std::vector<uint8_t> m_transactionId; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/48284d9f_0f83… : PS3, Line 126: std::vector<uint8_t> m_transactionId; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/dce77933_28ac… : PS3, Line 127: std::string m_caCertPath; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/0971dc94_aab9… : PS3, Line 129: std::unique_ptr<HttpClient> m_httpClient; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/69a82c17_971e… : PS3, Line 129: std::unique_ptr<HttpClient> m_httpClient; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/cf705b9f_3e4e… : PS3, Line 129: std::unique_ptr<HttpClient> m_httpClient; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/a0136cd9_4f42… : PS3, Line 131: std::string m_customTlsCertPath; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/77f10ac2_6d6f… : PS3, Line 134: std::string m_clientCertPath; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/62e20b76_d467… : PS3, Line 135: std::string m_clientKeyPath; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/352e160d_18d3… : PS3, Line 140: public: labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/92377444_341f… : PS3, Line 141: static std::unique_ptr<X509, X509Deleter> loadCertFromDER(const std::vector<uint8_t>& derData); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/7fed68bd_3903… : PS3, Line 141: static std::unique_ptr<X509, X509Deleter> loadCertFromDER(const std::vector<uint8_t>& derData); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/e96116bd_3cf2… : PS3, Line 141: static std::unique_ptr<X509, X509Deleter> loadCertFromDER(const std::vector<uint8_t>& derData); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/fed40fd5_dfd2… : PS3, Line 141: static std::unique_ptr<X509, X509Deleter> loadCertFromDER(const std::vector<uint8_t>& derData); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/bac6f28d_a257… : PS3, Line 141: static std::unique_ptr<X509, X509Deleter> loadCertFromDER(const std::vector<uint8_t>& derData); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/f6f9f06e_eda1… : PS3, Line 141: static std::unique_ptr<X509, X509Deleter> loadCertFromDER(const std::vector<uint8_t>& derData); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/f17e0efc_9321… : PS3, Line 142: static std::vector<std::unique_ptr<X509, X509Deleter>> loadCertificateChain(const std::string& filename); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/080f8d16_530f… : PS3, Line 142: static std::vector<std::unique_ptr<X509, X509Deleter>> loadCertificateChain(const std::string& filename); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/eaa72a8b_4529… : PS3, Line 142: static std::vector<std::unique_ptr<X509, X509Deleter>> loadCertificateChain(const std::string& filename); need consistent spacing around '>>' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/7fba611b_4241… : PS3, Line 142: static std::vector<std::unique_ptr<X509, X509Deleter>> loadCertificateChain(const std::string& filename); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/32e40d10_a795… : PS3, Line 143: static std::vector<std::unique_ptr<X509, X509Deleter>> loadCertificatesFromDirectory(const std::string& directory, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/826ee265_2ec4… : PS3, Line 143: static std::vector<std::unique_ptr<X509, X509Deleter>> loadCertificatesFromDirectory(const std::string& directory, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/604fe729_b9fd… : PS3, Line 143: static std::vector<std::unique_ptr<X509, X509Deleter>> loadCertificatesFromDirectory(const std::string& directory, need consistent spacing around '>>' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/80408ae7_d016… : PS3, Line 143: static std::vector<std::unique_ptr<X509, X509Deleter>> loadCertificatesFromDirectory(const std::string& directory, need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/ae5513bf_ace2… : PS3, Line 144: const std::vector<std::string>& name_filters); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/85681c6c_7a5e… : PS3, Line 144: const std::vector<std::string>& name_filters); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/19dd4ae7_b5e8… : PS3, Line 144: const std::vector<std::string>& name_filters); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/82c20e06_e1da… : PS3, Line 144: const std::vector<std::string>& name_filters); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/02c05a69_ef42… : PS3, Line 145: static std::string getEID(X509* cert); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/a60ca77b_ff0d… : PS3, Line 146: static std::string getSubjectName(X509* cert); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/a8ef8372_e35b… : PS3, Line 147: static std::vector<uint8_t> getSubjectKeyIdentifier(X509* cert); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/52dfc6d6_59b1… : PS3, Line 147: static std::vector<uint8_t> getSubjectKeyIdentifier(X509* cert); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/39d656c8_e7a1… : PS3, Line 147: static std::vector<uint8_t> getSubjectKeyIdentifier(X509* cert); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/0338591f_d0fa… : PS3, Line 148: static std::vector<uint8_t> getAuthorityKeyIdentifier(X509* cert); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/17e8a06b_8a6f… : PS3, Line 148: static std::vector<uint8_t> getAuthorityKeyIdentifier(X509* cert); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/21194dbf_e05b… : PS3, Line 148: static std::vector<uint8_t> getAuthorityKeyIdentifier(X509* cert); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/445edac0_f9f2… : PS3, Line 149: static bool validateEIDRange(const std::string& eid, const std::vector<uint8_t>& eumCertData); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/4a1b865f_fa84… : PS3, Line 149: static bool validateEIDRange(const std::string& eid, const std::vector<uint8_t>& eumCertData); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/b3b3b04c_c7a6… : PS3, Line 149: static bool validateEIDRange(const std::string& eid, const std::vector<uint8_t>& eumCertData); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/754812b7_89fc… : PS3, Line 149: static bool validateEIDRange(const std::string& eid, const std::vector<uint8_t>& eumCertData); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/f549d921_ef9a… : PS3, Line 149: static bool validateEIDRange(const std::string& eid, const std::vector<uint8_t>& eumCertData); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/15b7a321_6522… : PS3, Line 150: static bool hasRSPRole(const std::vector<uint8_t>& certData, const std::string& roleOid); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/e9e89843_473d… : PS3, Line 150: static bool hasRSPRole(const std::vector<uint8_t>& certData, const std::string& roleOid); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/81202730_99e2… : PS3, Line 150: static bool hasRSPRole(const std::vector<uint8_t>& certData, const std::string& roleOid); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/913fd2d7_1856… : PS3, Line 150: static bool hasRSPRole(const std::vector<uint8_t>& certData, const std::string& roleOid); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/a6cd8158_ac0a… : PS3, Line 150: static bool hasRSPRole(const std::vector<uint8_t>& certData, const std::string& roleOid); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/98e9284c_6349… : PS3, Line 151: static std::string getPermittedEINs(const std::vector<uint8_t>& eumCertData); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/8674dd6d_8393… : PS3, Line 151: static std::string getPermittedEINs(const std::vector<uint8_t>& eumCertData); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/ed8cda0b_1f72… : PS3, Line 151: static std::string getPermittedEINs(const std::vector<uint8_t>& eumCertData); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/6ee32e92_268b… : PS3, Line 151: static std::string getPermittedEINs(const std::vector<uint8_t>& eumCertData); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/0fad15c8_941e… : PS3, Line 152: static bool verifyECDHCompatible(const std::vector<uint8_t>& pubKey1, const std::vector<uint8_t>& pubKey2); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/9200d119_fdcc… : PS3, Line 152: static bool verifyECDHCompatible(const std::vector<uint8_t>& pubKey1, const std::vector<uint8_t>& pubKey2); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/82f9fcc7_abc7… : PS3, Line 152: static bool verifyECDHCompatible(const std::vector<uint8_t>& pubKey1, const std::vector<uint8_t>& pubKey2); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/bcfda601_0487… : PS3, Line 152: static bool verifyECDHCompatible(const std::vector<uint8_t>& pubKey1, const std::vector<uint8_t>& pubKey2); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/b62b2078_9bc8… : PS3, Line 152: static bool verifyECDHCompatible(const std::vector<uint8_t>& pubKey1, const std::vector<uint8_t>& pubKey2); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/af8752c9_6867… : PS3, Line 152: static bool verifyECDHCompatible(const std::vector<uint8_t>& pubKey1, const std::vector<uint8_t>& pubKey2); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/c51ca2d0_6dd5… : PS3, Line 152: static bool verifyECDHCompatible(const std::vector<uint8_t>& pubKey1, const std::vector<uint8_t>& pubKey2); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/32f24db8_562c… : PS3, Line 152: static bool verifyECDHCompatible(const std::vector<uint8_t>& pubKey1, const std::vector<uint8_t>& pubKey2); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/d120efb3_5d1f… : PS3, Line 153: static std::string getCurveOID(const std::vector<uint8_t>& certData); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/983a35f1_39cc… : PS3, Line 153: static std::string getCurveOID(const std::vector<uint8_t>& certData); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/9a165419_cbcf… : PS3, Line 153: static std::string getCurveOID(const std::vector<uint8_t>& certData); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/87ab5b3b_7b5d… : PS3, Line 153: static std::string getCurveOID(const std::vector<uint8_t>& certData); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/571b44a7_965e… : PS3, Line 154: static bool verifyCertificateChainDynamic(X509* cert, const std::vector<X509*>& certPool, X509* rootCA, bool verbose); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/c9ae3b5a_1cca… : PS3, Line 154: static bool verifyCertificateChainDynamic(X509* cert, const std::vector<X509*>& certPool, X509* rootCA, bool verbose); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/ef11eec8_f386… : PS3, Line 154: static bool verifyCertificateChainDynamic(X509* cert, const std::vector<X509*>& certPool, X509* rootCA, bool verbose); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/ce069735_1dc9… : PS3, Line 154: static bool verifyCertificateChainDynamic(X509* cert, const std::vector<X509*>& certPool, X509* rootCA, bool verbose); spaces required around that '>' (ctx:OxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/543e6ebe_3bd9… : PS3, Line 154: static bool verifyCertificateChainDynamic(X509* cert, const std::vector<X509*>& certPool, X509* rootCA, bool verbose); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/26b8bd45_f55f… : PS3, Line 154: static bool verifyCertificateChainDynamic(X509* cert, const std::vector<X509*>& certPool, X509* rootCA, bool verbose); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122/comment/7caa9079_a1ac… : PS3, Line 159: #endif // RSP_CLIENT_H adding a line without newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41122?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9dcb3249fc712e2ddb2c7cf48d4fc54425848bc6 Gerrit-Change-Number: 41122 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Sep 2025 13:46:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 days, 1 hour

1
0
0 0

[XL] Change in osmo-ttcn3-hacks[master]: smdpp: es9p testsuite

by Hoernchen

Attention is currently required from: Hoernchen. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: smdpp: es9p testsuite ...................................................................... smdpp: es9p testsuite Certs are from https://www.gsma.com/solutions-and-impact/technologies/esim/wp-content/uplo… the invalid ones are generated using smdpp/generate_all_test_certificates.py Change-Id: I3ba163d9155a3b019214dbccc3c8031dfd7deb6b --- A smdpp/.clang-format A smdpp/InvalidTestCases/CERT_EUICC_ECDSA_NIST_EXPIRED.der A smdpp/InvalidTestCases/CERT_EUICC_ECDSA_NIST_INVALID.der A smdpp/InvalidTestCases/CERT_EUICC_ECDSA_NIST_INVALID_EID.der A smdpp/InvalidTestCases/CERT_EUICC_ECDSA_NIST_INVALID_EID.pem A smdpp/InvalidTestCases/CERT_EUICC_ECDSA_NIST_UNMATCHED_EID.der A smdpp/InvalidTestCases/CERT_EUICC_ECDSA_NIST_UNMATCHED_EID.pem A smdpp/InvalidTestCases/CERT_EUM_ECDSA_NIST_EXPIRED.der A smdpp/InvalidTestCases/CERT_EUM_ECDSA_NIST_INVALID.der A smdpp/InvalidTestCases/CERT_EUM_ECDSA_NIST_UNKNOWN_CI.der A smdpp/InvalidTestCases/CERT_UNKNOWN_CI_ECDSA_NIST.der A smdpp/bsp_crypto.cpp A smdpp/bsp_crypto.h A smdpp/gen_links.sh A smdpp/generate_all_test_certificates.py A smdpp/helpers.h A smdpp/logger.h A smdpp/package.yml A smdpp/regen_makefile.sh A smdpp/rsp_client.cpp A smdpp/sgp26/CertificateIssuer/CERT_CI_ECDSA_BRP.der A smdpp/sgp26/CertificateIssuer/CERT_CI_ECDSA_BRP.pem A smdpp/sgp26/CertificateIssuer/CERT_CI_ECDSA_NIST.der A smdpp/sgp26/CertificateIssuer/CERT_CI_ECDSA_NIST.pem A smdpp/sgp26/CertificateIssuer/CI-csr.cnf A smdpp/sgp26/CertificateIssuer/SK_CI_ECDSA_BRP.pem A smdpp/sgp26/CertificateIssuer/SK_CI_ECDSA_NIST.pem A smdpp/sgp26/DPauth/CERT_S_SM_DP2auth_ECDSA_BRP.der A smdpp/sgp26/DPauth/CERT_S_SM_DP2auth_ECDSA_NIST.der A smdpp/sgp26/DPauth/CERT_S_SM_DPauth_ECDSA_BRP.der A smdpp/sgp26/DPauth/CERT_S_SM_DPauth_ECDSA_NIST.der A smdpp/sgp26/DPauth/PK_S_SM_DP2auth_ECDSA_BRP.pem A smdpp/sgp26/DPauth/PK_S_SM_DP2auth_ECDSA_NIST.pem A smdpp/sgp26/DPauth/PK_S_SM_DPauth_ECDSA_BRP.pem A smdpp/sgp26/DPauth/PK_S_SM_DPauth_ECDSA_NIST.pem A smdpp/sgp26/DPauth/SK_S_SM_DP2auth_ECDSA_BRP.pem A smdpp/sgp26/DPauth/SK_S_SM_DP2auth_ECDSA_NIST.pem A smdpp/sgp26/DPauth/SK_S_SM_DPauth_ECDSA_BRP.pem A smdpp/sgp26/DPauth/SK_S_SM_DPauth_ECDSA_NIST.pem A smdpp/sgp26/DPpb/CERT_S_SM_DP2pb_ECDSA_BRP.der A smdpp/sgp26/DPpb/CERT_S_SM_DP2pb_ECDSA_NIST.der A smdpp/sgp26/DPpb/CERT_S_SM_DPpb_ECDSA_BRP.der A smdpp/sgp26/DPpb/CERT_S_SM_DPpb_ECDSA_NIST.der A smdpp/sgp26/DPpb/PK_S_SM_DP2pb_ECDSA_BRP.pem A smdpp/sgp26/DPpb/PK_S_SM_DP2pb_ECDSA_NIST.pem A smdpp/sgp26/DPpb/PK_S_SM_DPpb_ECDSA_BRP.pem A smdpp/sgp26/DPpb/PK_S_SM_DPpb_ECDSA_NIST.pem A smdpp/sgp26/DPpb/SK_S_SM_DP2pb_ECDSA_BRP.pem A smdpp/sgp26/DPpb/SK_S_SM_DP2pb_ECDSA_NIST.pem A smdpp/sgp26/DPpb/SK_S_SM_DPpb_ECDSA_BRP.pem A smdpp/sgp26/DPpb/SK_S_SM_DPpb_ECDSA_NIST.pem A smdpp/sgp26/DPtls/CERT_S_SM_DP2_TLS.csr.cnf A smdpp/sgp26/DPtls/CERT_S_SM_DP2_TLS.der A smdpp/sgp26/DPtls/CERT_S_SM_DP2_TLS.ext.cnf A smdpp/sgp26/DPtls/CERT_S_SM_DP4_TLS.csr.cnf A smdpp/sgp26/DPtls/CERT_S_SM_DP4_TLS.der A smdpp/sgp26/DPtls/CERT_S_SM_DP4_TLS.ext.cnf A smdpp/sgp26/DPtls/CERT_S_SM_DP8_TLS.csr.cnf A smdpp/sgp26/DPtls/CERT_S_SM_DP8_TLS.der A smdpp/sgp26/DPtls/CERT_S_SM_DP8_TLS.ext.cnf A smdpp/sgp26/DPtls/CERT_S_SM_DP_TLS.csr.cnf A smdpp/sgp26/DPtls/CERT_S_SM_DP_TLS.ext.cnf A smdpp/sgp26/DPtls/CERT_S_SM_DP_TLS_BRP.der A smdpp/sgp26/DPtls/CERT_S_SM_DP_TLS_NIST.der A smdpp/sgp26/DPtls/PK_S_SM_DP2_TLS_NIST.pem A smdpp/sgp26/DPtls/PK_S_SM_DP4_TLS.pem A smdpp/sgp26/DPtls/PK_S_SM_DP8_TLS.pem A smdpp/sgp26/DPtls/PK_S_SM_DP_TLS_BRP.pem A smdpp/sgp26/DPtls/PK_S_SM_DP_TLS_NIST.pem A smdpp/sgp26/DPtls/SK_S_SM_DP2_TLS_NIST.pem A smdpp/sgp26/DPtls/SK_S_SM_DP4_TLS.pem A smdpp/sgp26/DPtls/SK_S_SM_DP8_TLS.pem A smdpp/sgp26/DPtls/SK_S_SM_DP_TLS_BRP.pem A smdpp/sgp26/DPtls/SK_S_SM_DP_TLS_NIST.pem A smdpp/sgp26/EUM/CERT_EUM_ECDSA_BRP.der A smdpp/sgp26/EUM/CERT_EUM_ECDSA_NIST.der A smdpp/sgp26/EUM/EUM-csr.cnf A smdpp/sgp26/EUM/EUM-ext.cnf A smdpp/sgp26/EUM/PK_EUM_ECDSA_BRP.pem A smdpp/sgp26/EUM/PK_EUM_ECDSA_NIST.pem A smdpp/sgp26/EUM/SK_EUM_ECDSA_BRP.pem A smdpp/sgp26/EUM/SK_EUM_ECDSA_NIST.pem A smdpp/sgp26/eUICC/CERT_EUICC_ECDSA_BRP.der A smdpp/sgp26/eUICC/CERT_EUICC_ECDSA_NIST.der A smdpp/sgp26/eUICC/PK_EUICC_ECDSA_BRP.pem A smdpp/sgp26/eUICC/PK_EUICC_ECDSA_NIST.pem A smdpp/sgp26/eUICC/SK_EUICC_ECDSA_BRP.pem A smdpp/sgp26/eUICC/SK_EUICC_ECDSA_NIST.pem A smdpp/sgp26/eUICC/eUICC-csr.cnf A smdpp/sgp26/eUICC/eUICC-ext.cnf A smdpp/smdpp_Tests.cfg A smdpp/smdpp_Tests.default A smdpp/smdpp_Tests.ttcn A smdpp/smdpp_Tests_Functions.cc 94 files changed, 10,892 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/19/41119/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3ba163d9155a3b019214dbccc3c8031dfd7deb6b Gerrit-Change-Number: 41119 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>

4 days, 1 hour

1
0
0 0

[XL] Change in osmo-ttcn3-hacks[master]: smdpp: es9p testsuite

by Hoernchen

Attention is currently required from: Hoernchen. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: smdpp: es9p testsuite ...................................................................... smdpp: es9p testsuite Certs are from https://www.gsma.com/solutions-and-impact/technologies/esim/wp-content/uplo… the invalid ones are generated using smdpp/generate_all_test_certificates.py Change-Id: I3ba163d9155a3b019214dbccc3c8031dfd7deb6b --- A smdpp/.clang-format A smdpp/InvalidTestCases/CERT_EUICC_ECDSA_NIST_EXPIRED.der A smdpp/InvalidTestCases/CERT_EUICC_ECDSA_NIST_INVALID.der A smdpp/InvalidTestCases/CERT_EUICC_ECDSA_NIST_INVALID_EID.der A smdpp/InvalidTestCases/CERT_EUICC_ECDSA_NIST_INVALID_EID.pem A smdpp/InvalidTestCases/CERT_EUICC_ECDSA_NIST_UNMATCHED_EID.der A smdpp/InvalidTestCases/CERT_EUICC_ECDSA_NIST_UNMATCHED_EID.pem A smdpp/InvalidTestCases/CERT_EUM_ECDSA_NIST_EXPIRED.der A smdpp/InvalidTestCases/CERT_EUM_ECDSA_NIST_INVALID.der A smdpp/InvalidTestCases/CERT_EUM_ECDSA_NIST_UNKNOWN_CI.der A smdpp/InvalidTestCases/CERT_UNKNOWN_CI_ECDSA_NIST.der A smdpp/bsp_crypto.cpp A smdpp/bsp_crypto.h A smdpp/gen_links.sh A smdpp/generate_all_test_certificates.py A smdpp/helpers.h A smdpp/logger.h A smdpp/package.yml A smdpp/regen_makefile.sh A smdpp/rsp_client.cpp A smdpp/sgp26/CertificateIssuer/CERT_CI_ECDSA_BRP.der A smdpp/sgp26/CertificateIssuer/CERT_CI_ECDSA_BRP.pem A smdpp/sgp26/CertificateIssuer/CERT_CI_ECDSA_NIST.der A smdpp/sgp26/CertificateIssuer/CERT_CI_ECDSA_NIST.pem A smdpp/sgp26/CertificateIssuer/CI-csr.cnf A smdpp/sgp26/CertificateIssuer/SK_CI_ECDSA_BRP.pem A smdpp/sgp26/CertificateIssuer/SK_CI_ECDSA_NIST.pem A smdpp/sgp26/DPauth/CERT_S_SM_DP2auth_ECDSA_BRP.der A smdpp/sgp26/DPauth/CERT_S_SM_DP2auth_ECDSA_NIST.der A smdpp/sgp26/DPauth/CERT_S_SM_DPauth_ECDSA_BRP.der A smdpp/sgp26/DPauth/CERT_S_SM_DPauth_ECDSA_NIST.der A smdpp/sgp26/DPauth/PK_S_SM_DP2auth_ECDSA_BRP.pem A smdpp/sgp26/DPauth/PK_S_SM_DP2auth_ECDSA_NIST.pem A smdpp/sgp26/DPauth/PK_S_SM_DPauth_ECDSA_BRP.pem A smdpp/sgp26/DPauth/PK_S_SM_DPauth_ECDSA_NIST.pem A smdpp/sgp26/DPauth/SK_S_SM_DP2auth_ECDSA_BRP.pem A smdpp/sgp26/DPauth/SK_S_SM_DP2auth_ECDSA_NIST.pem A smdpp/sgp26/DPauth/SK_S_SM_DPauth_ECDSA_BRP.pem A smdpp/sgp26/DPauth/SK_S_SM_DPauth_ECDSA_NIST.pem A smdpp/sgp26/DPpb/CERT_S_SM_DP2pb_ECDSA_BRP.der A smdpp/sgp26/DPpb/CERT_S_SM_DP2pb_ECDSA_NIST.der A smdpp/sgp26/DPpb/CERT_S_SM_DPpb_ECDSA_BRP.der A smdpp/sgp26/DPpb/CERT_S_SM_DPpb_ECDSA_NIST.der A smdpp/sgp26/DPpb/PK_S_SM_DP2pb_ECDSA_BRP.pem A smdpp/sgp26/DPpb/PK_S_SM_DP2pb_ECDSA_NIST.pem A smdpp/sgp26/DPpb/PK_S_SM_DPpb_ECDSA_BRP.pem A smdpp/sgp26/DPpb/PK_S_SM_DPpb_ECDSA_NIST.pem A smdpp/sgp26/DPpb/SK_S_SM_DP2pb_ECDSA_BRP.pem A smdpp/sgp26/DPpb/SK_S_SM_DP2pb_ECDSA_NIST.pem A smdpp/sgp26/DPpb/SK_S_SM_DPpb_ECDSA_BRP.pem A smdpp/sgp26/DPpb/SK_S_SM_DPpb_ECDSA_NIST.pem A smdpp/sgp26/DPtls/CERT_S_SM_DP2_TLS.csr.cnf A smdpp/sgp26/DPtls/CERT_S_SM_DP2_TLS.der A smdpp/sgp26/DPtls/CERT_S_SM_DP2_TLS.ext.cnf A smdpp/sgp26/DPtls/CERT_S_SM_DP4_TLS.csr.cnf A smdpp/sgp26/DPtls/CERT_S_SM_DP4_TLS.der A smdpp/sgp26/DPtls/CERT_S_SM_DP4_TLS.ext.cnf A smdpp/sgp26/DPtls/CERT_S_SM_DP8_TLS.csr.cnf A smdpp/sgp26/DPtls/CERT_S_SM_DP8_TLS.der A smdpp/sgp26/DPtls/CERT_S_SM_DP8_TLS.ext.cnf A smdpp/sgp26/DPtls/CERT_S_SM_DP_TLS.csr.cnf A smdpp/sgp26/DPtls/CERT_S_SM_DP_TLS.ext.cnf A smdpp/sgp26/DPtls/CERT_S_SM_DP_TLS_BRP.der A smdpp/sgp26/DPtls/CERT_S_SM_DP_TLS_NIST.der A smdpp/sgp26/DPtls/PK_S_SM_DP2_TLS_NIST.pem A smdpp/sgp26/DPtls/PK_S_SM_DP4_TLS.pem A smdpp/sgp26/DPtls/PK_S_SM_DP8_TLS.pem A smdpp/sgp26/DPtls/PK_S_SM_DP_TLS_BRP.pem A smdpp/sgp26/DPtls/PK_S_SM_DP_TLS_NIST.pem A smdpp/sgp26/DPtls/SK_S_SM_DP2_TLS_NIST.pem A smdpp/sgp26/DPtls/SK_S_SM_DP4_TLS.pem A smdpp/sgp26/DPtls/SK_S_SM_DP8_TLS.pem A smdpp/sgp26/DPtls/SK_S_SM_DP_TLS_BRP.pem A smdpp/sgp26/DPtls/SK_S_SM_DP_TLS_NIST.pem A smdpp/sgp26/EUM/CERT_EUM_ECDSA_BRP.der A smdpp/sgp26/EUM/CERT_EUM_ECDSA_NIST.der A smdpp/sgp26/EUM/EUM-csr.cnf A smdpp/sgp26/EUM/EUM-ext.cnf A smdpp/sgp26/EUM/PK_EUM_ECDSA_BRP.pem A smdpp/sgp26/EUM/PK_EUM_ECDSA_NIST.pem A smdpp/sgp26/EUM/SK_EUM_ECDSA_BRP.pem A smdpp/sgp26/EUM/SK_EUM_ECDSA_NIST.pem A smdpp/sgp26/eUICC/CERT_EUICC_ECDSA_BRP.der A smdpp/sgp26/eUICC/CERT_EUICC_ECDSA_NIST.der A smdpp/sgp26/eUICC/PK_EUICC_ECDSA_BRP.pem A smdpp/sgp26/eUICC/PK_EUICC_ECDSA_NIST.pem A smdpp/sgp26/eUICC/SK_EUICC_ECDSA_BRP.pem A smdpp/sgp26/eUICC/SK_EUICC_ECDSA_NIST.pem A smdpp/sgp26/eUICC/eUICC-csr.cnf A smdpp/sgp26/eUICC/eUICC-ext.cnf A smdpp/smdpp_Tests.cfg A smdpp/smdpp_Tests.default A smdpp/smdpp_Tests.ttcn A smdpp/smdpp_Tests_Functions.cc 94 files changed, 10,874 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/19/41119/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3ba163d9155a3b019214dbccc3c8031dfd7deb6b Gerrit-Change-Number: 41119 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>

4 days, 2 hours

1
0
0 0

[S] Change in osmo-msc[master]: tests/{ctrl,vty}_test_runner.py: dump stdout/stderr

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-msc/+/41127?usp=email ) Change subject: tests/{ctrl,vty}_test_runner.py: dump stdout/stderr ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41127?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie6a2f5b1bc56d35513643b52923403798e5a0a5a Gerrit-Change-Number: 41127 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Sep 2025 13:38:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 days, 2 hours

1
0
0 0

[S] Change in osmo-msc[master]: tests/{ctrl,vty}_test_runner.py: dump stdout/stderr

by fixeria

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/41127?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: tests/{ctrl,vty}_test_runner.py: dump stdout/stderr ...................................................................... tests/{ctrl,vty}_test_runner.py: dump stdout/stderr From time to time, we're seeing the following error in Jenkins: ---------------------------------------------------------------------- Traceback (most recent call last): File ".../tests/vty_test_runner.py", line 70, in tearDown raise Exception("Process returned %d" % rc) Exception: Process returned -9 ---------------------------------------------------------------------- Let's dump stdout/stderr of the process to get more information. Change-Id: Ie6a2f5b1bc56d35513643b52923403798e5a0a5a Related: OS#5665 --- M tests/ctrl_test_runner.py M tests/vty_test_runner.py 2 files changed, 37 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/27/41127/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41127?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie6a2f5b1bc56d35513643b52923403798e5a0a5a Gerrit-Change-Number: 41127 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

4 days, 2 hours

1
0
0 0

[S] Change in osmo-msc[master]: tests/{ctrl,vty}_test_runner.py: dump stdout/stderr

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-msc/+/41127?usp=email ) Change subject: tests/{ctrl,vty}_test_runner.py: dump stdout/stderr ...................................................................... Patch Set 1: (1 comment) File tests/ctrl_test_runner.py: https://gerrit.osmocom.org/c/osmo-msc/+/41127/comment/bc65f89f_9d05f7bf?usp… : PS1, Line 54: self.stdout = tempfile.TemporaryFile() > Does that mean now we create a temporary file each time a test is run which is never destroyed autom […] No. These files will be destroyed as soon as they're closed, see: https://docs.python.org/3/library/tempfile.html -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41127?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie6a2f5b1bc56d35513643b52923403798e5a0a5a Gerrit-Change-Number: 41127 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Sep 2025 12:54:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

4 days, 2 hours

1
0
0 0

[S] Change in osmo-msc[master]: tests/{ctrl,vty}_test_runner.py: dump stdout/stderr

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-msc/+/41127?usp=email ) Change subject: tests/{ctrl,vty}_test_runner.py: dump stdout/stderr ...................................................................... Patch Set 1: (1 comment) File tests/ctrl_test_runner.py: https://gerrit.osmocom.org/c/osmo-msc/+/41127/comment/eb36b838_e57924d0?usp… : PS1, Line 54: self.stdout = tempfile.TemporaryFile() Does that mean now we create a temporary file each time a test is run which is never destroyed automatically? This will end up with tons of files being created in tmpfs? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41127?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie6a2f5b1bc56d35513643b52923403798e5a0a5a Gerrit-Change-Number: 41127 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Sep 2025 12:44:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 days, 2 hours

1
0
0 0

[S] Change in osmo-msc[master]: tests/{ctrl,vty}_test_runner.py: dump stdout/stderr

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/41127?usp=email ) Change subject: tests/{ctrl,vty}_test_runner.py: dump stdout/stderr ...................................................................... tests/{ctrl,vty}_test_runner.py: dump stdout/stderr From time to time, we're seeing the following error in Jenkins: ---------------------------------------------------------------------- Traceback (most recent call last): File ".../tests/vty_test_runner.py", line 70, in tearDown raise Exception("Process returned %d" % rc) Exception: Process returned -9 ---------------------------------------------------------------------- Let's dump stdout/stderr of the process to get more information. Change-Id: Ie6a2f5b1bc56d35513643b52923403798e5a0a5a Related: OS#5665 --- M tests/ctrl_test_runner.py M tests/vty_test_runner.py 2 files changed, 36 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/27/41127/1 diff --git a/tests/ctrl_test_runner.py b/tests/ctrl_test_runner.py index 16d1e7c..1042df5 100755 --- a/tests/ctrl_test_runner.py +++ b/tests/ctrl_test_runner.py @@ -26,6 +26,7 @@ import socket import sys import struct +import tempfile import osmopy.obscvty as obscvty import osmopy.osmoutil as osmoutil @@ -50,8 +51,12 @@ cfi = config_index + 1 osmo_ctrl_cmd[cfi] = os.path.join(confpath, osmo_ctrl_cmd[cfi]) + self.stdout = tempfile.TemporaryFile() + self.stderr = tempfile.TemporaryFile() try: - self.proc = osmoutil.popen_devnull(osmo_ctrl_cmd) + # self.proc = osmoutil.popen_devnull(osmo_vty_cmd) + print("Launching: PWD=%s %s" % (os.getcwd(), ' '.join([repr(c) for c in osmo_vty_cmd]))) + self.proc = subprocess.Popen(osmo_vty_cmd, stdout=self.stdout, stderr=self.stderr) except OSError: print("Current directory: %s" % os.getcwd(), file=sys.stderr) print("Consider setting -b", file=sys.stderr) @@ -62,11 +67,23 @@ self.connect("127.0.0.1", appport) self.next_id = 1000 + def dump_file(self, file, name): + file.seek(0) + data = file.read() + print('=' * 80) + print(name) + print('=' * 80) + print(data.decode()) + def tearDown(self): self.disconnect() rc = osmoutil.end_proc(self.proc) if rc is not None and rc != 0: + self.dump_file(self.stdout, 'stdout') + self.dump_file(self.stderr, 'stderr') raise Exception("Process returned %d" % rc) + self.stdout.close() + self.stderr.close() def disconnect(self): if not (self.sock is None): diff --git a/tests/vty_test_runner.py b/tests/vty_test_runner.py index 2dfa155..571080e 100755 --- a/tests/vty_test_runner.py +++ b/tests/vty_test_runner.py @@ -20,6 +20,7 @@ import unittest import socket import subprocess +import tempfile import osmopy.obscvty as obscvty import osmopy.osmoutil as osmoutil @@ -51,8 +52,12 @@ cfi = config_index + 1 osmo_vty_cmd[cfi] = os.path.join(confpath, osmo_vty_cmd[cfi]) + self.stdout = tempfile.TemporaryFile() + self.stderr = tempfile.TemporaryFile() try: - self.proc = osmoutil.popen_devnull(osmo_vty_cmd) + # self.proc = osmoutil.popen_devnull(osmo_vty_cmd) + print("Launching: PWD=%s %s" % (os.getcwd(), ' '.join([repr(c) for c in osmo_vty_cmd]))) + self.proc = subprocess.Popen(osmo_vty_cmd, stdout=self.stdout, stderr=self.stderr) except OSError: print("Current directory: %s" % os.getcwd(), file=sys.stderr) print("Consider setting -b", file=sys.stderr) @@ -61,13 +66,25 @@ appport = self.vty_app()[0] self.vty = obscvty.VTYInteract(appstring, "127.0.0.1", appport) + def dump_file(self, file, name): + file.seek(0) + data = file.read() + print('=' * 80) + print(name) + print('=' * 80) + print(data.decode()) + def tearDown(self): if self.vty: self.vty._close_socket() self.vty = None rc = osmoutil.end_proc(self.proc) if rc is not None and rc != 0: + self.dump_file(self.stdout, 'stdout') + self.dump_file(self.stderr, 'stderr') raise Exception("Process returned %d" % rc) + self.stdout.close() + self.stderr.close() class TestVTYMSC(TestVTYBase): -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41127?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie6a2f5b1bc56d35513643b52923403798e5a0a5a Gerrit-Change-Number: 41127 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

4 days, 2 hours

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: tcap: Add initial templates

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41123?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: tcap: Add initial templates ...................................................................... tcap: Add initial templates Change-Id: Ibc471733554c75b7c494b2bd4126232dd8c0553c --- A library/tcap/TCAP_Templates.ttcn 1 file changed, 53 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/tcap/TCAP_Templates.ttcn b/library/tcap/TCAP_Templates.ttcn new file mode 100644 index 0000000..92f4bb9 --- /dev/null +++ b/library/tcap/TCAP_Templates.ttcn @@ -0,0 +1,53 @@ +module TCAP_Templates { + +import from General_Types all; +import from Misc_Helpers all; +import from Native_Functions all; + +import from TCAPMessages language "ASN.1:1997" all; +import from TCAP_Types all; + + +template (value) TCMessage +ts_TCAP_Begin(template (value) OCT4 otid) := { + begin := { + otid := otid, + dialoguePortion := omit, + components := omit + } +} + +template (value) TCMessage +ts_TCAP_Continue(template (value) OCT4 otid, + template (value) OCT4 dtid) := { + continue_ := { + otid := otid, + dtid := dtid, + dialoguePortion := omit, + components := omit + } +} + +template (value) TCMessage +ts_TCAP_End(template (value) OCT4 dtid) := { + end := { + dtid := dtid, + dialoguePortion := omit, + components := omit + } +} + +template (value) TCMessage +ts_TCAP_Abort(template (value) OCT4 dtid, template (omit) Reason reason := omit) := { + abort := { + dtid := dtid, + reason := reason + } +} + +template (value) Reason +ts_TCAP_Reason_p_AbortCause(template (value) P_AbortCause p_abortCause := 0 /*unrecognizedMessageType*/) := { + p_abortCause := p_abortCause +} + +} -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41123?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibc471733554c75b7c494b2bd4126232dd8c0553c Gerrit-Change-Number: 41123 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 days, 3 hours

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: Introduce TCAP asn enc/dec

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41118?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: Introduce TCAP asn enc/dec ...................................................................... Introduce TCAP asn enc/dec ASN.1 files obtained from libosmo-asn1-tcap.git a92fd1a6206832b626aa2a5c841b890ca37e4bd0. Related: SYS#5423 Change-Id: Iae7f92cde02e5da966966bc95f9b74feec51958d --- A library/tcap/TCAPMessages.asn A library/tcap/TCAP_CodecPort.ttcn A library/tcap/TCAP_DialoguePDUs.asn A library/tcap/TCAP_EncDec.cc A library/tcap/TCAP_Types.ttcn A library/tcap/TCAP_UnidialoguePDUs.asn A library/tcap/regen_makefile.sh 7 files changed, 789 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved daniel: Looks good to me, but someone else must approve diff --git a/library/tcap/TCAPMessages.asn b/library/tcap/TCAPMessages.asn new file mode 100644 index 0000000..84a3532 --- /dev/null +++ b/library/tcap/TCAPMessages.asn @@ -0,0 +1,247 @@ +-- $Id: tcap.asn 26192 2008-09-14 14:42:39Z etxrab $ +TCAPMessages {itu-t recommendation q 773 modules(2) messages(1) version3(3)} + +DEFINITIONS ::= + +BEGIN + +--EXPORTS OPERATION, ERROR, Component, InvokeId Type; +-- WS stuff +ExternalPDU ::= [APPLICATION 8] IMPLICIT SEQUENCE + { + oid OBJECT IDENTIFIER, + dialog [0] IMPLICIT Dialog1 + } + + +Dialog1 ::= OCTET STRING +-- End WS +-- Transaction Portion fields + +TCMessage ::= CHOICE { + unidirectional [APPLICATION 1] IMPLICIT Unidirectional, + begin [APPLICATION 2] IMPLICIT Begin, + end [APPLICATION 4] IMPLICIT End, + continue [APPLICATION 5] IMPLICIT Continue, + abort [APPLICATION 7] IMPLICIT Abort +} + +Unidirectional ::= SEQUENCE{ + dialoguePortion DialoguePortion OPTIONAL, + components ComponentPortion + } + +Begin ::= SEQUENCE{ + otid OrigTransactionID, + dialoguePortion DialoguePortion OPTIONAL, + components ComponentPortion OPTIONAL + } + +End ::= SEQUENCE{ + dtid DestTransactionID, + dialoguePortion DialoguePortion OPTIONAL, + components ComponentPortion OPTIONAL + } + + +Continue ::= SEQUENCE { + otid OrigTransactionID, + dtid DestTransactionID, + dialoguePortion DialoguePortion OPTIONAL, + components ComponentPortion OPTIONAL + } + +Abort ::= SEQUENCE{ + dtid DestTransactionID, + reason Reason OPTIONAL + } + +Reason ::= CHOICE{ + p-abortCause P-AbortCause, + u-abortCause DialoguePortion + } + +-- NOTE - When the Abort Message is generated by the Transaction sublayer, a p-Abort Cause may be +-- present. The u-abortCause may be generated by the component sublayer in which case it is an ABRT +-- APDU, or by the TC-User in which case it could be either an ABRT APDU or data in some user-defined +-- abstract syntax. + +DialoguePortion ::= [APPLICATION 11] EXPLICIT EXTERNAL + +-- WS adaptation +--DialoguePortion ::= [APPLICATION 11] IMPLICIT DialogueOC +--DialogueOC ::= OCTET STRING + +-- The dialogue portion carries the dialogue control PDUs as value of the external data type. +-- The direct reference should be set to { ccitt recommendation q 773 as (1) dialogue-as (1) version (1) } +-- if structured dialogue is used and to { ccitt recommendation q 773 as (1) unidialogue-as (2) version (1) } +-- if unstructured dialogue is used or any user defined abstract syntax name when only user information +-- is carried (e.g. when user information is sent in a 1988 Abort message). + +OrigTransactionID ::= [APPLICATION 8] IMPLICIT OCTET STRING (SIZE (1..4) ) + +DestTransactionID ::=[APPLICATION 9] IMPLICIT OCTET STRING (SIZE (1..4) ) + +P-AbortCause ::= [APPLICATION 10] IMPLICIT INTEGER { + unrecognizedMessageType (0), + unrecognizedTransactionID (1), + badlyFormattedTransactionPortion (2), + incorrectTransactionPortion (3), + resourceLimitation (4)}(0..127) + +-- COMPONENT PORTION. The last field in the transaction portion of the TCAP message is the Component Portion. +-- The Component Portion may be absent. + +ComponentPortion ::= [APPLICATION 12] IMPLICIT SEQUENCE SIZE (1..MAX) OF Component + +-- Component Portion fields +-- Recommendation X.880 defines four Application Protocol Data Units (APDUs) for invoking +-- operations, returning results or error, and for the rejection of invalid PDUs. +-- TCAP adds returnResultNotLast to allow for the segmentation of a result. + +Component ::= CHOICE { + invoke [1] IMPLICIT Invoke, + returnResultLast [2] IMPLICIT ReturnResult, + returnError [3] IMPLICIT ReturnError, + reject [4] IMPLICIT Reject, + returnResultNotLast [7] IMPLICIT ReturnResult + } + +-- The Components are sequences of data elements. + +Invoke ::= SEQUENCE { + invokeID InvokeIdType, + linkedID [0] IMPLICIT InvokeIdType OPTIONAL, + opCode OPERATION, + parameter Parameter OPTIONAL } + +Parameter ::= ANY + +-- ANY is filled by the single ASN.1 data type following the keyword PARAMETER or the keyword ARGUMENT +-- in the type definition of a particular operation. + +ReturnResult ::= SEQUENCE { + invokeID InvokeIdType, + resultretres SEQUENCE { + opCode OPERATION, + parameter Parameter OPTIONAL + } OPTIONAL + } + +-- ANY is filled by the single ASN.1 data type following the keyword RESULT in the type definition +-- of a particular operation. + +ReturnError ::= SEQUENCE { + invokeID InvokeIdType, + errorCode ErrorCode, + parameter Parameter OPTIONAL } + +-- ANY is filled by the single ASN.1 data type following the keyword PARAMETER in the type definition +-- of a particular error. + +Reject ::= SEQUENCE { + invokeIDRej CHOICE { + derivable InvokeIdType, + not-derivable NULL }, + problem CHOICE { + generalProblem [0] IMPLICIT GeneralProblem, + invokeProblem [1] IMPLICIT InvokeProblem, + returnResultProblem [2] IMPLICIT ReturnResultProblem, + returnErrorProblem [3] IMPLICIT ReturnErrorProblem } } + +InvokeIdType ::= INTEGER (-128..127) + + +OPERATION ::= CHOICE { + localValue INTEGER, + globalValue OBJECT IDENTIFIER } + +ERROR ::= CHOICE { + localValue INTEGER, + globalValue OBJECT IDENTIFIER } + +-- OPERATIONS + +-- Operations are specified with the OPERATION MACRO. +-- When an operation is specified, the valid parameter set, results, and errors for that operation are indicated. +-- Default values and optional parameters are permitted. + +--OPERATION MACRO ::= + +--BEGIN +-- TYPE NOTATION ::= Parameter Result Errors LinkedOperations +-- VALUE NOTATION ::= value (VALUE CHOICE { +-- localValue INTEGER, +-- globalValue OBJECT IDENTIFIER } ) +-- Parameter ::= ArgKeyword NamedType | empty +-- ArgKeyword ::= "ARGUMENT" | "PARAMETER" +-- Result ::= "RESULT" ResultType | empty +-- Errors ::= "ERRORS" "{"ErrorNames"}" | empty +-- LinkedOperations ::= "LINKED" "{"LinkedOperationNames"}" | empty +-- ResultType ::= NamedType | empty +-- ErrorNames ::= ErrorList | empty +-- ErrorList ::= Error | ErrorList "," Error +-- Error ::= value (ERROR) + -- shall reference an error value + --| type shall reference an error type + -- if no error value is specified + +-- LinkedOperationNames ::= OperationList | empty +-- OperationList ::= Operation | OperationList "," Operation +-- Operation ::= value (OPERATION) + -- shall reference an operation value +-- | type shall reference an operation type if + -- no operation value is specified +-- NamedType ::= identifier type | type +--END + +-- ERRORS + +-- Errors are specified with the ERROR MACRO. +-- When an error is specified, the valid parameters for that error are indicated. +-- Default values and optional parameters are permitted. + +--ERROR MACRO ::= +-- +--BEGIN +-- TYPE NOTATION ::= Parameter +-- VALUE NOTATION ::= value (VALUE CHOICE { +-- localValue INTEGER, +-- globalValue OBJECT IDENTIFIER } ) +-- Parameter ::= "PARAMETER" NamedType | empty +-- NamedType ::= identifier type | type +--END + +-- PROBLEMS + +GeneralProblem ::= INTEGER { unrecognizedComponent (0), + mistypedComponent (1), + badlyStructuredComponent (2) } + +InvokeProblem ::= INTEGER { duplicateInvokeID (0), + unrecognizedOperation (1), + mistypedParameter (2), + resourceLimitation (3), + initiatingRelease (4), + unrecognizedLinkedID (5), + linkedResponseUnexpected (6), + unexpectedLinkedOperation (7) } + +ReturnResultProblem ::= INTEGER { unrecognizedInvokeID (0), + returnResultUnexpected (1), + mistypedParameter (2) } + +ReturnErrorProblem ::= INTEGER { unrecognizedInvokeID (0), + returnErrorUnexpected (1), + unrecognizedError (2), + unexpectedError (3), + mistypedParameter (4) } + + +ErrorCode ::= CHOICE + { + nationaler [PRIVATE 19] IMPLICIT INTEGER (-32768..32767), + privateer [PRIVATE 20] IMPLICIT INTEGER + } + +END -- end of the TCAP Package Module diff --git a/library/tcap/TCAP_CodecPort.ttcn b/library/tcap/TCAP_CodecPort.ttcn new file mode 100644 index 0000000..50b0eed --- /dev/null +++ b/library/tcap/TCAP_CodecPort.ttcn @@ -0,0 +1,394 @@ +module TCAP_CodecPort { + +/* Simple TCAP Codec Port, translating between raw SCCP primitives with + * octetstring payload towards the SCCP provider, and TCAP-SCCP primitives + * which carry the decoded TCAP data types as payload. + * + * (C) 2025 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de> + * All rights reserved. + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + */ + +import from General_Types all; +import from Osmocom_Types all; + +import from SCCPasp_Types all; +import from SCCP_Types all; + +import from TCAPMessages language "ASN.1:1997" all; +import from TCAP_Types all; + +type record TCAP_N_CONNECT_req +{ + SCCP_PAR_Address calledAddress, + SCCP_PAR_Address callingAddress optional, + SCCP_PAR_Expedited_Data_Sel expeditedDataSel optional, + SCCP_PAR_Quality_Of_Service qualityOfService optional, + TCMessage userData optional, + SCCP_PAR_Connection_Id connectionId optional, + SCCP_PAR_Importance importance optional +} + +template (value) TCAP_N_CONNECT_req ts_TCAP_CONNECT_req(SCCP_PAR_Address called, + SCCP_PAR_Address calling, + SCCP_PAR_Connection_Id conn_id, + template (omit) TCMessage ranap := omit) := { + calledAddress := called, + callingAddress := calling, + expeditedDataSel := omit, + qualityOfService := omit, + userData := ranap, + connectionId := conn_id, + importance := omit +} + +type record TCAP_N_CONNECT_ind +{ + SCCP_PAR_Address calledAddress, + SCCP_PAR_Address callingAddress optional, + SCCP_PAR_Quality_Of_Service qualityOfService optional, + TCMessage userData optional, + SCCP_PAR_Connection_Id connectionId optional, + SCCP_PAR_Importance importance optional +} + +template (present) TCAP_N_CONNECT_ind tr_TCAP_CONNECT_ind(template SCCP_PAR_Address called, + template SCCP_PAR_Address calling, + template TCMessage payload := *) := { + calledAddress := called, + callingAddress := calling, + qualityOfService := *, + userData := payload, + connectionId := *, + importance := * +} + +type record TCAP_N_CONNECT_res +{ + SCCP_PAR_Address respondingAddress optional, + SCCP_PAR_Expedited_Data_Sel expeditedDataSel optional, + SCCP_PAR_Quality_Of_Service qualityOfService optional, + TCMessage userData optional, + SCCP_PAR_Connection_Id connectionId optional, + SCCP_PAR_Importance importance optional +} + +template (value) TCAP_N_CONNECT_res ts_TCAP_CONNECT_res(SCCP_PAR_Connection_Id conn_id, + template (omit) TCMessage ranap := omit) := { + respondingAddress := omit, + expeditedDataSel := omit, + qualityOfService := omit, + userData := ranap, + connectionId := conn_id, + importance := omit +} + +type record TCAP_N_CONNECT_cfm +{ + SCCP_PAR_Address respondingAddress optional, + SCCP_PAR_Quality_Of_Service qualityOfService optional, + TCMessage userData optional, + SCCP_PAR_Connection_Id connectionId optional, + SCCP_PAR_Importance importance optional +} + +template (present) TCAP_N_CONNECT_cfm tr_TCAP_CONNECT_cfm(template SCCP_PAR_Connection_Id conn_id, + template TCMessage ranap := *) := { + respondingAddress := *, + qualityOfService := *, + userData := ranap, + connectionId := conn_id, + importance := * +} + +type record TCAP_N_DATA_req +{ + TCMessage userData , + SCCP_PAR_Connection_Id connectionId optional , + SCCP_PAR_Importance importance optional +} + +template (value) TCAP_N_DATA_req ts_TCAP_DATA_req(SCCP_PAR_Connection_Id conn_id, + template (value) TCMessage ranap) := { + userData := ranap, + connectionId := conn_id, + importance := omit +} + + +type record TCAP_N_DATA_ind +{ + TCMessage userData , + SCCP_PAR_Connection_Id connectionId optional , + SCCP_PAR_Importance importance optional +} + +template (present) TCAP_N_DATA_ind tr_TCAP_DATA_ind(SCCP_PAR_Connection_Id conn_id, + template TCMessage ranap := *) := { + userData := ranap, + connectionId := conn_id, + importance := * +} + + +type record TCAP_N_DISCONNECT_req +{ + SCCP_PAR_Address respondingAddress optional, + SCCP_PAR_Reason reason , + TCMessage userData optional , + SCCP_PAR_Connection_Id connectionId optional , + SCCP_PAR_Importance importance optional +} + +template (value) TCAP_N_DISCONNECT_req ts_TCAP_DISC_req(SCCP_PAR_Connection_Id conn_id, + template (value) SCCP_PAR_Reason reason, + template (omit) TCMessage ranap := omit) := { + respondingAddress := omit, + reason := reason, + userData := ranap, + connectionId := conn_id, + importance := omit +} + + +type record TCAP_N_DISCONNECT_ind +{ + SCCP_PAR_Originator originator , + SCCP_PAR_Address respondingAddress optional , + SCCP_PAR_Reason reason , + TCMessage userData optional , + SCCP_PAR_Connection_Id connectionId optional , + SCCP_PAR_Importance importance optional +} + +template (present) TCAP_N_DISCONNECT_ind tr_TCAP_DISC_ind(template (present) SCCP_PAR_Connection_Id conn_id, + template (present) SCCP_PAR_Originator originator, + template (present) SCCP_PAR_Reason reason, + template TCMessage ranap := *) := { + originator := originator, + respondingAddress:= *, + reason := reason, + userData := ranap, + connectionId := conn_id, + importance := * +} + +type record TCAP_N_UNITDATA_req +{ + SCCP_PAR_Address calledAddress , + SCCP_PAR_Address callingAddress , + SCCP_PAR_Sequence_Control sequenceControl optional , + SCCP_PAR_Return_Option returnOption optional , + TCMessage userData , + SCCP_PAR_Importance importance optional + } + +template (value) TCAP_N_UNITDATA_req ts_TCAP_UNITDATA_req(SCCP_PAR_Address called, + SCCP_PAR_Address calling, + template (value) TCMessage payload) := { + calledAddress := called, + callingAddress := calling, + sequenceControl := omit, + returnOption := omit, + userData := payload, + importance := omit +} + +type record TCAP_N_UNITDATA_ind +{ + SCCP_PAR_Address calledAddress , + SCCP_PAR_Address callingAddress , + SCCP_PAR_Sequence_Control sequenceControl optional , + SCCP_PAR_Return_Option returnOption optional , + TCMessage userData , + SCCP_PAR_Importance importance optional +} + +template (present) TCAP_N_UNITDATA_ind tr_TCAP_UNITDATA_ind(template SCCP_PAR_Address called, + template SCCP_PAR_Address calling, + template TCMessage payload) := { + calledAddress := called, + callingAddress := calling, + sequenceControl := *, + returnOption := *, + userData := payload, + importance := * +} + +type record TCAP_N_NOTICE_ind +{ + SCCP_PAR_Address calledAddress , + SCCP_PAR_Address callingAddress , + SCCP_PAR_Reason_For_Return reasonForReturn , + TCMessage userData , + SCCP_PAR_Importance importance optional +} + + + +private function f_dec_ConnectInd(in ASP_SCCP_N_CONNECT_ind pin, out TCAP_N_CONNECT_ind pout) { + pout.calledAddress := pin.calledAddress; + pout.callingAddress := pin.callingAddress; + pout.qualityOfService := pin.qualityOfService; + if (ispresent(pin.userData)) { + pout.userData := dec_TCAP_TCMessage(pin.userData); + } else { + pout.userData := omit; + } + pout.connectionId := pin.connectionId; + pout.importance := pin.importance; + //port.setstate(0); +} with {extension "prototype(fast)" } + +private function f_dec_ConnectCfm(in ASP_SCCP_N_CONNECT_cfm pin, out TCAP_N_CONNECT_cfm pout) { + pout.respondingAddress := pin.respondingAddress; + pout.qualityOfService := pin.qualityOfService; + if (ispresent(pin.userData)) { + pout.userData := dec_TCAP_TCMessage(pin.userData); + } else { + pout.userData := omit; + } + pout.connectionId := pin.connectionId; + pout.importance := pin.importance; + //port.setstate(0); +} with {extension "prototype(fast)" } + +private function f_dec_DataInd(in ASP_SCCP_N_DATA_ind pin, out TCAP_N_DATA_ind pout) { + pout.userData := dec_TCAP_TCMessage(pin.userData); + pout.connectionId := pin.connectionId; + pout.importance := pin.importance; + //port.setstate(0); +} with {extension "prototype(fast)" } + +private function f_dec_DisconnectInd(in ASP_SCCP_N_DISCONNECT_ind pin, out TCAP_N_DISCONNECT_ind pout) { + pout.originator := pin.originator; + pout.respondingAddress := pin.respondingAddress; + pout.reason := pin.reason; + if (ispresent(pin.userData)) { + pout.userData := dec_TCAP_TCMessage(pin.userData); + } else { + pout.userData := omit; + } + pout.connectionId := pin.connectionId; + pout.importance := pin.importance; + //port.setstate(0); +} with {extension "prototype(fast)" } + +private function f_dec_UnitdataInd(in ASP_SCCP_N_UNITDATA_ind pin, out TCAP_N_UNITDATA_ind pout) { + pout.calledAddress := pin.calledAddress; + pout.callingAddress := pin.callingAddress; + pout.sequenceControl := pin.sequenceControl; + pout.returnOption := pin.returnOption; + pout.userData := dec_TCAP_TCMessage(pin.userData); + pout.importance := pin.importance; + //port.setstate(0); +} with {extension "prototype(fast)" } + +private function f_dec_NoticeInd(in ASP_SCCP_N_NOTICE_ind pin, out TCAP_N_NOTICE_ind pout) { + pout.calledAddress := pin.calledAddress; + pout.callingAddress := pin.callingAddress; + pout.reasonForReturn := pin.reasonForReturn; + pout.userData := dec_TCAP_TCMessage(pin.userData); + pout.importance := pin.importance; + //port.setstate(0); +} with {extension "prototype(fast)" } + + + +private function f_enc_ConnectReq(in TCAP_N_CONNECT_req pin, out ASP_SCCP_N_CONNECT_req pout) { + pout.calledAddress := pin.calledAddress; + pout.callingAddress := pin.callingAddress; + pout.expeditedDataSel := pin.expeditedDataSel; + pout.qualityOfService := pin.qualityOfService; + if (ispresent(pin.userData)) { + pout.userData := enc_TCAP_TCMessage(pin.userData); + } else { + pout.userData := omit; + } + pout.connectionId := pin.connectionId; + pout.importance := pin.importance; + //port.setstate(0); +} with {extension "prototype(fast)" } + +private function f_enc_ConnectRes(in TCAP_N_CONNECT_res pin, out ASP_SCCP_N_CONNECT_res pout) { + pout.respondingAddress := pin.respondingAddress; + pout.expeditedDataSel := pin.expeditedDataSel; + pout.qualityOfService := pin.qualityOfService; + if (ispresent(pin.userData)) { + pout.userData := enc_TCAP_TCMessage(pin.userData); + } else { + pout.userData := omit; + } + pout.connectionId := pin.connectionId; + pout.importance := pin.importance; + //port.setstate(0); +} with {extension "prototype(fast)" } + +private function f_enc_DataReq(in TCAP_N_DATA_req pin, out ASP_SCCP_N_DATA_req pout) { + pout.userData := enc_TCAP_TCMessage(pin.userData); + pout.connectionId := pin.connectionId; + pout.importance := pin.importance; + //port.setstate(0); +} with {extension "prototype(fast)" } + +private function f_enc_DisconnectReq(in TCAP_N_DISCONNECT_req pin, out ASP_SCCP_N_DISCONNECT_req pout) { + pout.respondingAddress := pin.respondingAddress; + pout.reason := pin.reason; + if (ispresent(pin.userData)) { + pout.userData := enc_TCAP_TCMessage(pin.userData); + } else { + pout.userData := omit; + } + pout.connectionId := pin.connectionId; + pout.importance := pin.importance; + //port.setstate(0); +} with {extension "prototype(fast)" } + +private function f_enc_UnitdataReq(in TCAP_N_UNITDATA_req pin, out ASP_SCCP_N_UNITDATA_req pout) { + pout.calledAddress := pin.calledAddress; + pout.callingAddress := pin.callingAddress; + pout.userData := enc_TCAP_TCMessage(pin.userData); + pout.sequenceControl := pin.sequenceControl; + pout.returnOption := pin.returnOption; + pout.importance := pin.importance; + //port.setstate(0); +} with {extension "prototype(fast)" } + +type port TCAP_CODEC_PT message { + out TCAP_N_CONNECT_req, + TCAP_N_CONNECT_res, + TCAP_N_DATA_req, + TCAP_N_DISCONNECT_req, + TCAP_N_UNITDATA_req, + ASP_SCCP_N_RESET_req; + in TCAP_N_CONNECT_ind, + TCAP_N_CONNECT_cfm, + TCAP_N_DATA_ind, + TCAP_N_DISCONNECT_ind, + TCAP_N_UNITDATA_ind, + TCAP_N_NOTICE_ind, + ASP_SCCP_N_RESET_ind, + ASP_SCCP_N_RESET_cfm, + ASP_SCCP_N_STATE_ind; +} with { extension "internal user SCCPasp_PT + out(TCAP_N_CONNECT_req -> ASP_SCCP_N_CONNECT_req: function(f_enc_ConnectReq); + TCAP_N_CONNECT_res -> ASP_SCCP_N_CONNECT_res: function(f_enc_ConnectRes); + TCAP_N_DATA_req -> ASP_SCCP_N_DATA_req: function(f_enc_DataReq); + TCAP_N_DISCONNECT_req -> ASP_SCCP_N_DISCONNECT_req: function(f_enc_DisconnectReq); + TCAP_N_UNITDATA_req -> ASP_SCCP_N_UNITDATA_req: function(f_enc_UnitdataReq); + ASP_SCCP_N_RESET_req -> ASP_SCCP_N_RESET_req: simple) + in(ASP_SCCP_N_CONNECT_ind -> TCAP_N_CONNECT_ind: function(f_dec_ConnectInd); + ASP_SCCP_N_CONNECT_cfm -> TCAP_N_CONNECT_cfm: function(f_dec_ConnectCfm); + ASP_SCCP_N_DATA_ind -> TCAP_N_DATA_ind: function(f_dec_DataInd); + ASP_SCCP_N_DISCONNECT_ind -> TCAP_N_DISCONNECT_ind: function(f_dec_DisconnectInd); + ASP_SCCP_N_UNITDATA_ind -> TCAP_N_UNITDATA_ind: function(f_dec_UnitdataInd); + ASP_SCCP_N_NOTICE_ind -> TCAP_N_NOTICE_ind: function(f_dec_NoticeInd); + ASP_SCCP_N_RESET_ind -> ASP_SCCP_N_RESET_ind: simple; + ASP_SCCP_N_RESET_cfm -> ASP_SCCP_N_RESET_cfm: simple; + ASP_SCCP_N_STATE_ind -> ASP_SCCP_N_STATE_ind: simple)" +} + + +} diff --git a/library/tcap/TCAP_DialoguePDUs.asn b/library/tcap/TCAP_DialoguePDUs.asn new file mode 100644 index 0000000..183b2ca --- /dev/null +++ b/library/tcap/TCAP_DialoguePDUs.asn @@ -0,0 +1,80 @@ +-- $Id: DialoguePDUs.asn 26186 2008-09-13 11:44:33Z etxrab $ +-- Generated by Asnp, the pretty-printer of France Telecom R&D (http://asn1.elibel.tm.fr/asnp/) +DialoguePDUs {itu-t recommendation q 773 modules(2) dialoguePDUs(2) version1(1) + } DEFINITIONS ::= +BEGIN + +EXPORTS dialogue-as-id, DialoguePDU; + +-- abstract syntax name for structured dialogue APDUs +dialogue-as-id OBJECT IDENTIFIER ::= + {itu-t recommendation q 773 as(1) dialogue-as(1) version1(1)} + +DialoguePDU ::= CHOICE { + dialogueRequest AARQ-apdu, + dialogueResponse AARE-apdu, + dialogueAbort ABRT-apdu +} + +AARQ-apdu ::= [APPLICATION 0] IMPLICIT SEQUENCE { + protocol-version + [0] IMPLICIT BIT STRING {version1(0)} DEFAULT {version1}, + application-context-name [1] OBJECT IDENTIFIER, + user-information [30] IMPLICIT SEQUENCE OF EXTERNAL OPTIONAL +} + +AARE-apdu ::= [APPLICATION 1] IMPLICIT SEQUENCE { + protocol-version + [0] IMPLICIT BIT STRING {version1(0)} DEFAULT {version1}, + application-context-name [1] OBJECT IDENTIFIER, + result [2] Associate-result, + result-source-diagnostic [3] Associate-source-diagnostic, + user-information [30] IMPLICIT SEQUENCE OF EXTERNAL OPTIONAL +} + +-- RLRQ PDU is currently not used. +-- It is included for completeness only. +RLRQ-apdu ::= [APPLICATION 2] IMPLICIT SEQUENCE { + reason [0] IMPLICIT Release-request-reason OPTIONAL, + user-information [30] IMPLICIT SEQUENCE OF EXTERNAL OPTIONAL +} + +-- RLRE PDU is currently not used. +-- It is included for completeness only +RLRE-apdu ::= [APPLICATION 3] IMPLICIT SEQUENCE { + reason [0] IMPLICIT Release-response-reason OPTIONAL, + user-information [30] IMPLICIT SEQUENCE OF EXTERNAL OPTIONAL +} + +ABRT-apdu ::= [APPLICATION 4] IMPLICIT SEQUENCE { + abort-source [0] IMPLICIT ABRT-source, + user-information [30] IMPLICIT SEQUENCE OF EXTERNAL OPTIONAL +} + +ABRT-source ::= INTEGER {dialogue-service-user(0), dialogue-service-provider(1) +} + +Associate-result ::= INTEGER {accepted(0), reject-permanent(1)} + +Associate-source-diagnostic ::= CHOICE { + dialogue-service-user + [1] INTEGER {null(0), no-reason-given(1), + application-context-name-not-supported(2)}, + dialogue-service-provider + [2] INTEGER {null(0), no-reason-given(1), no-common-dialogue-portion(2)} +} + +-- Release-request-reason is currently not used. +-- It is included for completeness only. +Release-request-reason ::= INTEGER {normal(0), urgent(1), user-defined(30) +} + +-- Release-response-reason is currently not used. +-- It is included for completeness only. +Release-response-reason ::= INTEGER { + normal(0), not-finished(1), user-defined(30)} + +END -- DialoguePDUs + +-- Generated by Asnp, the ASN.1 pretty-printer of France Telecom R&D + diff --git a/library/tcap/TCAP_EncDec.cc b/library/tcap/TCAP_EncDec.cc new file mode 100644 index 0000000..35cd30c --- /dev/null +++ b/library/tcap/TCAP_EncDec.cc @@ -0,0 +1,30 @@ + +#include <string.h> +#include <stdarg.h> +#include "TCAPMessages.hh" +namespace TCAP__Types { + +TTCN_Module TCAP__EncDec("TCAP_EncDec", __DATE__, __TIME__); + +OCTETSTRING enc__TCAP__TCMessage(const TCAPMessages::TCMessage &pdu) +{ + TTCN_Buffer TTCN_buf; + TTCN_buf.clear(); + pdu.encode(TCAPMessages::TCMessage_descr_, TTCN_buf, + TTCN_EncDec::CT_BER, BER_ENCODE_DER); + return OCTETSTRING(TTCN_buf.get_len(), TTCN_buf.get_data()); +} + +TCAPMessages::TCMessage dec__TCAP__TCMessage(const OCTETSTRING &stream) +{ + TCAPMessages::TCMessage pdu; + TTCN_Buffer TTCN_buf; + TTCN_buf.clear(); + TTCN_buf.put_os(stream); + pdu.decode(TCAPMessages::TCMessage_descr_, TTCN_buf, + TTCN_EncDec::CT_BER, BER_ACCEPT_ALL); + return pdu; +} + + +} diff --git a/library/tcap/TCAP_Types.ttcn b/library/tcap/TCAP_Types.ttcn new file mode 100644 index 0000000..6703b72 --- /dev/null +++ b/library/tcap/TCAP_Types.ttcn @@ -0,0 +1,7 @@ +module TCAP_Types { + + import from TCAPMessages language "ASN.1:1997" all; + + external function enc_TCAP_TCMessage(in TCMessage pdu) return octetstring; + external function dec_TCAP_TCMessage(in octetstring stream) return TCMessage; +} diff --git a/library/tcap/TCAP_UnidialoguePDUs.asn b/library/tcap/TCAP_UnidialoguePDUs.asn new file mode 100644 index 0000000..4f7c6c3 --- /dev/null +++ b/library/tcap/TCAP_UnidialoguePDUs.asn @@ -0,0 +1,25 @@ +-- Generated by Asnp, the pretty-printer of France Telecom R&D (http://asn1.elibel.tm.fr/asnp/) +UnidialoguePDUs {itu-t recommendation q 773 modules(2) unidialoguePDUs(3) + version1(1)} DEFINITIONS ::= +BEGIN + +EXPORTS uniDialogue-as-id, UniDialoguePDU; + +-- Abstract syntax name for unstructured dialogue APDUs +uniDialogue-as-id OBJECT IDENTIFIER ::= + {itu-t recommendation q 773 as(1) unidialogue-as(2) version1(1)} + +UniDialoguePDU ::= CHOICE {unidialoguePDU AUDT-apdu +} + +AUDT-apdu ::= [APPLICATION 0] IMPLICIT SEQUENCE { + protocol-version + [0] IMPLICIT BIT STRING {version1(0)} DEFAULT {version1}, + application-context-name [1] OBJECT IDENTIFIER, + user-information [30] IMPLICIT SEQUENCE OF EXTERNAL OPTIONAL +} + +END -- UNIDialoguePDU + +-- Generated by Asnp, the ASN.1 pretty-printer of France Telecom R&D + diff --git a/library/tcap/regen_makefile.sh b/library/tcap/regen_makefile.sh new file mode 100755 index 0000000..2ace50d --- /dev/null +++ b/library/tcap/regen_makefile.sh @@ -0,0 +1,6 @@ +#!/bin/sh + +FILES="*.asn *.ttcn TCAP_EncDec.cc" + +../../_buildsystem/regen-makefile.sh $FILES + -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41118?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iae7f92cde02e5da966966bc95f9b74feec51958d Gerrit-Change-Number: 41118 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 days, 3 hours

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2025