Attention is currently required from: fixeria, osmith.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41126?usp=email )
Change subject: s1gw: test S1GW originated PFCP Heartbeat
......................................................................
Patch Set 2:
(1 comment)
File s1gw/S1GW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41126/comment/f90646d9_c282… :
PS2, Line 1016: if (mp_rest_enable) {
I'm not following why do you wanto mix here the PFPC HEartbet procedures on both directions.
IMHO they are totally separate thing and should be triggered in different places.
Actually, I don't really understand why would one want to trigger an initiating PFCP procedure over the REST interface instead of having a configurable timer inside osmo-s1gw...
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41126?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I28fb46be037a488e225d20a16b83d0479c6e067d
Gerrit-Change-Number: 41126
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Sep 2025 11:20:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41124?usp=email )
Change subject: library/HTTP_Adapter: do not hard-code 'Content-Type'
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41124?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie35ffc56b4fedc0b4d8c4a689a2232b515b7b326
Gerrit-Change-Number: 41124
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Sep 2025 11:13:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: daniel, laforge, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41114?usp=email )
Change subject: stp: define PC for IPA ASP peers
......................................................................
Patch Set 2:
(1 comment)
File stp/osmo-stp-ipa.confmerge:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41114/comment/6256c482_8fe1… :
PS2, Line 37: 34
Why is it `34` here? In `STP_Tests_IPA.cfg` I see you're setting `point_code := 33` for the respective entry. I am not saying this is wrong, just trying to understand the logic. All entries except this one match.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41114?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9cca2f4dd38e03ab1d259ffafd904b8890778883
Gerrit-Change-Number: 41114
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Sep 2025 09:41:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41125?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: s1gw: implement the REST interface client
......................................................................
s1gw: implement the REST interface client
OsmoS1GW implements a custom (non-standard) REST interface, primarily
intended for state introspection. The interface is specified using
OpenAPI, with the specification available in osmo-s1gw.git.
Change-Id: Ic6e8b46b7de4fb72139b017fc9a9c83f92fc1541
Related: SYS#7066
---
M s1gw/S1GW_ConnHdlr.ttcn
A s1gw/S1GW_REST_Functions.ttcn
A s1gw/S1GW_REST_Types.ttcn
M s1gw/S1GW_Tests.cfg
M s1gw/S1GW_Tests.default
M s1gw/S1GW_Tests.ttcn
M s1gw/gen_links.sh
M s1gw/regen_makefile.sh
8 files changed, 290 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/25/41125/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41125?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic6e8b46b7de4fb72139b017fc9a9c83f92fc1541
Gerrit-Change-Number: 41125
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder