September 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ci[master]: jobs/master,gerrit: set CFLAGS=-g
by fixeria 26 Sep '25

26 Sep '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41157?usp=email ) Change subject: jobs/master,gerrit: set CFLAGS=-g ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41157?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ieff8670e376f140a672a800961be753028cf7b6f Gerrit-Change-Number: 41157 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 26 Sep 2025 11:43:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ci[master]: jobs/master,gerrit: use wrapper_core_bt_on_error
by fixeria 26 Sep '25

26 Sep '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41156?usp=email ) Change subject: jobs/master,gerrit: use wrapper_core_bt_on_error ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41156?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idc893969b158e11d5ae17d0c0a05b52e662f8929 Gerrit-Change-Number: 41156 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 26 Sep 2025 10:51:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ci[master]: scripts/wrapper_core_bt_on_error: new script
by fixeria 26 Sep '25

26 Sep '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41155?usp=email ) Change subject: scripts/wrapper_core_bt_on_error: new script ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41155?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9673abf3ae3b154505ea09237d37d7da4bf5d57f Gerrit-Change-Number: 41155 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 26 Sep 2025 10:49:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ci[master]: testenv-coredump-helper: remove
by fixeria 26 Sep '25

26 Sep '25

Attention is currently required from: daniel, osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41154?usp=email ) Change subject: testenv-coredump-helper: remove ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41154?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2959c6e6d97d5691ee2a4ae5d49a351eb5811f10 Gerrit-Change-Number: 41154 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 26 Sep 2025 10:36:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN_Tests: fix TC_sgsn_context_req_out
by lynxis lazus 26 Sep '25

26 Sep '25

Attention is currently required from: fixeria, laforge, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017?usp=email to look at the new patch set (#11). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: SGSN_Tests: fix TC_sgsn_context_req_out ...................................................................... SGSN_Tests: fix TC_sgsn_context_req_out The TC_sgsn_context_req_out wasn't complete when merged and didn't work as expected. Change-Id: I0666a518aed57c2594653ab6b0f801c4193fd2f3 --- M sgsn/SGSN_Tests.ttcn M sgsn/gen_links.sh 2 files changed, 151 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/17/39017/11 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0666a518aed57c2594653ab6b0f801c4193fd2f3 Gerrit-Change-Number: 39017 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN_Tests: rework TC_sgsn_context_req_out to actual function
by lynxis lazus 26 Sep '25

26 Sep '25

Attention is currently required from: fixeria, laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017?usp=email ) Change subject: SGSN_Tests: rework TC_sgsn_context_req_out to actual function ...................................................................... Patch Set 10: (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017/comment/4763f381_bdad… : PS10, Line 7: rework TC_sgsn_context_req_out to actual function > I find the commit name confusing. […] That is works. File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017/comment/75982b93_9d42… : PS10, Line 3237: tr_SGSNContextReqPDU > Weird formatting here. Is it this way better? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017/comment/277ac15c_86c5… : PS10, Line 3350: f_sleep(1.0); > Since I am already the second person asking why do you add an artificial delay here, please add a co […] Removed it. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0666a518aed57c2594653ab6b0f801c4193fd2f3 Gerrit-Change-Number: 39017 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 26 Sep 2025 09:53:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-msc[master]: vlr: remove old TODO to switch to osmo_tdef_fsm_inst_state_chg
by lynxis lazus 26 Sep '25

26 Sep '25

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/40422?usp=email ) Change subject: vlr: remove old TODO to switch to osmo_tdef_fsm_inst_state_chg ...................................................................... vlr: remove old TODO to switch to osmo_tdef_fsm_inst_state_chg The timer now using osmo_tdef_fsm_inst_state_chg. Change-Id: I1eecfeec494a2e129c41a6e964c56ed4430611de --- M src/libvlr/vlr.c 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: neels: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c index e90596c..c7b7e63 100644 --- a/src/libvlr/vlr.c +++ b/src/libvlr/vlr.c @@ -211,8 +211,7 @@ struct osmo_tdef *vlr_tdefs; -/* This is just a wrapper around the osmo_tdef API. - * TODO: we should start using osmo_tdef_fsm_inst_state_chg() */ +/* This is just a wrapper around the osmo_tdef API. */ unsigned long vlr_timer_secs(struct vlr_instance *vlr, int cs_timer, int ps_timer) { /* NOTE: since we usually do not need more than one instance of the VLR, -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40422?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I1eecfeec494a2e129c41a6e964c56ed4430611de Gerrit-Change-Number: 40422 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in osmo-msc[master]: vlr_lu_fsm: terminate the FSM instead of dispatching only a signal to...
by lynxis lazus 26 Sep '25

26 Sep '25

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/38491?usp=email ) Change subject: vlr_lu_fsm: terminate the FSM instead of dispatching only a signal to the parent ...................................................................... vlr_lu_fsm: terminate the FSM instead of dispatching only a signal to the parent CS doesn't need this because the FSM is bound to the signalling connection, but for PS, there is no direct signalling connection in the SGSN. Change-Id: I27fd1048f85363797b43808d2061ce28be6da81b --- M src/libvlr/vlr_lu_fsm.c M tests/msc_vlr/msc_vlr_test_authen_reuse.err M tests/msc_vlr/msc_vlr_test_call.err M tests/msc_vlr/msc_vlr_test_gsm_authen.err M tests/msc_vlr/msc_vlr_test_gsm_ciph.err M tests/msc_vlr/msc_vlr_test_hlr_reject.err M tests/msc_vlr/msc_vlr_test_hlr_timeout.err M tests/msc_vlr/msc_vlr_test_ms_timeout.err M tests/msc_vlr/msc_vlr_test_no_authen.err M tests/msc_vlr/msc_vlr_test_reject_concurrency.err M tests/msc_vlr/msc_vlr_test_rest.err M tests/msc_vlr/msc_vlr_test_ss.err M tests/msc_vlr/msc_vlr_test_umts_authen.err 13 files changed, 368 insertions(+), 367 deletions(-) Approvals: neels: Looks good to me, approved pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified daniel: Looks good to me, but someone else must approve -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38491?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I27fd1048f85363797b43808d2061ce28be6da81b Gerrit-Change-Number: 38491 Gerrit-PatchSet: 12 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: Register OSMO_EXT protocol number for TCAP routing
by osmith 26 Sep '25

26 Sep '25

Attention is currently required from: daniel, fixeria, lynxis lazus. osmith has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmocore/+/41165?usp=email ) Change subject: Register OSMO_EXT protocol number for TCAP routing ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41165?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3b8847ebcfedc8fc0ed5fcfd453dcfe26eb070b0 Gerrit-Change-Number: 41165 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 26 Sep 2025 07:52:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...osmo-epdg[master]: editorconfig: new file
by osmith 26 Sep '25

26 Sep '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41166?usp=email ) Change subject: editorconfig: new file ...................................................................... editorconfig: new file Let editors like vim, neovim and many more automatically indent erl files with 4 spaces as it is done throughout this source tree. Related: https://editorconfig.org/ Change-Id: Idb35212657f720aba236cb5dcdfa1bef8db9e838 --- A .editorconfig 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/66/41166/1 diff --git a/.editorconfig b/.editorconfig new file mode 100644 index 0000000..6163852 --- /dev/null +++ b/.editorconfig @@ -0,0 +1,8 @@ +root = true + +[**/*.erl] +indent_size = 4 +indent_style = space +end_of_line = lf +insert_final_newline = true +trim_trailing_whitespace = true -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41166?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Idb35212657f720aba236cb5dcdfa1bef8db9e838 Gerrit-Change-Number: 41166 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

2025

2024

2023

2022

gerrit-log September 2025