gerrit-log September 2025

gerrit-log@lists.osmocom.org

1 participants
1000 discussions

[S] Change in osmo-msc[master]: tests/{ctrl,vty}_test_runner.py: dump stdout/stderr

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/41127?usp=email ) Change subject: tests/{ctrl,vty}_test_runner.py: dump stdout/stderr ...................................................................... tests/{ctrl,vty}_test_runner.py: dump stdout/stderr From time to time, we're seeing the following error in Jenkins: ---------------------------------------------------------------------- Traceback (most recent call last): File ".../tests/vty_test_runner.py", line 70, in tearDown raise Exception("Process returned %d" % rc) Exception: Process returned -9 ---------------------------------------------------------------------- Let's dump stdout/stderr of the process to get more information. Change-Id: Ie6a2f5b1bc56d35513643b52923403798e5a0a5a Related: OS#5665 --- M tests/ctrl_test_runner.py M tests/vty_test_runner.py 2 files changed, 37 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/tests/ctrl_test_runner.py b/tests/ctrl_test_runner.py index 16d1e7c..127d747 100755 --- a/tests/ctrl_test_runner.py +++ b/tests/ctrl_test_runner.py @@ -26,6 +26,8 @@ import socket import sys import struct +import subprocess +import tempfile import osmopy.obscvty as obscvty import osmopy.osmoutil as osmoutil @@ -50,8 +52,12 @@ cfi = config_index + 1 osmo_ctrl_cmd[cfi] = os.path.join(confpath, osmo_ctrl_cmd[cfi]) + self.stdout = tempfile.TemporaryFile() + self.stderr = tempfile.TemporaryFile() try: - self.proc = osmoutil.popen_devnull(osmo_ctrl_cmd) + # self.proc = osmoutil.popen_devnull(osmo_ctrl_cmd) + print("Launching: PWD=%s %s" % (os.getcwd(), ' '.join([repr(c) for c in osmo_ctrl_cmd]))) + self.proc = subprocess.Popen(osmo_ctrl_cmd, stdout=self.stdout, stderr=self.stderr) except OSError: print("Current directory: %s" % os.getcwd(), file=sys.stderr) print("Consider setting -b", file=sys.stderr) @@ -62,11 +68,23 @@ self.connect("127.0.0.1", appport) self.next_id = 1000 + def dump_file(self, file, name): + file.seek(0) + data = file.read() + print('=' * 80) + print(name) + print('=' * 80) + print(data.decode()) + def tearDown(self): self.disconnect() rc = osmoutil.end_proc(self.proc) if rc is not None and rc != 0: + self.dump_file(self.stdout, 'stdout') + self.dump_file(self.stderr, 'stderr') raise Exception("Process returned %d" % rc) + self.stdout.close() + self.stderr.close() def disconnect(self): if not (self.sock is None): diff --git a/tests/vty_test_runner.py b/tests/vty_test_runner.py index 2dfa155..571080e 100755 --- a/tests/vty_test_runner.py +++ b/tests/vty_test_runner.py @@ -20,6 +20,7 @@ import unittest import socket import subprocess +import tempfile import osmopy.obscvty as obscvty import osmopy.osmoutil as osmoutil @@ -51,8 +52,12 @@ cfi = config_index + 1 osmo_vty_cmd[cfi] = os.path.join(confpath, osmo_vty_cmd[cfi]) + self.stdout = tempfile.TemporaryFile() + self.stderr = tempfile.TemporaryFile() try: - self.proc = osmoutil.popen_devnull(osmo_vty_cmd) + # self.proc = osmoutil.popen_devnull(osmo_vty_cmd) + print("Launching: PWD=%s %s" % (os.getcwd(), ' '.join([repr(c) for c in osmo_vty_cmd]))) + self.proc = subprocess.Popen(osmo_vty_cmd, stdout=self.stdout, stderr=self.stderr) except OSError: print("Current directory: %s" % os.getcwd(), file=sys.stderr) print("Consider setting -b", file=sys.stderr) @@ -61,13 +66,25 @@ appport = self.vty_app()[0] self.vty = obscvty.VTYInteract(appstring, "127.0.0.1", appport) + def dump_file(self, file, name): + file.seek(0) + data = file.read() + print('=' * 80) + print(name) + print('=' * 80) + print(data.decode()) + def tearDown(self): if self.vty: self.vty._close_socket() self.vty = None rc = osmoutil.end_proc(self.proc) if rc is not None and rc != 0: + self.dump_file(self.stdout, 'stdout') + self.dump_file(self.stderr, 'stderr') raise Exception("Process returned %d" % rc) + self.stdout.close() + self.stderr.close() class TestVTYMSC(TestVTYBase): -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41127?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie6a2f5b1bc56d35513643b52923403798e5a0a5a Gerrit-Change-Number: 41127 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 days, 9 hours

[S] Change in osmo-msc[master]: tests/{ctrl,vty}_test_runner.py: dump stdout/stderr

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-msc/+/41127?usp=email ) Change subject: tests/{ctrl,vty}_test_runner.py: dump stdout/stderr ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41127?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie6a2f5b1bc56d35513643b52923403798e5a0a5a Gerrit-Change-Number: 41127 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Sep 2025 06:10:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 days, 9 hours

[L] Change in osmo-ttcn3-hacks[master]: Move RAN_Configurations module parameter definition to *_Tests.default

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41129?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Move RAN_Configurations module parameter definition to *_Tests.default ...................................................................... Move RAN_Configurations module parameter definition to *_Tests.default This way we can easily tweak values, which usually involve other programs' config like osmo-stp, without needing to recompile ttcn-3. Furthermore, we avoid ending up in the situation where the .ttcn file contains invalid data which is alwayred overridden in .default, like it happened in MSC_Tests.ttcn. Change-Id: Id7e77a2ecf68520a853dc35fe0013a0611e744a1 --- M bsc/BSC_Tests.default M bsc/BSC_Tests.ttcn M bsc/BSC_Tests_SCCPlite.cfg M hnbgw/HNBGW_Tests.default M hnbgw/HNBGW_Tests.ttcn M msc/MSC_Tests.ttcn M sgsn/SGSN_Tests.cfg M sgsn/SGSN_Tests.default M sgsn/SGSN_Tests.ttcn 9 files changed, 146 insertions(+), 170 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/29/41129/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41129?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id7e77a2ecf68520a853dc35fe0013a0611e744a1 Gerrit-Change-Number: 41129 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de>

3 days, 21 hours

[L] Change in osmo-ttcn3-hacks[master]: Move RAN_Configurations module parameter definition to *_Tests.default

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41129?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Move RAN_Configurations module parameter definition to *_Tests.default ...................................................................... Move RAN_Configurations module parameter definition to *_Tests.default This way we can easily tweak values, which usually involve other programs' config like osmo-stp, without needing to recompile ttcn-3. Furthermore, we avoid ending up in the situation where the .ttcn file contains invalid data which is alwayred overridden in .default, like it happened in MSC_Tests.ttcn. Change-Id: Id7e77a2ecf68520a853dc35fe0013a0611e744a1 --- M bsc/BSC_Tests.default M bsc/BSC_Tests.ttcn M bsc/BSC_Tests_SCCPlite.cfg M hnbgw/HNBGW_Tests.default M hnbgw/HNBGW_Tests.ttcn M msc/MSC_Tests.ttcn M sgsn/SGSN_Tests.default M sgsn/SGSN_Tests.ttcn 8 files changed, 146 insertions(+), 165 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/29/41129/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41129?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id7e77a2ecf68520a853dc35fe0013a0611e744a1 Gerrit-Change-Number: 41129 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de>

3 days, 21 hours

[XS] Change in osmo-ttcn3-hacks[master]: smlc: Remove unneeded RAN_Adapter.ttcnpp from gen_links.sh

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41130?usp=email to look at the new patch set (#2). Change subject: smlc: Remove unneeded RAN_Adapter.ttcnpp from gen_links.sh ...................................................................... smlc: Remove unneeded RAN_Adapter.ttcnpp from gen_links.sh Change-Id: I332c09c65a9dba40bca2851eb34cd3edf8da8727 --- M smlc/gen_links.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/30/41130/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41130?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I332c09c65a9dba40bca2851eb34cd3edf8da8727 Gerrit-Change-Number: 41130 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

3 days, 21 hours

[XS] Change in osmo-ttcn3-hacks[master]: smlc: Remove uneeded RAN_Adapter.ttcnpp from gen_links.sh

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41130?usp=email ) Change subject: smlc: Remove uneeded RAN_Adapter.ttcnpp from gen_links.sh ...................................................................... smlc: Remove uneeded RAN_Adapter.ttcnpp from gen_links.sh Change-Id: I332c09c65a9dba40bca2851eb34cd3edf8da8727 --- M smlc/gen_links.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/30/41130/1 diff --git a/smlc/gen_links.sh b/smlc/gen_links.sh index 3308a0b..2c8bca3 100755 --- a/smlc/gen_links.sh +++ b/smlc/gen_links.sh @@ -67,7 +67,7 @@ gen_links $DIR $FILES DIR=../library -FILES="Misc_Helpers.ttcn General_Types.ttcn Osmocom_Types.ttcn GSM_Types.ttcn Osmocom_VTY_Functions.ttcn Native_Functions.ttcn Native_FunctionDefs.cc IPA_Types.ttcn IPA_CodecPort.ttcn IPA_CodecPort_CtrlFunct.ttcn IPA_CodecPort_CtrlFunctDef.cc IPA_Emulation.ttcnpp L3_Templates.ttcn BSSMAP_Templates.ttcn BSSAP_LE_Types.ttcn RAN_Emulation.ttcnpp RLCMAC_CSN1_Templates.ttcn RLCMAC_CSN1_Types.ttcn GSM_RR_Types.ttcn RSL_Types.ttcn RSL_Emulation.ttcn MGCP_Emulation.ttcn SDP_Templates.ttcn MGCP_Types.ttcn MGCP_Templates.ttcn MGCP_CodecPort.ttcn MGCP_CodecPort_CtrlFunct.ttcn MGCP_CodecPort_CtrlFunctDef.cc BSSAP_CodecPort.ttcn RAN_Adapter.ttcnpp Osmocom_CTRL_Types.ttcn Osmocom_CTRL_Functions.ttcn Osmocom_CTRL_Adapter.ttcn RTP_CodecPort.ttcn RTP_CodecPort_CtrlFunct.ttcn RTP_CodecPort_CtrlFunctDef.cc RTP_Emulation.ttcn IuUP_Types.ttcn IuUP_EncDec.cc IuUP_Emulation.ttcn SCCP_Templates.ttcn IPA_Testing.ttcn GSM_SystemInformation.ttcn GSM_RestOctets.ttcn " +FILES="Misc_Helpers.ttcn General_Types.ttcn Osmocom_Types.ttcn GSM_Types.ttcn Osmocom_VTY_Functions.ttcn Native_Functions.ttcn Native_FunctionDefs.cc IPA_Types.ttcn IPA_CodecPort.ttcn IPA_CodecPort_CtrlFunct.ttcn IPA_CodecPort_CtrlFunctDef.cc IPA_Emulation.ttcnpp L3_Templates.ttcn BSSMAP_Templates.ttcn BSSAP_LE_Types.ttcn RAN_Emulation.ttcnpp RLCMAC_CSN1_Templates.ttcn RLCMAC_CSN1_Types.ttcn GSM_RR_Types.ttcn RSL_Types.ttcn RSL_Emulation.ttcn MGCP_Emulation.ttcn SDP_Templates.ttcn MGCP_Types.ttcn MGCP_Templates.ttcn MGCP_CodecPort.ttcn MGCP_CodecPort_CtrlFunct.ttcn MGCP_CodecPort_CtrlFunctDef.cc BSSAP_CodecPort.ttcn Osmocom_CTRL_Types.ttcn Osmocom_CTRL_Functions.ttcn Osmocom_CTRL_Adapter.ttcn RTP_CodecPort.ttcn RTP_CodecPort_CtrlFunct.ttcn RTP_CodecPort_CtrlFunctDef.cc RTP_Emulation.ttcn IuUP_Types.ttcn IuUP_EncDec.cc IuUP_Emulation.ttcn SCCP_Templates.ttcn IPA_Testing.ttcn GSM_SystemInformation.ttcn GSM_RestOctets.ttcn " FILES+="BSSAP_LE_CodecPort.ttcn BSSAP_LE_Emulation.ttcn BSSAP_LE_Adapter.ttcn BSSLAP_Types.ttcn BSSMAP_LE_Templates.ttcn " FILES+="StatsD_Types.ttcn StatsD_CodecPort.ttcn StatsD_CodecPort_CtrlFunct.ttcn StatsD_CodecPort_CtrlFunctdef.cc StatsD_Checker.ttcnpp " -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41130?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I332c09c65a9dba40bca2851eb34cd3edf8da8727 Gerrit-Change-Number: 41130 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

3 days, 22 hours

[L] Change in osmo-ttcn3-hacks[master]: Move RAN_Configurations module parameter definition to *_Tests.default

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41129?usp=email ) Change subject: Move RAN_Configurations module parameter definition to *_Tests.default ...................................................................... Move RAN_Configurations module parameter definition to *_Tests.default This way we can easily tweak values, which usually involve other programs' config like osmo-stp, without needing to recompile ttcn-3. Furthermore, we avoid ending up in the situation where the .ttcn file contains invalid data which is alwayred overridden in .default, like it happened in MSC_Tests.ttcn. Change-Id: Id7e77a2ecf68520a853dc35fe0013a0611e744a1 --- M bsc/BSC_Tests.default M bsc/BSC_Tests.ttcn M hnbgw/HNBGW_Tests.default M hnbgw/HNBGW_Tests.ttcn M msc/MSC_Tests.ttcn M sgsn/SGSN_Tests.default M sgsn/SGSN_Tests.ttcn 7 files changed, 149 insertions(+), 165 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/29/41129/1 diff --git a/bsc/BSC_Tests.default b/bsc/BSC_Tests.default index 65cc7c2..51dbdc2 100644 --- a/bsc/BSC_Tests.default +++ b/bsc/BSC_Tests.default @@ -38,5 +38,43 @@ [MODULE_PARAMETERS] Osmocom_VTY_Functions.mp_prompt_prefix := "OsmoBSC"; +BSC_Tests.mp_bssap_cfg := { + { + transport := BSSAP_TRANSPORT_AoIP, + transport_is_server := false, + sccp_service_type := "mtp3_itu", + sctp_addr := { 23905, "127.0.0.1", 2905, "127.0.0.1" }, + own_pc := 185, /* 0.23.1 first MSC emulation */ + own_ssn := 254, + peer_pc := 187, /* 0.23.3 osmo-bsc */ + peer_ssn := 254, + sio := '83'O, + rctx := 1 + }, + { + transport := BSSAP_TRANSPORT_AoIP, + transport_is_server := false, + sccp_service_type := "mtp3_itu", + sctp_addr := { 23906, "127.0.0.1", 2905, "127.0.0.1" }, + own_pc := 2, /* 0.0.2 second MSC emulation */ + own_ssn := 254, + peer_pc := 187, /* 0.23.3 osmo-bsc */ + peer_ssn := 254, + sio := '83'O, + rctx := 2 + }, + { + transport := BSSAP_TRANSPORT_AoIP, + transport_is_server := false, + sccp_service_type := "mtp3_itu", + sctp_addr := { 23907, "127.0.0.1", 2905, "127.0.0.1" }, + own_pc := 3, /* 0.0.3 third MSC emulation */ + own_ssn := 254, + peer_pc := 187, /* 0.23.3 osmo-bsc */ + peer_ssn := 254, + sio := '83'O, + rctx := 3 + } +}; [EXECUTE] diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 86f9d48..e6260b3 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -687,41 +687,7 @@ /* IP address at which the test binds */ charstring mp_test_ip := "127.0.0.1"; - RAN_Configurations mp_bssap_cfg := { - { - transport := BSSAP_TRANSPORT_AoIP, - sccp_service_type := "mtp3_itu", - sctp_addr := { 23905, "127.0.0.1", 2905, "127.0.0.1" }, - own_pc := 185, /* 0.23.1 first MSC emulation */ - own_ssn := 254, - peer_pc := 187, /* 0.23.3 osmo-bsc */ - peer_ssn := 254, - sio := '83'O, - rctx := 1 - }, - { - transport := BSSAP_TRANSPORT_AoIP, - sccp_service_type := "mtp3_itu", - sctp_addr := { 23906, "127.0.0.1", 2905, "127.0.0.1" }, - own_pc := 2, /* 0.0.2 second MSC emulation */ - own_ssn := 254, - peer_pc := 187, /* 0.23.3 osmo-bsc */ - peer_ssn := 254, - sio := '83'O, - rctx := 2 - }, - { - transport := BSSAP_TRANSPORT_AoIP, - sccp_service_type := "mtp3_itu", - sctp_addr := { 23907, "127.0.0.1", 2905, "127.0.0.1" }, - own_pc := 3, /* 0.0.3 third MSC emulation */ - own_ssn := 254, - peer_pc := 187, /* 0.23.3 osmo-bsc */ - peer_ssn := 254, - sio := '83'O, - rctx := 3 - } - }; + RAN_Configurations mp_bssap_cfg := { /* Set in BSC_Tests.default */ }; /* Must match per BTS config in osmo-bsc.cfg */ phys_chan_configs phys_chan_config := { @@ -1100,7 +1066,7 @@ mgw_udp_port := 2427 + mgw_nr, /* Enable it for SCCPlite, since we have 2 MGCP sockets towards MGW (UDP one + the one with MGCP over IPA forwarded from MSC one) */ - multi_conn_mode := (mp_bssap_cfg[0].transport == BSSAP_TRANSPORT_SCCPlite_SERVER) + multi_conn_mode := (mp_bssap_cfg[0].transport == BSSAP_TRANSPORT_SCCPlite) }; vc_MGCP[mgw_nr] := MGCP_Emulation_CT.create(id) alive; @@ -12709,7 +12675,7 @@ execute( TC_stat_msc_sctp_disconnected() ); } execute( TC_ctrl() ); - if (mp_bssap_cfg[0].transport == BSSAP_TRANSPORT_SCCPlite_SERVER) { + if (mp_bssap_cfg[0].transport == BSSAP_TRANSPORT_SCCPlite) { execute( TC_ctrl_location() ); } diff --git a/hnbgw/HNBGW_Tests.default b/hnbgw/HNBGW_Tests.default index 174b012..0278796 100644 --- a/hnbgw/HNBGW_Tests.default +++ b/hnbgw/HNBGW_Tests.default @@ -33,5 +33,97 @@ [MODULE_PARAMETERS] Osmocom_VTY_Functions.mp_prompt_prefix := "OsmoHNBGW"; +#MSCs (NUM_MSC entries): +HNBGW_Tests.mp_cn_cfg := { + { + transport := RANAP_TRANSPORT_IuCS, + sccp_service_type := "mtp3_itu", + sctp_addr := { 23905, "127.0.0.1", 2905, "127.0.0.1" }, + own_pc := 185, /* 0.23.1 first MSC emulation */ + own_ssn := 142, + peer_pc := 189, /* 0.23.5 osmo-hnbgw */ + peer_ssn := 142, + sio := '83'O, + rctx := 1 + }, + { + transport := RANAP_TRANSPORT_IuCS, + sccp_service_type := "mtp3_itu", + sctp_addr := { 23907, "127.0.0.1", 2905, "127.0.0.1" }, + own_pc := 2, /* 0.0.2 second MSC emulation */ + own_ssn := 142, + peer_pc := 189, /* 0.23.5 osmo-hnbgw */ + peer_ssn := 142, + sio := '83'O, + rctx := 3 + }, + { + transport := RANAP_TRANSPORT_IuCS, + sccp_service_type := "mtp3_itu", + sctp_addr := { 23909, "127.0.0.1", 2905, "127.0.0.1" }, + own_pc := 3, /* 0.0.3 third MSC emulation */ + own_ssn := 142, + peer_pc := 189, /* 0.23.5 osmo-hnbgw */ + peer_ssn := 142, + sio := '83'O, + rctx := 5 + }, + { + transport := RANAP_TRANSPORT_IuCS, + sccp_service_type := "mtp3_itu", + sctp_addr := { 23911, "127.0.0.1", 2905, "127.0.0.1" }, + own_pc := 4, /* 0.0.4 fourth MSC emulation */ + own_ssn := 142, + peer_pc := 189, /* 0.23.5 osmo-hnbgw */ + peer_ssn := 142, + sio := '83'O, + rctx := 7 + }, + /* SGSNs (NUM_SGSN entries) */ + { + transport := RANAP_TRANSPORT_IuCS, + sccp_service_type := "mtp3_itu", + sctp_addr := { /* local */ 23906, "127.0.0.1", /* remote */ 2905, "127.0.0.1" }, + own_pc := 188, /* 0.23.4 first SGSN emulation */ + own_ssn := 142, + peer_pc := 189, /* 2237, 1.23.5 osmo-hnbgw */ + peer_ssn := 142, + sio := '83'O, + rctx := 2 + }, + { + transport := RANAP_TRANSPORT_IuCS, + sccp_service_type := "mtp3_itu", + sctp_addr := { /* local */ 23908, "127.0.0.1", /* remote */ 2905, "127.0.0.1" }, + own_pc := 10, /* 0.1.2 second SGSN emulation */ + own_ssn := 142, + peer_pc := 189, /* 2237, 1.23.5 osmo-hnbgw */ + peer_ssn := 142, + sio := '83'O, + rctx := 4 + }, + { + transport := RANAP_TRANSPORT_IuCS, + sccp_service_type := "mtp3_itu", + sctp_addr := { /* local */ 23910, "127.0.0.1", /* remote */ 2905, "127.0.0.1" }, + own_pc := 11, /* 0.1.3 third SGSN emulation */ + own_ssn := 142, + peer_pc := 189, /* 2237, 1.23.5 osmo-hnbgw */ + peer_ssn := 142, + sio := '83'O, + rctx := 6 + }, + { + transport := RANAP_TRANSPORT_IuCS, + sccp_service_type := "mtp3_itu", + sctp_addr := { /* local */ 23912, "127.0.0.1", /* remote */ 2905, "127.0.0.1" }, + own_pc := 12, /* 0.1.4 fourth SGSN emulation */ + own_ssn := 142, + peer_pc := 189, /* 2237, 1.23.5 osmo-hnbgw */ + peer_ssn := 142, + sio := '83'O, + rctx := 8 + } +}; [EXECUTE] diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 2a343fc..2ef7b4d 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -117,99 +117,7 @@ charstring mp_mgw_ip := "127.0.0.1"; integer mp_mgw_port := 2427; - RAN_Configurations mp_cn_cfg := { - /* MSCs (NUM_MSC entries) */ - { - transport := RANAP_TRANSPORT_IuCS, - sccp_service_type := "mtp3_itu", - sctp_addr := { 23905, "127.0.0.1", 2905, "127.0.0.1" }, - own_pc := 185, /* 0.23.1 first MSC emulation */ - own_ssn := 142, - peer_pc := 189, /* 0.23.5 osmo-hnbgw */ - peer_ssn := 142, - sio := '83'O, - rctx := 1 - }, - { - transport := RANAP_TRANSPORT_IuCS, - sccp_service_type := "mtp3_itu", - sctp_addr := { 23907, "127.0.0.1", 2905, "127.0.0.1" }, - own_pc := 2, /* 0.0.2 second MSC emulation */ - own_ssn := 142, - peer_pc := 189, /* 0.23.5 osmo-hnbgw */ - peer_ssn := 142, - sio := '83'O, - rctx := 3 - }, - { - transport := RANAP_TRANSPORT_IuCS, - sccp_service_type := "mtp3_itu", - sctp_addr := { 23909, "127.0.0.1", 2905, "127.0.0.1" }, - own_pc := 3, /* 0.0.3 third MSC emulation */ - own_ssn := 142, - peer_pc := 189, /* 0.23.5 osmo-hnbgw */ - peer_ssn := 142, - sio := '83'O, - rctx := 5 - }, - { - transport := RANAP_TRANSPORT_IuCS, - sccp_service_type := "mtp3_itu", - sctp_addr := { 23911, "127.0.0.1", 2905, "127.0.0.1" }, - own_pc := 4, /* 0.0.4 fourth MSC emulation */ - own_ssn := 142, - peer_pc := 189, /* 0.23.5 osmo-hnbgw */ - peer_ssn := 142, - sio := '83'O, - rctx := 7 - }, - - /* SGSNs (NUM_SGSN entries) */ - { - transport := RANAP_TRANSPORT_IuCS, - sccp_service_type := "mtp3_itu", - sctp_addr := { /* local */ 23906, "127.0.0.1", /* remote */ 2905, "127.0.0.1" }, - own_pc := 188, /* 0.23.4 first SGSN emulation */ - own_ssn := 142, - peer_pc := 189, /* 2237, 1.23.5 osmo-hnbgw */ - peer_ssn := 142, - sio := '83'O, - rctx := 2 - }, - { - transport := RANAP_TRANSPORT_IuCS, - sccp_service_type := "mtp3_itu", - sctp_addr := { /* local */ 23908, "127.0.0.1", /* remote */ 2905, "127.0.0.1" }, - own_pc := 10, /* 0.1.2 second SGSN emulation */ - own_ssn := 142, - peer_pc := 189, /* 2237, 1.23.5 osmo-hnbgw */ - peer_ssn := 142, - sio := '83'O, - rctx := 4 - }, - { - transport := RANAP_TRANSPORT_IuCS, - sccp_service_type := "mtp3_itu", - sctp_addr := { /* local */ 23910, "127.0.0.1", /* remote */ 2905, "127.0.0.1" }, - own_pc := 11, /* 0.1.3 third SGSN emulation */ - own_ssn := 142, - peer_pc := 189, /* 2237, 1.23.5 osmo-hnbgw */ - peer_ssn := 142, - sio := '83'O, - rctx := 6 - }, - { - transport := RANAP_TRANSPORT_IuCS, - sccp_service_type := "mtp3_itu", - sctp_addr := { /* local */ 23912, "127.0.0.1", /* remote */ 2905, "127.0.0.1" }, - own_pc := 12, /* 0.1.4 fourth SGSN emulation */ - own_ssn := 142, - peer_pc := 189, /* 2237, 1.23.5 osmo-hnbgw */ - peer_ssn := 142, - sio := '83'O, - rctx := 8 - } - }; + RAN_Configurations mp_cn_cfg := { /* Set in HNBGW_Tests.default */ }; boolean mp_enable_pfcp_tests := false; /* IP address at which we listen for PFCP to emulate a UPF in ttcn3 */ diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index ceddc11..12c6561 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -166,28 +166,7 @@ charstring mp_vlr_name := "vlr.example.net"; integer mp_bssap_reset_retries := 1; - RAN_Configurations mp_bssap_cfg := { - { - sccp_service_type := "mtp3_itu", - sctp_addr := { 23905, "127.0.0.1", 2905, "127.0.0.1" }, - own_pc := 185, - own_ssn := 254, - peer_pc := 187, - peer_ssn := 254, - sio := '83'O, - rctx := 0 - }, - { - sccp_service_type := "mtp3_itu", - sctp_addr := { 23906, "127.0.0.1", 2905, "127.0.0.1" }, - own_pc := 186, - own_ssn := 254, - peer_pc := 187, - peer_ssn := 254, - sio := '83'O, - rctx := 1 - } - }; + RAN_Configurations mp_bssap_cfg := { /* Set in MSC_Tests.default */ }; } /* altstep for the global guard timer (only used when BSSAP_DIRECT diff --git a/sgsn/SGSN_Tests.default b/sgsn/SGSN_Tests.default index 5a7b8c6..459429b 100644 --- a/sgsn/SGSN_Tests.default +++ b/sgsn/SGSN_Tests.default @@ -39,6 +39,19 @@ [MODULE_PARAMETERS] Osmocom_VTY_Functions.mp_prompt_prefix := "OsmoSGSN"; +SGSN_Tests.mp_ranap_cfg := { + { + transport := RANAP_TRANSPORT_IuCS, + sccp_service_type := "mtp3_itu", + sctp_addr := { 23908, "127.0.0.1", 2905, "127.0.0.1" }, + own_pc := 195, + own_ssn := 142, + peer_pc := 188, /* 0.23.4 */ + peer_ssn := 142, + sio := '83'O, + rctx := 2 + } +}; [MAIN_CONTROLLER] diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index 9c13c20..ab818d0 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -149,19 +149,7 @@ } }; - RAN_Configurations mp_ranap_cfg := { - { - transport := RANAP_TRANSPORT_IuCS, - sccp_service_type := "mtp3_itu", - sctp_addr := { 23908, "127.0.0.1", 2905, "127.0.0.1" }, - own_pc := 195, - own_ssn := 142, - peer_pc := 188, /* 0.23.4 */ - peer_ssn := 142, - sio := '83'O, - rctx := 2 - } - } + RAN_Configurations mp_ranap_cfg := { /* Set in SGSN_Tests.default */ }; }; const integer NUM_BVC_PER_NSE := 1; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41129?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id7e77a2ecf68520a853dc35fe0013a0611e744a1 Gerrit-Change-Number: 41129 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

3 days, 23 hours

[XS] Change in osmo-ttcn3-hacks[master]: sgsn: Remove unnedeed redefinition of RAN_Configurations

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41128?usp=email ) Change subject: sgsn: Remove unnedeed redefinition of RAN_Configurations ...................................................................... sgsn: Remove unnedeed redefinition of RAN_Configurations This is already defined in the same way in RAN_Adapter.ttcn, where record RAN_Configuration is also defined. Change-Id: Ia2193c2b7e71eb544e6aba75326babd28962a0f9 --- M sgsn/SGSN_Tests.ttcn 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/28/41128/1 diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index 7364dc4..9c13c20 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -183,7 +183,6 @@ GlobalRNC_ID grnc_id }; type record length(NUM_RNC) of IuInstance IuInstances; -type record of RAN_Configuration RAN_Configurations; type component test_CT extends GTP_ConnHdlr, StatsD_ConnHdlr { var GbInstances g_gb; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41128?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia2193c2b7e71eb544e6aba75326babd28962a0f9 Gerrit-Change-Number: 41128 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

3 days, 23 hours

[XL] Change in osmo-ttcn3-hacks[master]: smdpp: es9p testsuite

by Hoernchen

Attention is currently required from: Hoernchen. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: smdpp: es9p testsuite ...................................................................... smdpp: es9p testsuite Certs are from https://www.gsma.com/solutions-and-impact/technologies/esim/wp-content/uplo… the invalid ones are generated using smdpp/generate_all_test_certificates.py Change-Id: I3ba163d9155a3b019214dbccc3c8031dfd7deb6b --- M .checkpatch.conf A smdpp/.clang-format A smdpp/InvalidTestCases/CERT_EUICC_ECDSA_NIST_EXPIRED.der A smdpp/InvalidTestCases/CERT_EUICC_ECDSA_NIST_INVALID.der A smdpp/InvalidTestCases/CERT_EUICC_ECDSA_NIST_INVALID_EID.der A smdpp/InvalidTestCases/CERT_EUICC_ECDSA_NIST_INVALID_EID.pem A smdpp/InvalidTestCases/CERT_EUICC_ECDSA_NIST_UNMATCHED_EID.der A smdpp/InvalidTestCases/CERT_EUICC_ECDSA_NIST_UNMATCHED_EID.pem A smdpp/InvalidTestCases/CERT_EUM_ECDSA_NIST_EXPIRED.der A smdpp/InvalidTestCases/CERT_EUM_ECDSA_NIST_INVALID.der A smdpp/InvalidTestCases/CERT_EUM_ECDSA_NIST_UNKNOWN_CI.der A smdpp/InvalidTestCases/CERT_UNKNOWN_CI_ECDSA_NIST.der A smdpp/bsp_crypto.cpp A smdpp/bsp_crypto.h A smdpp/gen_links.sh A smdpp/generate_all_test_certificates.py A smdpp/helpers.h A smdpp/logger.h A smdpp/package.yml A smdpp/regen_makefile.sh A smdpp/rsp_client.cpp A smdpp/sgp26/CertificateIssuer/CERT_CI_ECDSA_BRP.der A smdpp/sgp26/CertificateIssuer/CERT_CI_ECDSA_BRP.pem A smdpp/sgp26/CertificateIssuer/CERT_CI_ECDSA_NIST.der A smdpp/sgp26/CertificateIssuer/CERT_CI_ECDSA_NIST.pem A smdpp/sgp26/CertificateIssuer/CI-csr.cnf A smdpp/sgp26/CertificateIssuer/SK_CI_ECDSA_BRP.pem A smdpp/sgp26/CertificateIssuer/SK_CI_ECDSA_NIST.pem A smdpp/sgp26/DPauth/CERT_S_SM_DP2auth_ECDSA_BRP.der A smdpp/sgp26/DPauth/CERT_S_SM_DP2auth_ECDSA_NIST.der A smdpp/sgp26/DPauth/CERT_S_SM_DPauth_ECDSA_BRP.der A smdpp/sgp26/DPauth/CERT_S_SM_DPauth_ECDSA_NIST.der A smdpp/sgp26/DPauth/PK_S_SM_DP2auth_ECDSA_BRP.pem A smdpp/sgp26/DPauth/PK_S_SM_DP2auth_ECDSA_NIST.pem A smdpp/sgp26/DPauth/PK_S_SM_DPauth_ECDSA_BRP.pem A smdpp/sgp26/DPauth/PK_S_SM_DPauth_ECDSA_NIST.pem A smdpp/sgp26/DPauth/SK_S_SM_DP2auth_ECDSA_BRP.pem A smdpp/sgp26/DPauth/SK_S_SM_DP2auth_ECDSA_NIST.pem A smdpp/sgp26/DPauth/SK_S_SM_DPauth_ECDSA_BRP.pem A smdpp/sgp26/DPauth/SK_S_SM_DPauth_ECDSA_NIST.pem A smdpp/sgp26/DPpb/CERT_S_SM_DP2pb_ECDSA_BRP.der A smdpp/sgp26/DPpb/CERT_S_SM_DP2pb_ECDSA_NIST.der A smdpp/sgp26/DPpb/CERT_S_SM_DPpb_ECDSA_BRP.der A smdpp/sgp26/DPpb/CERT_S_SM_DPpb_ECDSA_NIST.der A smdpp/sgp26/DPpb/PK_S_SM_DP2pb_ECDSA_BRP.pem A smdpp/sgp26/DPpb/PK_S_SM_DP2pb_ECDSA_NIST.pem A smdpp/sgp26/DPpb/PK_S_SM_DPpb_ECDSA_BRP.pem A smdpp/sgp26/DPpb/PK_S_SM_DPpb_ECDSA_NIST.pem A smdpp/sgp26/DPpb/SK_S_SM_DP2pb_ECDSA_BRP.pem A smdpp/sgp26/DPpb/SK_S_SM_DP2pb_ECDSA_NIST.pem A smdpp/sgp26/DPpb/SK_S_SM_DPpb_ECDSA_BRP.pem A smdpp/sgp26/DPpb/SK_S_SM_DPpb_ECDSA_NIST.pem A smdpp/sgp26/DPtls/CERT_S_SM_DP2_TLS.csr.cnf A smdpp/sgp26/DPtls/CERT_S_SM_DP2_TLS.der A smdpp/sgp26/DPtls/CERT_S_SM_DP2_TLS.ext.cnf A smdpp/sgp26/DPtls/CERT_S_SM_DP4_TLS.csr.cnf A smdpp/sgp26/DPtls/CERT_S_SM_DP4_TLS.der A smdpp/sgp26/DPtls/CERT_S_SM_DP4_TLS.ext.cnf A smdpp/sgp26/DPtls/CERT_S_SM_DP8_TLS.csr.cnf A smdpp/sgp26/DPtls/CERT_S_SM_DP8_TLS.der A smdpp/sgp26/DPtls/CERT_S_SM_DP8_TLS.ext.cnf A smdpp/sgp26/DPtls/CERT_S_SM_DP_TLS.csr.cnf A smdpp/sgp26/DPtls/CERT_S_SM_DP_TLS.ext.cnf A smdpp/sgp26/DPtls/CERT_S_SM_DP_TLS_BRP.der A smdpp/sgp26/DPtls/CERT_S_SM_DP_TLS_NIST.der A smdpp/sgp26/DPtls/PK_S_SM_DP2_TLS_NIST.pem A smdpp/sgp26/DPtls/PK_S_SM_DP4_TLS.pem A smdpp/sgp26/DPtls/PK_S_SM_DP8_TLS.pem A smdpp/sgp26/DPtls/PK_S_SM_DP_TLS_BRP.pem A smdpp/sgp26/DPtls/PK_S_SM_DP_TLS_NIST.pem A smdpp/sgp26/DPtls/SK_S_SM_DP2_TLS_NIST.pem A smdpp/sgp26/DPtls/SK_S_SM_DP4_TLS.pem A smdpp/sgp26/DPtls/SK_S_SM_DP8_TLS.pem A smdpp/sgp26/DPtls/SK_S_SM_DP_TLS_BRP.pem A smdpp/sgp26/DPtls/SK_S_SM_DP_TLS_NIST.pem A smdpp/sgp26/EUM/CERT_EUM_ECDSA_BRP.der A smdpp/sgp26/EUM/CERT_EUM_ECDSA_NIST.der A smdpp/sgp26/EUM/EUM-csr.cnf A smdpp/sgp26/EUM/EUM-ext.cnf A smdpp/sgp26/EUM/PK_EUM_ECDSA_BRP.pem A smdpp/sgp26/EUM/PK_EUM_ECDSA_NIST.pem A smdpp/sgp26/EUM/SK_EUM_ECDSA_BRP.pem A smdpp/sgp26/EUM/SK_EUM_ECDSA_NIST.pem A smdpp/sgp26/eUICC/CERT_EUICC_ECDSA_BRP.der A smdpp/sgp26/eUICC/CERT_EUICC_ECDSA_NIST.der A smdpp/sgp26/eUICC/PK_EUICC_ECDSA_BRP.pem A smdpp/sgp26/eUICC/PK_EUICC_ECDSA_NIST.pem A smdpp/sgp26/eUICC/SK_EUICC_ECDSA_BRP.pem A smdpp/sgp26/eUICC/SK_EUICC_ECDSA_NIST.pem A smdpp/sgp26/eUICC/eUICC-csr.cnf A smdpp/sgp26/eUICC/eUICC-ext.cnf A smdpp/smdpp_Tests.cfg A smdpp/smdpp_Tests.default A smdpp/smdpp_Tests.ttcn A smdpp/smdpp_Tests_Functions.cc 95 files changed, 10,894 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/19/41119/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3ba163d9155a3b019214dbccc3c8031dfd7deb6b Gerrit-Change-Number: 41119 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>

4 days, 1 hour

[XL] Change in osmo-ttcn3-hacks[master]: smdpp: es9p testsuite

by Jenkins Builder

Attention is currently required from: Hoernchen. Jenkins Builder has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119?usp=email ) Change subject: smdpp: es9p testsuite ...................................................................... Patch Set 3: (756 comments) File smdpp/bsp_crypto.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/034ab0b0_197c… : PS3, Line 37: typedef struct ReplaceSessionKeysRequest_ASN1_st { do not add new typedefs Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/ae8da942_416c… : PS3, Line 38: ASN1_OCTET_STRING* initialMacChainingValue; "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/99e85192_1f5e… : PS3, Line 39: ASN1_OCTET_STRING* ppkEnc; "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/cff04a73_5679… : PS3, Line 40: ASN1_OCTET_STRING* ppkCmac; "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a8950abf_c2fb… : PS3, Line 45: typedef ReplaceSessionKeysRequest_ASN1 ReplaceSessionKeysRequest_outer; do not add new typedefs Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a53dfcd4_df91… : PS3, Line 52: typedef ASN1_INTEGER RemoteOpId; do not add new typedefs Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/6d219379_1201… : PS3, Line 56: typedef struct ControlRefTemplate_st { do not add new typedefs Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/75bc4db3_c8ab… : PS3, Line 57: ASN1_OCTET_STRING* keyType; "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4f047750_c410… : PS3, Line 58: ASN1_OCTET_STRING* keyLen; "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/90641865_f449… : PS3, Line 59: ASN1_OCTET_STRING* hostId; "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/7868b544_ce27… : PS3, Line 65: typedef ASN1_OCTET_STRING SmdpOtpk; do not add new typedefs Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/5069a54f_eb8a… : PS3, Line 68: typedef ASN1_OCTET_STRING SmdpSign; do not add new typedefs Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/20fcaf17_db2c… : PS3, Line 72: typedef struct InitialiseSecureChannelRequest_ASN1_st { do not add new typedefs Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/6fb060d4_4064… : PS3, Line 73: RemoteOpId* remoteOpId; "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/0ce02c31_8881… : PS3, Line 74: ASN1_OCTET_STRING* transactionId; "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/649c210a_796b… : PS3, Line 75: ControlRefTemplate* controlRefTemplate; "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/ce422c35_eb27… : PS3, Line 76: SmdpOtpk* smdpOtpk; "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/75e2884e_04e8… : PS3, Line 77: SmdpSign* smdpSign; "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4bd1b83d_8279… : PS3, Line 83: typedef InitialiseSecureChannelRequest_ASN1 InitialiseSecureChannelRequest_tagged; do not add new typedefs Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/e4391314_e8e9… : PS3, Line 87: typedef ASN1_OCTET_STRING ASN1_OCTET_STRING_TAG7; do not add new typedefs Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/7b16fa0a_dc14… : PS3, Line 88: typedef ASN1_OCTET_STRING ASN1_OCTET_STRING_TAG8; do not add new typedefs Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/0562493c_05c9… : PS3, Line 89: typedef ASN1_OCTET_STRING ASN1_OCTET_STRING_TAG6; do not add new typedefs Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/fec491f0_c0f4… : PS3, Line 100: typedef struct BoundProfilePackage_st { do not add new typedefs Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/06371150_4b0b… : PS3, Line 101: InitialiseSecureChannelRequest_tagged* initialiseSecureChannelRequest; "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/b5d4114a_5cff… : PS3, Line 111: typedef BoundProfilePackage BoundProfilePackage_tagged; do not add new typedefs Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f8ca3563_ddb3… : PS3, Line 116: void operator()(BoundProfilePackage_tagged* ss1) const; Bad function definition - void operator() should probably be void operator(void) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/0fa31feb_286c… : PS3, Line 116: void operator()(BoundProfilePackage_tagged* ss1) const; need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/0c036d18_b931… : PS3, Line 120: void operator()(ReplaceSessionKeysRequest_outer* ss1) const; Bad function definition - void operator() should probably be void operator(void) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/30cb9316_7ff5… : PS3, Line 120: void operator()(ReplaceSessionKeysRequest_outer* ss1) const; need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a9034836_41bf… : PS3, Line 124: void operator()(EVP_CIPHER_CTX* ctx) const { Bad function definition - void operator() should probably be void operator(void) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f48c2eb2_d2b8… : PS3, Line 124: void operator()(EVP_CIPHER_CTX* ctx) const { need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/25189c9e_a4b6… : PS3, Line 131: void operator()(EVP_MAC_CTX* ctx) const { Bad function definition - void operator() should probably be void operator(void) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f5c05fe7_96bd… : PS3, Line 131: void operator()(EVP_MAC_CTX* ctx) const { need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/d6aeca91_5f45… : PS3, Line 138: void operator()(EVP_MAC* mac) const { Bad function definition - void operator() should probably be void operator(void) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/7cd23c5a_6fd5… : PS3, Line 138: void operator()(EVP_MAC* mac) const { need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/99c40788_5e0e… : PS3, Line 144: using BPP_ptr = std::unique_ptr<BoundProfilePackage_tagged, BoundProfilePackage_tagged_Deleter>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/01a3c3b3_c5f2… : PS3, Line 144: using BPP_ptr = std::unique_ptr<BoundProfilePackage_tagged, BoundProfilePackage_tagged_Deleter>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/105a56ca_f644… : PS3, Line 145: using RPK_ptr = std::unique_ptr<ReplaceSessionKeysRequest_outer, ReplaceSessionKeysRequest_outer_Deleter>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/715665f8_f957… : PS3, Line 145: using RPK_ptr = std::unique_ptr<ReplaceSessionKeysRequest_outer, ReplaceSessionKeysRequest_outer_Deleter>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/8a38fd97_8cb6… : PS3, Line 146: using EVP_CIPHER_CTX_unique_ptr = std::unique_ptr<EVP_CIPHER_CTX, EVP_CIPHER_CTX_Deleter>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/10e88037_5e11… : PS3, Line 146: using EVP_CIPHER_CTX_unique_ptr = std::unique_ptr<EVP_CIPHER_CTX, EVP_CIPHER_CTX_Deleter>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/5ce9271a_7e35… : PS3, Line 147: using EVP_MAC_CTX_unique_ptr = std::unique_ptr<EVP_MAC_CTX, EVP_MAC_CTX_Deleter>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/b3e99a8e_e612… : PS3, Line 147: using EVP_MAC_CTX_unique_ptr = std::unique_ptr<EVP_MAC_CTX, EVP_MAC_CTX_Deleter>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/1dbc2058_96b4… : PS3, Line 148: using EVP_MAC_unique_ptr = std::unique_ptr<EVP_MAC, EVP_MAC_Deleter>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/bf082a8a_6d57… : PS3, Line 148: using EVP_MAC_unique_ptr = std::unique_ptr<EVP_MAC, EVP_MAC_Deleter>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/88def918_b12a… : PS3, Line 151: private: labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/9ec7d2a9_bdae… : PS3, Line 156: std::vector<uint8_t> s_enc; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/ff870e36_3bf6… : PS3, Line 156: std::vector<uint8_t> s_enc; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/c865bca2_9bd7… : PS3, Line 156: std::vector<uint8_t> s_enc; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/90f1946e_3811… : PS3, Line 157: std::vector<uint8_t> s_mac; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/96b54ee0_4007… : PS3, Line 157: std::vector<uint8_t> s_mac; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f2ff0f8c_98f3… : PS3, Line 157: std::vector<uint8_t> s_mac; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f4f9fdb4_026a… : PS3, Line 158: std::vector<uint8_t> mac_chain; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f08ee413_c1e0… : PS3, Line 158: std::vector<uint8_t> mac_chain; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/e9eba978_2db5… : PS3, Line 158: std::vector<uint8_t> mac_chain; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/d3f4f859_b17a… : PS3, Line 161: static std::vector<uint8_t> compute_cmac(const std::vector<uint8_t>& key, const std::vector<uint8_t>& data, size_t output_size = AES_BLOCK_SIZE); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/38324929_9d2b… : PS3, Line 161: static std::vector<uint8_t> compute_cmac(const std::vector<uint8_t>& key, const std::vector<uint8_t>& data, size_t output_size = AES_BLOCK_SIZE); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/bd1781f6_9faa… : PS3, Line 161: static std::vector<uint8_t> compute_cmac(const std::vector<uint8_t>& key, const std::vector<uint8_t>& data, size_t output_size = AES_BLOCK_SIZE); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/2ea788db_6707… : PS3, Line 161: static std::vector<uint8_t> compute_cmac(const std::vector<uint8_t>& key, const std::vector<uint8_t>& data, size_t output_size = AES_BLOCK_SIZE); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/e281c008_210d… : PS3, Line 161: static std::vector<uint8_t> compute_cmac(const std::vector<uint8_t>& key, const std::vector<uint8_t>& data, size_t output_size = AES_BLOCK_SIZE); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/397438ca_7f88… : PS3, Line 161: static std::vector<uint8_t> compute_cmac(const std::vector<uint8_t>& key, const std::vector<uint8_t>& data, size_t output_size = AES_BLOCK_SIZE); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/8acb2ff7_4d99… : PS3, Line 161: static std::vector<uint8_t> compute_cmac(const std::vector<uint8_t>& key, const std::vector<uint8_t>& data, size_t output_size = AES_BLOCK_SIZE); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4dc2be6a_e4d1… : PS3, Line 161: static std::vector<uint8_t> compute_cmac(const std::vector<uint8_t>& key, const std::vector<uint8_t>& data, size_t output_size = AES_BLOCK_SIZE); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/da248f91_9ee7… : PS3, Line 161: static std::vector<uint8_t> compute_cmac(const std::vector<uint8_t>& key, const std::vector<uint8_t>& data, size_t output_size = AES_BLOCK_SIZE); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/584ef407_56ae… : PS3, Line 161: static std::vector<uint8_t> compute_cmac(const std::vector<uint8_t>& key, const std::vector<uint8_t>& data, size_t output_size = AES_BLOCK_SIZE); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f573ea2c_e592… : PS3, Line 163: std::vector<uint8_t> aes_cipher_operation(const std::vector<uint8_t>& input, const std::vector<uint8_t>& key, const std::vector<uint8_t>& iv, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/1db3fde1_f313… : PS3, Line 163: std::vector<uint8_t> aes_cipher_operation(const std::vector<uint8_t>& input, const std::vector<uint8_t>& key, const std::vector<uint8_t>& iv, spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a011c5e6_7cb3… : PS3, Line 163: std::vector<uint8_t> aes_cipher_operation(const std::vector<uint8_t>& input, const std::vector<uint8_t>& key, const std::vector<uint8_t>& iv, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/b37a59a9_94a7… : PS3, Line 163: std::vector<uint8_t> aes_cipher_operation(const std::vector<uint8_t>& input, const std::vector<uint8_t>& key, const std::vector<uint8_t>& iv, spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/b2ccb9e6_64fe… : PS3, Line 163: std::vector<uint8_t> aes_cipher_operation(const std::vector<uint8_t>& input, const std::vector<uint8_t>& key, const std::vector<uint8_t>& iv, space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/c2032559_9dd3… : PS3, Line 163: std::vector<uint8_t> aes_cipher_operation(const std::vector<uint8_t>& input, const std::vector<uint8_t>& key, const std::vector<uint8_t>& iv, space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/e01369cc_9735… : PS3, Line 163: std::vector<uint8_t> aes_cipher_operation(const std::vector<uint8_t>& input, const std::vector<uint8_t>& key, const std::vector<uint8_t>& iv, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/aea69a7a_9519… : PS3, Line 163: std::vector<uint8_t> aes_cipher_operation(const std::vector<uint8_t>& input, const std::vector<uint8_t>& key, const std::vector<uint8_t>& iv, spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/91a293b5_b797… : PS3, Line 163: std::vector<uint8_t> aes_cipher_operation(const std::vector<uint8_t>& input, const std::vector<uint8_t>& key, const std::vector<uint8_t>& iv, space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/8d128de9_0d19… : PS3, Line 163: std::vector<uint8_t> aes_cipher_operation(const std::vector<uint8_t>& input, const std::vector<uint8_t>& key, const std::vector<uint8_t>& iv, space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/743066da_b3a9… : PS3, Line 163: std::vector<uint8_t> aes_cipher_operation(const std::vector<uint8_t>& input, const std::vector<uint8_t>& key, const std::vector<uint8_t>& iv, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/2121ebb2_c96f… : PS3, Line 163: std::vector<uint8_t> aes_cipher_operation(const std::vector<uint8_t>& input, const std::vector<uint8_t>& key, const std::vector<uint8_t>& iv, spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/fb165f53_448f… : PS3, Line 163: std::vector<uint8_t> aes_cipher_operation(const std::vector<uint8_t>& input, const std::vector<uint8_t>& key, const std::vector<uint8_t>& iv, space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/60202f82_4d5c… : PS3, Line 163: std::vector<uint8_t> aes_cipher_operation(const std::vector<uint8_t>& input, const std::vector<uint8_t>& key, const std::vector<uint8_t>& iv, space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/93284f9d_c516… : PS3, Line 163: std::vector<uint8_t> aes_cipher_operation(const std::vector<uint8_t>& input, const std::vector<uint8_t>& key, const std::vector<uint8_t>& iv, labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/7cb89f7d_27ed… : PS3, Line 166: static std::vector<uint8_t> encode_bertlv_length(size_t length); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/b6215621_2522… : PS3, Line 166: static std::vector<uint8_t> encode_bertlv_length(size_t length); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/345440d3_24f0… : PS3, Line 168: static void print_hex(const std::string& label, const std::vector<uint8_t>& data); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/9f31f5f9_2bf0… : PS3, Line 168: static void print_hex(const std::string& label, const std::vector<uint8_t>& data); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f9e3255f_25f3… : PS3, Line 168: static void print_hex(const std::string& label, const std::vector<uint8_t>& data); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/cd7c2d93_ea84… : PS3, Line 168: static void print_hex(const std::string& label, const std::vector<uint8_t>& data); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/3352d1b2_42ea… : PS3, Line 168: static void print_hex(const std::string& label, const std::vector<uint8_t>& data); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/c25eefdc_1238… : PS3, Line 169: static void print_hex(const char* label, const unsigned char* data, int len); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/48bf177a_f539… : PS3, Line 169: static void print_hex(const char* label, const unsigned char* data, int len); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/eede3b3a_ef0e… : PS3, Line 171: static std::pair<size_t, size_t> parse_bertlv_length(const std::vector<uint8_t>& data, size_t offset); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4535b47e_fdee… : PS3, Line 171: static std::pair<size_t, size_t> parse_bertlv_length(const std::vector<uint8_t>& data, size_t offset); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a4495066_6928… : PS3, Line 171: static std::pair<size_t, size_t> parse_bertlv_length(const std::vector<uint8_t>& data, size_t offset); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/39463751_c4b3… : PS3, Line 171: static std::pair<size_t, size_t> parse_bertlv_length(const std::vector<uint8_t>& data, size_t offset); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/45bb2164_da32… : PS3, Line 171: static std::pair<size_t, size_t> parse_bertlv_length(const std::vector<uint8_t>& data, size_t offset); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/23a1e8b6_939f… : PS3, Line 171: static std::pair<size_t, size_t> parse_bertlv_length(const std::vector<uint8_t>& data, size_t offset); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/0da9d8bb_ce3d… : PS3, Line 173: std::vector<uint8_t> verify_and_decrypt_helper(const std::vector<uint8_t>& segment, const std::vector<uint8_t>& mac_chain_to_use, bool decrypt); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f29485fb_24f4… : PS3, Line 173: std::vector<uint8_t> verify_and_decrypt_helper(const std::vector<uint8_t>& segment, const std::vector<uint8_t>& mac_chain_to_use, bool decrypt); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/d8dbcb94_f9cd… : PS3, Line 173: std::vector<uint8_t> verify_and_decrypt_helper(const std::vector<uint8_t>& segment, const std::vector<uint8_t>& mac_chain_to_use, bool decrypt); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4c1f2664_a08a… : PS3, Line 173: std::vector<uint8_t> verify_and_decrypt_helper(const std::vector<uint8_t>& segment, const std::vector<uint8_t>& mac_chain_to_use, bool decrypt); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/71f089ee_f574… : PS3, Line 173: std::vector<uint8_t> verify_and_decrypt_helper(const std::vector<uint8_t>& segment, const std::vector<uint8_t>& mac_chain_to_use, bool decrypt); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/06da688e_d215… : PS3, Line 173: std::vector<uint8_t> verify_and_decrypt_helper(const std::vector<uint8_t>& segment, const std::vector<uint8_t>& mac_chain_to_use, bool decrypt); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/1777177a_d3db… : PS3, Line 173: std::vector<uint8_t> verify_and_decrypt_helper(const std::vector<uint8_t>& segment, const std::vector<uint8_t>& mac_chain_to_use, bool decrypt); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/adcfe342_c9ef… : PS3, Line 173: std::vector<uint8_t> verify_and_decrypt_helper(const std::vector<uint8_t>& segment, const std::vector<uint8_t>& mac_chain_to_use, bool decrypt); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/56ed7864_110a… : PS3, Line 173: std::vector<uint8_t> verify_and_decrypt_helper(const std::vector<uint8_t>& segment, const std::vector<uint8_t>& mac_chain_to_use, bool decrypt); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/c30b9856_5d15… : PS3, Line 173: std::vector<uint8_t> verify_and_decrypt_helper(const std::vector<uint8_t>& segment, const std::vector<uint8_t>& mac_chain_to_use, bool decrypt); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/915b8e85_f44b… : PS3, Line 173: std::vector<uint8_t> verify_and_decrypt_helper(const std::vector<uint8_t>& segment, const std::vector<uint8_t>& mac_chain_to_use, bool decrypt); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/6018203a_a1e7… : PS3, Line 175: public: labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/372343ab_b157… : PS3, Line 176: BspCrypto(const std::vector<uint8_t>& s_enc_key, const std::vector<uint8_t>& s_mac_key, const std::vector<uint8_t>& initial_mcv); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/8cf2aaf2_bdc8… : PS3, Line 176: BspCrypto(const std::vector<uint8_t>& s_enc_key, const std::vector<uint8_t>& s_mac_key, const std::vector<uint8_t>& initial_mcv); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/53772930_59c2… : PS3, Line 176: BspCrypto(const std::vector<uint8_t>& s_enc_key, const std::vector<uint8_t>& s_mac_key, const std::vector<uint8_t>& initial_mcv); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/ee40ba10_4d63… : PS3, Line 176: BspCrypto(const std::vector<uint8_t>& s_enc_key, const std::vector<uint8_t>& s_mac_key, const std::vector<uint8_t>& initial_mcv); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/85746722_ccac… : PS3, Line 176: BspCrypto(const std::vector<uint8_t>& s_enc_key, const std::vector<uint8_t>& s_mac_key, const std::vector<uint8_t>& initial_mcv); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/e2603910_7d3f… : PS3, Line 176: BspCrypto(const std::vector<uint8_t>& s_enc_key, const std::vector<uint8_t>& s_mac_key, const std::vector<uint8_t>& initial_mcv); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/44191211_79d4… : PS3, Line 176: BspCrypto(const std::vector<uint8_t>& s_enc_key, const std::vector<uint8_t>& s_mac_key, const std::vector<uint8_t>& initial_mcv); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/16afbd07_179e… : PS3, Line 176: BspCrypto(const std::vector<uint8_t>& s_enc_key, const std::vector<uint8_t>& s_mac_key, const std::vector<uint8_t>& initial_mcv); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/1a054756_0066… : PS3, Line 176: BspCrypto(const std::vector<uint8_t>& s_enc_key, const std::vector<uint8_t>& s_mac_key, const std::vector<uint8_t>& initial_mcv); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/b5dfb2bf_1f88… : PS3, Line 176: BspCrypto(const std::vector<uint8_t>& s_enc_key, const std::vector<uint8_t>& s_mac_key, const std::vector<uint8_t>& initial_mcv); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/0ccde7db_1da6… : PS3, Line 176: BspCrypto(const std::vector<uint8_t>& s_enc_key, const std::vector<uint8_t>& s_mac_key, const std::vector<uint8_t>& initial_mcv); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/aabf9370_53d5… : PS3, Line 176: BspCrypto(const std::vector<uint8_t>& s_enc_key, const std::vector<uint8_t>& s_mac_key, const std::vector<uint8_t>& initial_mcv); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/1ed705ff_1461… : PS3, Line 178: static std::vector<uint8_t> x963_kdf_sha256(const std::vector<uint8_t>& shared_secret, const std::vector<uint8_t>& shared_info, size_t output_length); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/14d3f6a1_15df… : PS3, Line 178: static std::vector<uint8_t> x963_kdf_sha256(const std::vector<uint8_t>& shared_secret, const std::vector<uint8_t>& shared_info, size_t output_length); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/ce110d4f_8057… : PS3, Line 178: static std::vector<uint8_t> x963_kdf_sha256(const std::vector<uint8_t>& shared_secret, const std::vector<uint8_t>& shared_info, size_t output_length); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/fdddd507_4e2d… : PS3, Line 178: static std::vector<uint8_t> x963_kdf_sha256(const std::vector<uint8_t>& shared_secret, const std::vector<uint8_t>& shared_info, size_t output_length); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/2d0adf68_9307… : PS3, Line 178: static std::vector<uint8_t> x963_kdf_sha256(const std::vector<uint8_t>& shared_secret, const std::vector<uint8_t>& shared_info, size_t output_length); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/101be1b5_19fc… : PS3, Line 178: static std::vector<uint8_t> x963_kdf_sha256(const std::vector<uint8_t>& shared_secret, const std::vector<uint8_t>& shared_info, size_t output_length); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/b048a0c2_d74a… : PS3, Line 178: static std::vector<uint8_t> x963_kdf_sha256(const std::vector<uint8_t>& shared_secret, const std::vector<uint8_t>& shared_info, size_t output_length); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/0ac7e5a9_1353… : PS3, Line 178: static std::vector<uint8_t> x963_kdf_sha256(const std::vector<uint8_t>& shared_secret, const std::vector<uint8_t>& shared_info, size_t output_length); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/af06da88_f889… : PS3, Line 178: static std::vector<uint8_t> x963_kdf_sha256(const std::vector<uint8_t>& shared_secret, const std::vector<uint8_t>& shared_info, size_t output_length); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/46711826_d9b4… : PS3, Line 178: static std::vector<uint8_t> x963_kdf_sha256(const std::vector<uint8_t>& shared_secret, const std::vector<uint8_t>& shared_info, size_t output_length); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/5b915b86_6ef6… : PS3, Line 180: static BspCrypto from_kdf(const std::vector<uint8_t>& shared_secret, uint8_t key_type, uint8_t key_length, const std::vector<uint8_t>& host_id, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/35e4bef1_c814… : PS3, Line 180: static BspCrypto from_kdf(const std::vector<uint8_t>& shared_secret, uint8_t key_type, uint8_t key_length, const std::vector<uint8_t>& host_id, spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/06792de5_8113… : PS3, Line 180: static BspCrypto from_kdf(const std::vector<uint8_t>& shared_secret, uint8_t key_type, uint8_t key_length, const std::vector<uint8_t>& host_id, space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a91d2f41_0ee5… : PS3, Line 180: static BspCrypto from_kdf(const std::vector<uint8_t>& shared_secret, uint8_t key_type, uint8_t key_length, const std::vector<uint8_t>& host_id, space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/2c201727_dc3c… : PS3, Line 180: static BspCrypto from_kdf(const std::vector<uint8_t>& shared_secret, uint8_t key_type, uint8_t key_length, const std::vector<uint8_t>& host_id, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/ed2edee4_8e77… : PS3, Line 180: static BspCrypto from_kdf(const std::vector<uint8_t>& shared_secret, uint8_t key_type, uint8_t key_length, const std::vector<uint8_t>& host_id, spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/333f74b2_dc9f… : PS3, Line 180: static BspCrypto from_kdf(const std::vector<uint8_t>& shared_secret, uint8_t key_type, uint8_t key_length, const std::vector<uint8_t>& host_id, space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/446fff48_14de… : PS3, Line 180: static BspCrypto from_kdf(const std::vector<uint8_t>& shared_secret, uint8_t key_type, uint8_t key_length, const std::vector<uint8_t>& host_id, space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/33ab063c_f98e… : PS3, Line 181: const std::vector<uint8_t>& eid); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/7a078d3a_0479… : PS3, Line 181: const std::vector<uint8_t>& eid); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/d81bf201_fb59… : PS3, Line 181: const std::vector<uint8_t>& eid); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/e1e8f7eb_f715… : PS3, Line 181: const std::vector<uint8_t>& eid); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/b6125d42_8860… : PS3, Line 183: std::vector<uint8_t> generate_icv(); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/83b1a756_83e5… : PS3, Line 183: std::vector<uint8_t> generate_icv(); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/0a0a7099_703d… : PS3, Line 183: std::vector<uint8_t> generate_icv(); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/ee8f0cf0_5cf8… : PS3, Line 184: std::vector<uint8_t> add_padding(const std::vector<uint8_t>& data); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/b760a9a8_3383… : PS3, Line 184: std::vector<uint8_t> add_padding(const std::vector<uint8_t>& data); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/c0e08bd1_adfa… : PS3, Line 184: std::vector<uint8_t> add_padding(const std::vector<uint8_t>& data); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/ff6dc842_f738… : PS3, Line 184: std::vector<uint8_t> add_padding(const std::vector<uint8_t>& data); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/23e55c11_ae7d… : PS3, Line 184: std::vector<uint8_t> add_padding(const std::vector<uint8_t>& data); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/37607110_d2ff… : PS3, Line 184: std::vector<uint8_t> add_padding(const std::vector<uint8_t>& data); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/fa5b6a7a_68d9… : PS3, Line 184: std::vector<uint8_t> add_padding(const std::vector<uint8_t>& data); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/852e08d1_0652… : PS3, Line 185: std::vector<uint8_t> remove_padding(const std::vector<uint8_t>& data); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/90b6626d_b725… : PS3, Line 185: std::vector<uint8_t> remove_padding(const std::vector<uint8_t>& data); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/75cfda15_d324… : PS3, Line 185: std::vector<uint8_t> remove_padding(const std::vector<uint8_t>& data); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f230bafa_5047… : PS3, Line 185: std::vector<uint8_t> remove_padding(const std::vector<uint8_t>& data); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/7b28997a_1546… : PS3, Line 185: std::vector<uint8_t> remove_padding(const std::vector<uint8_t>& data); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/d46a78bf_8e4d… : PS3, Line 185: std::vector<uint8_t> remove_padding(const std::vector<uint8_t>& data); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/0d9a64ad_0aeb… : PS3, Line 185: std::vector<uint8_t> remove_padding(const std::vector<uint8_t>& data); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/13d32c46_7dd9… : PS3, Line 186: std::vector<uint8_t> aes_encrypt(const std::vector<uint8_t>& plaintext); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/664f23cf_ebb8… : PS3, Line 186: std::vector<uint8_t> aes_encrypt(const std::vector<uint8_t>& plaintext); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/53d182f5_2b36… : PS3, Line 186: std::vector<uint8_t> aes_encrypt(const std::vector<uint8_t>& plaintext); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/b8bf9582_1f2d… : PS3, Line 186: std::vector<uint8_t> aes_encrypt(const std::vector<uint8_t>& plaintext); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/7d89f1dd_9a79… : PS3, Line 186: std::vector<uint8_t> aes_encrypt(const std::vector<uint8_t>& plaintext); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/42ff59b0_a77c… : PS3, Line 186: std::vector<uint8_t> aes_encrypt(const std::vector<uint8_t>& plaintext); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f79744f1_ce5d… : PS3, Line 186: std::vector<uint8_t> aes_encrypt(const std::vector<uint8_t>& plaintext); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/3174d112_59ea… : PS3, Line 187: std::vector<uint8_t> aes_decrypt_with_icv(const std::vector<uint8_t>& ciphertext, const std::vector<uint8_t>& icv); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/2e6ef1eb_8803… : PS3, Line 187: std::vector<uint8_t> aes_decrypt_with_icv(const std::vector<uint8_t>& ciphertext, const std::vector<uint8_t>& icv); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/0a8f1ffc_7cf8… : PS3, Line 187: std::vector<uint8_t> aes_decrypt_with_icv(const std::vector<uint8_t>& ciphertext, const std::vector<uint8_t>& icv); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f9e5f752_f1a5… : PS3, Line 187: std::vector<uint8_t> aes_decrypt_with_icv(const std::vector<uint8_t>& ciphertext, const std::vector<uint8_t>& icv); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/2354c41a_cf5b… : PS3, Line 187: std::vector<uint8_t> aes_decrypt_with_icv(const std::vector<uint8_t>& ciphertext, const std::vector<uint8_t>& icv); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/d37acac5_0ddb… : PS3, Line 187: std::vector<uint8_t> aes_decrypt_with_icv(const std::vector<uint8_t>& ciphertext, const std::vector<uint8_t>& icv); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/23149fa5_ea55… : PS3, Line 187: std::vector<uint8_t> aes_decrypt_with_icv(const std::vector<uint8_t>& ciphertext, const std::vector<uint8_t>& icv); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/8e49a1fe_a9d1… : PS3, Line 187: std::vector<uint8_t> aes_decrypt_with_icv(const std::vector<uint8_t>& ciphertext, const std::vector<uint8_t>& icv); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/e7f34c73_6343… : PS3, Line 187: std::vector<uint8_t> aes_decrypt_with_icv(const std::vector<uint8_t>& ciphertext, const std::vector<uint8_t>& icv); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/0242dc8c_151b… : PS3, Line 187: std::vector<uint8_t> aes_decrypt_with_icv(const std::vector<uint8_t>& ciphertext, const std::vector<uint8_t>& icv); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/8a0a52fd_5462… : PS3, Line 187: std::vector<uint8_t> aes_decrypt_with_icv(const std::vector<uint8_t>& ciphertext, const std::vector<uint8_t>& icv); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/16bc1526_71c0… : PS3, Line 188: std::vector<uint8_t> generate_icv_for_block(uint32_t block_num); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/7a725e7d_16e9… : PS3, Line 188: std::vector<uint8_t> generate_icv_for_block(uint32_t block_num); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/0a37cfde_53c9… : PS3, Line 188: std::vector<uint8_t> generate_icv_for_block(uint32_t block_num); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/8d810149_65de… : PS3, Line 189: std::vector<uint8_t> compute_mac(uint8_t tag, const std::vector<uint8_t>& data); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/6db32289_8e5e… : PS3, Line 189: std::vector<uint8_t> compute_mac(uint8_t tag, const std::vector<uint8_t>& data); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4da3e84f_84b4… : PS3, Line 189: std::vector<uint8_t> compute_mac(uint8_t tag, const std::vector<uint8_t>& data); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4a885385_bb02… : PS3, Line 189: std::vector<uint8_t> compute_mac(uint8_t tag, const std::vector<uint8_t>& data); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/e5e2b98d_4d0c… : PS3, Line 189: std::vector<uint8_t> compute_mac(uint8_t tag, const std::vector<uint8_t>& data); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/ed2f7b73_5ac7… : PS3, Line 189: std::vector<uint8_t> compute_mac(uint8_t tag, const std::vector<uint8_t>& data); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/22c3b504_6608… : PS3, Line 189: std::vector<uint8_t> compute_mac(uint8_t tag, const std::vector<uint8_t>& data); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/ed25cdc8_8158… : PS3, Line 190: std::vector<uint8_t> encrypt_and_mac_one(uint8_t tag, const std::vector<uint8_t>& plaintext); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/55287f18_9dd8… : PS3, Line 190: std::vector<uint8_t> encrypt_and_mac_one(uint8_t tag, const std::vector<uint8_t>& plaintext); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a202f3b8_36d2… : PS3, Line 190: std::vector<uint8_t> encrypt_and_mac_one(uint8_t tag, const std::vector<uint8_t>& plaintext); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/d399ac85_7718… : PS3, Line 190: std::vector<uint8_t> encrypt_and_mac_one(uint8_t tag, const std::vector<uint8_t>& plaintext); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/d40b0d12_d0bc… : PS3, Line 190: std::vector<uint8_t> encrypt_and_mac_one(uint8_t tag, const std::vector<uint8_t>& plaintext); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/dbb683e7_9794… : PS3, Line 190: std::vector<uint8_t> encrypt_and_mac_one(uint8_t tag, const std::vector<uint8_t>& plaintext); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/647f76f0_6bda… : PS3, Line 190: std::vector<uint8_t> encrypt_and_mac_one(uint8_t tag, const std::vector<uint8_t>& plaintext); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/ea846436_d829… : PS3, Line 191: std::vector<uint8_t> decrypt_and_verify(const std::vector<uint8_t>& segments, bool decrypt = true); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a85e011a_e092… : PS3, Line 191: std::vector<uint8_t> decrypt_and_verify(const std::vector<uint8_t>& segments, bool decrypt = true); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/075be3f2_34e3… : PS3, Line 191: std::vector<uint8_t> decrypt_and_verify(const std::vector<uint8_t>& segments, bool decrypt = true); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f8b71457_09ce… : PS3, Line 191: std::vector<uint8_t> decrypt_and_verify(const std::vector<uint8_t>& segments, bool decrypt = true); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/8be4821f_bc29… : PS3, Line 191: std::vector<uint8_t> decrypt_and_verify(const std::vector<uint8_t>& segments, bool decrypt = true); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/348d5e78_ef1e… : PS3, Line 191: std::vector<uint8_t> decrypt_and_verify(const std::vector<uint8_t>& segments, bool decrypt = true); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/382005c7_194f… : PS3, Line 191: std::vector<uint8_t> decrypt_and_verify(const std::vector<uint8_t>& segments, bool decrypt = true); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/6ee65feb_68c1… : PS3, Line 194: std::vector<uint8_t> ppkEnc; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/ee6af9c1_6e83… : PS3, Line 194: std::vector<uint8_t> ppkEnc; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/ce6420a8_7ad7… : PS3, Line 194: std::vector<uint8_t> ppkEnc; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/863288bc_ae87… : PS3, Line 195: std::vector<uint8_t> ppkCmac; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/191c1a39_09ec… : PS3, Line 195: std::vector<uint8_t> ppkCmac; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a67eb77a_146b… : PS3, Line 195: std::vector<uint8_t> ppkCmac; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4e45272c_63a3… : PS3, Line 196: std::vector<uint8_t> initialMacChainingValue; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/b0444e0c_d8ac… : PS3, Line 196: std::vector<uint8_t> initialMacChainingValue; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/33e0aa7d_165e… : PS3, Line 196: std::vector<uint8_t> initialMacChainingValue; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/2a0e32ce_bbe2… : PS3, Line 199: static std::vector<uint8_t> asn1_octet_string_to_vector(const ASN1_OCTET_STRING* asn1_str); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/1867f991_999e… : PS3, Line 199: static std::vector<uint8_t> asn1_octet_string_to_vector(const ASN1_OCTET_STRING* asn1_str); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/daeaf43f_8354… : PS3, Line 199: static std::vector<uint8_t> asn1_octet_string_to_vector(const ASN1_OCTET_STRING* asn1_str); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a82d0438_77cf… : PS3, Line 200: static ReplaceSessionKeysRequest parse_replace_session_keys(const std::vector<uint8_t>& data); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/9e56ab2b_8aa2… : PS3, Line 200: static ReplaceSessionKeysRequest parse_replace_session_keys(const std::vector<uint8_t>& data); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f2204468_34de… : PS3, Line 200: static ReplaceSessionKeysRequest parse_replace_session_keys(const std::vector<uint8_t>& data); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/c35b6076_3aae… : PS3, Line 200: static ReplaceSessionKeysRequest parse_replace_session_keys(const std::vector<uint8_t>& data); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/b01c50da_7777… : PS3, Line 201: static BspCrypto from_replace_session_keys(const ReplaceSessionKeysRequest& rsk); need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/566df727_9a05… : PS3, Line 204: std::vector<uint8_t> configureIsdp; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/cd63ede1_e8bb… : PS3, Line 204: std::vector<uint8_t> configureIsdp; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/7013d4c5_24de… : PS3, Line 204: std::vector<uint8_t> configureIsdp; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/83c81b56_5f0b… : PS3, Line 205: std::vector<uint8_t> storeMetadata; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f48d88ae_8448… : PS3, Line 205: std::vector<uint8_t> storeMetadata; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/1b38be18_8cf5… : PS3, Line 205: std::vector<uint8_t> storeMetadata; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/90e8a227_9e1b… : PS3, Line 207: std::vector<uint8_t> profileData; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/8244b371_f2e8… : PS3, Line 207: std::vector<uint8_t> profileData; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a6fe78bd_5b4d… : PS3, Line 207: std::vector<uint8_t> profileData; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/241b5b29_d650… : PS3, Line 211: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& allofit); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4e40ca38_422c… : PS3, Line 211: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& allofit); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/cd80c8f5_556b… : PS3, Line 211: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& allofit); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/9d2ac8ea_e943… : PS3, Line 211: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& allofit); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/14a4d069_0fcf… : PS3, Line 211: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& allofit); function definition argument 'uint8_t' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/e795d367_0eec… : PS3, Line 213: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& firstSequenceOf87, const std::vector<uint8_t>& sequenceOf88, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/46e290f5_d8f3… : PS3, Line 213: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& firstSequenceOf87, const std::vector<uint8_t>& sequenceOf88, spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/5538ee66_063c… : PS3, Line 213: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& firstSequenceOf87, const std::vector<uint8_t>& sequenceOf88, space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/d9d09a99_5c41… : PS3, Line 213: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& firstSequenceOf87, const std::vector<uint8_t>& sequenceOf88, space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4a3c62d2_5a16… : PS3, Line 213: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& firstSequenceOf87, const std::vector<uint8_t>& sequenceOf88, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/aaf2056a_b2b4… : PS3, Line 213: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& firstSequenceOf87, const std::vector<uint8_t>& sequenceOf88, spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/6250a26e_893a… : PS3, Line 213: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& firstSequenceOf87, const std::vector<uint8_t>& sequenceOf88, space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/341b2d73_0426… : PS3, Line 213: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& firstSequenceOf87, const std::vector<uint8_t>& sequenceOf88, space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/509bb231_f37a… : PS3, Line 213: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& firstSequenceOf87, const std::vector<uint8_t>& sequenceOf88, function definition argument 'uint8_t' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/5ceef60b_b52a… : PS3, Line 213: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& firstSequenceOf87, const std::vector<uint8_t>& sequenceOf88, function definition argument 'uint8_t' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/2b4dd2bc_cbfe… : PS3, Line 213: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& firstSequenceOf87, const std::vector<uint8_t>& sequenceOf88, function definition argument 'uint8_t' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/c8490094_2529… : PS3, Line 213: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& firstSequenceOf87, const std::vector<uint8_t>& sequenceOf88, function definition argument 'uint8_t' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/b8641895_7ecd… : PS3, Line 214: const std::vector<uint8_t>& secondSequenceOf87, const std::vector<uint8_t>& sequenceOf86); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/bd6c860e_45bf… : PS3, Line 214: const std::vector<uint8_t>& secondSequenceOf87, const std::vector<uint8_t>& sequenceOf86); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/768c02b3_5141… : PS3, Line 214: const std::vector<uint8_t>& secondSequenceOf87, const std::vector<uint8_t>& sequenceOf86); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/e53192e3_31e7… : PS3, Line 214: const std::vector<uint8_t>& secondSequenceOf87, const std::vector<uint8_t>& sequenceOf86); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/60cac5c9_ea02… : PS3, Line 214: const std::vector<uint8_t>& secondSequenceOf87, const std::vector<uint8_t>& sequenceOf86); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/b2eff16d_eaad… : PS3, Line 214: const std::vector<uint8_t>& secondSequenceOf87, const std::vector<uint8_t>& sequenceOf86); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/d47240a3_921a… : PS3, Line 214: const std::vector<uint8_t>& secondSequenceOf87, const std::vector<uint8_t>& sequenceOf86); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/2f5bac88_5f0f… : PS3, Line 214: const std::vector<uint8_t>& secondSequenceOf87, const std::vector<uint8_t>& sequenceOf86); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/bf67dadb_9db7… : PS3, Line 216: void reset(const std::vector<uint8_t>& initial_mcv); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f48232c2_45d6… : PS3, Line 216: void reset(const std::vector<uint8_t>& initial_mcv); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/1490cc01_e6b0… : PS3, Line 216: void reset(const std::vector<uint8_t>& initial_mcv); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/7979e45a_ab6f… : PS3, Line 216: void reset(const std::vector<uint8_t>& initial_mcv); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/7fae59b8_3f0c… : PS3, Line 216: void reset(const std::vector<uint8_t>& initial_mcv); function definition argument 'uint8_t' should also have an identifier name Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/d6dc190d_43b7… : PS3, Line 218: static std::vector<uint8_t> generate_replace_session_keys_data(const std::vector<uint8_t>& ppk_enc, const std::vector<uint8_t>& ppk_mac, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/b63ee1a1_ef7b… : PS3, Line 218: static std::vector<uint8_t> generate_replace_session_keys_data(const std::vector<uint8_t>& ppk_enc, const std::vector<uint8_t>& ppk_mac, spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/7fc57122_c5a9… : PS3, Line 218: static std::vector<uint8_t> generate_replace_session_keys_data(const std::vector<uint8_t>& ppk_enc, const std::vector<uint8_t>& ppk_mac, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/904f6054_7ac1… : PS3, Line 218: static std::vector<uint8_t> generate_replace_session_keys_data(const std::vector<uint8_t>& ppk_enc, const std::vector<uint8_t>& ppk_mac, spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/e97723b7_2114… : PS3, Line 218: static std::vector<uint8_t> generate_replace_session_keys_data(const std::vector<uint8_t>& ppk_enc, const std::vector<uint8_t>& ppk_mac, space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/0b954d16_c8fb… : PS3, Line 218: static std::vector<uint8_t> generate_replace_session_keys_data(const std::vector<uint8_t>& ppk_enc, const std::vector<uint8_t>& ppk_mac, space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/ad99ea55_189a… : PS3, Line 218: static std::vector<uint8_t> generate_replace_session_keys_data(const std::vector<uint8_t>& ppk_enc, const std::vector<uint8_t>& ppk_mac, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/9fa01bf4_9c96… : PS3, Line 218: static std::vector<uint8_t> generate_replace_session_keys_data(const std::vector<uint8_t>& ppk_enc, const std::vector<uint8_t>& ppk_mac, spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/7c486e5e_0b2e… : PS3, Line 218: static std::vector<uint8_t> generate_replace_session_keys_data(const std::vector<uint8_t>& ppk_enc, const std::vector<uint8_t>& ppk_mac, space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/71ed1690_1a0b… : PS3, Line 218: static std::vector<uint8_t> generate_replace_session_keys_data(const std::vector<uint8_t>& ppk_enc, const std::vector<uint8_t>& ppk_mac, space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/76bd8f4d_5cbb… : PS3, Line 219: const std::vector<uint8_t>& initial_mcv); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/d782c932_c69a… : PS3, Line 219: const std::vector<uint8_t>& initial_mcv); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/300a56cd_201c… : PS3, Line 219: const std::vector<uint8_t>& initial_mcv); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/7097f6ff_4db1… : PS3, Line 219: const std::vector<uint8_t>& initial_mcv); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/6d67a92c_1688… : PS3, Line 221: std::vector<uint8_t> mac_only_one(uint8_t tag, const std::vector<uint8_t>& plaintext); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f47174eb_f9ab… : PS3, Line 221: std::vector<uint8_t> mac_only_one(uint8_t tag, const std::vector<uint8_t>& plaintext); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/9848c086_0471… : PS3, Line 221: std::vector<uint8_t> mac_only_one(uint8_t tag, const std::vector<uint8_t>& plaintext); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a0cc8205_bc89… : PS3, Line 221: std::vector<uint8_t> mac_only_one(uint8_t tag, const std::vector<uint8_t>& plaintext); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/8774ee02_2afc… : PS3, Line 221: std::vector<uint8_t> mac_only_one(uint8_t tag, const std::vector<uint8_t>& plaintext); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/7e1635a4_7ae5… : PS3, Line 221: std::vector<uint8_t> mac_only_one(uint8_t tag, const std::vector<uint8_t>& plaintext); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/1d04ff22_141c… : PS3, Line 221: std::vector<uint8_t> mac_only_one(uint8_t tag, const std::vector<uint8_t>& plaintext); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/cf610898_d6be… : PS3, Line 222: std::vector<std::vector<uint8_t>> encrypt_and_mac_seg(uint8_t tag, const std::vector<uint8_t>& data); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/6350907e_d1dc… : PS3, Line 222: std::vector<std::vector<uint8_t>> encrypt_and_mac_seg(uint8_t tag, const std::vector<uint8_t>& data); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/ee5ff32b_7677… : PS3, Line 222: std::vector<std::vector<uint8_t>> encrypt_and_mac_seg(uint8_t tag, const std::vector<uint8_t>& data); need consistent spacing around '>>' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/fff7a8bb_b8f4… : PS3, Line 222: std::vector<std::vector<uint8_t>> encrypt_and_mac_seg(uint8_t tag, const std::vector<uint8_t>& data); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/001ca2f0_3dc8… : PS3, Line 222: std::vector<std::vector<uint8_t>> encrypt_and_mac_seg(uint8_t tag, const std::vector<uint8_t>& data); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/bdac362d_50ca… : PS3, Line 222: std::vector<std::vector<uint8_t>> encrypt_and_mac_seg(uint8_t tag, const std::vector<uint8_t>& data); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/bbdcfb86_54a5… : PS3, Line 222: std::vector<std::vector<uint8_t>> encrypt_and_mac_seg(uint8_t tag, const std::vector<uint8_t>& data); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/3f1e8990_21cf… : PS3, Line 222: std::vector<std::vector<uint8_t>> encrypt_and_mac_seg(uint8_t tag, const std::vector<uint8_t>& data); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/c1193ecf_d8eb… : PS3, Line 223: std::vector<std::vector<uint8_t>> mac_only_seg(uint8_t tag, const std::vector<uint8_t>& data); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/ddb1235a_7154… : PS3, Line 223: std::vector<std::vector<uint8_t>> mac_only_seg(uint8_t tag, const std::vector<uint8_t>& data); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/ed2f2779_1a2f… : PS3, Line 223: std::vector<std::vector<uint8_t>> mac_only_seg(uint8_t tag, const std::vector<uint8_t>& data); need consistent spacing around '>>' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/d2ee5c85_a427… : PS3, Line 223: std::vector<std::vector<uint8_t>> mac_only_seg(uint8_t tag, const std::vector<uint8_t>& data); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/fc0bcf2a_8fb5… : PS3, Line 223: std::vector<std::vector<uint8_t>> mac_only_seg(uint8_t tag, const std::vector<uint8_t>& data); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a4480c48_e77b… : PS3, Line 223: std::vector<std::vector<uint8_t>> mac_only_seg(uint8_t tag, const std::vector<uint8_t>& data); space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/26392380_5294… : PS3, Line 223: std::vector<std::vector<uint8_t>> mac_only_seg(uint8_t tag, const std::vector<uint8_t>& data); space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/0dd024c9_f897… : PS3, Line 223: std::vector<std::vector<uint8_t>> mac_only_seg(uint8_t tag, const std::vector<uint8_t>& data); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/b4e6788b_6fbc… : PS3, Line 228: #endif // BSP_CRYPTO_H adding a line without newline at end of file File smdpp/helpers.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/6661783a_86ac… : PS3, Line 1: std::ostream& operator<<(std::ostream& os, const std::vector<std::string>& v) { need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4a46b32e_0a2d… : PS3, Line 1: std::ostream& operator<<(std::ostream& os, const std::vector<std::string>& v) { need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a6626671_883a… : PS3, Line 1: std::ostream& operator<<(std::ostream& os, const std::vector<std::string>& v) { spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/ae6f5fe4_1423… : PS3, Line 1: std::ostream& operator<<(std::ostream& os, const std::vector<std::string>& v) { spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/08683959_7c9e… : PS3, Line 1: std::ostream& operator<<(std::ostream& os, const std::vector<std::string>& v) { space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/69b56fe7_5c87… : PS3, Line 1: std::ostream& operator<<(std::ostream& os, const std::vector<std::string>& v) { space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/c891de15_5ae4… : PS3, Line 3: copy(v.begin(), v.end(), std::ostream_iterator<std::string>(os, "\n")); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/49700964_3ae2… : PS3, Line 3: copy(v.begin(), v.end(), std::ostream_iterator<std::string>(os, "\n")); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/257e2a0a_c4eb… : PS3, Line 7: std::string to_string(const std::vector<std::string>& vec) { spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/1102128c_07ef… : PS3, Line 7: std::string to_string(const std::vector<std::string>& vec) { spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a1315dbb_0e73… : PS3, Line 7: std::string to_string(const std::vector<std::string>& vec) { space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/edd99d71_2049… : PS3, Line 7: std::string to_string(const std::vector<std::string>& vec) { space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/1f634530_2f7b… : PS3, Line 8: std::ostringstream oss; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/dad93a9e_6349… : PS3, Line 13: std::string operator+(const std::string& str, const std::vector<std::string>& vec) { need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/2ca97925_65a1… : PS3, Line 13: std::string operator+(const std::string& str, const std::vector<std::string>& vec) { spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/8328a22d_b7cb… : PS3, Line 13: std::string operator+(const std::string& str, const std::vector<std::string>& vec) { spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/1f38aed5_bd95… : PS3, Line 13: std::string operator+(const std::string& str, const std::vector<std::string>& vec) { space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/cebf6381_2d64… : PS3, Line 13: std::string operator+(const std::string& str, const std::vector<std::string>& vec) { space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/6d8b16cf_1166… : PS3, Line 17: std::string operator+(const std::vector<std::string>& vec, const std::string& str) { spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/827d2bd4_9c16… : PS3, Line 17: std::string operator+(const std::vector<std::string>& vec, const std::string& str) { spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/ba422bff_d977… : PS3, Line 17: std::string operator+(const std::vector<std::string>& vec, const std::string& str) { space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/1e216053_485a… : PS3, Line 17: std::string operator+(const std::vector<std::string>& vec, const std::string& str) { space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/c2f443fc_e979… : PS3, Line 17: std::string operator+(const std::vector<std::string>& vec, const std::string& str) { need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/44e101f2_73d1… : PS3, Line 24: void operator()(BIO* bio) const { Bad function definition - void operator() should probably be void operator(void) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/8dc25602_178c… : PS3, Line 24: void operator()(BIO* bio) const { need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/dd47373d_d475… : PS3, Line 30: void operator()(X509* cert) const { Bad function definition - void operator() should probably be void operator(void) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/0641b90f_4131… : PS3, Line 30: void operator()(X509* cert) const { need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/60cc4f02_03bc… : PS3, Line 36: void operator()(X509_STORE* store) const { Bad function definition - void operator() should probably be void operator(void) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/5743e0f9_d6bc… : PS3, Line 36: void operator()(X509_STORE* store) const { need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/e63ab76b_c064… : PS3, Line 42: void operator()(X509_STORE_CTX* ctx) const { Bad function definition - void operator() should probably be void operator(void) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/ff08cfc9_6b1b… : PS3, Line 42: void operator()(X509_STORE_CTX* ctx) const { need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a978fe13_87c8… : PS3, Line 48: void operator()(EVP_PKEY* key) const { Bad function definition - void operator() should probably be void operator(void) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/091cb884_cd44… : PS3, Line 48: void operator()(EVP_PKEY* key) const { need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/828b67f6_4e8f… : PS3, Line 54: void operator()(EVP_MD_CTX* ctx) const { Bad function definition - void operator() should probably be void operator(void) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/0b3db1b1_051f… : PS3, Line 54: void operator()(EVP_MD_CTX* ctx) const { need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f0a99886_3790… : PS3, Line 60: public: labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/46bda686_09c6… : PS3, Line 61: static std::vector<uint8_t> decode(const std::string& b64message) { spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a5864f62_7df7… : PS3, Line 61: static std::vector<uint8_t> decode(const std::string& b64message) { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/15f9d4ec_f5e4… : PS3, Line 61: static std::vector<uint8_t> decode(const std::string& b64message) { need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/bbf8dadb_c681… : PS3, Line 62: if (b64message.empty()) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f4133503_8e7b… : PS3, Line 68: if (b64message[b64message.size() - 1] == '=' && b64message[b64message.size() - 2] == '=') { braces {} are not necessary for any arm of this statement Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/045ddc19_7ebc… : PS3, Line 76: std::vector<uint8_t> buffer(decodeLen); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/5882efe1_e2f4… : PS3, Line 76: std::vector<uint8_t> buffer(decodeLen); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/35d82c8c_c752… : PS3, Line 76: std::vector<uint8_t> buffer(decodeLen); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/2596d366_e86b… : PS3, Line 78: BIO* b64 = BIO_new(BIO_f_base64()); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/8989ea2b_0222… : PS3, Line 81: BIO* mem = BIO_new_mem_buf(b64message.c_str(), -1); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/6ae0d549_a128… : PS3, Line 82: BIO* bioChain = BIO_push(b64, mem); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/00f5cb49_3ec0… : PS3, Line 84: std::unique_ptr<BIO, BIODeleter> bioPtr(bioChain); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f6d3ec03_f7db… : PS3, Line 84: std::unique_ptr<BIO, BIODeleter> bioPtr(bioChain); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/548ee647_c485… : PS3, Line 84: std::unique_ptr<BIO, BIODeleter> bioPtr(bioChain); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/be143e06_503b… : PS3, Line 87: if (length <= 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/478aabf2_b600… : PS3, Line 95: static std::string encode(const std::vector<uint8_t>& data) { spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/1719e61c_3748… : PS3, Line 95: static std::string encode(const std::vector<uint8_t>& data) { spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/aa7a1497_c325… : PS3, Line 95: static std::string encode(const std::vector<uint8_t>& data) { space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/3caa83fe_6e6e… : PS3, Line 95: static std::string encode(const std::vector<uint8_t>& data) { space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4a6bbcb1_0b6b… : PS3, Line 96: if (data.empty()) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/72d12d13_9b6e… : PS3, Line 100: BIO* b64 = BIO_new(BIO_f_base64()); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/2156ba8b_b10b… : PS3, Line 103: BIO* mem = BIO_new(BIO_s_mem()); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a6aee72e_6760… : PS3, Line 104: BIO* bioChain = BIO_push(b64, mem); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/c9c89828_0b99… : PS3, Line 106: std::unique_ptr<BIO, BIODeleter> bioPtr(bioChain); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/b82ab172_48fe… : PS3, Line 106: std::unique_ptr<BIO, BIODeleter> bioPtr(bioChain); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/20fb7cd8_1be6… : PS3, Line 106: std::unique_ptr<BIO, BIODeleter> bioPtr(bioChain); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/28e79e06_5d00… : PS3, Line 111: BUF_MEM* bufferPtr; "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/e8482a6a_76c1… : PS3, Line 119: public: labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a889790d_bed9… : PS3, Line 120: static std::vector<uint8_t> hexToBytes(const std::string& hex) { spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4468896e_73ae… : PS3, Line 120: static std::vector<uint8_t> hexToBytes(const std::string& hex) { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f587c7b4_98c3… : PS3, Line 120: static std::vector<uint8_t> hexToBytes(const std::string& hex) { need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/c57a815d_e3a2… : PS3, Line 121: if (hex.length() % 2 != 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/1dd9c79c_5814… : PS3, Line 125: std::vector<uint8_t> bytes(hex.length() / 2); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/e970c493_38b5… : PS3, Line 125: std::vector<uint8_t> bytes(hex.length() / 2); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/9fb6406b_38aa… : PS3, Line 125: std::vector<uint8_t> bytes(hex.length() / 2); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/e82d1207_e5b0… : PS3, Line 126: for (size_t i = 0; i < bytes.size(); ++i) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4a4c3fa1_5fd3… : PS3, Line 127: sscanf(hex.c_str() + (i * 2), "%2hhx", &bytes[i]); unchecked sscanf return value Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4857bb1a_ae38… : PS3, Line 133: static std::string bytesToHex(const std::vector<uint8_t>& bytes) { spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/7f4c2016_bd3d… : PS3, Line 133: static std::string bytesToHex(const std::vector<uint8_t>& bytes) { spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/224b8e7a_07c4… : PS3, Line 133: static std::string bytesToHex(const std::vector<uint8_t>& bytes) { space required before that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/9238e06c_81d9… : PS3, Line 133: static std::string bytesToHex(const std::vector<uint8_t>& bytes) { space prohibited after that '&' (ctx:OxW) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/438d721f_05cb… : PS3, Line 137: static std::string bytesToHex(const uint8_t* data, size_t length) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/cc692d4e_01dc… : PS3, Line 138: std::stringstream ss; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/645146e3_0254… : PS3, Line 141: for (size_t i = 0; i < length; ++i) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/85ccbc20_bd3a… : PS3, Line 142: ss << std::setw(2) << static_cast<int>(data[i]); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a181d15d_84ab… : PS3, Line 142: ss << std::setw(2) << static_cast<int>(data[i]); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/dfc326a6_dc52… : PS3, Line 149: } // namespace RspCrypto adding a line without newline at end of file File smdpp/logger.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/32b6f165_799d… : PS3, Line 63: public: labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/95e55caa_a1f5… : PS3, Line 66: static void log(Level level, const std::string& message, const char* filename = nullptr, int line = 0) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/2c803fe5_a7b1… : PS3, Line 66: static void log(Level level, const std::string& message, const char* filename = nullptr, int line = 0) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f98fd16f_af12… : PS3, Line 66: static void log(Level level, const std::string& message, const char* filename = nullptr, int line = 0) { need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f61164bb_c4ac… : PS3, Line 70: std::string levelStr; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/2bdcbaea_ee84… : PS3, Line 72: case Level::DEBUG: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/870bea1e_c381… : PS3, Line 75: case Level::INFO: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/bfa25100_58e6… : PS3, Line 78: case Level::WARNING: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/54f29429_21e1… : PS3, Line 81: case Level::ERROR: spaces required around that ':' (ctx:VxE) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/9e34a198_ef99… : PS3, Line 86: std::stringstream ss; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/949e6efb_8cb1… : PS3, Line 92: const char* base_filename = strrchr(filename, '/'); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/674c87ac_0b49… : PS3, Line 93: if (!base_filename) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/ec5218d3_9e5a… : PS3, Line 103: std::cout << ss.str() << std::endl; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4100683d_73f2… : PS3, Line 106: static void debug(const std::string& message, const char* filename = nullptr, int line = 0) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/66e9ed40_e4b0… : PS3, Line 106: static void debug(const std::string& message, const char* filename = nullptr, int line = 0) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/34744c01_94aa… : PS3, Line 106: static void debug(const std::string& message, const char* filename = nullptr, int line = 0) { need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a34e228d_9fc1… : PS3, Line 110: static void info(const std::string& message, const char* filename = nullptr, int line = 0) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/63f484cf_05dc… : PS3, Line 110: static void info(const std::string& message, const char* filename = nullptr, int line = 0) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/863af032_fe0e… : PS3, Line 110: static void info(const std::string& message, const char* filename = nullptr, int line = 0) { need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/14a34010_95a4… : PS3, Line 114: static void warning(const std::string& message, const char* filename = nullptr, int line = 0) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/862e9dd2_2e5e… : PS3, Line 114: static void warning(const std::string& message, const char* filename = nullptr, int line = 0) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/c7326c41_7b4c… : PS3, Line 114: static void warning(const std::string& message, const char* filename = nullptr, int line = 0) { need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/9d75a1fb_8f67… : PS3, Line 118: static void error(const std::string& message, const char* filename = nullptr, int line = 0) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/19420985_5a36… : PS3, Line 118: static void error(const std::string& message, const char* filename = nullptr, int line = 0) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/735a90ca_36a0… : PS3, Line 118: static void error(const std::string& message, const char* filename = nullptr, int line = 0) { need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/befb22c2_b4f3… : PS3, Line 130: public: labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/c6be10c6_3219… : PS3, Line 131: OpenSSLError(const std::string& message) : std::runtime_error(message + getOpenSSLErrors()) { need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/8b50e89f_cef8… : PS3, Line 134: private: labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/3a7f3eb5_635f… : PS3, Line 136: std::stringstream ss; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/bfc01376_8515… : PS3, Line 141: char* err_str = ERR_error_string(err, nullptr); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/bc113fd8_ba8d… : PS3, Line 150: public: labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/bbf5bf9e_0c3c… : PS3, Line 153: std::stringstream errorStream; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/0ede3f58_0e54… : PS3, Line 160: const char* library = ERR_lib_error_string(errorCode); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/149dc3fb_8303… : PS3, Line 163: const char* function = ERR_func_error_string(errorCode); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/8c7ef797_41b5… : PS3, Line 165: const char* reason = ERR_reason_error_string(errorCode); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/72f92cc2_abdf… : PS3, Line 181: static std::string getSSLError(SSL* ssl, int result) { need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/8ee35353_8f37… : PS3, Line 183: std::stringstream errorStream; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/c33cc9b1_fb01… : PS3, Line 190: std::string queueErrors = getLastError(); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/0655e940_02fb… : PS3, Line 191: if (!queueErrors.empty()) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/2c2c1ecb_410e… : PS3, Line 199: std::stringstream errorStream; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/dcda3576_d5d2… : PS3, Line 202: const char* errorString = X509_verify_cert_error_string(verifyResult); "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/d6d04c98_3c85… : PS3, Line 211: static void printSSLErrors(const std::string& context = "") { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/72d7851a_f82b… : PS3, Line 211: static void printSSLErrors(const std::string& context = "") { need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/0a244631_60d1… : PS3, Line 212: if (!context.empty()) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/17a5962f_cc36… : PS3, Line 213: std::cerr << "=== " << context << " ===" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4d7c7caf_55d7… : PS3, Line 216: std::string errors = getLastError(); labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4e8570b3_df01… : PS3, Line 217: if (!errors.empty()) { braces {} are not necessary for any arm of this statement Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/7ed0d3f5_3429… : PS3, Line 218: std::cerr << errors << std::endl; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/937e442a_44f4… : PS3, Line 220: std::cerr << "No OpenSSL errors in queue." << std::endl; labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/dabae21a_99a2… : PS3, Line 224: private: labels should not be indented Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/dda8edcd_8006… : PS3, Line 251: } // namespace RspCrypto adding a line without newline at end of file File smdpp/sgp26/CertificateIssuer/CERT_CI_ECDSA_BRP.pem: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/b2b4b547_223b… : PS3, Line 1: -----BEGIN CERTIFICATE----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/28c29979_d849… : PS3, Line 2: MIICUTCCAfigAwIBAgIJALh086v6bETTMAoGCCqGSM49BAMCMEQxEDAOBgNVBAMM DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/0d66f96f_43a5… : PS3, Line 3: B1Rlc3QgQ0kxETAPBgNVBAsMCFRFU1RDRVJUMRAwDgYDVQQKDAdSU1BURVNUMQsw DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4e3cb76a_aecd… : PS3, Line 4: CQYDVQQGEwJJVDAgFw0yMDA0MDEwODI3NTFaGA8yMDU1MDQwMTA4Mjc1MVowRDEQ DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/18dc5346_2f91… : PS3, Line 5: MA4GA1UEAwwHVGVzdCBDSTERMA8GA1UECwwIVEVTVENFUlQxEDAOBgNVBAoMB1JT DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a2da6d97_193e… : PS3, Line 6: UFRFU1QxCzAJBgNVBAYTAklUMFowFAYHKoZIzj0CAQYJKyQDAwIIAQEHA0IABCeH DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/716a3603_85b0… : PS3, Line 7: tNVu2CSp5r4E4Yh/a5i6/rjHY/UoN/cBE+k2Tt2+E5vAx95+Fo8eXNDBhTT8UGTm DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/ed110c02_d639… : PS3, Line 8: T2htxTMnyn8dzqhaKZSjgc8wgcwwHQYDVR0OBBYEFMC8cLo2kp1DtGf/V1cFMOV6 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/731c44b0_ec73… : PS3, Line 9: uPzYMA8GA1UdEwEB/wQFMAMBAf8wFwYDVR0gAQH/BA0wCzAJBgdngRIBAgEAMA4G DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/c96333f7_9d49… : PS3, Line 10: A1UdDwEB/wQEAwIBBjAOBgNVHREEBzAFiAOINwEwYQYDVR0fBFowWDAqoCigJoYk DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4ffcfcf7_f452… : PS3, Line 11: aHR0cDovL2NpLnRlc3QuZXhhbXBsZS5jb20vQ1JMLUEuY3JsMCqgKKAmhiRodHRw DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/2c0b0ee2_13fc… : PS3, Line 12: Oi8vY2kudGVzdC5leGFtcGxlLmNvbS9DUkwtQi5jcmwwCgYIKoZIzj0EAwIDRwAw DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/e4090af6_2012… : PS3, Line 13: RAIgPYrf0CKl0FBMUaHx5xS1duTDbQ4wBZN3qKBeNniuux0CIHBek2vLfoANAdtt DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/1f66093a_c27b… : PS3, Line 14: f5u5Ce6DVC2oIfpn5UnS24F3oMqM DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/57484946_43af… : PS3, Line 15: -----END CERTIFICATE----- DOS line endings File smdpp/sgp26/CertificateIssuer/CERT_CI_ECDSA_NIST.pem: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/cf950d1b_b2f1… : PS3, Line 1: -----BEGIN CERTIFICATE----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/59e3c601_55a0… : PS3, Line 2: MIICUDCCAfegAwIBAgIJALh086v6bETTMAoGCCqGSM49BAMCMEQxEDAOBgNVBAMM DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/3f596b2b_9fc7… : PS3, Line 3: B1Rlc3QgQ0kxETAPBgNVBAsMCFRFU1RDRVJUMRAwDgYDVQQKDAdSU1BURVNUMQsw DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/264b871a_3243… : PS3, Line 4: CQYDVQQGEwJJVDAgFw0yMDA0MDEwODI3NTFaGA8yMDU1MDQwMTA4Mjc1MVowRDEQ DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/173e5b2c_6d78… : PS3, Line 5: MA4GA1UEAwwHVGVzdCBDSTERMA8GA1UECwwIVEVTVENFUlQxEDAOBgNVBAoMB1JT DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/bd9edb62_6bd4… : PS3, Line 6: UFRFU1QxCzAJBgNVBAYTAklUMFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAElAZX DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/23562acb_b68d… : PS3, Line 7: pnPcKI+J1S6opHcEmSeR+cNLADbmM+LQy6lFTWXbMusXmBeZ0vJDiO4rlcEJRUbJ DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/0938cfde_1180… : PS3, Line 8: eQHOrrqWUJGaLiDSKaOBzzCBzDAdBgNVHQ4EFgQU9UFyvfmKldZcvriKOKHBHYAK DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/80674715_295f… : PS3, Line 9: hcMwDwYDVR0TAQH/BAUwAwEB/zAXBgNVHSABAf8EDTALMAkGB2eBEgECAQAwDgYD DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/06ed61a8_2af6… : PS3, Line 10: VR0PAQH/BAQDAgEGMA4GA1UdEQQHMAWIA4g3ATBhBgNVHR8EWjBYMCqgKKAmhiRo DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/097c5983_24b5… : PS3, Line 11: dHRwOi8vY2kudGVzdC5leGFtcGxlLmNvbS9DUkwtQS5jcmwwKqAooCaGJGh0dHA6 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/1aa9cb20_5a2c… : PS3, Line 12: Ly9jaS50ZXN0LmV4YW1wbGUuY29tL0NSTC1CLmNybDAKBggqhkjOPQQDAgNHADBE DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/9f6219e9_ee72… : PS3, Line 13: AiBSdWqvwgIKbOy/Ll88IIklEP8pdR0pi9OwFdlgWk/mfQIgV5goNuTSBd3S5sPB DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/b56a8b95_1ce4… : PS3, Line 14: tFWTf2tuSTtgL9G2bDV0iak192s= DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/843a88e4_8f87… : PS3, Line 15: -----END CERTIFICATE----- DOS line endings File smdpp/sgp26/CertificateIssuer/CI-csr.cnf: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/c7144510_f180… : PS3, Line 1: #openssl x509 extfile params DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f76aceea_ce47… : PS3, Line 2: extensions = extend DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a434bd82_0b0c… : PS3, Line 3: # This prevent the user to be prompted for values DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/3fbaa517_b613… : PS3, Line 4: prompt = no DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/45a71051_c975… : PS3, Line 5: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/98090e35_a96d… : PS3, Line 6: distinguished_name = dn-param DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/5572550e_a859… : PS3, Line 7: [dn-param] # DN fields DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/0dc102d5_9761… : PS3, Line 8: CN = Test CI DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/ef835a6e_ab1b… : PS3, Line 9: OU = TESTCERT DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/fd05e883_a296… : PS3, Line 10: O = RSPTEST DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/1d5c0f2e_f7e3… : PS3, Line 11: C = IT DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/2a28ebdd_cfb9… : PS3, Line 12: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/45532f17_46d7… : PS3, Line 13: # Extensions for the Test CI DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/04769f53_051d… : PS3, Line 14: [extend] # openssl extensions DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/260d2603_5962… : PS3, Line 15: subjectKeyIdentifier = hash DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a4420e03_cece… : PS3, Line 16: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/cce5a98f_67d4… : PS3, Line 17: basicConstraints = critical, CA:true DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a956eed3_6828… : PS3, Line 18: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a04ed6e1_b000… : PS3, Line 19: certificatePolicies=critical,2.23.146.1.2.1.0 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/87625651_dabf… : PS3, Line 20: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/9d2973e1_f1f1… : PS3, Line 21: keyUsage =critical, keyCertSign, cRLSign DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/b1d6a5b1_c77f… : PS3, Line 22: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/cd9dc8fe_6def… : PS3, Line 23: subjectAltName = RID:2.999.1 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/58ea15ef_a19f… : PS3, Line 24: DOS line endings File smdpp/sgp26/CertificateIssuer/SK_CI_ECDSA_BRP.pem: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/9e850dc3_ff1d… : PS3, Line 1: -----BEGIN EC PARAMETERS----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/354ab999_f19e… : PS3, Line 2: BgkrJAMDAggBAQc= DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/55ca919a_95f4… : PS3, Line 3: -----END EC PARAMETERS----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/c23f2e41_a884… : PS3, Line 4: -----BEGIN EC PRIVATE KEY----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/0ce4f4b2_eb46… : PS3, Line 5: MHgCAQEEIDWGs5Vx2Xz5Y17YWnRQ4tJYmTEJQ9ossf2KHmdLa/b0oAsGCSskAwMC DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/804000e2_e168… : PS3, Line 6: CAEBB6FEA0IABCeHtNVu2CSp5r4E4Yh/a5i6/rjHY/UoN/cBE+k2Tt2+E5vAx95+ DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a4d66e08_0e0c… : PS3, Line 7: Fo8eXNDBhTT8UGTmT2htxTMnyn8dzqhaKZQ= DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/22750d8e_358c… : PS3, Line 8: -----END EC PRIVATE KEY----- DOS line endings File smdpp/sgp26/DPauth/PK_S_SM_DP2auth_ECDSA_BRP.pem: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/aaebb719_828e… : PS3, Line 1: -----BEGIN PUBLIC KEY----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/6e436f07_2caa… : PS3, Line 2: MFowFAYHKoZIzj0CAQYJKyQDAwIIAQEHA0IABC7uB8ltAFvlGV95rR2tzR03jKMJ DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/0fdfc904_bdd9… : PS3, Line 3: XkT3LupBDwjHVhIskGPJZbf8hSnAyk6bT2WWnCg8ZWNkV4dxGPbRFy1qI2U= DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/630abcf9_374e… : PS3, Line 4: -----END PUBLIC KEY----- DOS line endings File smdpp/sgp26/DPauth/PK_S_SM_DP2auth_ECDSA_NIST.pem: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/6335f6b3_d854… : PS3, Line 1: -----BEGIN PUBLIC KEY----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/fd9ac50a_342b… : PS3, Line 2: MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEKy6bRdNRwJr0DpFDg6GQOEfyYH3m DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/2afd8e6e_eb02… : PS3, Line 3: DverJcQOA/jbtlCOFFdQjCvgAXNH7Pob+fd159B+gF5S4ZiLe1hacRGuMw== DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/330af608_0691… : PS3, Line 4: -----END PUBLIC KEY----- DOS line endings File smdpp/sgp26/DPauth/SK_S_SM_DP2auth_ECDSA_BRP.pem: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/c627ca32_3ecf… : PS3, Line 1: -----BEGIN EC PARAMETERS----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/22a998a8_94fc… : PS3, Line 2: BgkrJAMDAggBAQc= DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/2f4ebb1e_e6e8… : PS3, Line 3: -----END EC PARAMETERS----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/c86f45cb_df6a… : PS3, Line 4: -----BEGIN EC PRIVATE KEY----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/d9b6c9cb_8d27… : PS3, Line 5: MHgCAQEEIAwXNVwBHQ/o19rdY/GXhc9sUcvNRmroi+j4G8EFiEb2oAsGCSskAwMC DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/112b27fe_9e02… : PS3, Line 6: CAEBB6FEA0IABC7uB8ltAFvlGV95rR2tzR03jKMJXkT3LupBDwjHVhIskGPJZbf8 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/12829282_e508… : PS3, Line 7: hSnAyk6bT2WWnCg8ZWNkV4dxGPbRFy1qI2U= DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f9b30b6c_10b4… : PS3, Line 8: -----END EC PRIVATE KEY----- DOS line endings File smdpp/sgp26/DPauth/SK_S_SM_DP2auth_ECDSA_NIST.pem: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/27364c9c_f0ee… : PS3, Line 1: -----BEGIN EC PARAMETERS----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/fafbae36_aabe… : PS3, Line 2: BggqhkjOPQMBBw== DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/7d12e50c_7fc2… : PS3, Line 3: -----END EC PARAMETERS----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/9ccc8e66_ba03… : PS3, Line 4: -----BEGIN EC PRIVATE KEY----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/5683cc9d_dde6… : PS3, Line 5: MHcCAQEEIJwyoJXUiELZ/6QE9xJRKqLFQloaJjhqtqFF1YEeA5FBoAoGCCqGSM49 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/3a59270b_dda8… : PS3, Line 6: AwEHoUQDQgAEKy6bRdNRwJr0DpFDg6GQOEfyYH3mDverJcQOA/jbtlCOFFdQjCvg DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4bc3f6a4_91cb… : PS3, Line 7: AXNH7Pob+fd159B+gF5S4ZiLe1hacRGuMw== DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/94c28ee3_2030… : PS3, Line 8: -----END EC PRIVATE KEY----- DOS line endings File smdpp/sgp26/DPpb/PK_S_SM_DP2pb_ECDSA_BRP.pem: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/ddaf9195_9efe… : PS3, Line 1: -----BEGIN PUBLIC KEY----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/c42086c1_7a57… : PS3, Line 2: MFowFAYHKoZIzj0CAQYJKyQDAwIIAQEHA0IABHNhhV5ZAmSyUscaYGKgIeJ7Rvdg DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/c3a08e03_53a8… : PS3, Line 3: uBOCBqf3RCDvi8Vai5iNFlj51w06LYSAqt9k5ixNcSfeWgorkXqUP0R0qt0= DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/15a5791f_7928… : PS3, Line 4: -----END PUBLIC KEY----- DOS line endings File smdpp/sgp26/DPpb/PK_S_SM_DP2pb_ECDSA_NIST.pem: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/d7f935a3_dfb2… : PS3, Line 1: -----BEGIN PUBLIC KEY----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/74909d14_80d1… : PS3, Line 2: MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEPi11oQYiEhbCruj61YT3eWM8+URo DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/aa9c82f6_c08f… : PS3, Line 3: G17HWpZlP19AHEdq451UbAMtMtAHCnuG5dzrqt3zHKXCdmwZa9ebwhoBgA== DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a66105af_27f8… : PS3, Line 4: -----END PUBLIC KEY----- DOS line endings File smdpp/sgp26/DPpb/SK_S_SM_DP2pb_ECDSA_BRP.pem: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/5c542248_f890… : PS3, Line 1: -----BEGIN EC PARAMETERS----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/7292bcbe_e17c… : PS3, Line 2: BgkrJAMDAggBAQc= DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/bafa1af3_894b… : PS3, Line 3: -----END EC PARAMETERS----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/1a3aba12_170c… : PS3, Line 4: -----BEGIN EC PRIVATE KEY----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a3bb42a3_b121… : PS3, Line 5: MHgCAQEEIJyuLhpWB6nVeDgu7pMuJR9SME+G7rHxcIzb08B74s09oAsGCSskAwMC DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/73c0d87b_d59b… : PS3, Line 6: CAEBB6FEA0IABHNhhV5ZAmSyUscaYGKgIeJ7RvdguBOCBqf3RCDvi8Vai5iNFlj5 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/0f7bb28e_5c73… : PS3, Line 7: 1w06LYSAqt9k5ixNcSfeWgorkXqUP0R0qt0= DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/16b8f26e_f116… : PS3, Line 8: -----END EC PRIVATE KEY----- DOS line endings File smdpp/sgp26/DPpb/SK_S_SM_DP2pb_ECDSA_NIST.pem: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4d0f003a_0f30… : PS3, Line 1: -----BEGIN EC PARAMETERS----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/e2852a5a_94cd… : PS3, Line 2: BggqhkjOPQMBBw== DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/25651e6e_904d… : PS3, Line 3: -----END EC PARAMETERS----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/c4a20e6e_1705… : PS3, Line 4: -----BEGIN EC PRIVATE KEY----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/88fdff62_fe62… : PS3, Line 5: MHcCAQEEIGaTEUljnbqsHcPTBsWL0t/SL3O/Y6yGMZgykLV/kJNFoAoGCCqGSM49 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/fffcce33_5d8e… : PS3, Line 6: AwEHoUQDQgAEPi11oQYiEhbCruj61YT3eWM8+URoG17HWpZlP19AHEdq451UbAMt DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/42b1ac2d_d172… : PS3, Line 7: MtAHCnuG5dzrqt3zHKXCdmwZa9ebwhoBgA== DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/d59e25b4_4c51… : PS3, Line 8: -----END EC PRIVATE KEY----- DOS line endings File smdpp/sgp26/DPtls/CERT_S_SM_DP2_TLS.csr.cnf: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/e1e36e30_1c5e… : PS3, Line 1: [ req ] DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/729b39fd_af8c… : PS3, Line 2: prompt = no DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/61e3447c_c413… : PS3, Line 3: distinguished_name = req_distinguished_name DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/d0b442f4_21fd… : PS3, Line 4: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/371f7671_07b4… : PS3, Line 5: [ req_distinguished_name ] DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/46de63ad_691a… : PS3, Line 6: O = ACME DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/5f26868d_0fc4… : PS3, Line 7: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/c3adc500_a5e8… : PS3, Line 8: # shall be aligned with SGP.23 value #TEST_DP_ADDRESS2 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/6be8233f_3550… : PS3, Line 9: CN = testsmdpplus2.example.com DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/876035be_2875… : PS3, Line 10: DOS line endings File smdpp/sgp26/DPtls/CERT_S_SM_DP2_TLS.ext.cnf: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/88a77471_175a… : PS3, Line 1: ###################################################################################################################################################################### DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/91ce1f9d_716a… : PS3, Line 2: # Extensions for a DPTLS DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/708c8e36_82c2… : PS3, Line 3: keyUsage = critical, digitalSignature DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/67743a49_415f… : PS3, Line 4: extendedKeyUsage = critical, serverAuth, clientAuth DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/98ad7959_97b3… : PS3, Line 5: certificatePolicies = 2.23.146.1.2.1.3 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/5c29d4ce_78fd… : PS3, Line 6: subjectKeyIdentifier = hash DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/e1a547a8_c2cf… : PS3, Line 7: authorityKeyIdentifier = keyid:always,issuer DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/e22ff54e_7656… : PS3, Line 8: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/32d37c55_4869… : PS3, Line 9: # RID shall be aligend with SGP.23 value SM-DP+OID2 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/9991c23d_36ce… : PS3, Line 10: # DNS name shall be aligned with SGP.23 value #TEST_DP_ADDRESS2 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/fcf431ab_880d… : PS3, Line 11: subjectAltName = DNS:testsmdpplus2.example.com, RID:2.999.12 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/470048e5_b8cc… : PS3, Line 12: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f2f9a191_b819… : PS3, Line 13: crlDistributionPoints=URI:http://ci.test.example.com/CRL-A.crl, URI:http://ci.test.example.com/CRL-B.crl trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f7615022_9978… : PS3, Line 14: DOS line endings File smdpp/sgp26/DPtls/CERT_S_SM_DP4_TLS.csr.cnf: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/860995a0_77c9… : PS3, Line 1: [ req ] DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/9e605dbc_1950… : PS3, Line 2: prompt = no DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/7c2f1672_032c… : PS3, Line 3: distinguished_name = req_distinguished_name DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/ee2e5905_c720… : PS3, Line 4: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/237fc867_c2e0… : PS3, Line 5: [ req_distinguished_name ] DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/abdfedd1_f0a8… : PS3, Line 6: O = ACME DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/68df5100_d777… : PS3, Line 7: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/278c8ba2_5ad2… : PS3, Line 8: # shall be aligned with SGP.23 value #TEST_DP_ADDRESS4 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/cfa3744c_2a11… : PS3, Line 9: CN = testsmdpplus4.example.com DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/9d03b173_3866… : PS3, Line 10: DOS line endings File smdpp/sgp26/DPtls/CERT_S_SM_DP4_TLS.ext.cnf: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/5346dcef_5bda… : PS3, Line 1: ###################################################################################################################################################################### DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f7b0403b_f390… : PS3, Line 2: # Extensions for a DPTLS DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f6828832_4440… : PS3, Line 3: keyUsage = critical, digitalSignature DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/0c94bcbf_bd8a… : PS3, Line 4: extendedKeyUsage = critical, serverAuth, clientAuth DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/6882a8e6_864b… : PS3, Line 5: certificatePolicies = 2.23.146.1.2.1.3 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/115a1b13_454e… : PS3, Line 6: subjectKeyIdentifier = hash DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/1ce869eb_f42c… : PS3, Line 7: authorityKeyIdentifier = keyid:always,issuer DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/d60b155f_c26d… : PS3, Line 8: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/32dcc97d_5884… : PS3, Line 9: # RID shall be aligend with SGP.23 value SM-DP+OID4 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/7d376dee_c27e… : PS3, Line 10: # DNS name shall be aligned with SGP.23 value #TEST_DP_ADDRESS4 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/53ff98bf_381d… : PS3, Line 11: subjectAltName = DNS:testsmdpplus4.example.com, RID:2.999.14 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/de03a961_1b15… : PS3, Line 12: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f9e407e2_3330… : PS3, Line 13: crlDistributionPoints=URI:http://ci.test.example.com/CRL-A.crl, URI:http://ci.test.example.com/CRL-B.crl trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/8e853791_3a1e… : PS3, Line 14: DOS line endings File smdpp/sgp26/DPtls/CERT_S_SM_DP8_TLS.csr.cnf: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/5715cd22_9ea3… : PS3, Line 1: [ req ] DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/7acd9cd0_1a37… : PS3, Line 2: prompt = no DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f63af233_0f50… : PS3, Line 3: distinguished_name = req_distinguished_name DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/d52f5a18_0640… : PS3, Line 4: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/addf5b29_8d7c… : PS3, Line 5: [ req_distinguished_name ] DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/b1ab93c7_42b9… : PS3, Line 6: O = ACME DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/ebb15411_33b5… : PS3, Line 7: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/b69c00a0_7915… : PS3, Line 8: # shall be aligned with SGP.23 value #TEST_DP_ADDRESS8 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/b7eabdf4_7570… : PS3, Line 9: CN = testsmdpplus8.example.com DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/cf619757_2a0a… : PS3, Line 10: DOS line endings File smdpp/sgp26/DPtls/CERT_S_SM_DP8_TLS.ext.cnf: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/95409856_f2ac… : PS3, Line 1: ###################################################################################################################################################################### DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/0b14acac_dfca… : PS3, Line 2: # Extensions for a DPTLS DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/fb7fc893_cd9f… : PS3, Line 3: keyUsage = critical, digitalSignature DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4da66239_2635… : PS3, Line 4: extendedKeyUsage = critical, serverAuth, clientAuth DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/47b368f4_a0bc… : PS3, Line 5: certificatePolicies = 2.23.146.1.2.1.3 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/d7a4e6b7_aa33… : PS3, Line 6: subjectKeyIdentifier = hash DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/3da31797_7abc… : PS3, Line 7: authorityKeyIdentifier = keyid:always,issuer DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/970b8bc0_fa7b… : PS3, Line 8: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/1a465442_e90f… : PS3, Line 9: # RID shall be aligend with SGP.23 value SM-DP+OID8 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f0d6471e_1595… : PS3, Line 10: # DNS name shall be aligned with SGP.23 value #TEST_DP_ADDRESS8 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/3f2e372a_aca5… : PS3, Line 11: subjectAltName = DNS:testsmdpplus8.example.com, RID:2.999.18 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/47e78de3_4253… : PS3, Line 12: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/97640ee1_05ee… : PS3, Line 13: crlDistributionPoints=URI:http://ci.test.example.com/CRL-A.crl, URI:http://ci.test.example.com/CRL-B.crl trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/1cfa0e0e_6199… : PS3, Line 14: DOS line endings File smdpp/sgp26/DPtls/CERT_S_SM_DP_TLS.csr.cnf: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4e8adb5b_d690… : PS3, Line 1: [ req ] DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/87978b57_9b8e… : PS3, Line 2: prompt = no DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/b0c4d53b_1df9… : PS3, Line 3: distinguished_name = req_distinguished_name DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/3f3c090c_da0a… : PS3, Line 4: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/2524b253_c9d1… : PS3, Line 5: [ req_distinguished_name ] DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/027d0f7e_7fff… : PS3, Line 6: O = ACME DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/b26e3204_e677… : PS3, Line 7: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/97dd2820_9a0c… : PS3, Line 8: # shall be aligned with SGP.23 value #TEST_DP_ADDRESS1 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4ae22513_37ad… : PS3, Line 9: CN = testsmdpplus1.example.com DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/9a3c5628_2bab… : PS3, Line 10: DOS line endings File smdpp/sgp26/DPtls/CERT_S_SM_DP_TLS.ext.cnf: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/3f46ad68_46b3… : PS3, Line 1: ###################################################################################################################################################################### DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/7dec8f1b_bdad… : PS3, Line 2: # Extensions for a DPTLS DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/6e526ffc_9caa… : PS3, Line 3: keyUsage = critical, digitalSignature DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/9914157d_e9d8… : PS3, Line 4: extendedKeyUsage = critical, serverAuth, clientAuth DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/597bab73_b946… : PS3, Line 5: certificatePolicies = 2.23.146.1.2.1.3 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/bc8c6d23_830d… : PS3, Line 6: subjectKeyIdentifier = hash DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/cc9a6c4c_7880… : PS3, Line 7: authorityKeyIdentifier = keyid:always,issuer DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/96f72272_d8a7… : PS3, Line 8: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a7c2617e_fe8e… : PS3, Line 9: # RID shall be aligend with SGP.23 value SM-DP+OID DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a93d62e3_bc14… : PS3, Line 10: # DNS name shall be aligned with SGP.23 value #TEST_DP_ADDRESS1 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/70e6d14b_3ae9… : PS3, Line 11: subjectAltName = DNS:testsmdpplus1.example.com, RID:2.999.10 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/65240455_e7bf… : PS3, Line 12: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f693c3e2_a028… : PS3, Line 13: crlDistributionPoints=URI:http://ci.test.example.com/CRL-A.crl, URI:http://ci.test.example.com/CRL-B.crl trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/eb13ce93_e949… : PS3, Line 14: DOS line endings File smdpp/sgp26/EUM/EUM-csr.cnf: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/aeb1c1f6_e0e0… : PS3, Line 3: [req] trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/6b94338b_00da… : PS3, Line 7: [dn-name] trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/2e862eb6_4cf7… : PS3, Line 11: commonName = EUM Test trailing whitespace File smdpp/sgp26/EUM/EUM-ext.cnf: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/0c6b8671_2985… : PS3, Line 1: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/3beb94a0_b121… : PS3, Line 2: # openssl EUM certificate creation configuration file DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/b0e85a05_18cd… : PS3, Line 3: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/52401300_a8df… : PS3, Line 4: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/0fb7b510_b10d… : PS3, Line 5: authorityKeyIdentifier=keyid, issuer DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/9600b968_fdb7… : PS3, Line 6: subjectKeyIdentifier=hash DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/98960f35_6614… : PS3, Line 7: keyUsage=critical, keyCertSign DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f526e07f_f5af… : PS3, Line 8: certificatePolicies=critical,2.23.146.1.2.1.2 #OID id-rspRole-eum DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/c248cef6_b0f4… : PS3, Line 9: subjectAltName=RID:2.999.5 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/265c64ff_33e8… : PS3, Line 10: basicConstraints=critical,CA:TRUE, pathlen:0 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/fd0848a3_fcc7… : PS3, Line 11: crlDistributionPoints=URI:http://ci.test.example.com/CRL-B.crl trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/ccfe63dc_4eb1… : PS3, Line 12: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/25d1a722_eee1… : PS3, Line 13: nameConstraints=critical,DER:30:32:A0:30:30:2E:A4:2C:30:2A:31:15:30:13:06:03:55:04:0A:0C:0C:52:53:50:20:54:65:73:74:20:45:55:4D:31:11:30:0F:06:03:55:04:05:13:08:38:39:30:34:39:30:33:32 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/c873db6f_c031… : PS3, Line 14: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/b76650ae_bfb7… : PS3, Line 15: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/e4589f2f_2558… : PS3, Line 16: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/58c0cc27_e390… : PS3, Line 17: # DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a4050de9_097f… : PS3, Line 18: # TBSCertificate DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4ccc576c_ad79… : PS3, Line 19: #0000: 30 82 02 7c ; SEQUENCE DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/c2b8747e_a612… : PS3, Line 20: #0004: 30 82 02 21 ; SEQUENCE DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/60921d5e_46fb… : PS3, Line 21: #0008: | a0 03 ; OPTIONAL[0] DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/98e69e8a_27fd… : PS3, Line 22: #000a: | | 02 01 02 ; INTEGER - Version = 2(log. 3) DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4ca3bdfe_4437… : PS3, Line 23: #... DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/cf266ddb_f42c… : PS3, Line 24: #0120: | a3 82 01 05 ; OPTIONAL[3] - Extensions : tag = [3] DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a60408e4_5d74… : PS3, Line 25: #0124: | 30 82 01 01 ; SEQUENCE - OF Extension DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/8c5ba5d2_aa72… : PS3, Line 26: # ... DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/95878684_cc4d… : PS3, Line 27: #01e9: | 30 3e ; SEQUENCE DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/cc2f65c7_cb22… : PS3, Line 28: #01eb: | 06 03 55 1d 1e ; OBJECT_ID - 2.5.29.30 Name Constraints DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/42ee1843_e069… : PS3, Line 29: #01f0: | 01 01 ff ; BOOL - critical=TRUE DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/411c59a8_0c33… : PS3, Line 30: #01f3: | 04 34 ; OCTET_STRING - extnValue(CONTAINING NameConstraints) DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4d6f6f61_5984… : PS3, Line 31: # -------------------------------------DER input data ---------------------------------------------------------------------------------- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/e453423f_38e1… : PS3, Line 32: #01f5: | 30 32 ; SEQUENCE - NameConstraints DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f2337ab5_b228… : PS3, Line 33: #01f7: | a0 30 ; OPTIONAL[0] - permittedSubtrees : tag = [0] DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a7ead945_205c… : PS3, Line 34: #01f9: | 30 2e ; SEQUENCE - GeneralSubtrees of GeneralSubtree DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/63074e10_f938… : PS3, Line 35: #01fb: | a4 2c ; OPTIONAL[4] - base GeneralName CHOICE directoryName : tag = [4] DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/cf8673b2_6151… : PS3, Line 36: #01fd: | | 30 2a ; SEQUENCE - Name CHOICE rdnSequence RDNSequence DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/288aed5e_0be6… : PS3, Line 37: #01ff: | | 31 15 ; SET - RelativeDistinguishedName DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/72d293a0_19ef… : PS3, Line 38: #0201: | | 30 13 ; SEQUENCE - AttributeTypeAndValue DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/26916fde_2b22… : PS3, Line 39: #0203: | | | 06 03 ; OBJECT_ID - AttributeType DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/32ef0dab_82b8… : PS3, Line 40: #0205: | | | | 55 04 0a - 2.5.4.10 Organization (O) DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/79819d3d_cc1b… : PS3, Line 41: #0208: | | | 0c 0c ; UTF8_STRING - AttributeValue DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/3b49f415_da01… : PS3, Line 42: #020a | 52 53 50 20 74 65 73 74 65 75 4D - RSP Test EUM DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/20fe10ad_4625… : PS3, Line 43: #0216 | 31 11 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/2ff53937_d8d4… : PS3, Line 44: #0218: | 30 0f ; SEQUENCE DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/30560e21_e3ab… : PS3, Line 45: #021a: | 06 03 ; OBJECT_ID - AttributeType DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/598ae9d1_61f7… : PS3, Line 46: #021c: | | 55 04 05 - 2.5.4.5 Serial Number (SERIALNUMBER) DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/0c4cf23e_8528… : PS3, Line 47: #021f: | 13 08 ; PRINTABLE_STRING - AttributeValue DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/31c4a488_f1cd… : PS3, Line 48: #0221: | 38 39 30 34 39 30 33 32 - 89049032 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/8b80b0a5_a874… : PS3, Line 49: # DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/70114f3c_0baf… : PS3, Line 50: #-------------------------------------------------------------------------------------------------------------------------------- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/10b04ca6_2d93… : PS3, Line 51: #0229: 30 0a ; SEQUENCE (a Bytes) DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/6b42b581_58d0… : PS3, Line 52: #... DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4c6325ae_7bcc… : PS3, Line 53: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a6e7a41d_ffc5… : PS3, Line 54: trailing whitespace File smdpp/sgp26/EUM/PK_EUM_ECDSA_BRP.pem: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/867c6cc4_7f8e… : PS3, Line 1: -----BEGIN PUBLIC KEY----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/148808a2_215a… : PS3, Line 2: MFowFAYHKoZIzj0CAQYJKyQDAwIIAQEHA0IABKLlKjLf6JllccU69TKO9oIJP8HQ DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/e630e5af_a6ac… : PS3, Line 3: X1JlL2txHCQ4IffxawzsjSGbI9P5kPQ00LkNQnFsAuCTBSZEY/YR5lDDf/c= DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f2c1eb27_f4f0… : PS3, Line 4: -----END PUBLIC KEY----- DOS line endings File smdpp/sgp26/EUM/PK_EUM_ECDSA_NIST.pem: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/b6e4dc8a_cef8… : PS3, Line 1: -----BEGIN PUBLIC KEY----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/bee2aba6_0fc0… : PS3, Line 2: MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEEzDVklasDLUL2SjQ9MaAB8SF/j9C DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/673c951f_1835… : PS3, Line 3: mIrT7jh1rjP0mDqyO03UwxNA1nbdjhH5xcuhsR62lO7QmU21KSheYyyJBg== DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f4543eb3_0eba… : PS3, Line 4: -----END PUBLIC KEY----- DOS line endings File smdpp/sgp26/EUM/SK_EUM_ECDSA_BRP.pem: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/2c5083f5_6b3b… : PS3, Line 1: -----BEGIN EC PARAMETERS----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/45e1578e_0dd0… : PS3, Line 2: BgkrJAMDAggBAQc= DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/fe5d9746_5f82… : PS3, Line 3: -----END EC PARAMETERS----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/761fbfdb_f107… : PS3, Line 4: -----BEGIN EC PRIVATE KEY----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/dddd2a9f_ef96… : PS3, Line 5: MHgCAQEEIBKbCrE/F+FKQLb6Ttgj4M9GW3s9cyQF5ildOyOwRcmaoAsGCSskAwMC DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/30de99b2_5e78… : PS3, Line 6: CAEBB6FEA0IABKLlKjLf6JllccU69TKO9oIJP8HQX1JlL2txHCQ4IffxawzsjSGb DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/33cc8b23_5dee… : PS3, Line 7: I9P5kPQ00LkNQnFsAuCTBSZEY/YR5lDDf/c= DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/b53fae10_e537… : PS3, Line 8: -----END EC PRIVATE KEY----- DOS line endings File smdpp/sgp26/EUM/SK_EUM_ECDSA_NIST.pem: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4d668480_f3d5… : PS3, Line 1: -----BEGIN EC PARAMETERS----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/1b64a489_d073… : PS3, Line 2: BggqhkjOPQMBBw== DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4b1acad6_504b… : PS3, Line 3: -----END EC PARAMETERS----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/8c7d54a2_369a… : PS3, Line 4: -----BEGIN EC PRIVATE KEY----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/d9fedb53_8feb… : PS3, Line 5: MHcCAQEEICXmdXco4elRE1Gc3DRVXCm67SN3OsWv3dza2YSJilLwoAoGCCqGSM49 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/95b6e356_4012… : PS3, Line 6: AwEHoUQDQgAEEzDVklasDLUL2SjQ9MaAB8SF/j9CmIrT7jh1rjP0mDqyO03UwxNA DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/b8f55a2e_541e… : PS3, Line 7: 1nbdjhH5xcuhsR62lO7QmU21KSheYyyJBg== DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/637de6e5_fabe… : PS3, Line 8: -----END EC PRIVATE KEY----- DOS line endings File smdpp/sgp26/eUICC/PK_EUICC_ECDSA_BRP.pem: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/5fb9089f_673e… : PS3, Line 1: -----BEGIN PUBLIC KEY----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4ea24f14_b598… : PS3, Line 2: MFowFAYHKoZIzj0CAQYJKyQDAwIIAQEHA0IABD5ZDDipwlYxXs/zKRQW3TNUCaZm DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/b664c75e_362a… : PS3, Line 3: /UGztR5eURTzQ6vwomd0xsJsSHU6/ig2QyJ7tmCM0mHMly03SkeRJOvydyI= DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/c099e42b_6f92… : PS3, Line 4: -----END PUBLIC KEY----- DOS line endings File smdpp/sgp26/eUICC/PK_EUICC_ECDSA_NIST.pem: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/175bccb4_65f0… : PS3, Line 1: -----BEGIN PUBLIC KEY----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/c9eeae71_fd28… : PS3, Line 2: MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEbbP1OtyH3C/xDHv82HrROulwCa+g DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/6b383cc5_3084… : PS3, Line 3: ZaZ1fuVxs/LrsY9GwdaPPt6w50suXVQgUefSf1CVIChgWv3vef6f/9A5WQ== DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/58f993ed_d437… : PS3, Line 4: -----END PUBLIC KEY----- DOS line endings File smdpp/sgp26/eUICC/SK_EUICC_ECDSA_BRP.pem: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/90bf7abf_73e8… : PS3, Line 1: -----BEGIN EC PARAMETERS----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/bbd12d38_5554… : PS3, Line 2: BgkrJAMDAggBAQc= DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/a6d86da0_994f… : PS3, Line 3: -----END EC PARAMETERS----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/cf3ada91_ff58… : PS3, Line 4: -----BEGIN EC PRIVATE KEY----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/0b181ba5_f558… : PS3, Line 5: MHgCAQEEII3DR6dtt73WIi3XXqGhaIrKgR5MvGp/au+ksmQZYguQoAsGCSskAwMC DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/70e4f59a_256f… : PS3, Line 6: CAEBB6FEA0IABD5ZDDipwlYxXs/zKRQW3TNUCaZm/UGztR5eURTzQ6vwomd0xsJs DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/ac791f0d_0fd4… : PS3, Line 7: SHU6/ig2QyJ7tmCM0mHMly03SkeRJOvydyI= DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/ab8cca9f_8412… : PS3, Line 8: -----END EC PRIVATE KEY----- DOS line endings File smdpp/sgp26/eUICC/SK_EUICC_ECDSA_NIST.pem: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/bbdfe975_ab83… : PS3, Line 1: -----BEGIN EC PARAMETERS----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f9085804_0994… : PS3, Line 2: BggqhkjOPQMBBw== DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4e1b4ac4_6eb0… : PS3, Line 3: -----END EC PARAMETERS----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/31fcb832_4753… : PS3, Line 4: -----BEGIN EC PRIVATE KEY----- DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/45a4a4bb_d195… : PS3, Line 5: MHcCAQEEIBHhVGfcGU8zcYPkYMn2MmAJHhLoECbNZWHhfG2FOcycoAoGCCqGSM49 DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/cbc9ede4_78e3… : PS3, Line 6: AwEHoUQDQgAEbbP1OtyH3C/xDHv82HrROulwCa+gZaZ1fuVxs/LrsY9GwdaPPt6w DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/356947a4_551f… : PS3, Line 7: 50suXVQgUefSf1CVIChgWv3vef6f/9A5WQ== DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/dcf6cd8c_4248… : PS3, Line 8: -----END EC PRIVATE KEY----- DOS line endings File smdpp/sgp26/eUICC/eUICC-csr.cnf: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/915b243b_9d06… : PS3, Line 10: trailing whitespace File smdpp/sgp26/eUICC/eUICC-ext.cnf: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4aa7adaa_9536… : PS3, Line 1: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/21677d57_4e3f… : PS3, Line 2: #eUICC certificate creation configuration DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/f6b294c9_f3e8… : PS3, Line 3: # DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/28c69873_e6f5… : PS3, Line 4: # use openssl x509 -req -in eUICC-csr.cnf -CA ..\CERT_EUM_ECDSA_NIST.pem -CAkey ..\SK_EUM_ECDSA_NIST.pem -set_serial 0x020000000000000001 -days 2000000 -sha256 -extfile eUICC-ext.cnf -out CERT_EUICC_ECDSA_NIST.pem DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/be5e6dbb_1c79… : PS3, Line 5: # DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/49d06cf9_94bb… : PS3, Line 6: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4506cca7_f19b… : PS3, Line 7: authorityKeyIdentifier=keyid DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/4f1901b4_6116… : PS3, Line 8: subjectKeyIdentifier=hash DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/af0754f0_e483… : PS3, Line 9: keyUsage = critical, digitalSignature DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/3c3e1e6f_9824… : PS3, Line 10: certificatePolicies=critical,2.23.146.1.2.1.1 #OID id-rspRole-e DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/c83c7936_5b21… : PS3, Line 11: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/27ecce64_6c06… : PS3, Line 12: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/3461bd9b_4347… : PS3, Line 13: DOS line endings Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/c73463bc_ae22… : PS3, Line 14: DOS line endings File smdpp/smdpp_Tests_Functions.cc: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/5a5a0c7e_e0fc… : PS3, Line 537: LOG_DEBUG(" Key type: " + std::to_string(keyType.get_long_long_val()) + trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119/comment/b383dca1_6625… : PS3, Line 542: trailing whitespace -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3ba163d9155a3b019214dbccc3c8031dfd7deb6b Gerrit-Change-Number: 41119 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 17 Sep 2025 13:46:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 days, 1 hour

← Newer
1
...
6
7
8
9
10
11
12
...
100
Older →

Jump to page:

2025

2024

2023

2022

gerrit-log September 2025