pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41116?usp=email )
(
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: cosmetic: RANAP_CodecPort.ttcn: Fix trailing whitespace
......................................................................
cosmetic: RANAP_CodecPort.ttcn: Fix trailing whitespace
Change-Id: Ibad0a23cfc15dd9d9a03e78ca64eb26b4ecee6d8
---
M library/ranap/RANAP_CodecPort.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
osmith: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/library/ranap/RANAP_CodecPort.ttcn b/library/ranap/RANAP_CodecPort.ttcn
index 07e1b00..af2090c 100644
--- a/library/ranap/RANAP_CodecPort.ttcn
+++ b/library/ranap/RANAP_CodecPort.ttcn
@@ -353,7 +353,7 @@
} with {extension "prototype(fast)" }
-/*
+/*
type port RANAP_CODEC_PT message map to SCCPasp_PT {
out RANAP_N_CONNECT_req to ASP_SCCP_N_CONNECT_req with f_enc_ConnectReq(),
RANAP_N_CONNECT_res to ASP_SCCP_N_CONNECT_res with f_enc_ConnectRes(),
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41116?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibad0a23cfc15dd9d9a03e78ca64eb26b4ecee6d8
Gerrit-Change-Number: 41116
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41123?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: tcap: Add initial templates
......................................................................
tcap: Add initial templates
Change-Id: Ibc471733554c75b7c494b2bd4126232dd8c0553c
---
A library/tcap/TCAP_Templates.ttcn
1 file changed, 53 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/23/41123/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41123?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibc471733554c75b7c494b2bd4126232dd8c0553c
Gerrit-Change-Number: 41123
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: daniel, fixeria, laforge, osmith.
Hello Jenkins Builder, daniel, fixeria, laforge, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41114?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by osmith, Verified+1 by Jenkins Builder
Change subject: stp: define PC for IPA ASP peers
......................................................................
stp: define PC for IPA ASP peers
This allows explicitly matching what's configured in osmo-stp's
"routing-key" & "point-code override dpc" VTY configs for each AS.
This in turn makes the osmo-stp cfg file easy to understand by looking
at the peer's (TTCN3) configuration.
There's no need to configure "point-code override opc" in the osmo-stp
since by default the PC declared in the routing-key is used to apply an
OPC on incoming messages over an IPA ASP.
Once we have the PC available in the TTCN3 config file, we can use it
inside IPA<->M3UA test to put the value in generated M3UA messages
(there's no visible changes in IPA ones because ofc the IPA signalling
doesn't include the PC in the messages).
Change-Id: I9cca2f4dd38e03ab1d259ffafd904b8890778883
---
M stp/STP_Tests_IPA.cfg
M stp/STP_Tests_IPA.ttcn
M stp/STP_Tests_IPA_M3UA.cfg
M stp/STP_Tests_IPA_M3UA.ttcn
M stp/osmo-stp-ipa.confmerge
5 files changed, 39 insertions(+), 24 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/14/41114/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41114?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9cca2f4dd38e03ab1d259ffafd904b8890778883
Gerrit-Change-Number: 41114
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Attention is currently required from: pespin.
Hello Jenkins Builder, daniel, fixeria, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41118?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: Introduce TCAP asn enc/dec
......................................................................
Introduce TCAP asn enc/dec
ASN.1 files obtained from libosmo-asn1-tcap.git
a92fd1a6206832b626aa2a5c841b890ca37e4bd0.
Related: SYS#5423
Change-Id: Iae7f92cde02e5da966966bc95f9b74feec51958d
---
A library/tcap/TCAPMessages.asn
A library/tcap/TCAP_CodecPort.ttcn
A library/tcap/TCAP_DialoguePDUs.asn
A library/tcap/TCAP_EncDec.cc
A library/tcap/TCAP_Types.ttcn
A library/tcap/TCAP_UnidialoguePDUs.asn
A library/tcap/regen_makefile.sh
7 files changed, 789 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/18/41118/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41118?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iae7f92cde02e5da966966bc95f9b74feec51958d
Gerrit-Change-Number: 41118
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
Hello Jenkins Builder, fixeria, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41116?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: cosmetic: RANAP_CodecPort.ttcn: Fix trailing whitespace
......................................................................
cosmetic: RANAP_CodecPort.ttcn: Fix trailing whitespace
Change-Id: Ibad0a23cfc15dd9d9a03e78ca64eb26b4ecee6d8
---
M library/ranap/RANAP_CodecPort.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/16/41116/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41116?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibad0a23cfc15dd9d9a03e78ca64eb26b4ecee6d8
Gerrit-Change-Number: 41116
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41126?usp=email )
Change subject: s1gw: test S1GW originated PFCP Heartbeat
......................................................................
Patch Set 2:
(1 comment)
File s1gw/S1GW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41126/comment/0fb566ad_9127… :
PS2, Line 1016: if (mp_rest_enable) {
> I'm not following why do you wanto mix here the PFPC HEartbet procedures on both directions.
> IMHO they are totally separate thing and should be triggered in different places.
I don't see what's wrong with doing that. How could the same procedure that is specified for both CP and UP functions be a "totally separate thing"? I am not following your concern either.
> Actually, I don't really understand why would one want to trigger an initiating PFCP procedure over the REST interface instead of having a configurable timer inside osmo-s1gw...
Because periodic sending of PFCP Heartbeat (triggered by a timer) is not yet implemented in OsmoS1GW and triggering it via the REST interface is currently the only way.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41126?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I28fb46be037a488e225d20a16b83d0479c6e067d
Gerrit-Change-Number: 41126
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Sep 2025 11:28:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: daniel, fixeria, laforge.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41114?usp=email )
Change subject: stp: define PC for IPA ASP peers
......................................................................
Patch Set 2:
(1 comment)
File stp/osmo-stp-ipa.confmerge:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41114/comment/fc62647e_2be8… :
PS2, Line 37: 34
> Why is it `34` here? In `STP_Tests_IPA. […]
Ack, I'll change the point code in STP_TEsts_IPA.cfg. Both 33 or 34 could be valid depending on network topology, but yes the numbers should match.
In the end in here it doesn't matter because this AS/ASP is only used to send data, hence we never really need to route traffic to it (see there's no route entry in the route table below, and the name "sender" above indicates exactly this ;)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41114?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9cca2f4dd38e03ab1d259ffafd904b8890778883
Gerrit-Change-Number: 41114
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Sep 2025 11:26:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>