September 2025 - gerrit-log - lists.osmocom.org

[S] Change in ...osmo-s1gw[master]: [REST] MetricsList: return 404 on invalid path
by fixeria 27 Sep '25

27 Sep '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41170?usp=email ) Change subject: [REST] MetricsList: return 404 on invalid path ...................................................................... [REST] MetricsList: return 404 on invalid path Change-Id: If5ab039654007ccf3703a2364b767eaa19e43461 Related: SYS#7066 --- M contrib/openapi.yaml M priv/openapi.json M src/rest_server.erl 3 files changed, 14 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/70/41170/1 diff --git a/contrib/openapi.yaml b/contrib/openapi.yaml index e7934b2..a56f876 100644 --- a/contrib/openapi.yaml +++ b/contrib/openapi.yaml @@ -31,6 +31,8 @@ application/json: schema: $ref: '#/components/schemas/MetricsList' + '404': + description: No matching metrics found /pfcp/assoc: get: diff --git a/priv/openapi.json b/priv/openapi.json index 94c0287..5422c03 100644 --- a/priv/openapi.json +++ b/priv/openapi.json @@ -46,6 +46,9 @@ } } } + }, + "404": { + "description": "No matching metrics found" } } } diff --git a/src/rest_server.erl b/src/rest_server.erl index da859fe..9d2c355 100644 --- a/src/rest_server.erl +++ b/src/rest_server.erl @@ -62,11 +62,15 @@ << "gauge" >> -> metric_list([gauge]); << "all" >> -> metric_list([]) end, - L1 = case proplists:get_value(<< "path" >>, QP) of - undefined -> L0; - Path -> lists:filter(fun(M) -> metric_filter_path(M, Path) end, L0) - end, - {200, [], L1}. + case proplists:get_value(<< "path" >>, QP) of + undefined -> + {200, [], L0}; + Path -> + case lists:filter(fun(M) -> metric_filter_path(M, Path) end, L0) of + [] -> {404, [], undefined}; + L1 -> {200, [], L1} + end + end. %% PfcpAssocState :: Get the PFCP association state -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41170?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: If5ab039654007ccf3703a2364b767eaa19e43461 Gerrit-Change-Number: 41170 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: track eNB connection, fail immediately on loss
by fixeria 27 Sep '25

27 Sep '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41169?usp=email ) Change subject: s1gw: track eNB connection, fail immediately on loss ...................................................................... s1gw: track eNB connection, fail immediately on loss Change-Id: I34a3d30270f1236908643b60fc8abe590a780b89 --- M s1gw/S1GW_ConnHdlr.ttcn M s1gw/S1GW_Tests.ttcn 2 files changed, 29 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/69/41169/1 diff --git a/s1gw/S1GW_ConnHdlr.ttcn b/s1gw/S1GW_ConnHdlr.ttcn index 4e47544..94c6d78 100644 --- a/s1gw/S1GW_ConnHdlr.ttcn +++ b/s1gw/S1GW_ConnHdlr.ttcn @@ -45,6 +45,7 @@ var ConnHdlrPars g_pars; port S1AP_CODEC_PT S1AP_ENB; var ConnectionId g_s1ap_conn_id := -1; + var default conn_track := null; }; type record of ConnHdlr ConnHdlrList; @@ -92,6 +93,25 @@ fn.apply(id); } +/* track eNB connection loss events */ +private altstep as_conn_track() runs on ConnHdlr { + [] S1AP_CONN.receive(S1APSRV_Event:S1APSRV_EVENT_CONN_DOWN) { + setverdict(fail, "eNB disconnected unexpectedly"); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); + } +} + +function f_ConnHdlr_conn_track_enable() runs on ConnHdlr { + if (conn_track == null) { + conn_track := activate(as_conn_track()); + } +} + +function f_ConnHdlr_conn_track_disable() runs on ConnHdlr { + if (conn_track != null) { + deactivate(conn_track); + } +} function f_ConnHdlr_s1ap_connect(charstring local_addr, charstring remote_addr) runs on ConnHdlr { var Result res; @@ -110,6 +130,9 @@ } g_s1ap_conn_id := res.connId; + /* start tracking eNB connection */ + f_ConnHdlr_conn_track_enable(); + /* wait for the establishment confirmation */ T.start(2.0); alt { @@ -127,6 +150,9 @@ function f_ConnHdlr_s1ap_disconnect() runs on ConnHdlr { var Result res; + /* stop tracking eNB connection (teardown expected) */ + f_ConnHdlr_conn_track_disable(); + S1AP_CodecPort_CtrlFunct.f_IPL4_close(S1AP_ENB, g_s1ap_conn_id, { sctp := c_SctpTuple_S1AP }); g_s1ap_conn_id := -1; diff --git a/s1gw/S1GW_Tests.ttcn b/s1gw/S1GW_Tests.ttcn index 296c234..501f1be 100644 --- a/s1gw/S1GW_Tests.ttcn +++ b/s1gw/S1GW_Tests.ttcn @@ -343,6 +343,9 @@ f_ConnHdlr_s1ap_setup(g_pars.genb_id); f_sleep(0.5); /* keep the connection idle for some time */ + /* stop tracking eNB connection (teardown expected) */ + f_ConnHdlr_conn_track_disable(); + /* MME (S1AP_Server_CT) terminates connection */ f_ConnHdlr_s1ap_close_conn(g_pars.genb_id); /* expect our eNB connection to be released gracefully */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41169?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I34a3d30270f1236908643b60fc8abe590a780b89 Gerrit-Change-Number: 41169 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-msc[master]: vlr: add PS support
by lynxis lazus 26 Sep '25

26 Sep '25

Attention is currently required from: daniel, fixeria, laforge, neels, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email ) Change subject: vlr: add PS support ...................................................................... Patch Set 11: (1 comment) File src/libvlr/vlr_lu_fsm.c: https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/a736fbda_a91cc7e6?usp… : PS11, Line 1604: case VLR_ULA_S_WAIT_IMSI: > I'll check it and come back later. Because `VLR_ULA_S_WAIT_AUTH` is waiting for the HLR and not for the MS, yes we should also protect here against timeout towards the HLR. But this is not specific for PS timers - so it should go into a different commit. VLR_ULA_S_WAIT_CIPH is waiting for the MS/UE. I've added VLR_ULA_S_WAIT_CIPH -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie9ffeb140c9d354b3a0f4822e2619f623235add0 Gerrit-Change-Number: 38490 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 26 Sep 2025 20:39:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-msc[master]: vlr: vlr_set_ciph_mode(): use vlr_subscr_security_context instead of ...
by lynxis lazus 26 Sep '25

26 Sep '25

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/41168?usp=email ) Change subject: vlr: vlr_set_ciph_mode(): use vlr_subscr_security_context instead of umts_aka ...................................................................... vlr: vlr_set_ciph_mode(): use vlr_subscr_security_context instead of umts_aka Simplifies code when re-transmitting Ciphering Mode Command when using it also for PS. Change-Id: Ia556bc33d1cf30ef17fed2828908aa0b6b6dc8be --- M include/osmocom/vlr/vlr.h M src/libvlr/vlr.c M src/libvlr/vlr_access_req_fsm.c M src/libvlr/vlr_lu_fsm.c 4 files changed, 24 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/68/41168/1 diff --git a/include/osmocom/vlr/vlr.h b/include/osmocom/vlr/vlr.h index b1994d0..9b49ff2 100644 --- a/include/osmocom/vlr/vlr.h +++ b/include/osmocom/vlr/vlr.h @@ -488,7 +488,7 @@ int vlr_set_ciph_mode(struct vlr_instance *vlr, struct osmo_fsm_inst *fi, void *msc_conn_ref, - bool umts_aka, + enum vlr_subscr_security_context sec_ctx, bool retrieve_imeisv); bool vlr_use_umts_aka(struct osmo_auth_vector *vec, bool is_r99); diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c index c7b7e63..c9055dc 100644 --- a/src/libvlr/vlr.c +++ b/src/libvlr/vlr.c @@ -1664,19 +1664,35 @@ /* Internal evaluation of requested ciphering mode. * Send set_ciph_mode() to MSC depending on the ciph_mode argument. - * \param[in] vlr VLR instance. - * \param[in] fi Calling FSM instance, for logging. - * \param[in] msc_conn_ref MSC conn to send to. - * \param[in] ciph_mode Ciphering config, to decide whether to do ciphering. + * \param[in] vlr VLR instance. + * \param[in] fi Calling FSM instance, for logging. + * \param[in] msc_conn_ref MSC conn to send to. + * \param[in] sec_ctx the security context to be established. + * \param[in] retrieve_imeisv request the IMEI in the ciphering mode command. * \returns 0 if no ciphering is needed or message was sent successfully, * or a negative value if ciph_mode is invalid or sending failed. */ int vlr_set_ciph_mode(struct vlr_instance *vlr, struct osmo_fsm_inst *fi, void *msc_conn_ref, - bool umts_aka, + enum vlr_subscr_security_context sec_ctx, bool retrieve_imeisv) { + bool umts_aka; + + switch (sec_ctx) { + case VLR_SEC_CTX_GSM: + umts_aka = false; + break; + case VLR_SEC_CTX_UMTS: + umts_aka = true; + break; + case VLR_SEC_CTX_NONE: + return 0; + default: + return -EINVAL; + } + LOGPFSML(fi, LOGL_DEBUG, "Set Ciphering Mode\n"); return vlr->ops.set_ciph_mode(msc_conn_ref, umts_aka, retrieve_imeisv); } diff --git a/src/libvlr/vlr_access_req_fsm.c b/src/libvlr/vlr_access_req_fsm.c index 516f53d..91ff06e 100644 --- a/src/libvlr/vlr_access_req_fsm.c +++ b/src/libvlr/vlr_access_req_fsm.c @@ -297,7 +297,6 @@ { struct proc_arq_priv *par = fi->priv; struct vlr_subscr *vsub = par->vsub; - bool umts_aka; LOGPFSM(fi, "%s()\n", __func__); @@ -311,10 +310,7 @@ switch (vsub->sec_ctx) { case VLR_SEC_CTX_GSM: - umts_aka = false; - break; case VLR_SEC_CTX_UMTS: - umts_aka = true; break; default: LOGPFSML(fi, LOGL_ERROR, "Cannot start ciphering, security context is not established\n"); @@ -323,7 +319,7 @@ } if (vlr_set_ciph_mode(vsub->vlr, fi, par->msc_conn_ref, - umts_aka, + vsub->sec_ctx, vsub->vlr->cfg.retrieve_imeisv_ciphered)) { LOGPFSML(fi, LOGL_ERROR, "Failed to send Ciphering Mode Command\n"); diff --git a/src/libvlr/vlr_lu_fsm.c b/src/libvlr/vlr_lu_fsm.c index 5b2e96b..ec459a1 100644 --- a/src/libvlr/vlr_lu_fsm.c +++ b/src/libvlr/vlr_lu_fsm.c @@ -892,7 +892,6 @@ { struct lu_fsm_priv *lfp = lu_fsm_fi_priv(fi); struct vlr_subscr *vsub = lfp->vsub; - bool umts_aka; LOGPFSM(fi, "%s()\n", __func__); @@ -914,10 +913,7 @@ switch (vsub->sec_ctx) { case VLR_SEC_CTX_GSM: - umts_aka = false; - break; case VLR_SEC_CTX_UMTS: - umts_aka = true; break; default: LOGPFSML(fi, LOGL_ERROR, "Cannot start ciphering, security context is not established\n"); @@ -926,7 +922,7 @@ } if (vlr_set_ciph_mode(vsub->vlr, fi, lfp->msc_conn_ref, - umts_aka, + vsub->sec_ctx, vsub->vlr->cfg.retrieve_imeisv_ciphered)) { LOGPFSML(fi, LOGL_ERROR, "Failed to send Ciphering Mode Command\n"); -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41168?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ia556bc33d1cf30ef17fed2828908aa0b6b6dc8be Gerrit-Change-Number: 41168 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-msc[master]: vlr: add PS support
by lynxis lazus 26 Sep '25

26 Sep '25

Attention is currently required from: daniel, fixeria, laforge, neels, pespin. Hello Jenkins Builder, daniel, laforge, neels, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email to look at the new patch set (#12). The following approvals got outdated and were removed: Code-Review+1 by daniel, Code-Review+1 by laforge, Code-Review+1 by neels, Code-Review+2 by pespin, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: vlr: add PS support ...................................................................... vlr: add PS support Add vlr_ra_update() similar to vlr_lu_update(). Implement resending of GMM PDUs. While CS has a reliable connection between the MS and MSC, the MS and SGSN doesn't have such connection. The PDU is resend N times before the LU fsm is failing. Change-Id: Ie9ffeb140c9d354b3a0f4822e2619f623235add0 --- M src/libvlr/vlr.c M src/libvlr/vlr_lu_fsm.c 2 files changed, 220 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/90/38490/12 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie9ffeb140c9d354b3a0f4822e2619f623235add0 Gerrit-Change-Number: 38490 Gerrit-PatchSet: 12 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: GTPv1C_Templates: add cause code GTP_CAUSE_IMSI_IMEI_NOT_KNOWN
by lynxis lazus 26 Sep '25

26 Sep '25

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39263?usp=email to look at the new patch set (#15). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: GTPv1C_Templates: add cause code GTP_CAUSE_IMSI_IMEI_NOT_KNOWN ...................................................................... GTPv1C_Templates: add cause code GTP_CAUSE_IMSI_IMEI_NOT_KNOWN It will be used by SGSN Context Req/Resp/Ack test cases in the SGSN. Change-Id: I8f919d5982a3c9a317d309c383b36043ad5d3278 --- M library/GTPv1C_Templates.ttcn 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/63/39263/15 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39263?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8f919d5982a3c9a317d309c383b36043ad5d3278 Gerrit-Change-Number: 39263 Gerrit-PatchSet: 15 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN: add testcases for PDP Context Status
by lynxis lazus 26 Sep '25

26 Sep '25

Attention is currently required from: fixeria, laforge, pespin. Hello Jenkins Builder, fixeria, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262?usp=email to look at the new patch set (#15). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+2 by pespin, Code-Review-1 by fixeria, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: SGSN: add testcases for PDP Context Status ...................................................................... SGSN: add testcases for PDP Context Status Both the network and the UE can add a TLV which describes the active PDPs from their perspective. Change-Id: I5a29e667f53cc2834fbddd2c5dc901d3e6ae72c7 --- M library/L3_Templates.ttcn M sgsn/SGSN_Tests.ttcn M sgsn/expected-results.xml 3 files changed, 201 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/62/39262/15 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5a29e667f53cc2834fbddd2c5dc901d3e6ae72c7 Gerrit-Change-Number: 39262 Gerrit-PatchSet: 15 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: L3_Templates: add MM cause codes
by lynxis lazus 26 Sep '25

26 Sep '25

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39264?usp=email to look at the new patch set (#15). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: L3_Templates: add MM cause codes ...................................................................... L3_Templates: add MM cause codes It will be used by SGSN Context Req/Resp/Ack test cases in the SGSN. Change-Id: I396ddaf5b08faddcf002317307dcc20840898aa9 --- M library/L3_Templates.ttcn 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/64/39264/15 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39264?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I396ddaf5b08faddcf002317307dcc20840898aa9 Gerrit-Change-Number: 39264 Gerrit-PatchSet: 15 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN: add testcases for PDP Context Status
by lynxis lazus 26 Sep '25

26 Sep '25

Attention is currently required from: fixeria. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262?usp=email ) Change subject: SGSN: add testcases for PDP Context Status ...................................................................... Patch Set 14: (6 comments) File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262/comment/5c9685bd_81a9… : PS10, Line 2446: [] BSSGP[ran_index].receive(tr_GMM_RAU_REJECT); > Do you eventually expect ACCEPT or REJECT? I see you permit both... Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262/comment/00a209d8_d20a… : PS10, Line 2475: f_TC_attach_pdp_act_rau_pdp_ctx_status_ue_more > Am I correct that this function is 99% identical to `f_TC_attach_pdp_act_rau_pdp_ctx_status_same()` […] Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262/comment/81c51c53_bd2b… : PS10, Line 2503: [] BSSGP[ran_index].receive(tr_GMM_RAU_REJECT); > Likewise, receiving a REJECT here will unblock the alt statement and the testcase will finish. […] Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262/comment/83b1793b_4e3a… : PS10, Line 2548: as_gmm_auth > Is the authentication expected to happen before or after the procedures implemented in `as_ggsn_gtp_ […] Correct behaviour: After the auth happened, _if_ this RAU doesn't have any encryption/integrity, but I doubt it is exactly like this already implemented. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262/comment/46b4eb75_13ee… : PS10, Line 2554: Timeout rx RAU Reject > This does not reflect the actual expectations... Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262/comment/5c43a303_7459… : PS10, Line 2574: [] BSSGP[ran_index].receive(tr_GMM_RAU_REJECT); > Same here: REJECT vs ACCEPT. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5a29e667f53cc2834fbddd2c5dc901d3e6ae72c7 Gerrit-Change-Number: 39262 Gerrit-PatchSet: 14 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 26 Sep 2025 19:48:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: TC_attach_gsup_lu_timeout: increase timeout to 35 seconds
by lynxis lazus 26 Sep '25

26 Sep '25

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, fixeria, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39257?usp=email to look at the new patch set (#13). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: SGSN: TC_attach_gsup_lu_timeout: increase timeout to 35 seconds ...................................................................... SGSN: TC_attach_gsup_lu_timeout: increase timeout to 35 seconds Currently the SGSN times out after 30 seconds. Change-Id: Ie882dd39f3c606e5fe00162fcf17c47b9f713d49 --- M sgsn/SGSN_Tests.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/57/39257/13 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39257?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie882dd39f3c606e5fe00162fcf17c47b9f713d49 Gerrit-Change-Number: 39257 Gerrit-PatchSet: 13 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

2025

2024

2023

2022

gerrit-log September 2025