September 2025 - gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: Correctly calculate size iofd_msgb_alloc2()

by jolly

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41138?usp=email ) Change subject: Correctly calculate size iofd_msgb_alloc2() ...................................................................... Correctly calculate size iofd_msgb_alloc2() When limiting headroom value to 16 bits, the allocated buffer will be too small, if headroom exceeds 65535. Related: Coverity CID#548925 Change-Id: I16c1e08fb64a1fafaeee1844fd8c00ecc2861d12 --- M src/core/osmo_io.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/38/41138/1 diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index 399a604..708d2c0 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -187,7 +187,7 @@ /*! convenience wrapper to call msgb_alloc with parameters from osmo_io_fd (of given size) */ struct msgb *iofd_msgb_alloc2(struct osmo_io_fd *iofd, size_t size) { - uint16_t headroom = iofd->msgb_alloc.headroom; + size_t headroom = iofd->msgb_alloc.headroom; OSMO_ASSERT(size <= 0xffff - headroom); return msgb_alloc_headroom_c(iofd, size + headroom, headroom, "osmo_io_msgb"); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41138?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I16c1e08fb64a1fafaeee1844fd8c00ecc2861d12 Gerrit-Change-Number: 41138 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>

1 day, 22 hours

1
0
0 0

[M] Change in docker-playground[master]: redmine: set session_store to active_record_store

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/41137?usp=email ) Change subject: redmine: set session_store to active_record_store ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41137?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iacec800b9179cfac894f41e9eb1a5cca7e56ff1c Gerrit-Change-Number: 41137 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Sep 2025 10:24:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 days

1
0
0 0

[M] Change in docker-playground[master]: redmine: set session_store to active_record_store

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/41137?usp=email ) Change subject: redmine: set session_store to active_record_store ...................................................................... redmine: set session_store to active_record_store Change the session store to fix the "ActionDispatch::Cookies::CookieOverflow" errors we are getting. IMPORTANT: after deploying this change, the following commands must be executed once manually to create the session table: # docker compose exec redmine bash $ rails generate active_record:session_migration $ rake db:migrate Related: OS#5476 Change-Id: Iacec800b9179cfac894f41e9eb1a5cca7e56ff1c --- A redmine/0001-Set-session_store-to-active_record_store.patch M redmine/Dockerfile M redmine/docker-entrypoint-osmo.sh 3 files changed, 57 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/37/41137/1 diff --git a/redmine/0001-Set-session_store-to-active_record_store.patch b/redmine/0001-Set-session_store-to-active_record_store.patch new file mode 100644 index 0000000..47efd2c --- /dev/null +++ b/redmine/0001-Set-session_store-to-active_record_store.patch @@ -0,0 +1,44 @@ +From 84ab3fe831c138e452f6edbeff03c26524cff8ca Mon Sep 17 00:00:00 2001 +From: Oliver Smith <osmith(a)sysmocom.de> +Date: Fri, 19 Sep 2025 10:51:06 +0200 +Subject: [PATCH] Set session_store to active_record_store + +Related: https://www.redmineup.com/pages/help/getting-started/how-to-fix-cookiesover… +Related: OS#5476 +--- + Gemfile | 3 +++ + config/application.rb | 3 +-- + 2 files changed, 4 insertions(+), 2 deletions(-) + +diff --git a/Gemfile b/Gemfile +index 7746ece04..3082054e0 100644 +--- a/Gemfile ++++ b/Gemfile +@@ -16,6 +16,9 @@ gem 'rbpdf', '~> 1.21.3' + gem 'addressable' + gem 'rubyzip', '~> 2.3.0' + ++# OS#5476 ++gem 'activerecord-session_store', '~> 2.0.0' ++ + # Ruby Standard Gems + gem 'csv', '~> 3.2.6' + gem 'net-imap', '~> 0.3.4' +diff --git a/config/application.rb b/config/application.rb +index 5e93df122..c0d2deb39 100644 +--- a/config/application.rb ++++ b/config/application.rb +@@ -87,9 +87,8 @@ module RedmineApp + config.log_level = Rails.env.production? ? :info : :debug + + config.session_store( +- :cookie_store, ++ :active_record_store, + :key => '_redmine_session', +- :path => config.relative_url_root || '/', + :same_site => :lax + ) + +-- +2.43.0 + diff --git a/redmine/Dockerfile b/redmine/Dockerfile index 0fea460..c3545bf 100644 --- a/redmine/Dockerfile +++ b/redmine/Dockerfile @@ -18,6 +18,9 @@ ADD commitlog-references-oshash-5.1.3.diff /tmp/commitlog-references-oshash-5.1.3.diff RUN cd /usr/src/redmine && patch -p1 < /tmp/commitlog-references-oshash-5.1.3.diff +ADD 0001-Set-session_store-to-active_record_store.patch /tmp/ +RUN cd /usr/src/redmine && patch -p1 < /tmp/0001-Set-session_store-to-active_record_store.patch + ADD docker-entrypoint-osmo.sh / ENTRYPOINT ["/docker-entrypoint-osmo.sh"] CMD ["rails", "server", "-b", "0.0.0.0"] diff --git a/redmine/docker-entrypoint-osmo.sh b/redmine/docker-entrypoint-osmo.sh index 8206d29..546e1f3 100755 --- a/redmine/docker-entrypoint-osmo.sh +++ b/redmine/docker-entrypoint-osmo.sh @@ -11,6 +11,16 @@ echo done &) & +# Daily: delete all sessions that have not been updated in the last 30 days +# https://www.redmineup.com/pages/help/getting-started/how-to-fix-cookiesover… +(while :; do + sleep 1d + echo + echo "=== Running db:sessions:trim (OS#5476) ===" + rake db:sessions:trim + echo +done &) & + # Run the original docker-entrypoint.sh script. Exec is important, so "tini" # inside the original script becomes pid 1 to clean up zombies from redmine. # https://github.com/docker-library/redmine/ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41137?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iacec800b9179cfac894f41e9eb1a5cca7e56ff1c Gerrit-Change-Number: 41137 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

2 days

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: Move RAN_Configurations module parameter definition to *_Tests.default

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41129?usp=email ) Change subject: Move RAN_Configurations module parameter definition to *_Tests.default ...................................................................... Move RAN_Configurations module parameter definition to *_Tests.default This way we can easily tweak values, which usually involve other programs' config like osmo-stp, without needing to recompile ttcn-3. Furthermore, we avoid ending up in the situation where the .ttcn file contains invalid data which is always overridden in .default, like it happened in MSC_Tests.ttcn. Change-Id: Id7e77a2ecf68520a853dc35fe0013a0611e744a1 --- M bsc/BSC_Tests.default M bsc/BSC_Tests.ttcn M bsc/BSC_Tests_SCCPlite.cfg M hnbgw/HNBGW_Tests.default M hnbgw/HNBGW_Tests.ttcn M msc/MSC_Tests.ttcn M sgsn/SGSN_Tests.cfg M sgsn/SGSN_Tests.default M sgsn/SGSN_Tests.ttcn 9 files changed, 146 insertions(+), 170 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/bsc/BSC_Tests.default b/bsc/BSC_Tests.default index 65cc7c2..d14fa6c 100644 --- a/bsc/BSC_Tests.default +++ b/bsc/BSC_Tests.default @@ -38,5 +38,40 @@ [MODULE_PARAMETERS] Osmocom_VTY_Functions.mp_prompt_prefix := "OsmoBSC"; +BSC_Tests.mp_bssap_cfg := { + { + transport := BSSAP_TRANSPORT_AoIP, + sccp_service_type := "mtp3_itu", + sctp_addr := { 23905, "127.0.0.1", 2905, "127.0.0.1" }, + own_pc := 185, # 0.23.1 first MSC emulation + own_ssn := 254, + peer_pc := 187, # 0.23.3 osmo-bsc + peer_ssn := 254, + sio := '83'O, + rctx := 1 + }, + { + transport := BSSAP_TRANSPORT_AoIP, + sccp_service_type := "mtp3_itu", + sctp_addr := { 23906, "127.0.0.1", 2905, "127.0.0.1" }, + own_pc := 2, # 0.0.2 second MSC emulation + own_ssn := 254, + peer_pc := 187, # 0.23.3 osmo-bsc + peer_ssn := 254, + sio := '83'O, + rctx := 2 + }, + { + transport := BSSAP_TRANSPORT_AoIP, + sccp_service_type := "mtp3_itu", + sctp_addr := { 23907, "127.0.0.1", 2905, "127.0.0.1" }, + own_pc := 3, # 0.0.3 third MSC emulation + own_ssn := 254, + peer_pc := 187, # 0.23.3 osmo-bsc + peer_ssn := 254, + sio := '83'O, + rctx := 3 + } +}; [EXECUTE] diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 86f9d48..1559d6c 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -687,41 +687,7 @@ /* IP address at which the test binds */ charstring mp_test_ip := "127.0.0.1"; - RAN_Configurations mp_bssap_cfg := { - { - transport := BSSAP_TRANSPORT_AoIP, - sccp_service_type := "mtp3_itu", - sctp_addr := { 23905, "127.0.0.1", 2905, "127.0.0.1" }, - own_pc := 185, /* 0.23.1 first MSC emulation */ - own_ssn := 254, - peer_pc := 187, /* 0.23.3 osmo-bsc */ - peer_ssn := 254, - sio := '83'O, - rctx := 1 - }, - { - transport := BSSAP_TRANSPORT_AoIP, - sccp_service_type := "mtp3_itu", - sctp_addr := { 23906, "127.0.0.1", 2905, "127.0.0.1" }, - own_pc := 2, /* 0.0.2 second MSC emulation */ - own_ssn := 254, - peer_pc := 187, /* 0.23.3 osmo-bsc */ - peer_ssn := 254, - sio := '83'O, - rctx := 2 - }, - { - transport := BSSAP_TRANSPORT_AoIP, - sccp_service_type := "mtp3_itu", - sctp_addr := { 23907, "127.0.0.1", 2905, "127.0.0.1" }, - own_pc := 3, /* 0.0.3 third MSC emulation */ - own_ssn := 254, - peer_pc := 187, /* 0.23.3 osmo-bsc */ - peer_ssn := 254, - sio := '83'O, - rctx := 3 - } - }; + RAN_Configurations mp_bssap_cfg := { /* Set in BSC_Tests.default */ }; /* Must match per BTS config in osmo-bsc.cfg */ phys_chan_configs phys_chan_config := { diff --git a/bsc/BSC_Tests_SCCPlite.cfg b/bsc/BSC_Tests_SCCPlite.cfg index db0b4cd..9a1a1b3 100644 --- a/bsc/BSC_Tests_SCCPlite.cfg +++ b/bsc/BSC_Tests_SCCPlite.cfg @@ -18,9 +18,9 @@ transport := BSSAP_TRANSPORT_SCCPlite_SERVER, sccp_service_type := "mtp3_itu", sctp_addr := { 5000, "127.0.0.1", 4000, "" }, - own_pc := 185, /* 0.23.1 first MSC emulation */ + own_pc := 185, # 0.23.1 first MSC emulation own_ssn := 254, - peer_pc := 187, /* 0.23.3 osmo-bsc */ + peer_pc := 187, # 0.23.3 osmo-bsc peer_ssn := 254, sio := '83'O, rctx := 0 diff --git a/hnbgw/HNBGW_Tests.default b/hnbgw/HNBGW_Tests.default index 174b012..107d15c 100644 --- a/hnbgw/HNBGW_Tests.default +++ b/hnbgw/HNBGW_Tests.default @@ -33,5 +33,97 @@ [MODULE_PARAMETERS] Osmocom_VTY_Functions.mp_prompt_prefix := "OsmoHNBGW"; +#MSCs (NUM_MSC entries): +HNBGW_Tests.mp_cn_cfg := { + { + transport := RANAP_TRANSPORT_IuCS, + sccp_service_type := "mtp3_itu", + sctp_addr := { 23905, "127.0.0.1", 2905, "127.0.0.1" }, + own_pc := 185, # 0.23.1 first MSC emulation + own_ssn := 142, + peer_pc := 189, # 0.23.5 osmo-hnbgw + peer_ssn := 142, + sio := '83'O, + rctx := 1 + }, + { + transport := RANAP_TRANSPORT_IuCS, + sccp_service_type := "mtp3_itu", + sctp_addr := { 23907, "127.0.0.1", 2905, "127.0.0.1" }, + own_pc := 2, # 0.0.2 second MSC emulation + own_ssn := 142, + peer_pc := 189, # 0.23.5 osmo-hnbgw + peer_ssn := 142, + sio := '83'O, + rctx := 3 + }, + { + transport := RANAP_TRANSPORT_IuCS, + sccp_service_type := "mtp3_itu", + sctp_addr := { 23909, "127.0.0.1", 2905, "127.0.0.1" }, + own_pc := 3, # 0.0.3 third MSC emulation + own_ssn := 142, + peer_pc := 189, # 0.23.5 osmo-hnbgw + peer_ssn := 142, + sio := '83'O, + rctx := 5 + }, + { + transport := RANAP_TRANSPORT_IuCS, + sccp_service_type := "mtp3_itu", + sctp_addr := { 23911, "127.0.0.1", 2905, "127.0.0.1" }, + own_pc := 4, # 0.0.4 fourth MSC emulation + own_ssn := 142, + peer_pc := 189, # 0.23.5 osmo-hnbgw + peer_ssn := 142, + sio := '83'O, + rctx := 7 + }, + # SGSNs (NUM_SGSN entries) + { + transport := RANAP_TRANSPORT_IuCS, + sccp_service_type := "mtp3_itu", + sctp_addr := { 23906, "127.0.0.1", 2905, "127.0.0.1" }, + own_pc := 188, # 0.23.4 first SGSN emulation + own_ssn := 142, + peer_pc := 189, # 2237, 1.23.5 osmo-hnbgw + peer_ssn := 142, + sio := '83'O, + rctx := 2 + }, + { + transport := RANAP_TRANSPORT_IuCS, + sccp_service_type := "mtp3_itu", + sctp_addr := { 23908, "127.0.0.1", 2905, "127.0.0.1" }, + own_pc := 10, # 0.1.2 second SGSN emulation + own_ssn := 142, + peer_pc := 189, # 2237, 1.23.5 osmo-hnbgw + peer_ssn := 142, + sio := '83'O, + rctx := 4 + }, + { + transport := RANAP_TRANSPORT_IuCS, + sccp_service_type := "mtp3_itu", + sctp_addr := { 23910, "127.0.0.1", 2905, "127.0.0.1" }, + own_pc := 11, # 0.1.3 third SGSN emulation + own_ssn := 142, + peer_pc := 189, # 2237, 1.23.5 osmo-hnbgw + peer_ssn := 142, + sio := '83'O, + rctx := 6 + }, + { + transport := RANAP_TRANSPORT_IuCS, + sccp_service_type := "mtp3_itu", + sctp_addr := { 23912, "127.0.0.1", 2905, "127.0.0.1" }, + own_pc := 12, # 0.1.4 fourth SGSN emulation + own_ssn := 142, + peer_pc := 189, # 2237, 1.23.5 osmo-hnbgw + peer_ssn := 142, + sio := '83'O, + rctx := 8 + } +}; [EXECUTE] diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 2a343fc..2ef7b4d 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -117,99 +117,7 @@ charstring mp_mgw_ip := "127.0.0.1"; integer mp_mgw_port := 2427; - RAN_Configurations mp_cn_cfg := { - /* MSCs (NUM_MSC entries) */ - { - transport := RANAP_TRANSPORT_IuCS, - sccp_service_type := "mtp3_itu", - sctp_addr := { 23905, "127.0.0.1", 2905, "127.0.0.1" }, - own_pc := 185, /* 0.23.1 first MSC emulation */ - own_ssn := 142, - peer_pc := 189, /* 0.23.5 osmo-hnbgw */ - peer_ssn := 142, - sio := '83'O, - rctx := 1 - }, - { - transport := RANAP_TRANSPORT_IuCS, - sccp_service_type := "mtp3_itu", - sctp_addr := { 23907, "127.0.0.1", 2905, "127.0.0.1" }, - own_pc := 2, /* 0.0.2 second MSC emulation */ - own_ssn := 142, - peer_pc := 189, /* 0.23.5 osmo-hnbgw */ - peer_ssn := 142, - sio := '83'O, - rctx := 3 - }, - { - transport := RANAP_TRANSPORT_IuCS, - sccp_service_type := "mtp3_itu", - sctp_addr := { 23909, "127.0.0.1", 2905, "127.0.0.1" }, - own_pc := 3, /* 0.0.3 third MSC emulation */ - own_ssn := 142, - peer_pc := 189, /* 0.23.5 osmo-hnbgw */ - peer_ssn := 142, - sio := '83'O, - rctx := 5 - }, - { - transport := RANAP_TRANSPORT_IuCS, - sccp_service_type := "mtp3_itu", - sctp_addr := { 23911, "127.0.0.1", 2905, "127.0.0.1" }, - own_pc := 4, /* 0.0.4 fourth MSC emulation */ - own_ssn := 142, - peer_pc := 189, /* 0.23.5 osmo-hnbgw */ - peer_ssn := 142, - sio := '83'O, - rctx := 7 - }, - - /* SGSNs (NUM_SGSN entries) */ - { - transport := RANAP_TRANSPORT_IuCS, - sccp_service_type := "mtp3_itu", - sctp_addr := { /* local */ 23906, "127.0.0.1", /* remote */ 2905, "127.0.0.1" }, - own_pc := 188, /* 0.23.4 first SGSN emulation */ - own_ssn := 142, - peer_pc := 189, /* 2237, 1.23.5 osmo-hnbgw */ - peer_ssn := 142, - sio := '83'O, - rctx := 2 - }, - { - transport := RANAP_TRANSPORT_IuCS, - sccp_service_type := "mtp3_itu", - sctp_addr := { /* local */ 23908, "127.0.0.1", /* remote */ 2905, "127.0.0.1" }, - own_pc := 10, /* 0.1.2 second SGSN emulation */ - own_ssn := 142, - peer_pc := 189, /* 2237, 1.23.5 osmo-hnbgw */ - peer_ssn := 142, - sio := '83'O, - rctx := 4 - }, - { - transport := RANAP_TRANSPORT_IuCS, - sccp_service_type := "mtp3_itu", - sctp_addr := { /* local */ 23910, "127.0.0.1", /* remote */ 2905, "127.0.0.1" }, - own_pc := 11, /* 0.1.3 third SGSN emulation */ - own_ssn := 142, - peer_pc := 189, /* 2237, 1.23.5 osmo-hnbgw */ - peer_ssn := 142, - sio := '83'O, - rctx := 6 - }, - { - transport := RANAP_TRANSPORT_IuCS, - sccp_service_type := "mtp3_itu", - sctp_addr := { /* local */ 23912, "127.0.0.1", /* remote */ 2905, "127.0.0.1" }, - own_pc := 12, /* 0.1.4 fourth SGSN emulation */ - own_ssn := 142, - peer_pc := 189, /* 2237, 1.23.5 osmo-hnbgw */ - peer_ssn := 142, - sio := '83'O, - rctx := 8 - } - }; + RAN_Configurations mp_cn_cfg := { /* Set in HNBGW_Tests.default */ }; boolean mp_enable_pfcp_tests := false; /* IP address at which we listen for PFCP to emulate a UPF in ttcn3 */ diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index ceddc11..12c6561 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -166,28 +166,7 @@ charstring mp_vlr_name := "vlr.example.net"; integer mp_bssap_reset_retries := 1; - RAN_Configurations mp_bssap_cfg := { - { - sccp_service_type := "mtp3_itu", - sctp_addr := { 23905, "127.0.0.1", 2905, "127.0.0.1" }, - own_pc := 185, - own_ssn := 254, - peer_pc := 187, - peer_ssn := 254, - sio := '83'O, - rctx := 0 - }, - { - sccp_service_type := "mtp3_itu", - sctp_addr := { 23906, "127.0.0.1", 2905, "127.0.0.1" }, - own_pc := 186, - own_ssn := 254, - peer_pc := 187, - peer_ssn := 254, - sio := '83'O, - rctx := 1 - } - }; + RAN_Configurations mp_bssap_cfg := { /* Set in MSC_Tests.default */ }; } /* altstep for the global guard timer (only used when BSSAP_DIRECT diff --git a/sgsn/SGSN_Tests.cfg b/sgsn/SGSN_Tests.cfg index edda944..ccd9b5e 100644 --- a/sgsn/SGSN_Tests.cfg +++ b/sgsn/SGSN_Tests.cfg @@ -54,11 +54,6 @@ } } } -SGSN_Tests.mp_ranap_cfg := { - { - sctp_addr := { 23908, "127.0.0.104", 2905, "127.0.0.200" } - } -} SGSN_Tests.mp_hlr_ip := "127.0.0.103" SGSN_Tests.mp_ggsn_ip := "127.0.0.103" diff --git a/sgsn/SGSN_Tests.default b/sgsn/SGSN_Tests.default index 5a7b8c6..04f4e09 100644 --- a/sgsn/SGSN_Tests.default +++ b/sgsn/SGSN_Tests.default @@ -39,6 +39,19 @@ [MODULE_PARAMETERS] Osmocom_VTY_Functions.mp_prompt_prefix := "OsmoSGSN"; +SGSN_Tests.mp_ranap_cfg := { + { + transport := RANAP_TRANSPORT_IuCS, + sccp_service_type := "mtp3_itu", + sctp_addr := { 23908, "127.0.0.104", 2905, "127.0.0.200" }, + own_pc := 195, + own_ssn := 142, + peer_pc := 188, # 0.23.4 + peer_ssn := 142, + sio := '83'O, + rctx := 2 + } +}; [MAIN_CONTROLLER] diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index 9c13c20..ab818d0 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -149,19 +149,7 @@ } }; - RAN_Configurations mp_ranap_cfg := { - { - transport := RANAP_TRANSPORT_IuCS, - sccp_service_type := "mtp3_itu", - sctp_addr := { 23908, "127.0.0.1", 2905, "127.0.0.1" }, - own_pc := 195, - own_ssn := 142, - peer_pc := 188, /* 0.23.4 */ - peer_ssn := 142, - sio := '83'O, - rctx := 2 - } - } + RAN_Configurations mp_ranap_cfg := { /* Set in SGSN_Tests.default */ }; }; const integer NUM_BVC_PER_NSE := 1; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41129?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id7e77a2ecf68520a853dc35fe0013a0611e744a1 Gerrit-Change-Number: 41129 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 days, 12 hours

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: Move RAN_Configurations module parameter definition to *_Tests.default

by pespin

Attention is currently required from: daniel, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41129?usp=email ) Change subject: Move RAN_Configurations module parameter definition to *_Tests.default ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41129?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id7e77a2ecf68520a853dc35fe0013a0611e744a1 Gerrit-Change-Number: 41129 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Sep 2025 21:35:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 days, 12 hours

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: RAN_{Emulation,Adapter}: Split transport type from transport client/s...

by pespin

Attention is currently required from: fixeria. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41132?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: RAN_{Emulation,Adapter}: Split transport type from transport client/server mode ...................................................................... RAN_{Emulation,Adapter}: Split transport type from transport client/server mode The RAN_Transport is used to identify the stack of protocols in use up to SCCP. The client/server mode is some extra independent information. For instance, RAN_Emulation doesn't really use it while RAN_Adapter does, since the later is the one in charge of setting up the lower layer socket connection. Change-Id: Ib2e7d029bd7eb59cc6f3b3a28bc417f00d3fed9c --- M bsc/BSC_Tests.default M bsc/BSC_Tests.ttcn M bsc/BSC_Tests_SCCPlite.cfg M hnbgw/HNBGW_Tests.default M library/RAN_Adapter.ttcnpp M library/RAN_Emulation.ttcnpp M msc/MSC_Tests.default M sgsn/SGSN_Tests.default 8 files changed, 36 insertions(+), 29 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/32/41132/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41132?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib2e7d029bd7eb59cc6f3b3a28bc417f00d3fed9c Gerrit-Change-Number: 41132 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

2 days, 12 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SCCP_Adapter: Allow configuring ipa_ccm_pars in SCCPLite transport

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41134?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: SCCP_Adapter: Allow configuring ipa_ccm_pars in SCCPLite transport ...................................................................... SCCP_Adapter: Allow configuring ipa_ccm_pars in SCCPLite transport This is needed for instance to set ipa_unit_id, which must match the AS name configured at the STP. Change-Id: I16e1f5d0c40c03330642b2781dc6ddae81d821b2 --- M bsc/BSC_Tests_SCCPlite.cfg M library/SCCP_Adapter.ttcnpp 2 files changed, 23 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/34/41134/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41134?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I16e1f5d0c40c03330642b2781dc6ddae81d821b2 Gerrit-Change-Number: 41134 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

2 days, 12 hours

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: Split SCCP_Adapter out of RAN_Adapter

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41133?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Split SCCP_Adapter out of RAN_Adapter ...................................................................... Split SCCP_Adapter out of RAN_Adapter RAN_Adapter has further features and goes up in the stack, while sometimes getting an SCCP SAP is enough, eg. when doing stuf with SIGTRAN on the Core Network (eg. TCAP). Change-Id: I0558d74d53ceb1b33c4f3d583f1b4489f6d7ee60 --- M bsc/BSC_Tests.default M bsc/BSC_Tests.ttcn M bsc/BSC_Tests_ASCI.ttcn M bsc/BSC_Tests_SCCPlite.cfg M bsc/gen_links.sh M hnbgw/HNBGW_Tests.default M hnbgw/HNBGW_Tests.ttcn M hnbgw/gen_links.sh M library/RAN_Adapter.ttcnpp A library/SCCP_Adapter.ttcnpp M msc/MSC_Tests.default M msc/MSC_Tests.ttcn M msc/gen_links.sh M sgsn/SGSN_Tests.default M sgsn/SGSN_Tests.ttcn M sgsn/SGSN_Tests_Iu.ttcn M sgsn/gen_links.sh 17 files changed, 548 insertions(+), 378 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/33/41133/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41133?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0558d74d53ceb1b33c4f3d583f1b4489f6d7ee60 Gerrit-Change-Number: 41133 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

2 days, 12 hours

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: RAN_{Emulation,Adapter}: Split transport type from transport client/s...

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41132?usp=email ) Change subject: RAN_{Emulation,Adapter}: Split transport type from transport client/server mode ...................................................................... Patch Set 2: (2 comments) File library/RAN_Adapter.ttcnpp: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41132/comment/0c78dda5_4a18… : PS2, Line 120: ba.vc_IPA := IPA_Emulation_CT.create(id & "-IPA") alive; : map(ba.vc_IPA:IPA_PORT, system:IPA_CODEC_PT); : /* connect MTP3 service provider (IPA) to lower side of SCCP */ : connect(ba.vc_IPA:MTP3_SP_PORT, ba.vc_SCCP:MTP3_SCCP_PORT); : /* connect waiter to general IPA port (for ASP_IPA_Event) */ : ba.vc_WAIT := IPA_EventWaiter_CT.create(id & "-IPA-WAIT") alive; : connect(ba.vc_IPA:IPA_SP_PORT, ba.vc_WAIT:IPA_SP_PORT); : > Unneeded indent level? (shift left) Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41132/comment/0b5ddd3c_121a… : PS2, Line 138: /* wait until we received an IPA CCM ID_ACK */ : ba.vc_WAIT.done; : > Likewise here, why are you adding an indent level? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41132?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib2e7d029bd7eb59cc6f3b3a28bc417f00d3fed9c Gerrit-Change-Number: 41132 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Sep 2025 21:32:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

2 days, 12 hours

1
0
0 0

[L] Change in ...osmo-s1gw[master]: [REST] Implement EnbList and EnbInfo

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41101?usp=email ) Change subject: [REST] Implement EnbList and EnbInfo ...................................................................... Patch Set 7: (1 comment) Patchset: PS6: > I would appreciate if we could include a small snippet of how the usage + output looks like from the […] Done -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41101?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Iba5a36678cf4bc245e9ae8cecc20ced76dfb7d75 Gerrit-Change-Number: 41101 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 18 Sep 2025 19:39:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

2 days, 14 hours

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2025