Attention is currently required from: Hoernchen, laforge.
Hello Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Verified+1 by Jenkins Builder
Change subject: smdpp: es9p testsuite
......................................................................
smdpp: es9p testsuite
Implemented parts conform to sgp 23 v1.13-v1.15
Certs are from https://www.gsma.com/solutions-and-impact/technologies/esim/wp-content/uplo…
the invalid ones are generated using smdpp/generate_all_test_certificates.py
Change-Id: I3ba163d9155a3b019214dbccc3c8031dfd7deb6b
---
M .checkpatch.conf
A smdpp/.clang-format
A smdpp/InvalidTestCases/CERT_EUICC_ECDSA_NIST_EXPIRED.der
A smdpp/InvalidTestCases/CERT_EUICC_ECDSA_NIST_INVALID.der
A smdpp/InvalidTestCases/CERT_EUICC_ECDSA_NIST_INVALID_EID.der
A smdpp/InvalidTestCases/CERT_EUICC_ECDSA_NIST_INVALID_EID.pem
A smdpp/InvalidTestCases/CERT_EUICC_ECDSA_NIST_UNMATCHED_EID.der
A smdpp/InvalidTestCases/CERT_EUICC_ECDSA_NIST_UNMATCHED_EID.pem
A smdpp/InvalidTestCases/CERT_EUM_ECDSA_NIST_EXPIRED.der
A smdpp/InvalidTestCases/CERT_EUM_ECDSA_NIST_INVALID.der
A smdpp/InvalidTestCases/CERT_EUM_ECDSA_NIST_UNKNOWN_CI.der
A smdpp/InvalidTestCases/CERT_UNKNOWN_CI_ECDSA_NIST.der
A smdpp/bsp_crypto.cpp
A smdpp/bsp_crypto.h
A smdpp/gen_links.sh
A smdpp/generate_all_test_certificates.py
A smdpp/helpers.h
A smdpp/logger.h
A smdpp/package.yml
A smdpp/regen_makefile.sh
A smdpp/rsp_client.cpp
A smdpp/sgp26/CertificateIssuer/CERT_CI_ECDSA_BRP.der
A smdpp/sgp26/CertificateIssuer/CERT_CI_ECDSA_BRP.pem
A smdpp/sgp26/CertificateIssuer/CERT_CI_ECDSA_NIST.der
A smdpp/sgp26/CertificateIssuer/CERT_CI_ECDSA_NIST.pem
A smdpp/sgp26/CertificateIssuer/CI-csr.cnf
A smdpp/sgp26/CertificateIssuer/SK_CI_ECDSA_BRP.pem
A smdpp/sgp26/CertificateIssuer/SK_CI_ECDSA_NIST.pem
A smdpp/sgp26/DPauth/CERT_S_SM_DP2auth_ECDSA_BRP.der
A smdpp/sgp26/DPauth/CERT_S_SM_DP2auth_ECDSA_NIST.der
A smdpp/sgp26/DPauth/CERT_S_SM_DPauth_ECDSA_BRP.der
A smdpp/sgp26/DPauth/CERT_S_SM_DPauth_ECDSA_NIST.der
A smdpp/sgp26/DPauth/PK_S_SM_DP2auth_ECDSA_BRP.pem
A smdpp/sgp26/DPauth/PK_S_SM_DP2auth_ECDSA_NIST.pem
A smdpp/sgp26/DPauth/PK_S_SM_DPauth_ECDSA_BRP.pem
A smdpp/sgp26/DPauth/PK_S_SM_DPauth_ECDSA_NIST.pem
A smdpp/sgp26/DPauth/SK_S_SM_DP2auth_ECDSA_BRP.pem
A smdpp/sgp26/DPauth/SK_S_SM_DP2auth_ECDSA_NIST.pem
A smdpp/sgp26/DPauth/SK_S_SM_DPauth_ECDSA_BRP.pem
A smdpp/sgp26/DPauth/SK_S_SM_DPauth_ECDSA_NIST.pem
A smdpp/sgp26/DPpb/CERT_S_SM_DP2pb_ECDSA_BRP.der
A smdpp/sgp26/DPpb/CERT_S_SM_DP2pb_ECDSA_NIST.der
A smdpp/sgp26/DPpb/CERT_S_SM_DPpb_ECDSA_BRP.der
A smdpp/sgp26/DPpb/CERT_S_SM_DPpb_ECDSA_NIST.der
A smdpp/sgp26/DPpb/PK_S_SM_DP2pb_ECDSA_BRP.pem
A smdpp/sgp26/DPpb/PK_S_SM_DP2pb_ECDSA_NIST.pem
A smdpp/sgp26/DPpb/PK_S_SM_DPpb_ECDSA_BRP.pem
A smdpp/sgp26/DPpb/PK_S_SM_DPpb_ECDSA_NIST.pem
A smdpp/sgp26/DPpb/SK_S_SM_DP2pb_ECDSA_BRP.pem
A smdpp/sgp26/DPpb/SK_S_SM_DP2pb_ECDSA_NIST.pem
A smdpp/sgp26/DPpb/SK_S_SM_DPpb_ECDSA_BRP.pem
A smdpp/sgp26/DPpb/SK_S_SM_DPpb_ECDSA_NIST.pem
A smdpp/sgp26/DPtls/CERT_S_SM_DP2_TLS.csr.cnf
A smdpp/sgp26/DPtls/CERT_S_SM_DP2_TLS.der
A smdpp/sgp26/DPtls/CERT_S_SM_DP2_TLS.ext.cnf
A smdpp/sgp26/DPtls/CERT_S_SM_DP4_TLS.csr.cnf
A smdpp/sgp26/DPtls/CERT_S_SM_DP4_TLS.der
A smdpp/sgp26/DPtls/CERT_S_SM_DP4_TLS.ext.cnf
A smdpp/sgp26/DPtls/CERT_S_SM_DP8_TLS.csr.cnf
A smdpp/sgp26/DPtls/CERT_S_SM_DP8_TLS.der
A smdpp/sgp26/DPtls/CERT_S_SM_DP8_TLS.ext.cnf
A smdpp/sgp26/DPtls/CERT_S_SM_DP_TLS.csr.cnf
A smdpp/sgp26/DPtls/CERT_S_SM_DP_TLS.ext.cnf
A smdpp/sgp26/DPtls/CERT_S_SM_DP_TLS_BRP.der
A smdpp/sgp26/DPtls/CERT_S_SM_DP_TLS_NIST.der
A smdpp/sgp26/DPtls/PK_S_SM_DP2_TLS_NIST.pem
A smdpp/sgp26/DPtls/PK_S_SM_DP4_TLS.pem
A smdpp/sgp26/DPtls/PK_S_SM_DP8_TLS.pem
A smdpp/sgp26/DPtls/PK_S_SM_DP_TLS_BRP.pem
A smdpp/sgp26/DPtls/PK_S_SM_DP_TLS_NIST.pem
A smdpp/sgp26/DPtls/SK_S_SM_DP2_TLS_NIST.pem
A smdpp/sgp26/DPtls/SK_S_SM_DP4_TLS.pem
A smdpp/sgp26/DPtls/SK_S_SM_DP8_TLS.pem
A smdpp/sgp26/DPtls/SK_S_SM_DP_TLS_BRP.pem
A smdpp/sgp26/DPtls/SK_S_SM_DP_TLS_NIST.pem
A smdpp/sgp26/EUM/CERT_EUM_ECDSA_BRP.der
A smdpp/sgp26/EUM/CERT_EUM_ECDSA_NIST.der
A smdpp/sgp26/EUM/EUM-csr.cnf
A smdpp/sgp26/EUM/EUM-ext.cnf
A smdpp/sgp26/EUM/PK_EUM_ECDSA_BRP.pem
A smdpp/sgp26/EUM/PK_EUM_ECDSA_NIST.pem
A smdpp/sgp26/EUM/SK_EUM_ECDSA_BRP.pem
A smdpp/sgp26/EUM/SK_EUM_ECDSA_NIST.pem
A smdpp/sgp26/eUICC/CERT_EUICC_ECDSA_BRP.der
A smdpp/sgp26/eUICC/CERT_EUICC_ECDSA_NIST.der
A smdpp/sgp26/eUICC/PK_EUICC_ECDSA_BRP.pem
A smdpp/sgp26/eUICC/PK_EUICC_ECDSA_NIST.pem
A smdpp/sgp26/eUICC/SK_EUICC_ECDSA_BRP.pem
A smdpp/sgp26/eUICC/SK_EUICC_ECDSA_NIST.pem
A smdpp/sgp26/eUICC/eUICC-csr.cnf
A smdpp/sgp26/eUICC/eUICC-ext.cnf
A smdpp/smdpp_Tests.cfg
A smdpp/smdpp_Tests.default
A smdpp/smdpp_Tests.ttcn
A smdpp/smdpp_Tests_Functions.cc
95 files changed, 10,895 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/19/41119/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3ba163d9155a3b019214dbccc3c8031dfd7deb6b
Gerrit-Change-Number: 41119
Gerrit-PatchSet: 5
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Attention is currently required from: fixeria, laforge.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41099?usp=email )
Change subject: [REST] Implement MetricsList
......................................................................
Patch Set 7:
(1 comment)
File doc/osmo-s1gw-cli.md:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41099/comment/d2480afe_941d… :
PS7, Line 109: | pfcp.assoc_setup_req.timeout | counter | 21 |
imho it would be better to have those as "c" and "g", otherwise it populates a lot of space.
In any case, I'd have the value next to the name.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41099?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I43114aa8f5f8a388dd6a436f83ad1ee97f1d2ab1
Gerrit-Change-Number: 41099
Gerrit-PatchSet: 7
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 19 Sep 2025 15:27:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: jolly.
pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/41138?usp=email )
Change subject: Correctly calculate size iofd_msgb_alloc2()
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/41138/comment/88e33270_e39670fc?… :
PS1, Line 10: too small, if headroom exceeds 65535.
how can headroom exceed 65535 is it's limited to 16bit value?
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41138?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I16c1e08fb64a1fafaeee1844fd8c00ecc2861d12
Gerrit-Change-Number: 41138
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Fri, 19 Sep 2025 15:21:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No