Attention is currently required from: jolly.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/40854?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: osmo_io: Add unit test to verify segmentation process
......................................................................
osmo_io: Add unit test to verify segmentation process
Change-Id: I7d8feba9c8e8386c9fd144669f6ccd01d6bbbabb
---
M tests/osmo_io/osmo_io_test.c
M tests/osmo_io/osmo_io_test.ok
2 files changed, 126 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/54/40854/3
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40854?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I7d8feba9c8e8386c9fd144669f6ccd01d6bbbabb
Gerrit-Change-Number: 40854
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Attention is currently required from: fixeria, laforge, lynxis lazus.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863?usp=email )
Change subject: msc: add TC_silent_call_{start_stop,active_conn}
......................................................................
Patch Set 4: Code-Review+1
(3 comments)
File msc/MSC_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863/comment/fcbff9f6_418d… :
PS4, Line 7720: cmd := "subscriber imsi " & hex2str(g_pars.imsi) & " silent-call ";
I'd better enclose this into a helper function so we only need to change it in one place if we ever change the vty command.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863/comment/f8546d82_390d… :
PS4, Line 7726: MSCVTY.send(cmd & "start any signalling");
the "start any signalling" and the wait below can also be part of the function call.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863/comment/fbe3436b_b8ae… :
PS4, Line 7750: MSCVTY.send(cmd & "stop");
this can also be a helper function.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3ef22fbb5a05f69cc8aea7f42e05f6e1d6c4a8b6
Gerrit-Change-Number: 40863
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 18 Aug 2025 09:40:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-iuh/+/40878?usp=email )
Change subject: debian: fix installing osmocom/iuh/common.h
......................................................................
Patch Set 3:
(1 comment)
File debian/control:
https://gerrit.osmocom.org/c/osmo-iuh/+/40878/comment/f525159e_c6d31442?usp… :
PS3, Line 65: Depends: libosmo-ranap7 (= ${binary:Version}), ${misc:Depends}, libosmo-iuh-dev
AFAIU this looks wrong. b63f98110684af44b161700bb5a40fcebab59436 makes iu_client.h depend on ranap code, so it should be the other way around: libosmo-iuh-dev depending on libosmo-ranap-dev.
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40878?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I4f7df05bf8b66d1be866895d7fe4158a7b555265
Gerrit-Change-Number: 40878
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Aug 2025 09:29:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: fixeria, lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39236?usp=email )
Change subject: MSC Tests: add TC_gsup_lu_and_det: do a LU, Detach and expect GSUP MS Purge
......................................................................
Patch Set 3:
(1 comment)
File msc/MSC_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39236/comment/1bb640ad_98a8… :
PS3, Line 3352: GSUP.receive
> I believe there should be an `alt` statement with a timeout here, since older osmo-msc versions do n […]
What's the problem with waiting for Tguard? simply that we go a few seconds quicker to fail in -latest until next release? If that's the case, leaving it as is is fine for me.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39236?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9e87537efc2c921fa860539a706316ed410b45d5
Gerrit-Change-Number: 39236
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 18 Aug 2025 09:25:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: daniel, laforge, lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/40847?usp=email )
Change subject: Drop iu_client - adopted by osmo-sgsn
......................................................................
Patch Set 7: Code-Review-1
(1 comment)
Patchset:
PS7:
IMHO this needs to be kept to avoid breaking ABI. I'd instead mark all those APIs as DEPRECATED.
This ofc still plays well with the fact that newer osmo-sgsn shouldn't be using iu_client from osmo-iuh; it should be using it's own copy of the code and then be improved from there.
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40847?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I95a5aeccc314ffdeaa04cc93f4e5947f715dd5de
Gerrit-Change-Number: 40847
Gerrit-PatchSet: 7
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 18 Aug 2025 09:23:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: jolly.
pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40854?usp=email )
Change subject: osmo_io: Add unit test to verify segmentation process
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
+1 once you fix build jenkins problems.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40854?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I7d8feba9c8e8386c9fd144669f6ccd01d6bbbabb
Gerrit-Change-Number: 40854
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Mon, 18 Aug 2025 09:07:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No