August 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: testenv: Dockerfile: fix Suites: stable-backports

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40874?usp=email ) Change subject: testenv: Dockerfile: fix Suites: stable-backports ...................................................................... testenv: Dockerfile: fix Suites: stable-backports Using "stable-backports" broke now that Debian 13 is out. Use "bookworm-backports" instead. Fix for: E: The value 'bookworm-backports' is invalid for APT::Default-Release as such a release is not available in the sources Change-Id: Icc46b6dc2493806dc12f0ff442abd70fe5b48eb8 --- M _testenv/data/podman/Dockerfile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/_testenv/data/podman/Dockerfile b/_testenv/data/podman/Dockerfile index d79bda9..aa99337 100644 --- a/_testenv/data/podman/Dockerfile +++ b/_testenv/data/podman/Dockerfile @@ -101,7 +101,7 @@ RUN set -x && \ echo "Types: deb deb-src" >>"$BACKPORTS_SOURCES_LIST" && \ echo "URIs: http://deb.debian.org/debian" >>"$BACKPORTS_SOURCES_LIST" && \ - echo "Suites: stable-backports" >>"$BACKPORTS_SOURCES_LIST" && \ + echo "Suites: bookworm-backports" >>"$BACKPORTS_SOURCES_LIST" && \ echo "Components: main" >>"$BACKPORTS_SOURCES_LIST" && \ echo "Enabled: yes" >>"$BACKPORTS_SOURCES_LIST" && \ echo "Signed-By: /usr/share/keyrings/debian-archive-keyring.gpg" >>"$BACKPORTS_SOURCES_LIST" && \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40874?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icc46b6dc2493806dc12f0ff442abd70fe5b48eb8 Gerrit-Change-Number: 40874 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 weeks, 3 days

1
0
0 0

[S] Change in osmo-iuh[master]: debian: fix installing osmocom/iuh/common.h

by osmith

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-iuh/+/40878?usp=email ) Change subject: debian: fix installing osmocom/iuh/common.h ...................................................................... Patch Set 3: (1 comment) File debian/control: https://gerrit.osmocom.org/c/osmo-iuh/+/40878/comment/4f412f95_e9b2b4f3?usp… : PS3, Line 65: Depends: libosmo-ranap7 (= ${binary:Version}), ${misc:Depends}, libosmo-iuh-dev as discussed in chat, this is correct. > libosmo-iuh-dev only contains one header file, ./include/osmocom/iuh/common.h, which does not include anything else. this header is included by another header in libosmo-ranap-dev; so from that perspective I think the dependency ordering is correct > iu_client.h is also in libosmo-ranap-dev, not in libosmo-iuh-dev -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40878?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I4f7df05bf8b66d1be866895d7fe4158a7b555265 Gerrit-Change-Number: 40878 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Aug 2025 10:43:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 weeks, 3 days

1
0
0 0

[XS] Change in osmo-msc[master]: Fix building for debian 13 armv7l

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/40873?usp=email ) Change subject: Fix building for debian 13 armv7l ...................................................................... Fix building for debian 13 armv7l In Debian 13 armv7l, time_t and suseconds_t are "long long int" instead of "long unsigned int" as seen on x86_64 and aarch64. Fix it by casting to "long long int". Related: OS#6828 Change-Id: I3de792d62b1989cf35051cbecde98fa9030bfbf2 --- M src/libmsc/msc_vty.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c index e727feb..cbcad24 100644 --- a/src/libmsc/msc_vty.c +++ b/src/libmsc/msc_vty.c @@ -1048,9 +1048,9 @@ MSC_VTY_DUMP(vty, offset, "Expires: never%s", VTY_NEWLINE); } else if (osmo_clock_gettime(CLOCK_MONOTONIC, &now) == 0) { - MSC_VTY_DUMP(vty, offset, "Expires: in %ld min %ld sec%s", - (vsub->expire_lu - now.tv_sec) / 60, - (vsub->expire_lu - now.tv_sec) % 60, + MSC_VTY_DUMP(vty, offset, "Expires: in %lld min %lld sec%s", + (long long int) ((vsub->expire_lu - now.tv_sec) / 60), + (long long int) ((vsub->expire_lu - now.tv_sec) % 60), VTY_NEWLINE); } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40873?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3de792d62b1989cf35051cbecde98fa9030bfbf2 Gerrit-Change-Number: 40873 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu>

3 weeks, 3 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: MSC Tests: add TC_gsup_lu_and_det: do a LU, Detach and expect GSUP MS...

by fixeria

Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39236?usp=email ) Change subject: MSC Tests: add TC_gsup_lu_and_det: do a LU, Detach and expect GSUP MS Purge ...................................................................... Patch Set 3: (1 comment) File msc/MSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39236/comment/da37dd49_cbbc… : PS3, Line 3352: GSUP.receive > What's the problem with waiting for Tguard? simply that we go a few seconds quicker to fail in -late […] `Tguard` is `60.0` seconds by default, so blocking the testsuite for an additional minute doesn't look nice to me. If an alt statement is too much code, then just pass something like `t_guard=8.0` to `f_init_handler()`. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39236?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9e87537efc2c921fa860539a706316ed410b45d5 Gerrit-Change-Number: 39236 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 18 Aug 2025 10:30:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

3 weeks, 3 days

1
0
0 0

[M] Change in libosmocore[master]: Put all io_uring related read and write states into sub structures

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40856?usp=email ) Change subject: Put all io_uring related read and write states into sub structures ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40856?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3cf4ab6d9aebf5532ad174c90c7b0e9633491c88 Gerrit-Change-Number: 40856 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 18 Aug 2025 10:29:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 3 days

1
0
0 0

[S] Change in libosmocore[master]: Remove old empty io_uring

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40855?usp=email ) Change subject: Remove old empty io_uring ...................................................................... Patch Set 3: (3 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/40855/comment/532892e6_fa73b16f?… : PS3, Line 14: The counter is decrements whenever a CQE is received and handled. This is decremeted File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/40855/comment/3285e255_73e513e9?… : PS3, Line 76: unsigned int in_flight; "num_in_transit" woulb be better imho, or at least "num_in_flight" to quickly denote it's counter and not a boolean. Maybe also "num_pending_reqs". https://gerrit.osmocom.org/c/libosmocore/+/40855/comment/daedf8d9_7938a8a1?… : PS3, Line 639: ring->in_flight++; Sounds like we may want to have a wrapper around io_uring_get_sqe() which increases in_flight if sqe was obtained. I see this same pattern is done in multiple non-related code paths. This way we may avoid skipping the step if we add new code or change it. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40855?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id2d2a0400ad442198c684ea0ead4eaeaead4c53d Gerrit-Change-Number: 40855 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 18 Aug 2025 10:28:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

3 weeks, 3 days

1
0
0 0

[M] Change in libosmocore[master]: Automatically increase io_uring, if too small.

by pespin

Attention is currently required from: jolly, laforge. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40725?usp=email ) Change subject: Automatically increase io_uring, if too small. ...................................................................... Patch Set 12: (2 comments) File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/08a6dfef_9a46a235?… : PS9, Line 208: /* All subsequent read SQEs must be on the same ring. */ > iofd_uring_get_sqe() has no knowledge about the iofd, so it doesn't know if there are SQEs already s […] yeah well that's my point, a function named "iofd_" can perfectly get passed an iofd and do that logic there :) https://gerrit.osmocom.org/c/libosmocore/+/40725/comment/9fd6e9d6_f25f8240?… : PS9, Line 282: while (iofd->u.uring.reads_submitted < ((iofd->u.uring.num_read_sqes) ? : g_io_uring_read_sqes)) { > if iofd instance is created, num_read_sqes (read.num_sques now) is not set by the user, so that it is 0. why aren't we setting num_read_sqes to g_io_uring_read_sques by default when the iofd is allocated? Not doing so looks very confusing to me. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40725?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id9230146acc8d54bfd44834e783c31b37bd64bca Gerrit-Change-Number: 40725 Gerrit-PatchSet: 12 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 18 Aug 2025 10:20:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 weeks, 3 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: msc: add TC_silent_call_{start_stop,active_conn}

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863?usp=email ) Change subject: msc: add TC_silent_call_{start_stop,active_conn} ...................................................................... msc: add TC_silent_call_{start_stop,active_conn} This patch adds testcases for the silent-call feature: * MSC_Tests.TC_silent_call_start_stop Test starting and stopping silent call via the VTY. * MSC_Tests.TC_silent_call_active_conn Test initiating a silent call while there's an active connection. The MSC is expected to be smart and reject such an attempt. Change-Id: I3ef22fbb5a05f69cc8aea7f42e05f6e1d6c4a8b6 Related: osmo-msc.git I93913d189800d71f82c013b6e946bd63db362f65 Related: osmo-msc.git I52b3be26c61cadacc4783b5c324809ecd6906b36 --- M msc/MSC_Tests.ttcn M msc/expected-results.xml 2 files changed, 101 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 4a7acdc..3f4afe4 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -7710,6 +7710,101 @@ setverdict(pass); } +/* Test starting and stopping silent call via the VTY */ +private function f_TC_silent_call_start_stop(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { + var charstring cmd, resp; + timer T; + + f_init_handler(pars); + + cmd := "subscriber imsi " & hex2str(g_pars.imsi) & " silent-call "; + + f_perform_lu(); + f_ran_register_imsi(g_pars.imsi, g_pars.tmsi); + + /* Start silent call via the VTY */ + MSCVTY.send(cmd & "start any signalling"); + resp := f_vty_wait_for_prompt(MSCVTY); + if (resp != "% Silent call initiated") { + setverdict(fail, "VTY: Unexpected response: ", resp); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); + } + + /* MSC->BSC: expect PAGING from the MSC */ + f_expect_paging(); + /* MS -> MSC: PAGING RESPONSE */ + f_establish_fully(EST_TYPE_PAG_RESP); + + /* Hold the call for some time */ + T.start(3.0); + alt { + [] BSSAP.receive(tr_BSSMAP_AssignmentReq) { + BSSAP.send(ts_BSSMAP_AssignmentComplete); + repeat; + } + [] as_unexp_bssap_msg(); + [] T.timeout { setverdict(pass); } + } + + /* Stop silent call via the VTY */ + MSCVTY.send(cmd & "stop"); + resp := f_vty_wait_for_prompt(MSCVTY); + if (resp != "% Silent call ended\n% Silent call stopped") { + setverdict(fail, "VTY: Unexpected response: ", resp); + } + + f_expect_clear(); +} +testcase TC_silent_call_start_stop() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + + vc_conn := f_start_handler(refers(f_TC_silent_call_start_stop), 30); + vc_conn.done; +} + +/* Test initiating a silent call while there's an active connection. + * The MSC is expected to be smart and reject such an attempt. */ +private function f_TC_silent_call_active_conn(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { + var charstring cmd, resp; + + f_init_handler(pars); + + cmd := "subscriber imsi " & hex2str(g_pars.imsi) & " silent-call "; + + f_perform_lu(); + f_ran_register_imsi(g_pars.imsi, g_pars.tmsi); + + /* The MS establishes a connection (e.g. for periodic Location Updating) */ + f_establish_fully(); + + /* Try initiating a silent call via the VTY */ + MSCVTY.send(cmd & "start any signalling"); + resp := f_vty_wait_for_prompt(MSCVTY); + select (resp) { + case ("% Subscriber already has an active connection") { + setverdict(pass); + } + case ("% Silent call initiated") { + setverdict(fail, "The MSC initiated silent call despite an active connection"); + f_expect_paging(); + } + case else { + setverdict(fail, "Unexpected VTY response: ", resp); + } + } + + BSSAP.send(ts_BSSMAP_ClearRequest(0)); + f_expect_clear(); +} +testcase TC_silent_call_active_conn() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + + vc_conn := f_start_handler(refers(f_TC_silent_call_active_conn), 30); + vc_conn.done; +} + control { execute( TC_cr_before_reset() ); execute( TC_lu_imsi_noauth_tmsi() ); @@ -7910,6 +8005,9 @@ if (Misc_Helpers.f_osmo_repo_is("nightly")) { execute( TC_stat_bsc_sctp_disconnected() ); } + + execute( TC_silent_call_start_stop() ); + execute( TC_silent_call_active_conn() ); } diff --git a/msc/expected-results.xml b/msc/expected-results.xml index 7a5066d..65f6d8e 100644 --- a/msc/expected-results.xml +++ b/msc/expected-results.xml @@ -1,5 +1,5 @@ <?xml version="1.0"?> -<testsuite name='Titan' tests='229' failures='10' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='Titan' tests='239' failures='5' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='MSC_Tests' name='TC_cr_before_reset' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_lu_imsi_noauth_tmsi' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_lu_imsi_noauth_notmsi' time='MASKED'/> @@ -177,6 +177,8 @@ <testcase classname='MSC_Tests' name='TC_lu_and_mt_csd' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_lu_and_mo_call_reass_for_mt_codec' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_stat_bsc_sctp_disconnected' time='MASKED'/> + <testcase classname='MSC_Tests' name='TC_silent_call_start_stop' time='MASKED'/> + <testcase classname='MSC_Tests' name='TC_silent_call_active_conn' time='MASKED'/>  <testcase classname='MSC_Tests_Iu' name='TC_iu_lu_imsi_reject' time='MASKED'/> <testcase classname='MSC_Tests_Iu' name='TC_iu_lu_imsi_timeout_gsup' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3ef22fbb5a05f69cc8aea7f42e05f6e1d6c4a8b6 Gerrit-Change-Number: 40863 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 weeks, 3 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: msc: add TC_silent_call_{start_stop,active_conn}

by fixeria

Attention is currently required from: laforge, lynxis lazus, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863?usp=email ) Change subject: msc: add TC_silent_call_{start_stop,active_conn} ...................................................................... Patch Set 4: Code-Review+2 (1 comment) File msc/MSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863/comment/299a305e_10b4… : PS4, Line 7720: cmd := "subscriber imsi " & hex2str(g_pars.imsi) & " silent-call "; > I'd better enclose this into a helper function so we only need to change it in one place if we ever […] If there ever be more silent-call related TCs, I'll definitely add something like `f_vty_silent_call_{start,stop}()`. For now it's just two TCs and I think it's not a big problem if we merge it as-is. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3ef22fbb5a05f69cc8aea7f42e05f6e1d6c4a8b6 Gerrit-Change-Number: 40863 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 18 Aug 2025 10:19:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 weeks, 3 days

1
0
0 0

[S] Change in libosmocore[master]: Add environment variable to set io_uring size

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40782?usp=email ) Change subject: Add environment variable to set io_uring size ...................................................................... Patch Set 5: Code-Review+1 (2 comments) File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/40782/comment/d9256dee_d4604c92?… : PS5, Line 56: #define IOFD_URING_MAXIMUM_SIZE 32768 I'm still wondering where is this maximum specified? Is it a kernel hardcoded value? liburing? Do we have a liburing define for this? https://gerrit.osmocom.org/c/libosmocore/+/40782/comment/43a58613_76984c1c?… : PS5, Line 112: /* 32768 is the maximum number of entries the Kernel can handle. */ Better move this comment to where IOFD_URING_MAXIMUM_SIZE is defined. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40782?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I55289d9282e13aa1bf82f3931c85c196752f1484 Gerrit-Change-Number: 40782 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 18 Aug 2025 10:15:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

3 weeks, 3 days

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2025