August 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-pcu[master]: llc_queue: Store MetaInfo in msgb headroom instead of cb[]

by laforge

Attention is currently required from: osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcu/+/40885?usp=email ) Change subject: llc_queue: Store MetaInfo in msgb headroom instead of cb[] ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/40885?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I98d966c257d50d3b2fc326dce85ead5591acf51f Gerrit-Change-Number: 40885 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Aug 2025 17:37:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 3 days

1
0
0 0

[XL] Change in libosmo-netif[master]: bring twrtp into libosmo-netif

by pespin

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email ) Change subject: bring twrtp into libosmo-netif ...................................................................... Patch Set 5: (1 comment) File src/twrtp_base.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/0915c024_0707acd… : PS1, Line 132: * another variant of this API with that alternative behavior. > I see what you are asking for now. […] ack, I think we are aligned with what I mean now :) -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ib63215aaf13ef8ab8f2e0c8d310164cd5c8824eb Gerrit-Change-Number: 39281 Gerrit-PatchSet: 5 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 18 Aug 2025 16:55:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 weeks, 3 days

1
0
0 0

[XL] Change in libosmo-netif[master]: bring twrtp into libosmo-netif

by falconia

Attention is currently required from: pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email ) Change subject: bring twrtp into libosmo-netif ...................................................................... Patch Set 5: (1 comment) File src/twrtp_base.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/4d6e95a1_8c237d4… : PS1, Line 132: * another variant of this API with that alternative behavior. > See 3GPP TS 25.414 clause 5.1.3.4. RTCP is optional in IuUP. […] I see what you are asking for now. In order to make it consistent, we would need to not only allow absent `rtcp_fd` in the low-level API `osmo_twrtp_supply_fds()`, but also add a Boolean argument to the higher-level API `osmo_twrtp_bind_local()`, enabling or disabling creation and binding of RTCP socket. Before I implement it in the next patch iteration, please confirm that this is what you want. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ib63215aaf13ef8ab8f2e0c8d310164cd5c8824eb Gerrit-Change-Number: 39281 Gerrit-PatchSet: 5 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Aug 2025 16:44:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 weeks, 3 days

1
0
0 0

[M] Change in osmo-pcu[master]: llc_queue: Store MetaInfo in msgb headroom instead of cb[]

by fixeria

Attention is currently required from: laforge, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcu/+/40885?usp=email ) Change subject: llc_queue: Store MetaInfo in msgb headroom instead of cb[] ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/40885?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I98d966c257d50d3b2fc326dce85ead5591acf51f Gerrit-Change-Number: 40885 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Aug 2025 16:37:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 3 days

1
0
0 0

[XL] Change in libosmo-netif[master]: bring twrtp into libosmo-netif

by pespin

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email ) Change subject: bring twrtp into libosmo-netif ...................................................................... Patch Set 5: (2 comments) File src/twrtp_base.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/8f2984a3_cf223b5… : PS1, Line 120: * file descriptor passing mechanism - hence twrtp layer must have a public > Can this point be marked as resolved? Done https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/b7b340e9_2f1ce4f… : PS1, Line 132: * another variant of this API with that alternative behavior. > Still not sure about 3G and IuUP specifically, but more generally speaking, if some application of R […] See 3GPP TS 25.414 clause 5.1.3.4. RTCP is optional in IuUP. I think it's still nice to avoid creating one extra socket for each RTP flow (eg. ending up in hundreds of sockets spared, same amount of io_uring sqes being used, etc.) if not expected to be used. So I'd really welcome possibility to pass <0 as rtcp_fd and as a result leave the iofd below as NULL. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ib63215aaf13ef8ab8f2e0c8d310164cd5c8824eb Gerrit-Change-Number: 39281 Gerrit-PatchSet: 5 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 18 Aug 2025 16:10:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 weeks, 3 days

1
0
0 0

[XL] Change in libosmo-netif[master]: bring twrtp into libosmo-netif

by pespin

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email ) Change subject: bring twrtp into libosmo-netif ...................................................................... Patch Set 5: (1 comment) File src/twrtp_traffic.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/1dcffe52_f506644… : PS2, Line 32: struct osmo_twrtp *endp = osmo_iofd_get_data(iofd); > Can this point be marked as resolved? Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ib63215aaf13ef8ab8f2e0c8d310164cd5c8824eb Gerrit-Change-Number: 39281 Gerrit-PatchSet: 5 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 18 Aug 2025 16:02:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 weeks, 3 days

1
0
0 0

[XL] Change in libosmo-netif[master]: bring twjit into libosmo-netif

by pespin

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email ) Change subject: bring twjit into libosmo-netif ...................................................................... Patch Set 5: (5 comments) File include/osmocom/netif/twjit.h: https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/bb8990ab_5f15f87… : PS2, Line 35: /*! buffer depth: starting minimum */ > The long-promised document has been written: […] It probably makes sense to submit this or parts of this document in text format under doc/, so it can be updated whenever something needs to be modified/improved in the future, to keep it in sync as code documentation. File src/twjit.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/5a2e5e7a_3cd5537… : PS2, Line 42: /*! Current depth as defined in twjit architecture document */ > The master document is here: […] Done https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/50ab06d1_62f930a… : PS2, Line 504: rtph = osmo_rtp_get_hdr(msg); > Please see section 2.3.8 of this document: […] Thanks. After having read your document: The fact that we may like or not like one way to generate RTP transmission (gap vs continous) doesn't mean others will be following that. Hence, for interop it still makes sense to accept the M bit as a trigger for handover. This will help for instance when reading from peers outputting RTP after a gaps which eg. keep an in-sync timestamp+seq+ssrc despite clearly specifying a gap through M bit. Hence, I still believe this option must be implemented. As mentioned, I'm fine if this can be tweaked with a API & VTY config per twjit. You also need to update the document, eg. clause 2.3.7 appending text: "or M (Marker) bit set". Also in clause 3.4 you may want to add a new stats "markers_received" (feel free to find a better naming), which should be increased here if the M bit is detected. See what I'm asking afaiu is not a lot of work, only adding a new API+VTY setting + a few more lines here to check M bit and probably call analytis_init() and increment stats here, plus applying same logic eg. when SSRC changes. https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/ed269504_f092907… : PS2, Line 544: if (id == INPUT_RESET) { > Please see document sections 2.3.2 and 2.3.3. […] Done File src/twjit_vty.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/9695ca35_d8a3518… : PS2, Line 41: vty_out(vty, "%s%s%s", prefix, name ? : "twjit", VTY_NEWLINE); > Can this point be marked as resolved? Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658 Gerrit-Change-Number: 39280 Gerrit-PatchSet: 5 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 18 Aug 2025 15:53:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 weeks, 3 days

1
0
0 0

[XL] Change in libosmo-netif[master]: bring twjit into libosmo-netif

by pespin

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email ) Change subject: bring twjit into libosmo-netif ...................................................................... Patch Set 5: (1 comment) File src/twjit.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/065fe851_cc7b1ee… : PS3, Line 331: static void analytics_cont(struct osmo_twjit *twjit, uint16_t rx_seq, > Sure, I will append ", not necessarily in order" to `analytics_cont()` head comment in the next patc […] I'm currently on it reading your pdf. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658 Gerrit-Change-Number: 39280 Gerrit-PatchSet: 5 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 18 Aug 2025 14:46:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 weeks, 3 days

1
0
0 0

[XL] Change in libosmo-netif[master]: bring twjit into libosmo-netif

by falconia

Attention is currently required from: pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email ) Change subject: bring twjit into libosmo-netif ...................................................................... Patch Set 5: (1 comment) File src/twjit.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/a24714f1_298ce4a… : PS3, Line 331: static void analytics_cont(struct osmo_twjit *twjit, uint16_t rx_seq, > Maybe append ", not necessarily in order". Sure, I will append ", not necessarily in order" to `analytics_cont()` head comment in the next patch revision, exactly as you asked. But before I produce that next patch iteration, please respond to the other 6 currently unresolved points on this patch. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658 Gerrit-Change-Number: 39280 Gerrit-PatchSet: 5 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Aug 2025 14:42:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 weeks, 3 days

1
0
0 0

[XL] Change in libosmo-netif[master]: bring twjit into libosmo-netif

by pespin

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email ) Change subject: bring twjit into libosmo-netif ...................................................................... Patch Set 5: (2 comments) File src/twjit.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/a60a0c5c_1fba961… : PS2, Line 157: config->thinning_int = 17; > Can this point be marked as resolved? Done File src/twjit.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/d0c95c1d_a8ba387… : PS3, Line 331: static void analytics_cont(struct osmo_twjit *twjit, uint16_t rx_seq, > Can this point be marked as resolved? Maybe append ", not necessarily in order". -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658 Gerrit-Change-Number: 39280 Gerrit-PatchSet: 5 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 18 Aug 2025 14:03:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 weeks, 3 days

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2025